Update patch set 4
Patch Set 4:
(11 comments)
This change is ready for review.
Patch-set: 4
Work-in-progress: false
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010
Gerrit Code Review
parent
7b7aaca126
commit
5d6360bbe8
|
|
@ -125,6 +125,24 @@
|
|||
"revId": "49caf67823927af0176179a3113c988f5e2cfb98",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5e467a9a_020cffd6",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "I hope later patchset revisions are now closer to what we concluded here, so marking as resolved. The question whether to rename `sctp-role (client|server)` is now being discussed in a separate thread.",
|
||||
"parentUuid": "2907673b_9f9ef633",
|
||||
"revId": "49caf67823927af0176179a3113c988f5e2cfb98",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -538,6 +556,30 @@
|
|||
},
|
||||
"revId": "49caf67823927af0176179a3113c988f5e2cfb98",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "b2fa22d9_fac97148",
|
||||
"filename": "src/xua_rkm.c",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 240,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "This is no longer a relevant question, marking thread as resolved.",
|
||||
"parentUuid": "f8b462b4_432b7986",
|
||||
"range": {
|
||||
"startLine": 240,
|
||||
"startChar": 10,
|
||||
"endLine": 240,
|
||||
"endChar": 76
|
||||
},
|
||||
"revId": "49caf67823927af0176179a3113c988f5e2cfb98",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -35,6 +35,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "35c6700d_e8d1d87b",
|
||||
"filename": "include/osmocom/sigtran/osmo_ss7.h",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 293,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "79fc8376_065406dc",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -88,6 +106,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "28e3372c_1bf846c0",
|
||||
"filename": "include/osmocom/sigtran/osmo_ss7.h",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 349,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "b4eb789f_92e333a2",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -141,6 +177,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e287e85b_ea919b35",
|
||||
"filename": "include/osmocom/sigtran/osmo_ss7.h",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 616,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "fb9fab4c_5a76f7fb",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -212,6 +266,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "4bb8cd94_f2964a84",
|
||||
"filename": "src/osmo_ss7_asp.c",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 137,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Actually, we don\u0027t need to change anything here because by doing:\n\n```((trans_proto \u003c\u003c 8) | (asp_proto \u003c\u003c 0))```\n\nwe leave one byte and thus 256 unique values for the `asp_proto` (`OSMO_SS7_ASP_PROT_*`), and 3 or 7 bytes for the `trans_proto` (depending on the architecture). Does that make sense? Or am I missing something?",
|
||||
"parentUuid": "6c10896e_cbfb827a",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -247,6 +319,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "d532c02d_16cc31b3",
|
||||
"filename": "src/osmo_ss7_asp.c",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 532,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "f3d29fae_8ffc61d5",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -371,6 +461,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "7a3189a3_dbacd8ec",
|
||||
"filename": "src/osmo_ss7_vty.c",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 65,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "I implemented the optional transport protocol parameter using aliases.\nMarking as resolved.",
|
||||
"parentUuid": "fccd3b75_26c84b50",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -442,6 +550,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "37e9bf09_3058db9f",
|
||||
"filename": "src/osmo_ss7_vty.c",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 995,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done in a separate change:\n\nhttps://gerrit.osmocom.org/c/libosmo-sccp/+/35978 VTY: rename \u0027sctp-role\u0027 to \u0027transport-role\u0027, add an alias",
|
||||
"parentUuid": "a16f1926_267bc604",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -477,6 +603,24 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ea0563bc_28cbc19a",
|
||||
"filename": "src/osmo_ss7_vty.c",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 1641,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "029b4031_69c2626e",
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -601,6 +745,30 @@
|
|||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "49f8d013_3099aaca",
|
||||
"filename": "tests/vty/ss7_asp_test.vty",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 408,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2024-02-14T22:41:48Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "8451a3ae_61bf66b8",
|
||||
"range": {
|
||||
"startLine": 408,
|
||||
"startChar": 29,
|
||||
"endLine": 408,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue