74 lines
2.3 KiB
Plaintext
74 lines
2.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4a51ea7b_82dec78e",
|
|
"filename": "src/libosmo-pfcp/pfcp_ies_custom.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 435,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-03-19T11:40:31Z",
|
|
"side": 1,
|
|
"message": "\"make do\" ?",
|
|
"revId": "5d2ee7e72c62db67ee3f70805e7d40f3c154209f",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "07fe9b28_7f2fce94",
|
|
"filename": "src/libosmo-pfcp/pfcp_ies_custom.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 435,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-03-20T09:43:33Z",
|
|
"side": 1,
|
|
"message": "https://dictionary.cambridge.org/dictionary/english/make-do",
|
|
"parentUuid": "4a51ea7b_82dec78e",
|
|
"revId": "5d2ee7e72c62db67ee3f70805e7d40f3c154209f",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b3b96f18_0d923e71",
|
|
"filename": "src/libosmo-pfcp/pfcp_ies_custom.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 436,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-03-19T11:40:31Z",
|
|
"side": 1,
|
|
"message": "we can probably avoid memcpying twice.",
|
|
"revId": "5d2ee7e72c62db67ee3f70805e7d40f3c154209f",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8f2d8350_a4151eef",
|
|
"filename": "src/libosmo-pfcp/pfcp_ies_custom.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 436,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-03-20T09:43:33Z",
|
|
"side": 1,
|
|
"message": "where\u0027s the second memcpy? you mean avoiding memset and memcpy\u0027ing the same location? I\u0027m always hoping compilers are smart enough to figure that out during optimization. But I never really tested that \"hope\".\n\nAlso, this isn\u0027t really a super performance critical code path, so let\u0027s not over-optimize.",
|
|
"parentUuid": "b3b96f18_0d923e71",
|
|
"revId": "5d2ee7e72c62db67ee3f70805e7d40f3c154209f",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |