osmocom
/
libosmo-pfcp
mirror of https://gerrit.osmocom.org/libosmo-pfcp
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 1000004 2023-03-14 20:25:04 +00:00 committed by Gerrit Code Review
parent d02347ce8a
commit fe1f2c4e41
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fa778022813e6b9192a02c9973d69c04dbb0f2d5
View File

@ -105,6 +105,24 @@
"parentUuid": "40f680f2_2898dfd7",
"revId": "fa778022813e6b9192a02c9973d69c04dbb0f2d5",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "13eaf2a4_d9220168",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2023-03-14T20:25:04Z",
"side": 1,
"message": "So in libosmoi-pfcp/Makefile.am you are \n\n* including LIBOSMOGSM_LIBS in AM_LDFLAGS (where it doesn\u0027t belong, but let\u0027s set that aside for now)\n* then overriding those flags by using libosmo_pfcp_la_LDFLAGS *without* including LDFLAGS. So all other programs/libraries/targets (that don\u0027t have a prog_name_LDFLAGS) will be linked against libosmocore, but not the library itself\n\nAs a result, you have a library that depens on other librarires, but which doesn\u0027t express this dependency to the dynamic linker at runtime.\n\npkg-config can\u0027t fix that. pkg-config is just metadata for easy discovery of linker flags / cflags, and it has to assume the libraries are correctly linked in the first place.",
"parentUuid": "3b648100_9554086f",
"revId": "fa778022813e6b9192a02c9973d69c04dbb0f2d5",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}