osmocom
/
libosmo-pfcp
mirror of https://gerrit.osmocom.org/libosmo-pfcp
14
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review+2

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"neels replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
This commit is contained in:
Gerrit User 1000005 2022-11-28 13:47:12 +00:00 committed by Gerrit Code Review
parent c262d0ebd8
commit c5f032b3e2
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
abecf789261e53bdb99a0ab275008e4d8f65cb6d
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bc6690e1_d627de2a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000005
},
"writtenOn": "2022-11-28T13:47:12Z",
"side": 1,
"message": "combine votes",
"revId": "abecf789261e53bdb99a0ab275008e4d8f65cb6d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -16,6 +33,24 @@
"message": "Did you think about simply copying the address part? addr.u.in.sin_addr or alike?",
"revId": "abecf789261e53bdb99a0ab275008e4d8f65cb6d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "37898af2_b875e635",
"filename": "src/libosmo-pfcp/pfcp_msg.c",
"patchSetId": 1
},
"lineNbr": 504,
"author": {
"id": 1000005
},
"writtenOn": "2022-11-28T13:47:12Z",
"side": 1,
"message": "i find it conceptually simpler to set the port number to zero instead...",
"parentUuid": "a7d3268e_77de7649",
"revId": "abecf789261e53bdb99a0ab275008e4d8f65cb6d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}