Update patch set 3

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1, 884cc7593a1b0ddf7aba6a726a58c96e65592999
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}

0e07fa5ac81f039f67077e1ede11cfdf48be236f

@@ -1,5 +1,28 @@
 {
   "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c726a8d9_a959a778",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 3
+      },
+      "lineNbr": 15,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-03-09T08:12:34Z",
+      "side": 1,
+      "message": "use",
+      "range": {
+        "startLine": 15,
+        "startChar": 58,
+        "endLine": 15,
+        "endChar": 62
+      },
+      "revId": "0e07fa5ac81f039f67077e1ede11cfdf48be236f",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": false,
       "key": {

aac637fe5aa6f135c4a3b5d0742372c18a29875d

@@ -129,6 +129,30 @@
       },
       "revId": "aac637fe5aa6f135c4a3b5d0742372c18a29875d",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "598a6047_c54ca009",
+        "filename": "src/libosmo-pfcp/Makefile.am",
+        "patchSetId": 1
+      },
+      "lineNbr": 68,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-03-09T08:12:34Z",
+      "side": 1,
+      "message": "I still don\u0027t like changing `_LDADD` to `_LDFLAGS`. The author of this patch https://lore.kernel.org/all/20181118160802.11087-4-jengelh@inai.de/ explains that having -l arguments (i.e. `*_LIBS`) in `LDFLAGS` is wrong.\n\nI guess the problem was that initially you had `AM_LDFLAGS` with `*_LIBS` in there -- this is wrong because the `LDFLAGS` do appear earlier in the linker\u0027s command line than `LDADD`. Now that you have removed the `AM_LDFLAGS`, I think it should work as expected without the need to change `_LDADD` to `_LDFLAGS`.",
+      "parentUuid": "7f30d7fa_0347fc4c",
+      "range": {
+        "startLine": 68,
+        "startChar": 0,
+        "endLine": 68,
+        "endChar": 26
+      },
+      "revId": "aac637fe5aa6f135c4a3b5d0742372c18a29875d",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }

fa778022813e6b9192a02c9973d69c04dbb0f2d5

@@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f860ed82_cedfa358",
+        "filename": "src/libosmo-pfcp/Makefile.am",
+        "patchSetId": 3
+      },
+      "lineNbr": 71,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-03-09T08:12:34Z",
+      "side": 0,
+      "message": "This does not belong here and should be done in https://gerrit.osmocom.org/c/libosmo-pfcp/+/31761.",
+      "range": {
+        "startLine": 71,
+        "startChar": 3,
+        "endLine": 71,
+        "endChar": 19
+      },
+      "revId": "fa778022813e6b9192a02c9973d69c04dbb0f2d5",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}