osmocom
/
libosmo-netif
mirror of https://gerrit.osmocom.org/libosmo-netif
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1, 402a61dd18e4385ea3ff04446104b47eb7e3982c
This commit is contained in:
Gerrit User 1000074 2024-04-16 14:17:47 +00:00 committed by Gerrit Code Review
parent 48e1cd8660
commit ff007dbd83
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
81b535c9186cc276329f8e52a6d41e7e443dd1a6
View File

@ -33,6 +33,24 @@
"message": "The res \u003d -EAGAIN is more like \"historical reasons\" imho (I wrote further support there afterwards), you should better check the flags (set in stream_sctp_recvmsg_trailer()):\n\n if (msgb_sctp_msg_flags(msg) \u0026 OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION)\n \nSee for instance: libosmo-sccp/src/osmo_ss7_asp.c:824 or line 998.",
"revId": "81b535c9186cc276329f8e52a6d41e7e443dd1a6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "7c8db9c7_c61f745f",
"filename": "src/stream_cli.c",
"patchSetId": 1
},
"lineNbr": 500,
"author": {
"id": 1000074
},
"writtenOn": "2024-04-16T14:17:47Z",
"side": 1,
"message": "Wait, that\u0027s wrong though, you are basically preventing stream_cli users to get SCTP notifications, which is wrong. osmo_ss7_asp.c expects to get those.",
"parentUuid": "137e8852_3488b14f",
"revId": "81b535c9186cc276329f8e52a6d41e7e443dd1a6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}