osmocom
/
libosmo-gprs
mirror of https://gerrit.osmocom.org/libosmo-gprs
11
0
Fork 0
Code Releases Wiki Activity

rlcmac: Avoid generating UL data if no data to be sent available 

Dummy LLC commands only make sense in the network->MS direction, in
order to delay closing the DL TBF (3GPP TS 44.064 6.4.2.2). That code in
the MS is a leftover from porting code from osmo-pcu.

Change-Id: I062aa9aea4f7d66a70ed53eae1c67780ddc3dca5
This commit is contained in:
Pau Espin 2023-05-29 14:41:46 +02:00
parent d2fd394e4d
commit 4c225a7912
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/rlcmac/tbf_ul.c
View File

@ -589,13 +589,6 @@ static int take_next_bsn(struct gprs_rlcmac_ul_tbf *ul_tbf, const struct gprs_rl
gprs_rlcmac_rlc_ul_window_v_a(ul_tbf->ulw));
if (restart_bsn_cycle(ul_tbf))
return take_next_bsn(ul_tbf, bi, previous_bsn, may_combine);
} else {
/* Nothing left to send, create dummy LLC commands */
LOGPTBFUL(ul_tbf, LOGL_DEBUG, "Sending new dummy block at BSN %d, CS=%s\n",
gprs_rlcmac_rlc_ul_window_v_s(ul_tbf->ulw),
gprs_rlcmac_mcs_name(tx_cs));
bsn = create_new_bsn(ul_tbf, bi, tx_cs);
/* Don't send a second block, so don't set cs_current_trans */
}
if (bsn < 0) {