Commit Graph

16 Commits

Author SHA1 Message Date
Vadim Yanitskiy 62717b6375 build: fix packaging problems and make distcheck happy
The 'distcheck' rule performs all of the operations associated with
packaging a distribution and verifying that the distribution works.

There were several problems:

  - libgsmhr/Makefile.am: 'patches' dir was not listed in EXTRA_DIST
  - libgsmhr/Makefile.am: (dist)clean targets wan't defined properly
  - tests/Makefile.am: 'ref-files' dir was not listed in EXTRA_DIST
  - tests/testsuite.at: wrong path was used for io_sample.txt

Change-Id: Ieb8f6a2a81f9b75c8c6c5db443b0e7be02bc4153
2018-07-09 22:15:39 +07:00
Vadim Yanitskiy 48e0acdbe6 libgsmhr/fetch_sources.py: fix source code downloading
For some reason, the 3GPP server started to reject the source
code download request:

  urllib2.HTTPError: HTTP Error 403: Forbidden

Adding both 'User-Agent' and 'Accept' headers solves the problem.

Change-Id: I8afd39c85dd3e450c5355888ab6edcf4c81f8b87
2018-07-03 15:24:37 +00:00
Vadim Yanitskiy 9e997267f6 libgsmhr/libgsmhr.c: fix memory leak after gsmhr_exit()
During the HR codec initialization, a part of the state is
allocated, but not freed at exit. Let's fix this.

Found during debugging with Valgrind:

4,932 bytes in 1 blocks are definitely lost in loss record 177 of 179
at 0x4C2AB80: malloc (in vgpreload_memcheck-amd64-linux.so)
by 0x6381C8F: gsmhr_init (libgsmhr.c:63)
by 0x526DF62: osmo_gapk_pq_queue_codec (pq_codec.c:48)
by 0x401ACE: make_processing_chain (app_osmo_gapk.c:573)
by 0x401ACE: main (app_osmo_gapk.c:765)

Change-Id: Ie9ead89c2272782de8d928f29753e6a523cf8834
2018-01-08 23:42:24 +06:00
Sylvain Munaut c0f0342596 libgsmhr: Make it safe to decode/encode different streams at once
Basically the reference code has a bunch of global state.
With some minimal patchihg (previous commit) we can ensure that all
that state is within .bss

So what we do it to save/restore the bss section between calls of the
reference code so we can process several in // and we don't have to
completely fix all reference to global state in the reference codec.

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:55:03 +01:00
Sylvain Munaut 5e2e0442e0 libgsmhr: Add some code cleanup / speedup patches for reference codec
Mostly this will help witht the upcoming bss switcheroo patch

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:55:03 +01:00
Sylvain Munaut 59a6c2dc62 libgsmhr: Use patch instead of 'sed'
Patches are without function-name and without context to minimize what
we have to include.

The current patchset does exactly what the previous 'sed' did, but this
will make it easier to add more.

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:55:03 +01:00
Sylvain Munaut 04a705f419 libgsmhr: Fix parallel build dependency
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:55:03 +01:00
Sylvain Munaut cddc91428f libgsmhr: fix Makefile.am dependency on source download
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:44:37 +01:00
Sylvain Munaut 8966846f3e libgsmhr/fetch_sources: Only use the filename and not any path
There shouldn't be any but somebody might be nasty :p

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:44:37 +01:00
Sylvain Munaut ea1c6c61f4 build: Use autotools 'subdir-objects' option
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2015-12-30 11:44:37 +01:00
Harald Welte bb782d98f3 Fix dist / distcheck targets by including fetch_sources.py in EXTRA_DIST 2015-11-05 21:37:57 +01:00
Sylvain Munaut 8b5e0c7b81 libgsmhr: Update source location
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2013-12-13 15:41:07 +01:00
Sylvain Munaut 2c8b3fd281 build: Use AM_CPPFLAGS in Makefile.am
Since automake 1.13 INCLUDES is depricates and causes a warning

Inspired from similar patches by Alexander Huemer for other osmocom
projects

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2013-06-17 08:53:21 +02:00
Sylvain Munaut f7d6f3c828 [3/4] HR support: Add actual wrapper code to call reference code
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2010-11-12 20:47:30 +01:00
Sylvain Munaut aa55d30d20 [2/4] HR support: Add logic to fetch reference source code and build it
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2010-11-12 20:47:30 +01:00
Sylvain Munaut 0d2a82c312 [1/4] HR support: Add autotools skeleton for libgsmhr
Not functional yet, just the autotools magic to make a library

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2010-11-12 20:36:14 +01:00