osmocom
/
docker-playground
mirror of https://gerrit.osmocom.org/docker-playground
10
0
Fork 0
Code Releases Activity

Update patch set 2 

Patch Set 2: Code-Review+2

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Someone else replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"removed on reply"}
This commit is contained in:
Gerrit User 1000010 2023-01-16 15:00:05 +00:00 committed by Gerrit Code Review
parent db50fcc165
commit f4878ee5df
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
99c552cd3c04ff3e44d6d82dff822c8e124af1c7 Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "01963a39_19c8e27d",
"filename": "jenkins-common.sh",
"patchSetId": 2
},
"lineNbr": 211,
"author": {
"id": 1000010
},
"writtenOn": "2023-01-16T15:00:05Z",
"side": 1,
"message": "I was about to say that with $(expr ...) this can be done simpler:\n\n SUBNET\u003d$(expr ($SUBNET + 1) % 256)\n\nbut as it turned out it requires escaping of the parentheses:\n\n SUBNET\u003d$(expr \\( $SUBNET + 1 \\) % 256)",
"range": {
"startLine": 211,
"startChar": 2,
"endLine": 211,
"endChar": 45
},
"revId": "99c552cd3c04ff3e44d6d82dff822c8e124af1c7",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}