osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
31434 commits 23 branches 0 tags 1.3 GiB
Commit graph

9789 commits

Author SHA1 Message Date
Anders Broman
43dc0d1157 From Matteo Valdina: 
Support for RTCP RFC-5104.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4582

svn path=/trunk/; revision=32210
 2010-03-16 20:38:34 +00:00
Kovarththanan Rajaratnam
8318689fc8 Remove trailing semicolon 
svn path=/trunk/; revision=32209
 2010-03-16 14:11:24 +00:00
Anders Broman
a291939fc3 Add AMR-WB to the rtp_dyn_payload_type table. 
svn path=/trunk/; revision=32208
 2010-03-16 09:12:24 +00:00
Bill Meier
f12c3e59ff A few minor changes: 
- Move proto_reg_handoff... to the end of the file;
- Remove unneeded forward declaration;
- Fix a typo;
- Use #if 0/#endif rather than /*...*/to comment-out code.

svn path=/trunk/; revision=32200
 2010-03-16 01:07:42 +00:00
Guy Harris
1f1a9ef2cc tvb_length() is *not* the length of the packet; it's the amount of 
captured data for the packet, which could well be less then the length
of the packet if a slice/snapshot length was used. 
tvb_reported_length() is the length as the packet appeared on the
{wire,air}.

If a > b, and you want to report how much a was greater than b, subtract
b from a, don't take the negative of b-a, especially if a and b are
unsigned....

svn path=/trunk/; revision=32199
 2010-03-15 21:36:56 +00:00
Jaap Keuter
ecb18edf04 From Adrian Daerr: 
I have written a crude dissector of GigE-vision Control Protocol packets.
The dissector was written as part of the opengigevision project:
http://gitorious.org/opengigevision

svn path=/trunk/; revision=32198
 2010-03-15 21:07:46 +00:00
Anders Broman
b362b47f71 My previous checkin reverted some changes, try to fix that. 
svn path=/trunk/; revision=32197
 2010-03-15 18:51:37 +00:00
Jeff Morriss
a6ca78fc2b Initialize a variable that otherwise might not be 
svn path=/trunk/; revision=32196
 2010-03-15 18:31:10 +00:00
Jeff Morriss
3ffbfe347e Declare sip_uri_offset_init() as returning void and remove a couple unused variables 
svn path=/trunk/; revision=32195
 2010-03-15 17:51:19 +00:00
Anders Broman
e2f2c4c2cf To fill stat_info->tap_to_addr it needs to be outside of if(tree). 
svn path=/trunk/; revision=32194
 2010-03-15 15:23:37 +00:00
Anders Broman
518ca45156 Use dissect_sip_uri() in dfilter_sip_request_line(). 
svn path=/trunk/; revision=32191
 2010-03-14 19:54:09 +00:00
Martin Mathieson
b3a29fcb32 Add some extra (optional) physical layer attributes to logged MAC frames. 
svn path=/trunk/; revision=32190
 2010-03-14 17:56:37 +00:00
Stig Bjørlykke
0d8a56ef72 From Hadar Shoham via bug 4578: 
Fix bootp option 125, Cablelab sun option 1, Option Request as string instead
of integer.

svn path=/trunk/; revision=32189
 2010-03-14 17:32:58 +00:00
Martin Mathieson
1ef05048a3 Use val_to_str_const() where have no format is default string 
svn path=/trunk/; revision=32188
 2010-03-14 16:36:41 +00:00
Martin Mathieson
1c6dae70d7 Took a guess at the code for missing RAPS. 
The G.8032 spec is limited to members of some organisation ("TIES users").

svn path=/trunk/; revision=32184
 2010-03-14 14:16:57 +00:00
Jaap Keuter
7e179f613f From Jouni Malinen: 
Use Key Info field to figure out which EAPOL-Key frame use case (4-way
handshake and Group key handshake) and provide more details in
COL_INFO column to make it easier to debug issues with EAPOL-Key
exchanges. In addition, add description of key descriptor version 3
from IEEE Std 802.11r-2008.

svn path=/trunk/; revision=32183
 2010-03-14 13:23:36 +00:00
Jaap Keuter
69267c7bab From Robert Dickerson: 
Adding the R-APS (Ring-Automatic Protection Switching), G.8032, to the built-in
CFM dissector.

svn path=/trunk/; revision=32182
 2010-03-14 13:07:09 +00:00
Jörg Mayer
5e7ff4dadc Forgot to copy over idl_types.h 
svn path=/trunk/; revision=32180
 2010-03-13 10:59:23 +00:00
Anders Broman
d26a6348e7 Use dissect_sip_name_addr_or_addr_spec() or dissect_sip_uri() as needed. 
svn path=/trunk/; revision=32178
 2010-03-13 08:38:11 +00:00
Gerasimos Dimitriadis
0b13ca1a48 Decode GPRS SM Messages related to MBMS Context handling 
svn path=/trunk/; revision=32176
 2010-03-12 21:30:54 +00:00
Anders Broman
8ccdb36c75 From Mark Wallis: 
Fix up proto and info columns.

svn path=/trunk/; revision=32175
 2010-03-12 19:34:07 +00:00
Martin Mathieson
27efebc70c Last missing SN wasn't coming out correctly if it was 1023... 
svn path=/trunk/; revision=32174
 2010-03-12 03:50:47 +00:00
Gerald Combs
005143d62f Partially revert copyright. 
svn path=/trunk/; revision=32173
 2010-03-11 20:29:06 +00:00
Gerald Combs
dfff249e12 Initialize a variable. 
svn path=/trunk/; revision=32172
 2010-03-11 20:21:06 +00:00
Anders Broman
bd77bea4f2 Remove unused variables etc 
svn path=/trunk/; revision=32171
 2010-03-11 20:14:59 +00:00
Anders Broman
25e7ead105 Start to clean up parsing of SIP URI. 
svn path=/trunk/; revision=32170
 2010-03-11 17:45:16 +00:00
Stig Bjørlykke
fd2911dd89 Fixed decoding of CableLab "Agent Information Option" according to 
CL-SP-CANN-DHCP-Reg-I03-090811.

svn path=/trunk/; revision=32169
 2010-03-11 11:49:20 +00:00
Stig Bjørlykke
15a0ac519c From Hadar Shoham via bug 4567: 
Add support to CL-SP-CANN-DHCP-Reg-I03-090811 at bootp option 124.

svn path=/trunk/; revision=32168
 2010-03-11 09:19:36 +00:00
Anders Broman
d8ea0a5fb4 Remove C++ style comments in packet-ieee802154.c 
svn path=/trunk/; revision=32167
 2010-03-11 09:19:29 +00:00
Jaap Keuter
e0cef3d9f9 From Owen Kirby: 
This patch adds a hash table that stores any short-to-extended address mappings
that the dissector finds for later use during packet decryption. I've also
added a UAT so the user can manually add address pairs if needed.

svn path=/trunk/; revision=32166
 2010-03-11 07:50:45 +00:00
Jaap Keuter
e347a5f155 From Colin O'Flynn: 
This is a minor change between the version in SVN which is hc-05, 
and the latest which is hc-06.

svn path=/trunk/; revision=32163
 2010-03-10 19:21:17 +00:00
Stig Bjørlykke
26521245a5 Added support for V-I Vendor Class (RFC3925). 
svn path=/trunk/; revision=32161
 2010-03-10 11:09:47 +00:00
Guy Harris
2341d987a7 Add a sanity check in dissect_6lowpan_hc1() for the datagram length. 
Fail, and add an expert item, for invalid lengths.

Having done that, add some casts to squelch compiler warnings.

svn path=/trunk/; revision=32160
 2010-03-10 10:23:19 +00:00
Stig Bjørlykke
383e289f16 Print Enterprise-number as "Name (value)". 
svn path=/trunk/; revision=32159
 2010-03-10 10:09:30 +00:00
Stig Bjørlykke
193e353b7a From Hadar Shoham via bug 4566: 
Add support to CL-SP-CANN-DHCP-Reg-I03-090811 at bootp option 123.

svn path=/trunk/; revision=32158
 2010-03-10 09:49:29 +00:00
Jaap Keuter
4732c51d52 From Owen Kirby: 
I've come across a bug in the 6LoWPAN header decompression code that
incorrectly computes the length of IPv6 extension headers by adding the
protocol and length fields twice.

svn path=/trunk/; revision=32157
 2010-03-10 07:15:07 +00:00
Anders Broman
342a3ca712 From Vladimir Kazansky: 
Wrong offset returned by de_sm_pdp_addr().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4568

svn path=/trunk/; revision=32156
 2010-03-10 06:39:14 +00:00
Jaap Keuter
103d684a3f From Owen Kirby: 
This patch fixes 6LoWPAN fragmentation to comply with RFC4944.
I also happened across a problem with the derivations of 
interface identifiers from 16-bit IEEE 802.15.4 addresses, which 
should also be fixed in my patch.

svn path=/trunk/; revision=32155
 2010-03-09 23:22:03 +00:00
Jaap Keuter
de0f1f1391 From Owen Kirby: 
Fix for malformed IEEE 802.15.4 decryption.

svn path=/trunk/; revision=32154
 2010-03-09 22:26:29 +00:00
Anders Broman
18202ab0ed from Pascal Quantin: 
Update that enhance a little bit the display of the Parameters List IE

svn path=/trunk/; revision=32153
 2010-03-09 16:57:24 +00:00
Martin Mathieson
5aaf90b753 Put context info in own subtree. 
Use common function to append text to info column and tree items

svn path=/trunk/; revision=32151
 2010-03-09 01:41:36 +00:00
Martin Mathieson
13e5793106 Write context fields inside own subtree. 
Use common functions to append text to info column and tree items.

svn path=/trunk/; revision=32150
 2010-03-09 01:39:08 +00:00
Guy Harris
b9d9dd8ec1 Mark unused arguments. 
Clean up white space.

svn path=/trunk/; revision=32149
 2010-03-09 01:34:55 +00:00
Anders Broman
2864c2a643 From Alexis La Goutte: 
Enchancement ISAKMP dissector (IKEv1 / IKEv2).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4546

svn path=/trunk/; revision=32148
 2010-03-08 21:22:07 +00:00
Anders Broman
dd8b8710e8 Remove unused variable. 
svn path=/trunk/; revision=32147
 2010-03-08 21:11:23 +00:00
Anders Broman
334210d3db From Pascal Quantin: 
[NAS EPS] Fixes for the Traffic Flow Template IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4564

svn path=/trunk/; revision=32145
 2010-03-08 20:46:30 +00:00
Anders Broman
25af78517e Make tvb_pbrk_guint8() return the found needle. 
svn path=/trunk/; revision=32144
 2010-03-08 20:45:13 +00:00
Stig Bjørlykke
d3c25dda59 Build without warnings. 
svn path=/trunk/; revision=32142
 2010-03-08 09:30:22 +00:00
Guy Harris
7e7ced5c30 Make some constants float, as they're used to compute a value assigned 
to a float, rather than a double, variable.

svn path=/trunk/; revision=32140
 2010-03-07 21:09:14 +00:00
Martin Mathieson
c5a2423a7a Fix another crashing problem. 
A status PDU can contain multiple entries for the same SN (for different partial ranges).  So make sure that we don't copy the same SN twice into our list of repeated NACKs (otherwise each instance in the tap struct will get added multiple times and we'll end up writing beyond the array bound).

svn path=/trunk/; revision=32133
 2010-03-07 10:03:05 +00:00
Anders Broman
1a855bfde2 From Andrej Kuehnal: 
New feature: extract specified diameter AVPs from large capture files.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4560

svn path=/trunk/; revision=32132
 2010-03-06 20:54:58 +00:00
Anders Broman
71fae79030 From Alex Lindberg: 
A fix to pass the entire RTCP APP payload to dissector.  The subtype field may be required by the registered dissector.
Added by hand.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4559

svn path=/trunk/; revision=32131
 2010-03-06 20:40:15 +00:00
Anders Broman
016530ba0f From Pascal Quantin: 
[NAS EPS] Various small bug fixes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4562

svn path=/trunk/; revision=32130
 2010-03-06 20:32:27 +00:00
Martin Mathieson
e10b2fb11e Add hidden roots for each mode (i.e. rlc-lte.tm, rlc-lte.um, rlc-lte.am). 
svn path=/trunk/; revision=32128
 2010-03-06 19:35:40 +00:00
Jaap Keuter
4c6c2ffbe7 From Francesco Fondelli: 
add support for ERROR_STRING IF_ID TLV (see RFC 4783)

add support for generalized label interpretation: SUKLM
format for SONET/SDH label (RFC 4606), t3t2t1 format for G.709 ODUk label
(RFC 4328), G.694 format for lambda label (draft-ietf-ccamp-gmpls-g-694-lamb
da-labels-05).  Add related user preference option.

svn path=/trunk/; revision=32127
 2010-03-06 12:48:30 +00:00
Gerasimos Dimitriadis
00c4b361e2 Decoding support for GPRS Session Management 'Activate MBMS 
Context Request' message and related IEs

svn path=/trunk/; revision=32126
 2010-03-06 00:06:27 +00:00
Jaap Keuter
60e215982e Fix for bug 4551. 
Add type to engine ID MAC Address format for Cisco agent/manager.

svn path=/trunk/; revision=32125
 2010-03-05 20:09:37 +00:00
Anders Broman
f9ee74b4f6 From Alex Lindberg: 
Permit registration of sub-dissectors for RTPC type APP messages.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4559

svn path=/trunk/; revision=32123
 2010-03-05 18:35:44 +00:00
Anders Broman
3e1b6fd0a4 Check if URI is SIP. 
svn path=/trunk/; revision=32122
 2010-03-05 15:16:30 +00:00
Anders Broman
5d0629d36c Add comments and move some things inside if(tree). 
svn path=/trunk/; revision=32121
 2010-03-05 09:33:37 +00:00
Jörg Mayer
af443c79c8 Add three more ICMPv6 type that only have a code of 0 
svn path=/trunk/; revision=32120
 2010-03-04 23:51:30 +00:00
Gerald Combs
2b619452ae Try to fix build errors. 
svn path=/trunk/; revision=32118
 2010-03-04 21:48:44 +00:00
Martin Mathieson
5e8b6b21b2 Report accurate NACK count in stats (although not all values stored in array in tap). 
svn path=/trunk/; revision=32117
 2010-03-04 20:58:54 +00:00
Anders Broman
b2c9e92823 Use a hash table to lookup the SIP header. 
It reduces the loading time of a file with 220 000 packets by 3s.
(SIP parsing should be optimized, if SIP is dissabled loading time is ~15s with SIP ~30s ).

svn path=/trunk/; revision=32116
 2010-03-04 20:35:45 +00:00
Martin Mathieson
d5fb076397 Check that we haven't gone over MAX_NACKs! 
svn path=/trunk/; revision=32115
 2010-03-04 17:49:51 +00:00
Stig Bjørlykke
437d42a943 From Ivan Sy via bug 4555: 
Added RFC5702 algo for packet-dns.

svn path=/trunk/; revision=32114
 2010-03-04 15:07:56 +00:00
Anders Broman
130d309444 from Luis Ontanon: 
calculate the value of a ber integer by hand instead of just using
proto_tree_add_item().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3230

svn path=/trunk/; revision=32113
 2010-03-04 13:54:21 +00:00
Stig Bjørlykke
2f8830b4d0 From LEGO via bug 3459: 
Add a callback to UAT to be called after the table has being updated,
use it to renew the snmp_ue_cache.

svn path=/trunk/; revision=32112
 2010-03-04 12:50:18 +00:00
Anders Broman
b507e40fa7 From Mark Wallis: 
Improvements to newHNBAP Iuh dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4553
Removed check_col() from the patch as it's no longer needed.

svn path=/trunk/; revision=32109
 2010-03-04 06:09:03 +00:00
Anders Broman
ffbdfc3285 From Mark Wallis: 
Improvements to new RUA Iuh dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4552
Removed check_col() from the patch as it's no longer needed.

svn path=/trunk/; revision=32108
 2010-03-04 05:56:59 +00:00
Martin Mathieson
5baac1de18 Fix crash where was overwriting buffer for large PDUs when tracking retxs. 
svn path=/trunk/; revision=32095
 2010-03-03 16:04:12 +00:00
Anders Broman
a2ba94064d Set the link dir for DCCH_Messages. 
svn path=/trunk/; revision=32094
 2010-03-03 15:54:57 +00:00
Bill Meier
f041bb3e19 Fix a gcc -Wshadow warning. 
svn path=/trunk/; revision=32093
 2010-03-03 15:47:28 +00:00
Martin Mathieson
eba3b41978 Fix a test. 
svn path=/trunk/; revision=32092
 2010-03-03 15:38:37 +00:00
Martin Mathieson
c40143abbc Fix re-NACk detection by updating channel *after* have compared with tap_info! 
svn path=/trunk/; revision=32091
 2010-03-03 15:34:44 +00:00
Anders Broman
87576533f7 Changed to use g_str_hash () 
sip_hash_func() function seem to not generate unique enough keys
if load generation tools are used with many thousands users.
Loading time ~5 min -> 30s

There is a memory leak in the sip_is_packet_resend area as well.

svn path=/trunk/; revision=32090
 2010-03-03 15:29:38 +00:00
Anders Broman
aaa917be72 remove check_col 
svn path=/trunk/; revision=32089
 2010-03-03 13:52:17 +00:00
Martin Mathieson
80d7644409 Its convenient to be able to filter on mac-lte.ulsch or mac-lte.dlsch. 
svn path=/trunk/; revision=32088
 2010-03-03 11:57:21 +00:00
Martin Mathieson
ebd8c30044 When looking at time differences between frames, round to nearest number of ms. 
svn path=/trunk/; revision=32086
 2010-03-02 18:41:35 +00:00
Martin Mathieson
bec769f815 Add 'repeated-NACK' analysis. 
This is a common symptom of serious problems.

svn path=/trunk/; revision=32085
 2010-03-02 18:40:34 +00:00
Anders Broman
989d6cb6cf remove check_col 
svn path=/trunk/; revision=32084
 2010-03-02 16:43:22 +00:00
Anders Broman
1d86f42804 Update to 9.0.0 
svn path=/trunk/; revision=32083
 2010-03-02 11:23:26 +00:00
Anders Broman
149c7ae55f From Hitoshi Irino: 
Displaying value and type of IPFIX reverse PEN elements in data records
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4399

svn path=/trunk/; revision=32082
 2010-03-02 06:12:21 +00:00
Anders Broman
c4d69e4453 From Luis Ontanon: 
Check for duplicate entries in usmUserTable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2426

svn path=/trunk/; revision=32081
 2010-03-02 05:44:04 +00:00
Martin Mathieson
15e32b3c73 Re-order file, and give some types/vars more specific names. 
svn path=/trunk/; revision=32075
 2010-03-01 23:56:35 +00:00
Martin Mathieson
862dd48d35 Improve RLC AM sequence analysis by taking MAC retx into account. 
svn path=/trunk/; revision=32071
 2010-03-01 22:52:34 +00:00
Stig Bjørlykke
011aa07154 From LEGO via bug 4395: 
Have the current_frame's last_item actually point to the last item.

svn path=/trunk/; revision=32069
 2010-03-01 22:12:38 +00:00
Stig Bjørlykke
aa6b8e1347 From LEGO via bug 4405: 
Add the dot ('.') to the characters that can compose a name.

svn path=/trunk/; revision=32068
 2010-03-01 22:11:20 +00:00
Anders Broman
fb7dab8874 Dissect Content-type application/vnd.3gpp.sms 
(Untested).

svn path=/trunk/; revision=32066
 2010-03-01 18:03:37 +00:00
Anders Broman
50f7fa97dc from Colin O'Flynn: 
6lowpan dissector: copy/paste error results in 64-bit source & 16-bit dest failing
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4545

svn path=/trunk/; revision=32065
 2010-03-01 11:13:54 +00:00
Anders Broman
27295cace2 Try to get rid of unused code warnings. 
svn path=/trunk/; revision=32064
 2010-03-01 11:05:06 +00:00
Anders Broman
71d08408ab Try to get rid of unused code warnings. 
svn path=/trunk/; revision=32063
 2010-03-01 09:49:46 +00:00
Anders Broman
2f89e6c62b Try to get rid of unused code warnings. 
svn path=/trunk/; revision=32062
 2010-03-01 09:33:47 +00:00
Anders Broman
6a4c131442 Try to get rid of unused code warnings. 
svn path=/trunk/; revision=32061
 2010-03-01 09:30:45 +00:00
Anders Broman
f25e74c524 Dissect error code. 
svn path=/trunk/; revision=32060
 2010-03-01 07:27:35 +00:00
Anders Broman
74f6bfd176 Add the missing .cnf file and try to fix unused code warnings. 
svn path=/trunk/; revision=32058
 2010-03-01 05:48:27 +00:00
Anders Broman
e64f902f7e Try to remove unused code warnings, update HNBAP to 9.0.0. 
svn path=/trunk/; revision=32057
 2010-02-28 21:18:45 +00:00
Anders Broman
c126a3970b From Erwin van Eijk: 
Add ETSI ts101671 dissector
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4543
I added dissection of 
	UmtsQos,
	IMSevent,
	LDIevent,
	TARGETACTIVITYMONITOR-1
	TARGETACTIVITYMONITORind,
	TARGETCOMMSMONITORind,
	TTRAFFICind,
	CTTRAFFICind
And used the original HI2Operations ASN1 file.l

svn path=/trunk/; revision=32053
 2010-02-28 20:51:24 +00:00
Martin Mathieson
58edf76433 Fix test for AM Rx window, and add a seqnum.analysis.ok field. 
svn path=/trunk/; revision=32051
 2010-02-28 20:43:04 +00:00
Martin Mathieson
9a1100ce5a Add 'missing SDUs' to tap info / RLC stats window. 
Also includes typo fixes from Pascal Quantin.

svn path=/trunk/; revision=32049
 2010-02-28 18:42:41 +00:00
Martin Mathieson
76d5a1eb75 Add some AM sequence analysis. 
svn path=/trunk/; revision=32044
 2010-02-28 02:18:35 +00:00
Jaap Keuter
0c12762330 Add two missing headerfields which were missing in revision 32033. 
svn path=/trunk/; revision=32037
 2010-02-27 21:09:25 +00:00
Guy Harris
0811fba435 Squelch a compiler warning. 
svn path=/trunk/; revision=32035
 2010-02-27 19:15:36 +00:00
Guy Harris
500eb99cd9 Add a third date format, ABSOLUTE_TIME_DOY_UTC, to show UTC with the 
date as YYYY/DDD, where DDD is a 1-origin day of year.  Move the formats
to a "time_fmt.h" file, included by the headers that use it.  Have
abs_time_to_str() and abs_time_secs_to_str() take the date format value,
rather than a Boolean "show this as UTC" flag, as an argument.  Document
the ABSOLUTE_TIME_ formats a bit better.  Use that format in the CCSDS
and VCDU dissectors, rather than having those dissectors do the
formatting themselves.

svn path=/trunk/; revision=32034
 2010-02-27 19:01:27 +00:00
Jaap Keuter
9dd11bb90e From Alexis La Goutte: 
Add support of notify msg type for RFC3706 Dead Peer Detection (DPD)
and dissect DPD Sequence.
Cleanup and enhancement for dissect CFG attributes.

svn path=/trunk/; revision=32033
 2010-02-27 18:55:11 +00:00
Stig Bjørlykke
0d51423cb0 Regenerated to get a constrained bitstring. 
svn path=/trunk/; revision=32032
 2010-02-27 16:48:07 +00:00
Guy Harris
79c2cf4c30 Temporarily un-staticize utc_to_julian(); it needs to be hoisted up into 
libwireshark, for use by multiple dissectors.

svn path=/trunk/; revision=32026
 2010-02-27 01:43:10 +00:00
Guy Harris
ca4125eb5e Staticize. 
svn path=/trunk/; revision=32025
 2010-02-27 01:18:21 +00:00
Guy Harris
ce3c4b2370 Get rid of unnecessary casting away of const. 
svn path=/trunk/; revision=32024
 2010-02-27 01:12:24 +00:00
Guy Harris
64fc28d937 Squelch warning (I think some compiler out there, perhaps AIX's, will 
fail on that).

svn path=/trunk/; revision=32023
 2010-02-27 01:03:16 +00:00
Guy Harris
7d7a964d3f Constify and staticize. 
svn path=/trunk/; revision=32022
 2010-02-27 01:02:19 +00:00
Guy Harris
e6e56a0652 Constify and clean up indentation. 
svn path=/trunk/; revision=32021
 2010-02-27 00:55:55 +00:00
Guy Harris
f3b4098040 Constify. 
Don't have variables that point to string constants, just make the
string constants be static const arrays.

strlen(array of unspecified size initialized with a string) ==
sizeof array - 1; the latter can be computed at compile time.

svn path=/trunk/; revision=32020
 2010-02-27 00:51:14 +00:00
Guy Harris
85fccb7f91 Constify, clean up indentation. 
svn path=/trunk/; revision=32019
 2010-02-27 00:43:44 +00:00
Stig Bjørlykke
6cf41668c2 Move rua to dirty dissectors. 
svn path=/trunk/; revision=32001
 2010-02-25 08:26:25 +00:00
Anders Broman
bacd403236 Move HNBAP to dirty dissectors for now. 
svn path=/trunk/; revision=31994
 2010-02-24 22:19:54 +00:00
Gerasimos Dimitriadis
d00eec07e2 Fix for bug 3926: 
Enhance decoding of TS2 channel list

svn path=/trunk/; revision=31993
 2010-02-24 22:17:52 +00:00
Anders Broman
da5346bf77 From Neil Piercy: 
Add 3GPP Home Node B Iuh protocol support (HNBAP & RUA)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4531
 - Added IE extension for HNBAP
 - Removed unused .h files

svn path=/trunk/; revision=31989
 2010-02-24 20:16:33 +00:00
Anders Broman
2f9306d05a GSM SMS PDU TPVPF wrong interpretation. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4524

svn path=/trunk/; revision=31985
 2010-02-24 12:41:01 +00:00
Stig Bjørlykke
2a05629490 Moved charging_ase, s1ap and x2ap to ASN.1 dissectors list. 
svn path=/trunk/; revision=31977
 2010-02-24 08:18:15 +00:00
Martin Mathieson
360077ae74 Calculate/show time between Msg3 and Msg4 
svn path=/trunk/; revision=31970
 2010-02-23 22:28:42 +00:00
Jaap Keuter
761414b98e Final missing end option is a protocol error too. 
svn path=/trunk/; revision=31968
 2010-02-23 20:04:11 +00:00
Jaap Keuter
be73966017 Fix for bug 4517: 
DNS response address is also in network order.

svn path=/trunk/; revision=31965
 2010-02-23 08:11:21 +00:00
Stig Bjørlykke
f81b2c196d Decode SecurityCategoryValue according to SecurityCategoryIdentifier. 
svn path=/trunk/; revision=31964
 2010-02-23 08:06:11 +00:00
Stig Bjørlykke
fc6df2979b Small fix for DistributionExtensionField. 
svn path=/trunk/; revision=31963
 2010-02-23 08:04:48 +00:00
Anders Broman
c1defb60a7 Try to fix compilation with MSVC. 
Please review.

svn path=/trunk/; revision=31962
 2010-02-23 06:28:34 +00:00
Guy Harris
b395a98305 Squelch a bunch of compiler warnings. 
svn path=/trunk/; revision=31961
 2010-02-23 04:35:23 +00:00
Guy Harris
c85899e946 Move the declarations of wtap_pcap_encap_to_wtap_encap() and 
wtap_wtap_encap_to_pcap_encap() to wiretap/pcap-encap.h.  Include it
where it's needed; don't include other Wiretap headers where they're not
needed.

Include pcapng.h in pcapng.c, to declare the functions defined in
pcapng.c.  Add some casts to squelch some warnings, and add to a comment
to indicate one of the problems.

svn path=/trunk/; revision=31960
 2010-02-23 03:50:42 +00:00
Guy Harris
0cc33d4c98 Move some dissectors to the "clean" category - the Ubuntu buildbot 
cranks up the warnings, with the side-effect of turning off -Werror, and
none of the other GCC buildbots complains about them.

svn path=/trunk/; revision=31958
 2010-02-23 02:49:28 +00:00
Stephen Fisher
b62d27c43d Minor cosmetic changes: 
- Display "Asynchronous Transfer Mode" instead of "ATM" in the protocol tree
 - Highlight the rest of the packet when the user selects ATM in the
   packet details pane.


svn path=/trunk/; revision=31946
 2010-02-22 09:06:41 +00:00
Gerasimos Dimitriadis
c79b4e5473 Fix for bug 4509: 
Make sure that the length addition results have not wrapped.

svn path=/trunk/; revision=31945
 2010-02-22 00:04:51 +00:00
Guy Harris
6105fcc8d5 Squelch some uninitialized-variable warnings (they're false positives). 
svn path=/trunk/; revision=31936
 2010-02-20 18:51:56 +00:00
Guy Harris
4a44d2c3dd Cast away some implicit-narrowing-conversion warnings. 
svn path=/trunk/; revision=31935
 2010-02-20 18:36:01 +00:00
Martin Mathieson
6a0c3ecaaf Include detected DL retx in stats. 
Each row is now a uniqe RNTI/UEId pair.
Added a filter button to filter by selected RNTI + UEId

svn path=/trunk/; revision=31931
 2010-02-20 16:58:48 +00:00
Anders Broman
cb427754aa Add a protocol reference. 
svn path=/trunk/; revision=31930
 2010-02-20 11:53:36 +00:00
Anders Broman
85b2749d36 From Mithun Roy: 
DTN Dissector Bugs.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4500

svn path=/trunk/; revision=31929
 2010-02-20 11:06:16 +00:00
Guy Harris
13c971dde3 We don't call assert() (and shouldn't - dissectors should use 
DISSECTOR_ASSERT(), so the dissection stops, but the app continues to
run), so we don't need to include <assert.h>.

svn path=/trunk/; revision=31928
 2010-02-19 23:45:31 +00:00
Jaap Keuter
f7e082ad35 Add expert items for missing end option in: 
- vendor option field
- overloaded sname field
- overloaded file name field

Improve the overload determination of sname and file name field.

svn path=/trunk/; revision=31927
 2010-02-19 22:46:07 +00:00
Guy Harris
9a5521a819 Fix tpyo. 
svn path=/trunk/; revision=31924
 2010-02-19 17:51:36 +00:00
Guy Harris
1b59a2446f Clean up decryption; have it return various indications for whether it 
was able to decrypt and, if it wasn't, why it wasn't, and put that
information into an expert information indication.

svn path=/trunk/; revision=31922
 2010-02-19 10:24:13 +00:00
Jaap Keuter
4ab14bc71e Ditch the last direct indexed character array. 
And some minor formatting updates.

svn path=/trunk/; revision=31921
 2010-02-19 07:43:26 +00:00
Martin Mathieson
7b2a3c26e6 Recognise update string for SR failure, and show ueid in MAC if set. 
svn path=/trunk/; revision=31916
 2010-02-18 21:24:47 +00:00
Jaap Keuter
6e795990fb The evil bit IS a security issue.... ;) 
svn path=/trunk/; revision=31915
 2010-02-18 20:58:04 +00:00
Anders Broman
48746a9fe7 Add a protocol reference. 
svn path=/trunk/; revision=31914
 2010-02-18 06:32:23 +00:00
Anders Broman
d8684d1d8d Cleanup of DECT dissector INFO column. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4502
- remove check_col()

svn path=/trunk/; revision=31913
 2010-02-18 06:18:34 +00:00
Anders Broman
802b91ecdb A stab in the dark at deissecting IS-637-A decoding for the CDMA SMS data Message Body. 
svn path=/trunk/; revision=31903
 2010-02-17 16:47:02 +00:00
Bill Meier
b9b7b1a57a Keep gcc happy. 
svn path=/trunk/; revision=31901
 2010-02-16 21:22:55 +00:00
Bill Meier
5b9cba54e3 Various relatively small changes: 
- #include stdio, stdlib, string not req'd.
- Use less generic macro names for a few defines.
- Fix some gcc -Wshadow warnings.
- Use the "standard idiom" for handling port preferences;
  (Doing port add/delete via a registered_init routine is not req'd).
- fix a typo.


svn path=/trunk/; revision=31900
 2010-02-16 21:17:26 +00:00
Bill Meier
ae429401e6 Fix a (small) memory leak. 
svn path=/trunk/; revision=31899
 2010-02-16 20:44:39 +00:00
Bill Meier
0958c9f41b Do SVN #31896 in a (somewhat) better way. 
svn path=/trunk/; revision=31897
 2010-02-16 19:57:46 +00:00
Bill Meier
ec023d7c92 Properly specify the IKE2 Decryption table default Encryption & Integrity Algorithms; 
This ensures that the correct defaults are shown when creating a new entry 
in the IKEV2 Decryption Table.

svn path=/trunk/; revision=31896
 2010-02-16 19:29:07 +00:00
Bill Meier
a1149978bd From Yaniv Kaul: minor changes + smallest additions 
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4339#c5

From Me:
 - Use VNC_... as the initial part of various enum identifiers to
   ensure that they are unique since they are part of the global namespace;
 - Fix some indentatiom;

svn path=/trunk/; revision=31876
 2010-02-13 16:42:01 +00:00
Bill Meier
a8a673ef42 Fix some indentation. 
svn path=/trunk/; revision=31875
 2010-02-13 16:28:32 +00:00
Bill Meier
629a186c14 From Mike Sager: NFS: parse RECLAIM_COMPLETE op 
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4469

svn path=/trunk/; revision=31874
 2010-02-13 16:25:30 +00:00
Jaap Keuter
3126f22a14 From Owen Kirby: 
This patch fixes a bug in the 6LoWPAN dissectors that corrupts addresses when
multicast address compression is used. Testing this fix also uncovered a bug in
the computation of the length of the extension headers. And some typos.

svn path=/trunk/; revision=31870
 2010-02-12 22:10:53 +00:00
Gerasimos Dimitriadis
f8d7a4c4b4 Show the substrings of AUTN and AUTS. Expert info warnings 
when their lengths is not the expected one.

svn path=/trunk/; revision=31869
 2010-02-12 21:57:07 +00:00
Gerasimos Dimitriadis
448b9a5199 Fix for Bug 4480: 
Octet containing first digit of IMEI(SV) highlighted
when IMEI(SV) selected

svn path=/trunk/; revision=31868
 2010-02-12 20:52:54 +00:00
Gerasimos Dimitriadis
fab0f16c18 Create FT_BYTES fields for the RAND, AUTN, SRES, XRES 
and AUTS octet strings in DTAP

svn path=/trunk/; revision=31859
 2010-02-10 22:34:34 +00:00
Jeff Morriss
8634f52025 Add SVN Id tag 
svn path=/trunk/; revision=31855
 2010-02-10 16:08:16 +00:00
Guy Harris
deccd41b15 No need for cvse_reserved as a variable; getting rid of it squelches a 
compiler warning.

svn path=/trunk/; revision=31854
 2010-02-10 08:20:55 +00:00
Anders Broman
8f5b2d749b Define VENDOR_VERIZON in sminmpec.h 
svn path=/trunk/; revision=31853
 2010-02-10 07:21:51 +00:00
Anders Broman
047f688a5c From yi ren: 
CVSE fields for MIP protocol is not correctly decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4477
From me:
- Fixed hf blurbs.
- FT_BYTES, BASE_NONE
- Updated value_strings from IANA registery.

svn path=/trunk/; revision=31852
 2010-02-10 06:59:26 +00:00
Bill Meier
9a3b1a78d1 Fix some memory leaks; Fix some indentation. 
This is a re-submission of SVN #31838 this time
properly using g_list_free() instead of g_free().

svn path=/trunk/; revision=31848
 2010-02-09 17:48:41 +00:00
Bill Meier
9fc016d8b9 Revert SVN #31838; It's NG. 
svn path=/trunk/; revision=31847
 2010-02-09 14:43:30 +00:00
Guy Harris
161c33aadb Don't trust the length field in a V5 sample to be valid. 
This appears to fix bug 4473.

svn path=/trunk/; revision=31846
 2010-02-09 10:17:53 +00:00
Guy Harris
07922081ff Do all the missing dissectors the same way. 
Oh, and there's no dissector registered as "atm" - and, if there were,
it probably wouldn't be able to handle AAL5 packets by themselves, as
you'd probably have to supply pseudo-header information (where does the
VPI/VCI come from, for example?).

This fixes bug 4471.

svn path=/trunk/; revision=31845
 2010-02-09 09:52:10 +00:00
Jaap Keuter
3c702d064b From Owen Kirby: 
This patch fixes a bug in the 6LoWPAN dissector where link-local addresses
created from an EUI-64 address do not correctly invert the universal/local bit
as recommended by section 4 of RFC2464.

svn path=/trunk/; revision=31843
 2010-02-09 08:40:40 +00:00
Ronnie Sahlberg
7d52b73e5d these two guys are actually range-strings and not value-string 
so it is surprising we didnt catche these before.


gcc complains about strict alignment on these



svn path=/trunk/; revision=31842
 2010-02-09 07:42:38 +00:00
Anders Broman
96bcad4ea8 Initialize sub_cfg_attr_type_tree. 
svn path=/trunk/; revision=31841
 2010-02-09 06:52:49 +00:00
Anders Broman
bceda505c0 From Alexis La Goutte: 
ISAKMP Enhancements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2905

svn path=/trunk/; revision=31840
 2010-02-09 06:15:49 +00:00
Anders Broman
c2f165f2e0 Another BASE_NONE. 
svn path=/trunk/; revision=31839
 2010-02-09 05:55:39 +00:00
Bill Meier
b3be21c93b Fix some memory leaks; Fix some indentation. 
svn path=/trunk/; revision=31838
 2010-02-08 23:45:10 +00:00
Guy Harris
f329e32f09 Terminate a value_string, and get rid of a non-ASCII character. 
(No ligatures, please.)

svn path=/trunk/; revision=31837
 2010-02-08 22:40:27 +00:00
Ronnie Sahlberg
118377ca6b flag two unusued arguments with _U_ to prevent a compiler warning 
svn path=/trunk/; revision=31836
 2010-02-08 22:35:49 +00:00
Anders Broman
b18d2bc900 Fix field base. 
svn path=/trunk/; revision=31833
 2010-02-08 21:15:54 +00:00
Anders Broman
fde5ff4c56 From Yi Yu: 
Enhanced sFlow dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3543

svn path=/trunk/; revision=31832
 2010-02-08 21:01:21 +00:00
Bill Meier
0880d9865c (Minor) Fix code so port pref change actually deletes the previous dissector port registration 
svn path=/trunk/; revision=31831
 2010-02-08 19:30:32 +00:00
Bill Meier
1a203c17b5 (Trivial): remove an incorrect _U_ in a few cases. 
svn path=/trunk/; revision=31830
 2010-02-08 18:54:31 +00:00
Bill Meier
a2a0eb4767 (Trivial changes): 
#include <stdio.h> not req'd; 
  localize two variables; 
  remove two unneeded forward reference declarations.

svn path=/trunk/; revision=31829
 2010-02-08 18:32:20 +00:00
Martin Mathieson
2e08a73235 Add preference that allows RLC PDUs embedded inside MAC info to be seen nicely in the info column 
svn path=/trunk/; revision=31828
 2010-02-08 15:01:08 +00:00
Ronnie Sahlberg
b4c02070e8 try autogenerate lsa in preparation for updates to the lsa idl file 
svn path=/trunk/; revision=31827
 2010-02-08 01:48:33 +00:00
Ronnie Sahlberg
ba234c5206 add a macro to handle types that are 2 bytes in ndr and 4 bytes in 
ndr64, i.e. enums.


svn path=/trunk/; revision=31826
 2010-02-08 00:48:45 +00:00
Ronnie Sahlberg
9b5ed8bf3b Flag the arguments as _U_ so that we dont fail the build with "unusued 
parameter" warnings if we build without libgcrypt



svn path=/trunk/; revision=31825
 2010-02-08 00:14:40 +00:00
Bill Meier
e74e2a598c Fix and rework some code a bit: 
-No prefs so prefs calback not req'd;
-Remove (seemingly) not needed dissector registration on UDP port 0;
-Rework dissect_applemidi_heur() and related so that once dissect_applemidi_heur()
  determines that a pair of UDP addr/ports are being used for the AppleMIDI protocol,
  dissect_apple_midi() will always be called directly for UDP packets with that pair 
  (rather than dissect_applemidi_heur() always be called for every packet).

svn path=/trunk/; revision=31824
 2010-02-07 23:51:56 +00:00
Guy Harris
7a4031e31d More uninitialized-variable warning squelching. 
svn path=/trunk/; revision=31823
 2010-02-07 20:45:49 +00:00
Stig Bjørlykke
f092ff045d Initialize a subtree. 
svn path=/trunk/; revision=31822
 2010-02-07 20:12:48 +00:00
Anders Broman
6d64ae6425 Try to pacify the buildbot. 
svn path=/trunk/; revision=31821
 2010-02-07 20:08:00 +00:00
Anders Broman
95e212e6c7 From Owen Kirby: 
Packet decryption for IEEE 802.15.4.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4457

svn path=/trunk/; revision=31820
 2010-02-07 19:39:31 +00:00
Stig Bjørlykke
85504613fd Fixed warning: format not a string literal and no format arguments. 
svn path=/trunk/; revision=31816
 2010-02-07 15:38:42 +00:00
Anders Broman
5ffc91810b From Tobias Erichsen: 
AppleMIDI - dissector for lightweight session protocol used in Apple network MIDI.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4455

svn path=/trunk/; revision=31814
 2010-02-07 14:30:11 +00:00
Anders Broman
0d999e6e74 From Stephen Donnelly: 
AAL2 preference.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4465

svn path=/trunk/; revision=31813
 2010-02-07 13:37:51 +00:00
Stig Bjørlykke
539b558f8c Renamed some reassembled data texts. 
Removed some check_col().

svn path=/trunk/; revision=31809
 2010-02-06 18:20:21 +00:00
Jaap Keuter
c084355412 From Chris Maynard: 
Take into account PIM protocol specifics with regards to TTL when colorizing packets.

svn path=/trunk/; revision=31807
 2010-02-05 22:39:14 +00:00
Jaap Keuter
ac07c187ee Harden "Process Information" presentation functions. 
svn path=/trunk/; revision=31806
 2010-02-05 22:08:29 +00:00
Jaap Keuter
a264038022 From Alex Burlyga: 
Currently parsing of the Exchange_Id is technically correct but hard to read.
This patch updates display inline with data structures specified in RFC 5661.

svn path=/trunk/; revision=31805
 2010-02-05 22:02:55 +00:00
Jaap Keuter
3d987f81c5 From Mike Sager: 
Dynamically register callback dissector based on the NFSv4.0 SETCLIENTID args
(the equivalent of what had already been done for NFSv4.1 CREATE_SESSION).

Fix CB_LAYOUTRECALL dissecting: the recall type wasn't getting parsed, so some
of the layout recall info wasn't being displayed.

Parse CB_SEQUENCE's referring call lists.

svn path=/trunk/; revision=31804
 2010-02-05 21:37:21 +00:00
Gerasimos Dimitriadis
214148c7c6 Fix the MNC decoding when Global Title is built 
according to E.212

svn path=/trunk/; revision=31802
 2010-02-05 20:54:13 +00:00
Anders Broman
222b6fac82 Try to pacify the buildbot. 
svn path=/trunk/; revision=31799
 2010-02-05 06:46:32 +00:00
Anders Broman
f93f8f0388 From Joshua Zhao: 
Add vendor extension support for 802.11 radiotap header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4283
Slightly modified.

svn path=/trunk/; revision=31798
 2010-02-05 05:54:56 +00:00
Guy Harris
85dd2ca96b I think you meant "pinfo->pseudo_header->atm.flags & ATM_AAL2_NOPHDR" 
(test whether ATM_AAL2_NOPHDR is set in atm.flags), not
"pinfo->pseudo_header->atm.flags | ATM_AAL2_NOPHDR" (which is always
true if ATM_AAL2_NOPHDR is nonzero, which it is).

svn path=/trunk/; revision=31796
 2010-02-05 01:06:27 +00:00