osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Changed to use g_str_hash () 

sip_hash_func() function seem to not generate unique enough keys
if load generation tools are used with many thousands users.
Loading time ~5 min -> 30s

There is a memory leak in the sip_is_packet_resend area as well.

svn path=/trunk/; revision=32090
This commit is contained in:
Anders Broman 2010-03-03 15:29:38 +00:00
parent aaa917be72
commit 87576533f7
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
epan/dissectors/packet-sip.c
View File

@ -803,7 +803,13 @@ static gint sip_equal(gconstpointer v, gconstpointer v2)
(ADDRESSES_EQUAL(&(val1->dest_address), &(val2->dest_address))) &&
(val1->dest_port == val2->dest_port);
}
#if 0
/*
20010-03-03 Changed to use g_str_hash ()
This function seem to not generate unique enough keys
if load generation tools are used with many thousands users.
Leave the code for a while to se if someone gets poor performance.
*/
/* Compute a hash value for a given key. */
/* Don't try to use addresses here, call-id should be almost unique. */
static guint sip_hash_func(gconstpointer v)
@ -821,7 +827,7 @@ static guint sip_hash_func(gconstpointer v)
return value;
}
#endif
/* Initializes the hash table and the mem_chunk area each time a new
* file is loaded or re-loaded in wireshark */
@ -833,7 +839,7 @@ sip_init_protocol(void)
g_hash_table_destroy(sip_hash);
/* Now create them over */
sip_hash = g_hash_table_new(sip_hash_func, sip_equal);
sip_hash = g_hash_table_new(g_str_hash , sip_equal);
}
/* Structure to collect info about a sip uri */