It makes it easier to see what is actually decrypted.
Change-Id: I6c1378f93d32dc31cedc6d901069fa9c30438d61
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/37269
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Initialize err in capture_loop_init_output, as caught by both clang's
scan-build and Visual Studio's code analysis. Initialze err in
capture_loop_init_pcapng_output to match.
Move another variable to the code block in which it is used.
Change-Id: I0306ae6a02a02a8e1ebda89b7c574a7cae01b68f
Reviewed-on: https://code.wireshark.org/review/37274
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
* Add new initial_source_connection_id and retry_source_connection_id
transport parameters for authenticating connection IDs.
* Rename original_connection_id to original_destination_connection_id.
* Rename max_packet_size to to max_udp_payload_size.
* Add new APPLICATION_ERROR transport error code.
Bug: 13881
Change-Id: I45c92e10a42fa8f8849b4c9f7b36b93870760173
Reviewed-on: https://code.wireshark.org/review/37262
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Give a new URL on LiveAction's Web site; that version speaks of both
Aruba and Cisco access points together.
Change-Id: I122441531081ceebff6fb6c865da8d898209d2cf
Reviewed-on: https://code.wireshark.org/review/37267
Reviewed-by: Guy Harris <gharris@sonic.net>
That URL is now dead - Wildpackets is now (part of) LiveAction.
Change-Id: I2dea461fa6e97034d9070cef397038bf606de98b
Reviewed-on: https://code.wireshark.org/review/37263
Reviewed-by: Guy Harris <gharris@sonic.net>
Added range_string for Operating Indicator Class
information to support Hotspot 2.0 ANQP messages
Bug: 16568
Change-Id: I98db7aed00703cf329d5a96d317bdf655a0f3dcd
Reviewed-on: https://code.wireshark.org/review/37245
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Adding Hotspot 2.0 ANQP Connection Capability Information
so the IP protocol and port assignments show up in the GUI
based on the Hotspot 2.0 documentation and implementation details.
Bug: 16569
Change-Id: Ic3e26e04c5d48269d59b6604b125569328c82faf
Reviewed-on: https://code.wireshark.org/review/37246
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Adding ANQP Type 280 - Network Authentication Type
Information with Timestamp per IEEE 802.11-2016 standard
and adding fields required for timestamp values.
Bug: 16570
Change-Id: Ifbe5d8abc40fcb543c2abaa7478d5feaae2f7945
Reviewed-on: https://code.wireshark.org/review/37247
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
IVIM decoding fixed where RSCUnit subtype with PER visible constraint is used, e.g. RSCUnit(0..1)
Change-Id: I2c15ef70ed9d89875737dd01769f6f882215276d
Reviewed-on: https://code.wireshark.org/review/37192
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
- the DEB bit no longer exists
- the EPS parameter highlight was off by one
Change-Id: Ic2abf827a2d70babab7854f339964a6535c73c53
Reviewed-on: https://code.wireshark.org/review/37243
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
It's ISO 11783-6, and the spec agrees with the previous change.
Change-Id: Iac8dd83a7844c59bcc1b74cd0712bc5f38b3ae43
Reviewed-on: https://code.wireshark.org/review/37218
Reviewed-by: Guy Harris <gharris@sonic.net>
Fix dissection of Ethertype IE which is two-octet long but
dissected as one-octet long.
Change-Id: I141ffebb4a53195d95e8af45fa7ef69e9c7feccd
Signed-off-by: Yoshiyuki Kurauchi <ahochauwaaaaa@gmail.com>
Reviewed-on: https://code.wireshark.org/review/37213
Reviewed-by: Joakim Karlsson <oakimk@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit fixes wrong dissection on the following fields
in Trace Information IE.
Session Trace Depth: don't overwrite length_trigger_events.
List of Interfaces: use length_list_interfaces instead of
length_list_trigger_events.
IP Address of Trace Collection Entity:
* dissect as IPv4 or IPv6 depending on the length.
* rename the field with the full name defined in spec.
Change-Id: I53537bfd61149fe42417667799c0542b98815882
Signed-off-by: Yoshiyuki Kurauchi <ahochauwaaaaa@gmail.com>
Reviewed-on: https://code.wireshark.org/review/37212
Reviewed-by: Joakim Karlsson <oakimk@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Important information to follow GPRS flows is added, and cleanup of
strings is done to follow flows if UL/DL or DATA/CTRL packets are
intersected.
Change-Id: I0f1839a71dc45a2ad9dd273f6ca00a7dfae365e0
Reviewed-on: https://code.wireshark.org/review/37197
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
In TLS RFCs PSK is referred to as "Pre-Shared Key". Update preference
text to use this.
Change-Id: I13f1380bfc46c90019a3560f316008864aae6ace
Reviewed-on: https://code.wireshark.org/review/37208
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Remove the test on tree before decoding the PDU and display the message
name
Change-Id: I2e8d9000d6da4ef812bf84539c1dc32c8ae9e2a1
Reviewed-on: https://code.wireshark.org/review/37194
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
The following sizes and offsets were incorrect:
- negotiation frame size (negotiation header size was used)
- response frame size (response frame header size was used)
- request frame size (response(sic!) frame header size was used)
- mutation subtree offset (resulting in wrong subtree size too)
- partition key subtree offset (resulting in wrong subtree size too)
Also, negotiation/response frames were not dissected correctly if they were
shorter than request header size (28) - they are correctly handled now.
Additionally, Seastar RPC magic sequence (SSTARRPC) is explicitly
added to the negotiation tree in order to explicitly show each part
of the frame.
Change-Id: Ibc5024b329113e98a363cfeb40223d61b9473fb2
Reviewed-on: https://code.wireshark.org/review/37186
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
1. Dissect the Motion Configuration Block from the Forward Open
2. Add Motion Attributes related to #1
3. Save the first/last segment for certain segment types in an EPATH.
Behavior changes based on the values in first segments for a given type,
vs later segments.
Change-Id: Id0552a585d158041c13adfa50f4bb164cada79b7
Reviewed-on: https://code.wireshark.org/review/37168
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Because we can.
Change-Id: Ic6e43ccea0e556be36c7a41b4fa40d52006e309b
Reviewed-on: https://code.wireshark.org/review/37183
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Response packets already contained references to their original
requests. Now, the reverse link is provided as well, so the response
frame can be conveniently reached from the request.
Change-Id: I09c7e3fc08c46d14315e2bad01573c20d9a079ad
Reviewed-on: https://code.wireshark.org/review/37179
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Two more packets do not expect a response:
- DEFINITIONS_UPDATE
- PAXOS_PRUNE
Change-Id: I7159f1311c0884a42e0d347244bfb734465c6fb9
Reviewed-on: https://code.wireshark.org/review/37184
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Added additional data items as defined in
* RFC 8757 Latency Range Extension
* RFC 8629 Multi-Hop Forwarding Extension
* RFC 8703 Link Identifier Extension
Change-Id: Iaf567911b20bf6e66466da5a3daba0499e2ce527
Reviewed-on: https://code.wireshark.org/review/37165
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
The verb was introduced recently as part of the paxos reconciliation
protocol.
Change-Id: I0c397a45790ff8ff3990c1906297405841b30a09
Reviewed-on: https://code.wireshark.org/review/37178
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
While we're at it, fix some typoes, and clean up the white space.
Change-Id: I32cdcb6603bcf76df26f74bd60cdaadc01b28693
Reviewed-on: https://code.wireshark.org/review/37171
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
/opt/SourceCode/wireshark/epan/dissectors/packet-frame.c 818 warn V547 Expression 'fi' is always true.
/opt/SourceCode/wireshark/epan/dissectors/packet-gsm_sms.c 2692 warn V547 Expression 'length <= (offset - saved_offset)' is always false.
/opt/SourceCode/wireshark/epan/dissectors/packet-isup.c 4688 warn V1037 Two or more case-branches perform the same actions. Check lines: 4688, 4697
/opt/SourceCode/wireshark/extcap/androiddump.c 1237 warn V560 A part of conditional expression is always true: data_str.
/opt/SourceCode/wireshark/extcap/androiddump.c 1603 warn V547 Expression is always true.
/opt/SourceCode/wireshark/ui/qt/models/packet_list_model.cpp 497 warn V560 A part of conditional expression is always true: ok_r1.
For the voip_calls.c change, I preferred to initailize along with every other field, rather than set to actual value it gets set to later.
For the isobus-vt change, I could not find a spec but followed the pattern from other error bit fields.
Bug: 16335
Change-Id: Ie55082222b582f6fff4e8c7a992d863acee6cf15
Reviewed-on: https://code.wireshark.org/review/37160
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Map the "Link-layer address type" value to ARP hardware types.
Change-Id: I0552bf57bf39e2daa26588181b4a9e343eb9cd6d
Reviewed-on: https://code.wireshark.org/review/37170
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
Different header, with a different size, an additional field, and with
fields being in a different order.
Distinguish between V1 and V2 by giving the version.
That means we can no longer use the "ethertype" dissector as it stands,
because the packet type field isn't at the end of the header, right
before the payload; pull the "add the type field to the protocol tree"
functionality out of the "ethertype" dissector and leave it up to the
dissector calling it.
Change-Id: I72b8a2483c0a539919fbe5d35fd7e60bff4bf75a
Reviewed-on: https://code.wireshark.org/review/37169
Petri-Dish: Guy Harris <gharris@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <gharris@sonic.net>
Pascal Quantin
Pau Espin