Commit Graph

17363 Commits

Author SHA1 Message Date
Ulf Lamping f8d7cbf654 remove some XXX markers in comments which are no (longer) ToDo items
svn path=/trunk/; revision=17715
2006-03-24 02:40:59 +00:00
Ulf Lamping fe3c3029aa Various code cleanup in the capture pipe stuff
svn path=/trunk/; revision=17714
2006-03-24 02:23:48 +00:00
Ulf Lamping e43c4e50c9 add another comment what's currently missing in the PROFINET specific parts
svn path=/trunk/; revision=17713
2006-03-24 02:20:37 +00:00
Jaap Keuter a10dd1b04e Completed Channel Identification IE with Channel number/Slot map field
svn path=/trunk/; revision=17712
2006-03-23 23:04:43 +00:00
Gerald Combs fa522c7349 Add Coverity IDs 44-109, plus others. More tomorrow after my eyes rest.
svn path=/trunk/; revision=17711
2006-03-23 23:03:22 +00:00
Gerald Combs 6be7d55c40 Further refinements for Coverity CID 42. Make some "0"s (which were
confusing my feeble mind) NULLs.  Fix up whitespace.

svn path=/trunk/; revision=17710
2006-03-23 20:13:00 +00:00
Anders Broman e4bdd466cf From Mike Duigou:
> I have improved the heuristics and the display tree building code in
> dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem.

svn path=/trunk/; revision=17709
2006-03-23 18:42:25 +00:00
Gerald Combs 40be5362b6 Coverity CID 48 is still complaining about a NULL dereference. Hopefully
this will fix it.

svn path=/trunk/; revision=17708
2006-03-23 18:22:42 +00:00
Anders Broman 699146b353 Doc update from Sqlite
svn path=/trunk/; revision=17707
2006-03-23 17:01:51 +00:00
Anders Broman f2de697f7d Minor update to the dictionary
svn path=/trunk/; revision=17706
2006-03-23 17:01:14 +00:00
Anders Broman b0d52994be Covierty bug fix.
svn path=/trunk/; revision=17705
2006-03-23 17:00:32 +00:00
Anders Broman 7186d13653 Fix bug:
825 setup message has an error in gsm-a-dtap 

svn path=/trunk/; revision=17704
2006-03-23 16:59:48 +00:00
Anders Broman 2f9f463ede Fix Bugs
820     gsm-map checkIMEI decoding error  
821     gsm-map sendIMSI decoding error  

svn path=/trunk/; revision=17703
2006-03-23 16:58:50 +00:00
Luis Ontanon fdb5257f7c Bug 796
the dictionary parser could not handle more than one attribute with parameters per file 


svn path=/trunk/; revision=17702
2006-03-23 00:57:56 +00:00
Michael Tüxen fd0640e930 Update to draft-ietf-tsvwg-sctp-auth-02.txt.
svn path=/trunk/; revision=17701
2006-03-23 00:36:35 +00:00
Gerald Combs 92460ae2b0 Add entries for several bugs, including Coverity IDs 1 - 43.
svn path=/trunk/; revision=17700
2006-03-22 21:39:32 +00:00
Anders Broman 70a045d772 From Mertin Wrnes:
Following my last submitted patch I did some further investigation on the different types of iSeries  Comms Traces, although the field formats are constant, things such as page throws and line spacing vary depending on the tool used to pull the trace form the iSeries spool.

This patch should better handle the different formats and more importantly exit in a graceful manner if an unknown format is encountered.


svn path=/trunk/; revision=17699
2006-03-22 17:37:04 +00:00
Anders Broman 441d892b13 From Motonori Shindo:
find attached the patch that reflects this interpretation of 
> this field accordingly. It also fixes a few minor bugs associated with 
> the handling of 'UNIX Secs' field and two field types
> (LAST_SWITCHED(21) and FIRST_SWITCHED(22)) in case of NetFlow V9.

svn path=/trunk/; revision=17698
2006-03-22 17:19:56 +00:00
Anders Broman 8fa4a23147 From Jeff Morris
fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=332

svn path=/trunk/; revision=17697
2006-03-22 17:13:09 +00:00
Anders Broman f0c117048d Handle two octet lengths correctly and remove optional decoding of sns_config, as I read the standard there is no difference.
svn path=/trunk/; revision=17696
2006-03-22 17:11:31 +00:00
Anders Broman f935a4f8f6 Fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=820
svn path=/trunk/; revision=17695
2006-03-22 17:10:19 +00:00
Guy Harris ed351b85c1 Use "opt_func_string_t" so that we get some more type checking done.
Use safe_ versions of <ctype.h> macros, so we don't get hosed by
characters with the 8th bit set.

Define "tplt_linedir()" with a function prototype.

Constify some stuff to squelch compiler warnings.

svn path=/trunk/; revision=17694
2006-03-21 23:55:30 +00:00
Guy Harris 7a2997ff83 Make it a bit more like the SQLite lemon.c 1.36.
Get rid of some function pointer casting.

Get rid of an unused routine, and make some routines static.

Remove trailing white space.

svn path=/trunk/; revision=17693
2006-03-21 23:17:15 +00:00
Anders Broman 2d99b1a362 Mimmicing lemon.c 1.36 exactly for Symbolcmpp does not make MSVC completly happy, see what FC4 says.
svn path=/trunk/; revision=17692
2006-03-21 20:03:56 +00:00
Anders Broman b5f2bdac77 Upadates to squlite:s lemon 1.36
svn path=/trunk/; revision=17691
2006-03-21 18:56:34 +00:00
Guy Harris 0129bb146c Simplify the argument list to cap_pipe_dispatch().
svn path=/trunk/; revision=17690
2006-03-21 09:36:07 +00:00
Jaap Keuter f4248f455d From Bill Meier:
Ensure "relevant function" logic works for loopback packets containing multiple forwarding addresses.


svn path=/trunk/; revision=17689
2006-03-21 06:54:12 +00:00
Ulf Lamping a9b74a73ce fix Docbook/XML DTD conformance
svn path=/trunk/; revision=17688
2006-03-21 00:17:40 +00:00
Gerald Combs 38b73ce55e Add security bugs found after canary checking was added. Coverity bugs
will be added separately.

Add other release items.

svn path=/trunk/; revision=17687
2006-03-20 20:27:52 +00:00
Anders Broman 3239ded778 svn properties
svn path=/trunk/; revision=17686
2006-03-20 19:53:07 +00:00
Anders Broman 6087ba3942 svn properties
svn path=/trunk/; revision=17685
2006-03-20 19:51:06 +00:00
Anders Broman ea024eb4ad From Martin Mathieson:
Some cosmetic changes:
- when working out the application id description to show in the info 
column, also consider vendor application identifiers
- make sure application ids and command codes are always shown as 
decimal numbers
- a little whitespace tidyup

svn path=/trunk/; revision=17684
2006-03-20 19:46:04 +00:00
Anders Broman bc7e69cc09 Try again, this should take us to lemon version 1.16 http://www.sqlite.org/cvstrac/rlog?f=sqlite/tool/lemon.c
svn path=/trunk/; revision=17683
2006-03-20 19:40:09 +00:00
Jaap Keuter 95fc8d3c59 Provide options to work with defaults of text2pcap.
svn path=/trunk/; revision=17682
2006-03-20 11:45:36 +00:00
Ronnie Sahlberg f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00
Anders Broman 17cee445d7 Back out the previous changes (:
svn path=/trunk/; revision=17680
2006-03-20 08:16:03 +00:00
Anders Broman 4edc146c8d Insert the code from sqlite http://www.sqlite.org/cvstrac/rlog?f=sqlite/tool/lemon.c:
2002-Mar-10 21:21    1.11    Check-in [425] : Bug fix: updates within a transaction would fail if there was existed a temporary table. By drh. (diff)  
2002-Mar-03 02:49    1.10    Check-in [411] : Bug fixes and additional tests for the subquery flattener. By drh. (diff)  

svn path=/trunk/; revision=17679
2006-03-20 06:41:08 +00:00
Guy Harris ce711119e0 Add guid_to_str to the list of exported functions.
svn path=/trunk/; revision=17678
2006-03-19 22:44:47 +00:00
Luis Ontanon 43ca54066a Add pinfo.lo and pinfo.hi been thise the lower and the higher between pinfo.src and pinfo.dst.
Do not faill if Columns is NULL, as it can normally be NULL. 


svn path=/trunk/; revision=17677
2006-03-19 22:18:57 +00:00
Guy Harris 7db8eea5c6 Make the GUIDs in various data structures e_guid_t's rather than arrays
of 16 bytes.  Use "sizeof" for the size of e_guid_t's, and use structure
assignment to copy GUID values.

Make functions such as append_h225ras_call() and new_h225ras_call() take
pointers to e_guid_t's as arguments.

Define GUID_LEN in epan/guid-utils.h and use it as the length of a GUID
in a packet.  (Note that "sizeof e_guid_t" is not guaranteed to be 16,
although it is guaranteed to be the size of an e_guid_t.)

When constructing a display filter that matches a GUID, use
guid_to_str() to construct the string for the GUID.

svn path=/trunk/; revision=17676
2006-03-19 20:45:45 +00:00
Guy Harris 624db0dc41 Fix pipe_read_bytes() to return the total number of bytes read, not just
the number of bytes read in the last read() call done.

svn path=/trunk/; revision=17675
2006-03-19 20:39:49 +00:00
Guy Harris 68a1def103 Get rid of extra arguments in g_strdup_printf() calls (the end of the
list of arguments is determined by the format string; there's no need
for a NULL terminator).

Fix indentation.

svn path=/trunk/; revision=17674
2006-03-19 20:26:45 +00:00
Guy Harris 7cf33cb6fc Get rid of a declaration of a non-existent function.
svn path=/trunk/; revision=17673
2006-03-19 20:23:59 +00:00
Guy Harris 0d66eda9ba Fix some format strings to display all fields in some mode sense page
bytes.

Constify some variables to squelch compiler warnings.

svn path=/trunk/; revision=17672
2006-03-19 20:23:17 +00:00
Guy Harris f1a5571448 Turn the handle types into an enum, so that they're more likely to be
displayed by name in debuggers and so that switch statements can check
whether all types are handled.

Add a check for an unknown handle type, to squelch compiler warnings
(and to catch missing handle type code at run-time, if new handle types
are added).

svn path=/trunk/; revision=17671
2006-03-19 20:21:56 +00:00
Guy Harris cfe070105f Fix typo.
svn path=/trunk/; revision=17670
2006-03-19 20:19:40 +00:00
Jaap Keuter be52b0238d No negative power consumption, so unsigned value.
svn path=/trunk/; revision=17669
2006-03-19 17:32:21 +00:00
Anders Broman 5d20a3ba36 Sqlite lemon 1.8 ( 1.7 Make lemon 64-bit clean skipped) :
Bugfix Check-in [388] : Bug fix in lemon: 3-way conflicts (SHIFT/REDUCE/REDUCE) were not detected or resolved. This is now fixed. Also, table compression works a little better. By drh. (diff) 

http://www.sqlite.org/cvstrac/rlog?f=sqlite/tool/lemon.c 


svn path=/trunk/; revision=17668
2006-03-19 13:59:44 +00:00
Jaap Keuter 0050f4e68d Patch that fixes bug 793 and a few other things mostly revolving around
BACnet schedules.  Could someone please take care of this?

1) fDate - correctly handle wild card year
2) fTime - rename local variables cut-and-pasted from fDate
3) fCalendarEntry - do single-pass decoding rather than while loop since the structure cannot be repeated.
4) fDailySchedule - correctly handle enclosing context tags.
5) fWeeklySchedule - correctly handle enclosing context tags
6) fAcknowledgeAlarmRequest - fix function name spelling and tags 3 and 5 are timeStamp, not time.
7) fSpecialEvent - handle context tags correctly.
8) fReadRangeRequest - Add cases from 2004 spec

Dave Richards


svn path=/trunk/; revision=17667
2006-03-19 12:28:21 +00:00
Anders Broman 94d4d822da Align lemon/lempar.c with Squlite ver 1.2 http://www.sqlite.org/cvstrac/rlog?f=sqlite/tool/lempar.c
svn path=/trunk/; revision=17666
2006-03-19 08:54:00 +00:00