osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
44,430 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

44430 Commits

Author SHA1 Message Date
Bill Meier f4e862fb1a Cleanup: 
- "localize" some variables; remove some unneeded initializers;
- indentation, whitespace, long lines & etc.

svn path=/trunk/; revision=47103
 2013-01-15 21:52:23 +00:00
Bill Meier 026c798c98 Fix several window resize behavior differences between Gtk2 & Gtk3. 
Specifically: replace several gtk_container_add() calls by
              gtk_box_pack_start() calls.

svn path=/trunk/; revision=47102
 2013-01-15 21:09:12 +00:00
Evan Huus d0b774d0ea Minor documentation tweaks. Add a hash table to the wishlist. 
svn path=/trunk/; revision=47101
 2013-01-15 18:29:27 +00:00
Bill Meier 786d870f1f Cleanup: 
- localize some vars; remove some unneeded initializers;
- indentation & white space & etc.

svn path=/trunk/; revision=47100
 2013-01-15 17:54:47 +00:00
Bill Meier e0b350aafb Fix Gtk2 vs Gtk3 issue: 
Set a default size for the window so that the
initial size of the window in Gtk3 is similar to
that in Gtk2. That is: so that all the columns
(and a number of rows) show.

svn path=/trunk/; revision=47099
 2013-01-15 17:10:32 +00:00
Evan Huus b1ac6585bc Don't run past the end of a fragment array, either in the loop or by putting a 
useless sentinel in.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8213

svn path=/trunk/; revision=47098
 2013-01-15 16:51:55 +00:00
Jeff Morriss 1a93ee3345 Based on http://ask.wireshark.org/questions/17661/tcap-decoding-bug : 
Register the Camel dissector for SSN 146 instead of (GSM MAP's) SSN 6-9.
Looks like the 6-9 list was a carryover from when this dissector was created
based on the GSM MAP dissector.

svn path=/trunk/; revision=47097
 2013-01-15 16:44:02 +00:00
Martin Kaiser e00af44a36 extend the iso7816 dissector 
link request apdus to response apdus
dissect parameters p1 and p2 for some messages

svn path=/trunk/; revision=47096
 2013-01-15 16:41:03 +00:00
Evan Huus 5a74d61822 Add modelines. 
svn path=/trunk/; revision=47095
 2013-01-15 16:37:29 +00:00
Evan Huus e963cec25c Add missing header #include as the slab is part of the API even if nobody 
outside wmem itself uses it yet.

svn path=/trunk/; revision=47094
 2013-01-15 16:27:17 +00:00
Evan Huus b0a0372cff Use the block allocator for wmem's file-scope by default. 
svn path=/trunk/; revision=47093
 2013-01-15 16:25:24 +00:00
Bill Meier 3adfacfea6 Cleanup: indentation, whitespace, long-lines, formatting & etc. 
svn path=/trunk/; revision=47092
 2013-01-15 15:16:53 +00:00
Jeff Morriss 5e543a3e28 From Hadriel Kaplan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8202 : 
AM_CONFIG_HEADER() is obsolete (and removed from automake 1.13 and later); use
AC_CONFIG_HEADERS instead.

svn path=/trunk/; revision=47091
 2013-01-15 14:07:53 +00:00
Jeff Morriss 2233b34cf1 Add boilerplate GPLv2+ license as per email response from Scott Renfro: 
https://www.wireshark.org/lists/wireshark-dev/201301/msg00062.html

svn path=/trunk/; revision=47088
 2013-01-15 02:17:16 +00:00
Bill Meier ef4749d4e2 Minor cleanup: 
- remove severl gtk_box_set_child_packing() statements which "do nothing";
 - replace several gtk_container_add()/gtk_box_set_child_packing() sequences
    by gtk_box_pack_start().

svn path=/trunk/; revision=47087
 2013-01-15 01:42:09 +00:00
Bill Meier 8c2127b946 Replace gtk_table...() with ws_gtk_grid...() 
(with some finagling so that the layout is about the same
for both Gtk2 & Gtk3).

svn path=/trunk/; revision=47086
 2013-01-14 23:54:08 +00:00
Gerald Combs b0ef1a67ed strcmp → g_strcmp0. Fixes a crash on Windows. 
svn path=/trunk/; revision=47085
 2013-01-14 23:23:50 +00:00
Evan Huus e4f46ce55f Take a wild guess at what might be causing 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8197

It can't hurt, in any case.

svn path=/trunk/; revision=47084
 2013-01-14 22:29:23 +00:00
Gerald Combs b82f42d8cf When the user is editing text or selecting from a combo box, don't 
immediately close the dialog if he or she presses the escape or enter
keys. Revert the value if the user presses escape. Properly handle the
base for uint preferences. Fix a NULL pointer dereference.

Add a gchar_free_to_qstring utility routine which creates a QString from
a g_malloced string and frees it.

svn path=/trunk/; revision=47083
 2013-01-14 22:21:11 +00:00
Jaap Keuter 21f9ab573d Add missing files to package. 
Allow more recent automake.

svn path=/trunk/; revision=47082
 2013-01-14 21:39:10 +00:00
Gerald Combs aafa77c6f4 Try to show what condition triggered a failure. 
svn path=/trunk/; revision=47079
 2013-01-14 20:17:20 +00:00
Gerald Combs 6be760c512 Put packet-ncp2222.c in epan/dissectors. This matches Makefile.am's behavior. 
svn path=/trunk/; revision=47078
 2013-01-14 20:05:24 +00:00
Chris Maynard ad78db491a Fix Coverity CID 732304: Missing break in switch. 
svn path=/trunk/; revision=47077
 2013-01-14 19:23:26 +00:00
Chris Maynard f2dd9bc0d2 Avoid any possibility of an infinte loop. Fixes Coverity CID 739883: Infinite loop. (Minor whitespace cleanup also.) 
svn path=/trunk/; revision=47076
 2013-01-14 19:14:51 +00:00
Chris Maynard afdc2a9a12 Fix Coverity CID 741081: Logically dead code. (Minor whitespace cleanup also.) 
svn path=/trunk/; revision=47075
 2013-01-14 19:00:44 +00:00
Chris Maynard c6c41ee09b Fix Coverity CID 741991: Wrong sizeof argument. 
svn path=/trunk/; revision=47074
 2013-01-14 18:41:25 +00:00
Chris Maynard b3bc6cf28f Fix Coverity CID 741992: Unused pointer value. 
svn path=/trunk/; revision=47073
 2013-01-14 18:31:04 +00:00
Gerald Combs 57c3d011b3 Make sure we have epan/wmem/*.h. 
svn path=/trunk/; revision=47072
 2013-01-14 18:29:50 +00:00
Pascal Quantin 1891adc28e Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8208 : 
Display ECI and LAC in decimal and fix highlighting of CGI, SAI, RAI, TAI, ECGI and LAI fields

svn path=/trunk/; revision=47071
 2013-01-14 18:29:27 +00:00
Chris Maynard fc9663740e Use SET_ADDRESS() to initialize src and dst as both src.hf and dst.hf were uninitialized. Fixes Coverity CID's 752013-752014: Uninitialized scalar variable. 
svn path=/trunk/; revision=47070
 2013-01-14 16:55:07 +00:00
Chris Maynard de91f3638b Declare count as ssize_t instead of size_t, since read(), and thus ws_read(), can return a negative number. If that were to happen, then assigning the return value to an unsigned variable and then comparing that variable against 0 will yield incorrect/unintended results. Fixes Coverity CID 761910: Negative array index write. 
svn path=/trunk/; revision=47069
 2013-01-14 16:34:19 +00:00
Bill Meier 31e5c6f727 Replace gtk_table...() with ws_gtk_grid...(). 
Also:
  Use #if 0 rather than /* */ to coment out some code;
  Very minor whitespace fixup.

svn path=/trunk/; revision=47068
 2013-01-14 16:17:42 +00:00
Chris Maynard 231bd8ab50 Fix Coverity CID 762007: Logically dead code. 
svn path=/trunk/; revision=47067
 2013-01-14 16:06:20 +00:00
Chris Maynard 110509a77f Fixed Coverity CID 762008: Structurally dead code. 
svn path=/trunk/; revision=47066
 2013-01-14 15:49:30 +00:00
Jeff Morriss 664d138ea2 Previous commit put a little too much of the README.developer boilerplate in... 
svn path=/trunk/; revision=47065
 2013-01-14 15:47:55 +00:00
Chris Maynard 9dedcbdb82 packet-ncp2222.c -> dissectors/packet-ncp2222.c 
svn path=/trunk/; revision=47064
 2013-01-14 15:39:38 +00:00
Jeff Morriss e64d2f9b3f In response to http://ask.wireshark.org/questions/17660/licence-of-editcap 
and as per email response from Richard Sharpe, add GPLv2+ boilerplate header
and license.

svn path=/trunk/; revision=47063
 2013-01-14 15:25:49 +00:00
Chris Maynard b89380dd74 Fix CID 966603: Unused pointer value. 
svn path=/trunk/; revision=47062
 2013-01-14 15:13:21 +00:00
Chris Maynard c56910aa70 Fix CID 967205: Unused pointer value. 
svn path=/trunk/; revision=47061
 2013-01-14 15:09:12 +00:00
Jaap Keuter 23d2320dd0 Fixing CID 280433 and 280357. 
Also strengthening the checking and debug presentation.

svn path=/trunk/; revision=47060
 2013-01-14 07:43:14 +00:00
Bill Meier 165f86b9a3 Cleanup: Whitespace, formatting-style, long-lines & etc. 
Use "4 space" indentation.

Add an XXX comment about better formating needed
 for the text in the Help window (so the
 text columns line up and so the Help text
 looks better).

Comment out a "does-noting" for loop;

svn path=/trunk/; revision=47059
 2013-01-14 04:28:16 +00:00
Bill Meier c7120ce08e Replace gtk_table...() with ws_gtk_grid...(); 
Also: Minor changes so that window resizing is handled
      identically in Gtk2 & Gtk3.

svn path=/trunk/; revision=47058
 2013-01-14 03:13:55 +00:00
Gerald Combs 917510f087 Fix building a Debian package. 
svn path=/trunk/; revision=47053
 2013-01-13 23:00:38 +00:00
Gerald Combs a0df458eb8 [Automatic manuf, services and enterprise-numbers update for 2013-01-13] 
svn path=/trunk/; revision=47048
 2013-01-13 15:03:34 +00:00
Pascal Quantin ccbff26e80 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8196 : 
Add dissection of IPv4v6 type to End User Address IE

svn path=/trunk/; revision=47047
 2013-01-13 11:04:46 +00:00
Michael Mann a9fb54c677 bugfix nested loop that wasn't breaking out of the main loop when subloop really wanted it to. Bug 8198 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8198) 
svn path=/trunk/; revision=47046
 2013-01-13 02:58:42 +00:00
Michael Mann 8a18cb574b guint16 needed to prevent rollover. Bug 8199 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8199) 
#BACKPORT

svn path=/trunk/; revision=47045
 2013-01-13 02:03:55 +00:00
Bill Meier 492d84d6a2 General whitespace & formatting style cleanup. 
svn path=/trunk/; revision=47044
 2013-01-12 20:00:50 +00:00
Bill Meier 83bc776dc3 Replace gtk_table...() with ws_gtk_grid...(). 
svn path=/trunk/; revision=47043
 2013-01-12 18:40:01 +00:00
Bill Meier 4fbdb87e1a General cleanup: whitespace, long-lines, & etc. 
svn path=/trunk/; revision=47042
 2013-01-12 16:23:09 +00:00