Commit graph

58 commits

Author SHA1 Message Date
Jeff Morriss
dc53486da6 Fix (or at least work around the crash in)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4119 :

Never insert more than 1000 silence frames (e.g., if the sequence number jumps
massively).  There may be a better way, but at least now we won't crash.
Leave a comment in the code indicating this.

svn path=/trunk/; revision=32304
2010-03-27 00:54:11 +00:00
Jeff Morriss
14f2f93a35 s/#if DEBUG/#ifdef DEBUG/
svn path=/trunk/; revision=32302
2010-03-26 23:34:54 +00:00
Bill Meier
538dd47d5d Fix various gcc -Wshadow warnings.
svn path=/trunk/; revision=31731
2010-01-29 19:09:01 +00:00
Bill Meier
b28c81bf19 Use gtk_progress_bar_set_fraction instead of the deprecated gtk_progress_bar_update;
svn path=/trunk/; revision=31384
2009-12-29 17:46:34 +00:00
Jaap Keuter
220054bd43 PortAudio doesn't make sure that a default device is even available on the default Host API (go figure).
Therefore opening the default stream may fail in the precense of usable devices, on other Host API's.
If the default stream fails to open iterate among the Host API's to find one with a default device.

svn path=/trunk/; revision=31318
2009-12-18 23:26:12 +00:00
Jaap Keuter
9b55f28a3d Squelch GTK warnings on the RTP player progress bar when resizeing the window.
svn path=/trunk/; revision=31298
2009-12-17 19:58:57 +00:00
Jaap Keuter
b5080f83c7 Squelch a GTK warning on the RTP player spinner control.
svn path=/trunk/; revision=31297
2009-12-17 17:59:46 +00:00
Anders Broman
b16fab6435 From Alejandro Vaquero:
Add RTP player to "RTP Stream Analysis" and makeover of VoIP flow
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4240

svn path=/trunk/; revision=30967
2009-11-15 20:13:08 +00:00
Jaap Keuter
e2c8640c8d Properly handle closing/destruction of RTP player window.
svn path=/trunk/; revision=29468
2009-08-18 17:36:30 +00:00
Anders Broman
485fc6805b Change window_new() to dlg_window_new() and destroy the window with the top level window.
svn path=/trunk/; revision=28810
2009-06-22 15:22:37 +00:00
Gerald Combs
35b474b83f From Nick Lewis via bug 3319:
When audio samples have to be dropped or silence samples inserted to reflect
the timestamp there is no indication of these problems on the display.

I propose that such problems be indicated on the waveform display by the use of
amber coloration and that the number of incorrect timestamps be listed

svn path=/trunk/; revision=28451
2009-05-22 18:39:26 +00:00
Jaap Keuter
5f900d062c Extend error reporting from PortAudio library.
svn path=/trunk/; revision=28358
2009-05-14 06:26:16 +00:00
Jaap Keuter
4692f6cae7 When destroying the RTP player make sure to terminate the use of PortAudio library.
At least that is what the documentation says.

svn path=/trunk/; revision=27073
2008-12-21 18:49:20 +00:00
Jaap Keuter
c95944a16a Correct language.
svn path=/trunk/; revision=27060
2008-12-19 11:31:28 +00:00
Jaap Keuter
2621a14a34 Plug memory leak.
svn path=/trunk/; revision=26873
2008-11-28 22:54:08 +00:00
Bill Meier
d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Tomas Kukosa
5f4f0df387 From Alejandro Vaquero:
Added a new checkbox for the RTP player to use the RTP timing instead of the
arriving time of the packets. This is useful when the RTP is being tunneled
(e.g. EtherIP), so the original timing is missing.
In some cases when encapsulating the original IP/RTP over EtherIP, the
encapsulated data comes in chunks of 1sec, so it is useful to use the RTP
timing to play it. In these cases we can not simulate jitter buffer, so this is
disabled when checking the new "Use RTP timestamp" option.

svn path=/trunk/; revision=25293
2008-05-14 06:22:07 +00:00
Ulf Lamping
644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping
d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping
8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping
1f4b5e5f07 replace SIGNAL_DISCONNECT_BY_FUNC with g_signal_handlers_disconnect_by_func
svn path=/trunk/; revision=24911
2008-04-11 20:34:30 +00:00
Ulf Lamping
c6d13dc2c8 replace WIDGET_SET_SIZE with gtk_widget_set_size_request
svn path=/trunk/; revision=24910
2008-04-11 20:31:05 +00:00
Ulf Lamping
ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier
77b615b79f OBJECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24896
2008-04-11 16:55:44 +00:00
Ulf Lamping
3b7fe5fc6c remove GTK1 code
svn path=/trunk/; revision=24823
2008-04-07 00:42:04 +00:00
Jaap Keuter
2e0f8088c3 From Jim Young:
This patch provides a new RTP Player preferences dialog.  It allows one to
select the maximum number of visable channels in the RTP Player window.  The
default is four (4) channels which is the maximum number of usable channels 
that the RTP Player can display and still have access to the bottom row buttons 
on a 1024*768 resolution display.  Specifying a value less than 1 or greater than 
10 will be result in the RTP Player displaying the default 4 channels.

svn path=/trunk/; revision=24112
2008-01-16 07:36:34 +00:00
Stephen Fisher
430866e511 To ease troubleshooting of bug #2017 and for code clarity in the future, use
two different variables for types voip_rtp_stream_info_t (strinfo) and
voip_calls_info_t (callsinfo) instead of using strinfo for both.


svn path=/trunk/; revision=24038
2008-01-09 08:34:58 +00:00
Jaap Keuter
670e46f78b Make RTP player G.729 Annex B compatible.
svn path=/trunk/; revision=24032
2008-01-08 13:04:50 +00:00
Mike Duigou
7dcafc5e82 Avoid casting directly from int to pointers. (It doesn't work on 64-bit linux)
svn path=/trunk/; revision=23322
2007-10-31 15:16:33 +00:00
Tomas Kukosa
136de3920c new codec table for registering codecs by name
new codec plugin type
search registered codecs in rtp player
fix memory leak in rtp player

svn path=/trunk/; revision=23270
2007-10-25 09:38:15 +00:00
Bill Meier
09e7be9068 From Jim Young: Simple one line patch resolves compiler warning.: Bug #1929
svn path=/trunk/; revision=23240
2007-10-22 15:13:41 +00:00
Alejandro Vaquero
4bf238547f VoIP Calls changes: Add the file name to the title window in VoIP calls, Voip graph and RTP player windows. Make the calls selection using standard multiple selection using the GTK buildin functions. Add a 'Select All' buttom to the VoIP calls window.
svn path=/trunk/; revision=23089
2007-10-08 00:31:26 +00:00
Bill Meier
64d7c80f56 Add #include needed to get defs for PT_PCMU & etc
svn path=/trunk/; revision=22549
2007-08-18 04:28:40 +00:00
Guy Harris
e104794902 Use #defines, rather than raw numbers, for RTP payload types.
Note that we should return an error for payload types we don't support,
so the user knows we can't handle the audio.

svn path=/trunk/; revision=22547
2007-08-18 01:46:14 +00:00
Jaap Keuter
c55f11cc73 Fixing the GTK1 build shouldn't break the GTK2 build.
svn path=/trunk/; revision=22485
2007-08-11 08:03:46 +00:00
Jaap Keuter
7e33de36d7 Fix GTK1 compilation.
svn path=/trunk/; revision=22479
2007-08-09 20:41:09 +00:00
Jaap Keuter
1b50aa2a44 Unused parameter
svn path=/trunk/; revision=21444
2007-04-16 06:20:39 +00:00
Sebastien Tandel
83cac28421 uninitialized warning fix
svn path=/trunk/; revision=21439
2007-04-14 19:49:48 +00:00
Sebastien Tandel
04f63f9897 unused variable
svn path=/trunk/; revision=21436
2007-04-14 18:18:25 +00:00
Ulf Lamping
407d0aeab0 fix all warnings in gtk dir & set the "treat all warnings as errors" MSVC flag
svn path=/trunk/; revision=21080
2007-03-21 03:26:26 +00:00
Guy Harris
007f88f3e2 Unreffing rci->cursor_pixbuf should cause the pixbuf to be released, so
null out the pointer to it.  This prevents a freed pixbuf from being
used.

svn path=/trunk/; revision=19687
2006-10-25 19:48:54 +00:00
Guy Harris
aecfc9cf43 Clean up indentation.
Fix typos.

Null out "pa_stream" when the stream is closed; this appears to prevent
some crashes.

svn path=/trunk/; revision=19633
2006-10-20 18:18:50 +00:00
Guy Harris
62d7ab40f6 Don't destroy something if it doesn't exist.
svn path=/trunk/; revision=19632
2006-10-20 17:56:21 +00:00
Guy Harris
89b99ff3f2 Don't pass an uninitialized string to gtk_widget_create_pango_layout();
it supports NULL for "no text".

svn path=/trunk/; revision=19631
2006-10-20 17:47:28 +00:00
Guy Harris
0d9a445fee Don't do things with the RTP channels hash table if it hasn't been
created yet.

svn path=/trunk/; revision=19630
2006-10-20 17:30:27 +00:00
Guy Harris
ff780d78f3 Fix the progress bars.
svn path=/trunk/; revision=19629
2006-10-20 17:12:52 +00:00
Ulf Lamping
a1b7a22a8e from Stephen Fisher:
Here is a patch for spelling typos in comments and strings in the gtk/ 
directories.

svn path=/trunk/; revision=19568
2006-10-17 01:29:55 +00:00
Jörg Mayer
926ed8aa01 Alejandro Vaquero:
Add portaudio v19 support in addition to v18:

   Here is a patch using the API 2 (v19). I tested it only in Windows.
Attached also the Windows v19 zip file used. I did not modify the
Makefile.nmake to download this new version (when running the "setup"),
because Windows v18 it is still good.


svn path=/trunk/; revision=19446
2006-10-07 14:24:32 +00:00
Guy Harris
2ac8761978 Include "rtp_player.h" in "voip_calls.c" if we're supporting the RTP
player, so that we get declartions of rtp_player_init() and
add_rtp_packet().

Constify the first argument to add_rtp_packet(), as it's passed a
pointer to a const value.

svn path=/trunk/; revision=19272
2006-09-21 17:39:17 +00:00