Commit Graph

33057 Commits

Author SHA1 Message Date
Guy Harris f2f1023487 Fix comments (not all platforms on which we run support dlopen(), but
GLib handles that with g_module_open() as a platform-independent "load a
module at run time" wrapper).

svn path=/trunk/; revision=34491
2010-10-12 18:25:42 +00:00
Bill Meier 2b0f6a63f1 Define some fcns & vars as static;
Rename g_capture_in_progress to gbl_capture_in_progress (capture_if_dlg.c)
Do some whitespace cleanup.

svn path=/trunk/; revision=34490
2010-10-12 17:39:44 +00:00
Bill Meier 2d3abb5cec Minor cleanup of the global name space:
- Define some vars as static;
- Rename some externs to be less generic;
Also: cleanup some whitespace.

svn path=/trunk/; revision=34489
2010-10-12 16:42:02 +00:00
Bill Meier c004d57361 Minor cleanup of the global namespace:
- Define some fcns and vars as static;
- Use less generic names for certain externs;
Also: Remove some usused #defines & cleanup some whitespace


svn path=/trunk/; revision=34488
2010-10-12 16:05:19 +00:00
Bill Meier c78221d4ce Rename g_resolv_flags --> gbl_resolv_flags; Also: cleanup some whitespace & indentation.
svn path=/trunk/; revision=34487
2010-10-12 13:15:08 +00:00
Anders Broman 6e31c8c406 It's no longer neccesarry to set the E_DFILTER_TE_KEY on the popup_menu objects.
svn path=/trunk/; revision=34486
2010-10-12 07:41:18 +00:00
Guy Harris 3c27b97c26 Get rid of C++-style comments; use #if 0/#endif to remove code.
svn path=/trunk/; revision=34485
2010-10-12 01:27:58 +00:00
Jeff Morriss 0267a5293d Fix an error in a comment I added last week.
svn path=/trunk/; revision=34480
2010-10-11 20:16:35 +00:00
Anders Broman 24d4eda023 menus.c: In function 'add_menu_recent_capture_file_absolute':
menus.c:4583: warning: unused variable 'recent_files_list'

svn path=/trunk/; revision=34479
2010-10-11 20:05:49 +00:00
Anders Broman eb007bae23 Get filter_te from top_level rather then from the widget.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5288

svn path=/trunk/; revision=34478
2010-10-11 19:29:52 +00:00
Bill Meier e7568712ef Define some fcns & vars as static;
Minor whitespace and comments cleanup.

svn path=/trunk/; revision=34477
2010-10-11 19:00:55 +00:00
Gerald Combs b2a92a4c35 Use the latest User's Guide.
svn path=/trunk/; revision=34470
2010-10-11 16:01:48 +00:00
Stig Bjørlykke 32da2562b8 We set sensitivity on the map button in ct_nb_map_switch_page_cb().
svn path=/trunk/; revision=34469
2010-10-11 08:29:25 +00:00
Stig Bjørlykke ce8e4aa47c Don't add a border around the main window, this looks bad in the new
Ubuntu release.

svn path=/trunk/; revision=34468
2010-10-11 08:28:38 +00:00
Jeff Morriss 074e49fd41 hf variables can be copied/passed by value, not by reference.
svn path=/trunk/; revision=34467
2010-10-11 01:52:41 +00:00
Jeff Morriss 6deff94555 Add comments indicating that the DISSECTOR_ASSERT() routines should not be used to report malformed packets.
svn path=/trunk/; revision=34466
2010-10-11 01:28:22 +00:00
Bill Meier 0b9a803e45 #include <string.h> apparently req'd on OSX ...
svn path=/trunk/; revision=34465
2010-10-10 23:48:16 +00:00
Bill Meier 93b94a23ca Define some fcns & vars as static; Some #includes not req'd; packet-mikey.h not req'd.
svn path=/trunk/; revision=34464
2010-10-10 23:28:40 +00:00
Bill Meier 09d718f723 Rename vals_status & vals_pdu_type to wsp_vals_status & wsp_vals_pdu_type
svn path=/trunk/; revision=34463
2010-10-10 20:45:19 +00:00
Bill Meier 4ae8d25300 Minor code cleanup:
- define some vars & fcns as static;
- remove an unused var;
- use tfs_set_notset in tfs.c;
- slightly simplify reg_handoff.

svn path=/trunk/; revision=34462
2010-10-10 20:39:00 +00:00
Bill Meier 4d56c5b57b Define a variable as static; Minor code simplification.
svn path=/trunk/; revision=34461
2010-10-10 20:28:22 +00:00
Bill Meier 6486e8b781 Combine packet-opsi.h with packet-opsi.c (since not used elsewhere); Define some fcns as static.
svn path=/trunk/; revision=34460
2010-10-10 20:19:05 +00:00
Bill Meier acccf6a77c Define some fcns & vars as static...
svn path=/trunk/; revision=34459
2010-10-10 20:14:34 +00:00
Bill Meier 209109c2fd Define some fcns & vars as static ...
svn path=/trunk/; revision=34458
2010-10-10 20:07:06 +00:00
Bill Meier 219877f1d3 #include <epan/tfs.h> not req'd.
svn path=/trunk/; revision=34457
2010-10-10 20:03:39 +00:00
Guy Harris 708e2d905b Fix build.
svn path=/trunk/; revision=34456
2010-10-10 19:42:30 +00:00
Anders Broman 45371fce82 - Fix more callbacks.
When using the GUImanager the callback signature is (GtkAction *action , gpointer user_data) which causes problems when retreiveing
object data stored with the widget such as the filter box widget.

Work around that problem by doing
	filter_cm = g_object_get_data(G_OBJECT(top_level), E_DFILTER_CM_KEY);
	filter_te = gtk_bin_get_child(GTK_BIN(filter_cm));
in the follow_udp/tcp/ssl_stream.

svn path=/trunk/; revision=34455
2010-10-10 19:33:42 +00:00
Guy Harris f9371b0e0b It's now "change column", not just "rename column"; fix build.
Clean up indentation.

svn path=/trunk/; revision=34454
2010-10-10 19:05:04 +00:00
Anders Broman dc03d627d7 Fix up a number of callbacks.
Bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5288
requires abit of reworking of the callbacks or a different aproach to setting object data.

svn path=/trunk/; revision=34453
2010-10-10 18:10:33 +00:00
Gerald Combs 6a17a217d9 [Automatic manuf, services and enterprise-numbers update for 2010-10-10]
svn path=/trunk/; revision=34449
2010-10-10 15:42:36 +00:00
Gerald Combs cca5e071af [Automatic manuf, services and enterprise-numbers update for 2010-10-10]
svn path=/trunk/; revision=34448
2010-10-10 15:03:38 +00:00
Stig Bjørlykke 7bb2c88475 Fix menu entry.
svn path=/trunk/; revision=34447
2010-10-09 18:41:46 +00:00
Stig Bjørlykke 2ed80dc7ba Fix menu entries.
svn path=/trunk/; revision=34446
2010-10-09 18:38:25 +00:00
Stig Bjørlykke 4ce3021a07 Prefix window title with "Wireshark".
svn path=/trunk/; revision=34445
2010-10-09 18:37:31 +00:00
Stig Bjørlykke ccfe41300c Added "Edit Column Details" functions to the packet list heading popup.
Removed "Rename Column Title" as this is moved to "Edit Column Details".

svn path=/trunk/; revision=34444
2010-10-09 15:22:53 +00:00
Stig Bjørlykke 20cdf3194c From Alexander Koeppe via bug 5287:
Correct order of Window Scaling Graph in Graph control box.

svn path=/trunk/; revision=34443
2010-10-09 11:37:57 +00:00
Jeff Morriss 161a233392 Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

svn path=/trunk/; revision=34437
2010-10-08 18:11:31 +00:00
Jeff Morriss 33f116a46d Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).

Remove check_col().

svn path=/trunk/; revision=34436
2010-10-08 17:48:22 +00:00
Jeff Morriss 7321549932 Don't use a TRY/CATCH block just to ignore any exceptions thrown by
tvb_get_ntohs(): check the remaining tvb length instead.

svn path=/trunk/; revision=34435
2010-10-08 17:37:19 +00:00
Stig Bjørlykke 06a60e48c3 Show custom column occurrence in the packet list heading tooltips.
svn path=/trunk/; revision=34434
2010-10-08 11:08:36 +00:00
Martin Mathieson f6ee7d8d4f From Tobias Witek (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5283)
epan/dissectors/packet-umts_fp.c
* Added mac subdissector (MAC) call to HSDSCH TYPE2 frames

epan/dissectors/packet-umts_mac.c
* Added support for HSDSCH TYPE2 frames by means of
        not nibble-shifting (4 bits) the SDU if MAC-ehs is used

epan/dissectors/packet-rlc.c
* Added support for "Use special value of the HE field" (3gpp 25.332-7a0 
9.2.2.7) commonly used for Release 7 HSDPA.
        REMARK: although the specification mandates that the
        special value is only allowed when activated by higher
        layers (RRC), it is interpreted unconditionally. We assume
        this is OK, because a different use in future specifications
        is very unlikely.

epan/dissectors/packet-fp_hint.c
* Added decoding of MAC-ehs indicator for HSDSCH frames
* Bumped fpi->release from 6 to 7 to enable proper
        HSDSCH TYPE2 frame decoding in the UTMS MAC parser.
        In general, this appears not to affect decoding
        of (conformant) FP frames of pevious releases.

svn path=/trunk/; revision=34433
2010-10-08 11:03:08 +00:00
Anders Broman 2239d905db Add Alexander Koeppe to the list.
svn path=/trunk/; revision=34432
2010-10-08 10:51:21 +00:00
Anders Broman 0135435c0f Get rid of an GUI artifact if the recent list is empty.
svn path=/trunk/; revision=34431
2010-10-08 06:05:06 +00:00
Guy Harris a9e7cb04cc Make some routines unused outside gtk/menus.c static.
svn path=/trunk/; revision=34430
2010-10-08 03:09:15 +00:00
Guy Harris e6894e3175 Fix a routine name - that menu item has nothing to do with colorization.
svn path=/trunk/; revision=34429
2010-10-08 03:00:54 +00:00
Guy Harris cf6b73afed Clean up white space.
set_menu_object_data_meat_old() is only used with main_menu_factory;
simplify it.

Add some comments to #else's and #endif's.

svn path=/trunk/; revision=34428
2010-10-08 02:38:47 +00:00
Guy Harris 186ad7c299 set_menu_sensitivity_old() is now only used for the main menu; simplify
it accordingly.

svn path=/trunk/; revision=34427
2010-10-08 02:17:37 +00:00
Jeff Morriss fae45ea6a1 Remove check_col()
svn path=/trunk/; revision=34426
2010-10-08 01:50:50 +00:00
Guy Harris d4c3cbea6d Move a comment next to the only item to which it now refers.
svn path=/trunk/; revision=34425
2010-10-08 01:38:12 +00:00
Jeff Morriss 8d9ed7f963 Restore private_data even if there was an exception
svn path=/trunk/; revision=34424
2010-10-08 01:36:20 +00:00