osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
23475 commits 23 branches 0 tags 1.3 GiB
Commit graph

6050 commits

Author SHA1 Message Date
Anders Broman
38f23ab4e6 Finish dissection of 
- NAL unit - Sequence parameter set
- NAL unit - Picture parameter set
for the trace I have and also dissect those NAL units in the RTP stream.
For "elements coded as ue(v), me(v), or se(v) are Exp-Golomb-coded" only ue(v) is implemented.

svn path=/trunk/; revision=23858
 2007-12-13 21:20:52 +00:00
Jörg Mayer
7303115b86 Replace // comments 
svn path=/trunk/; revision=23856
 2007-12-13 11:37:03 +00:00
Jörg Mayer
3c397a3459 Add airopeek dissector 
svn path=/trunk/; revision=23855
 2007-12-13 11:33:53 +00:00
Jörg Mayer
160d7b71af Update a comment about some flags 
svn path=/trunk/; revision=23853
 2007-12-12 23:59:31 +00:00
Jörg Mayer
68a28c4a97 The extra bytes seem to go away if I call wlan_datapad instead 
of wlan.

svn path=/trunk/; revision=23852
 2007-12-12 23:26:39 +00:00
Jörg Mayer
a1af5ede6f Beginnings of airopeek remote capture support. 
The metainformation is not yet decoded, also, there
are problems with QoS frames (extra bytes).

svn path=/trunk/; revision=23851
 2007-12-12 23:03:44 +00:00
Anders Broman
4d01fd05cb tvbuff.c - fix abug if reading last byte in tvb 
Further H.264 decoding in SDP

svn path=/trunk/; revision=23847
 2007-12-12 21:50:14 +00:00
Tomas Kukosa
a76ff82d70 - register RFC 2198 as RTP dynamic payload type "red" 
- display dynamic payload type names inside RFC 2198

svn path=/trunk/; revision=23846
 2007-12-12 10:51:09 +00:00
Tomas Kukosa
2ce05b41eb strings registered to dissector table have to be allocated permanently 
svn path=/trunk/; revision=23838
 2007-12-11 09:33:09 +00:00
Jaap Keuter
6016eab0bf From Jim Young: 
Attached is a patch to packet-vlan.c to add "summary info" to the protocol tree.

svn path=/trunk/; revision=23837
 2007-12-11 07:42:36 +00:00
Stephen Fisher
1479f03673 Make the EtherNet/IP (Industrial Protocol) I/O dissection a new type 
of dissector that rejects packets it doesn't recognize (on udp port
2222).


svn path=/trunk/; revision=23836
 2007-12-11 04:33:08 +00:00
Stig Bjørlykke
36c9b397d7 uint16_t -> guint16 
uint32_t -> guint32

svn path=/trunk/; revision=23835
 2007-12-10 22:22:15 +00:00
Stig Bjørlykke
5a1bb85a2c Mark some pinfo unused to make it compile. 
svn path=/trunk/; revision=23833
 2007-12-10 22:18:53 +00:00
Anders Broman
92e1ee3721 Decode more of H264 info in SDP. 
svn path=/trunk/; revision=23832
 2007-12-10 21:25:32 +00:00
Ronnie Sahlberg
9a3eeab4ee add some more names for Query/Set path info levels and add empty stubs 
for these blobs


svn path=/trunk/; revision=23831
 2007-12-10 21:16:17 +00:00
Jaap Keuter
1f272d5f5e From Masatake YAMATO: 
This dissector supports version 3.0 of the dlm (Distributed Lock Manager) protocol.
Actual implementation for the protocol is in linux kernel. See files under linux/fs/dlm/.

svn path=/trunk/; revision=23828
 2007-12-10 19:02:43 +00:00
Anders Broman
70aa312f01 Add OID:s related to H264. 
svn path=/trunk/; revision=23827
 2007-12-10 18:25:44 +00:00
Stig Bjørlykke
d450d9fe4e Added option to turn off SEQ/ACK analysis. 
Moved some resend expert infos to correct entry.
Small fix in seq/ack analysis for report/notificacion.

svn path=/trunk/; revision=23825
 2007-12-10 11:17:48 +00:00
Tomas Kukosa
1e794fc494 ANSI TCAP regenerated and tested with -T -X asn2wrs options 
asn2wrs has -T (tagged types support) and -X (new BER sttructures) default behavior
remove all -T and -X usage

svn path=/trunk/; revision=23823
 2007-12-10 08:35:41 +00:00
Gerald Combs
b7d8f269b2 Make sure we don't try to allocate a negative number. 
svn path=/trunk/; revision=23820
 2007-12-10 03:12:11 +00:00
Guy Harris
b2f28fb370 Get rid of non-ASCII character in a value_string table. (They might 
upset MSVC++ if the wrong code page is selected, and there's no
guarantee that all forms of output of dissected packets are in any
particular character encoding.)

svn path=/trunk/; revision=23819
 2007-12-09 21:10:25 +00:00
Anders Broman
e5f48395f1 Move the routines tvb_skip_wsp() to tvbuff.c 
svn path=/trunk/; revision=23818
 2007-12-09 17:41:16 +00:00
Jaap Keuter
006d1c446e From Márton Németh: 
When an ISOCHRONOUS URB was captured the packet-usb.c does not handle it.
Case URB_ISOCHRONOUS was added at two different places to handle it also.

svn path=/trunk/; revision=23817
 2007-12-09 10:59:09 +00:00
Jörg Mayer
1621df1080 Warning fix: 
- No comma after last element in enum

Fix:
- Call new_dissector_register for new style dissector.

svn path=/trunk/; revision=23808
 2007-12-08 17:45:02 +00:00
Stephen Fisher
f4fcd1b146 Fix TiVoConnect dissector, seemingly broken since rev 18415. 
svn path=/trunk/; revision=23807
 2007-12-08 09:15:23 +00:00
Gerald Combs
be6e31fa44 Register the "samr.nt_password" preference as obsolete. 
svn path=/trunk/; revision=23794
 2007-12-07 18:50:41 +00:00
Martin Mathieson
a73c7817f6 Fix build by creating dissect function that tcp_dissect_pdus(). My Windows build didn't miss the mismatched return type... 
svn path=/trunk/; revision=23791
 2007-12-07 13:26:15 +00:00
Martin Mathieson
f33ca55e00 Make stun2 over udp a new-style dissector, so that it can reject stun frames on the standard port they share (and let the heuristic dissector for stun run). Otherwise I needed to set UDP to try heuristic dissectors first or disable stun2 altogether... 
svn path=/trunk/; revision=23789
 2007-12-07 00:23:16 +00:00
Tomas Kukosa
1bef58264a fix field attributes handling for tagged types 
regenerate involved dissectors

svn path=/trunk/; revision=23783
 2007-12-06 11:23:35 +00:00
Guy Harris
a3d7a2c66f Squelch a warning about a variable getting clobbered by a longjmp. 
svn path=/trunk/; revision=23780
 2007-12-06 08:22:16 +00:00
Anders Broman
325b335505 fixe http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2064 GSM_MAP decodes SendRoutingInfov2 incorrectly 
- Add TYPE_ATTR for RoutingInfo ( Fixes the choice problem).
- Dissect ExternalSignalInfo
- Use subtree for AddressStrings

svn path=/trunk/; revision=23776
 2007-12-05 21:58:58 +00:00
Anders Broman
437bfb9910 Remove debug code. 
svn path=/trunk/; revision=23775
 2007-12-05 20:49:46 +00:00
Anders Broman
d639aace72 Insert asn1 code for SendRoutingInfov2 and update template 
Partly fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2064 GSM_MAP decodes SendRoutingInfov2 incorrectly

svn path=/trunk/; revision=23774
 2007-12-05 20:16:02 +00:00
Jeff Morriss
20a98a36f3 From Cliff Romash: TMR is not a mandatory parameter on an ANSI IAM but USI is. 
svn path=/trunk/; revision=23773
 2007-12-05 19:55:40 +00:00
Guy Harris
61eeae5de2 Clean up indentation. 
Use G_GINT64_MODIFIER for gint64 and guint64 values.  Use "u", rather
than "d", for unsigned values.  Put whitespace in the proper place in
format strings.

svn path=/trunk/; revision=23762
 2007-12-05 09:43:20 +00:00
Guy Harris
35fc0e7187 Make the "protocol" field big enough to hold the 3-character 
null-terminated string that the format item used when scanning says it
is - i.e., 4 "char"s, including the null terminator.

(Thanks and a tip of the hat to "gcc (GCC) 3.3.5 (propolice)" on OpenBSD
4.2 for finding this.)

svn path=/trunk/; revision=23761
 2007-12-05 09:31:05 +00:00
Ronnie Sahlberg
d55f6955d6 the GSS Checksum in secure onc-rpc contains the same blobs as GSS Tokens 
does.

make wireshark decode these blobs


svn path=/trunk/; revision=23759
 2007-12-05 08:37:51 +00:00
Mike Duigou
cb3f7e3f7d svn path=/trunk/; revision=23758 2007-12-05 04:20:21 +00:00
Greg Morris
6c87d3d49e Display textual explanation for printer and job values from RFC 2911. 
svn path=/trunk/; revision=23752
 2007-12-04 16:33:48 +00:00
Stig Bjørlykke
0f0c02bbae Duplicate packet # -> Retransmission # 
svn path=/trunk/; revision=23751
 2007-12-04 14:04:37 +00:00
Tomas Kukosa
08bbd29c71 Support for RPCAP features in GUI (from Boris Misenov, see Bug 1366) 
- retrieving the list of remote PCAP interfaces
  - password authentication support
  - UDP data fransfer
  - packet sampling (available in WinPcap 4.x)
  etc.

fix problem if non-default rpcap port is used

svn path=/trunk/; revision=23750
 2007-12-04 11:19:29 +00:00
Jaap Keuter
852d928901 Make mpeg2ts over UDP possible. Heuristic and Decode as. 
svn path=/trunk/; revision=23743
 2007-12-04 07:11:38 +00:00
Jaap Keuter
f4c89beb21 Remove superfluous buffer allocation. 
svn path=/trunk/; revision=23742
 2007-12-04 06:50:11 +00:00
Anders Broman
95d422156a Use common code for ASCII -> tvb. 
svn path=/trunk/; revision=23741
 2007-12-04 06:00:02 +00:00
Ronnie Sahlberg
ee6c98b8b2 update to new signature for string keyed trees 
svn path=/trunk/; revision=23737
 2007-12-04 03:27:27 +00:00
Anders Broman
b414c81f1f Fetch all fmtp parameters. 
svn path=/trunk/; revision=23724
 2007-12-03 22:40:04 +00:00
Anders Broman
063c688bc0 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2057 
The tag for PSTNTermination is [95].

svn path=/trunk/; revision=23723
 2007-12-03 22:22:25 +00:00
Ronnie Sahlberg
b10403f13e add end of line to the last line of the file 
svn path=/trunk/; revision=23718
 2007-12-03 21:54:27 +00:00
Ronnie Sahlberg
830da048fc mark two unused parameters as _U_ 
svn path=/trunk/; revision=23717
 2007-12-03 21:52:57 +00:00
Stig Bjørlykke
b958a1a124 Mark pinfo as unused. 
svn path=/trunk/; revision=23713
 2007-12-03 21:33:56 +00:00
Anders Broman
20b383c1b1 Dissect RTP payload of H.264 and SDP profile-leve-id for H.264. 
svn path=/trunk/; revision=23709
 2007-12-03 20:14:42 +00:00
Graeme Lunt
a58643173d Revised P7 dissector to use #.TABLE directive to generate tables for the ROS dissector from 
the [ABSTRACT] OPERATIONS definitions in the ASN.1 file.


svn path=/trunk/; revision=23707
 2007-12-03 19:32:28 +00:00
Graeme Lunt
5d8693069d Support table-based dissection of ROS operations. 
This simplifies the generation of dissectors for ROS-based protocols using the asn2wrs #.TABLE directive.

See the P7 dissector for an example.


svn path=/trunk/; revision=23706
 2007-12-03 19:29:24 +00:00
Jeff Morriss
aabf0f25d1 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2059 : reassemble XUDTS, too 
svn path=/trunk/; revision=23705
 2007-12-03 18:12:25 +00:00
Jeff Morriss
757b5e13e6 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2063 : there's only 1 octet of FSN in non-ANSI COO/COA's. 
svn path=/trunk/; revision=23704
 2007-12-03 17:32:02 +00:00
Martin Mathieson
8a311e2320 Add "soap" -> "http" mapping. 
svn path=/trunk/; revision=23703
 2007-12-03 15:47:08 +00:00
Tomas Kukosa
0ba8976eb7 fix confusion in tag handling 
svn path=/trunk/; revision=23702
 2007-12-03 13:48:45 +00:00
Martin Mathieson
b8ef070e84 My compiler (I think wrongly) says that fnum could be used uninitialised. 
svn path=/trunk/; revision=23701
 2007-12-03 12:22:13 +00:00
Stig Bjørlykke
ecdb4359d2 From Florent DROUIN: 
I just add a test for the index, to check we are in the element table.

This fixes bug 2051.

svn path=/trunk/; revision=23688
 2007-11-30 16:01:08 +00:00
Stig Bjørlykke
8286c9a645 From Florent DROUIN: 
There is a new check for the length, and the reported_length is added to the
offset, instead of the "theorical" length of the element.

This fixes bug 2052.

svn path=/trunk/; revision=23687
 2007-11-30 15:55:28 +00:00
Tomas Kukosa
f9fae482f5 define ssl_debug_flush() for disabled debug 
svn path=/trunk/; revision=23683
 2007-11-30 12:41:23 +00:00
Tomas Kukosa
187864ff8f setup SRTP stream if MIKEY is detected in OLC 
svn path=/trunk/; revision=23682
 2007-11-30 12:37:30 +00:00
Tomas Kukosa
b19d4c9e42 use g_strconcat() which should be faster instead of g_strdup_printf() 
svn path=/trunk/; revision=23681
 2007-11-30 11:46:13 +00:00
Tomas Kukosa
aab2bf936e - fix warnings in prefs.c 
- do not flush SSL debug output after each message but only once per packet

svn path=/trunk/; revision=23680
 2007-11-30 11:12:55 +00:00
Stig Bjørlykke
c068f9acf2 From Jens Braeuer (bug 1999): 
This patchs adds the 
- requested check of tlv_len at top of the disection-loop
- length check for fields w/ variable length (expert_add_info_format)

svn path=/trunk/; revision=23673
 2007-11-29 17:25:36 +00:00
Anders Broman
b1370e46d0 Didier Gautheron: 
Only call ether_to_str(), get_ether_name() if the tree is visible, they are slow.

svn path=/trunk/; revision=23666
 2007-11-29 06:29:20 +00:00
Anders Broman
87503b059e Didier Gautheron: 
Call subdissectors preference for retransmitted frames.

svn path=/trunk/; revision=23665
 2007-11-29 06:28:07 +00:00
Bill Meier
b69928928f From Didier Gautheron: Fix for Bug #1862: JPEG (JFIF) packet always malformed 
svn path=/trunk/; revision=23662
 2007-11-29 00:01:09 +00:00
Anders Broman
5935bf73a4 Didier Gautheron: 
icmp dissector must call subdissectors even if tree is NULL

svn path=/trunk/; revision=23653
 2007-11-28 21:44:40 +00:00
Bill Meier
7f9585782d Fixes for Windows build w/o ZLIB 
svn path=/trunk/; revision=23651
 2007-11-28 20:06:21 +00:00
Jaap Keuter
fe11aff158 From Brian W. Antoine: 
The Packet decoder for CFM has a couple of small bugs.
1) The frame rate for CCM's is wrong for rate=4, it's shown as 1ms and it should be shown as 1s.
2) The flags display for a LTM packet has the wrong title for bit 7.  It should be UseFDBonly, not RDI.

svn path=/trunk/; revision=23649
 2007-11-28 18:59:37 +00:00
Gerald Combs
f07871ac79 Use guints instead of guint8s for counters. 
svn path=/trunk/; revision=23646
 2007-11-28 15:55:50 +00:00
Tomas Kukosa
ff7c20938e Various changes with focus to startup speedup 
The startup timeout on Win32 is reduced to 80% without assembler and to 50% with assembler usage (which is optional)
proto.c
 - do not look up in filed tree and inserts in two steps but do it at once
 - next few small speedups
 - some often called elementary functions can be optionally implemented in assembler
 - dispart some functions to see more exact result from profiling
packet-tpnc.c
 - do not reallocate memory for each filed

svn path=/trunk/; revision=23643
 2007-11-28 10:18:16 +00:00
Stig Bjørlykke
60686647d2 Fixed a possible infinite loop. 
svn path=/trunk/; revision=23642
 2007-11-28 09:30:10 +00:00
Ronnie Sahlberg
c79cf40b3b update to most recent wkssvc.idl from the samba4 repository 
svn path=/trunk/; revision=23641
 2007-11-28 06:21:28 +00:00
Stig Bjørlykke
111cedfc75 - Added SEQ/ACK analysis for reports and notifications. 
- Identify ack type in COL_INFO.
- No analysis when in error packets.
- Some cleanup in hf_ names.

svn path=/trunk/; revision=23630
 2007-11-27 22:54:15 +00:00
Anders Broman
95d8c7e2da Apply yet another of the optimization patches: 
- Only call functions if they are needed or once.

svn path=/trunk/; revision=23628
 2007-11-27 21:24:39 +00:00
Anders Broman
eeab60b75f Apply yet another of the optimization patches: 
- Remove a spurious volatile.

svn path=/trunk/; revision=23627
 2007-11-27 21:23:45 +00:00
Gerald Combs
e679376996 From Sam Leffler: Add support for IEEE80211_RADIOTAP_XCHANNEL. 
svn path=/trunk/; revision=23625
 2007-11-27 20:03:43 +00:00
Gerald Combs
e8fd375630 Fixes from Sam Leffler: 
In capture_sync.c: Don't clobber the DLT value.

  In packet-cops.c (modified by me): Instead of adding an item as a static,
  mis-cast FT_UINT16 to the tree, add it as an FT_NONE.

  In packet-802.11.c: Add the right address to the tree.

svn path=/trunk/; revision=23624
 2007-11-27 19:57:35 +00:00
Guy Harris
9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda 
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
 2007-11-27 18:52:51 +00:00
Michael Tüxen
d00e6fe59e Fix from Stephen Fisher for bug 2028. 
svn path=/trunk/; revision=23621
 2007-11-27 17:46:55 +00:00
Jeff Morriss
7b5c60314c Don't attach to any TCP/UDP ports if we weren't able to load the database--and thus the hf_ entries (which are required for dissection). 
svn path=/trunk/; revision=23620
 2007-11-27 16:08:24 +00:00
Guy Harris
7a4eb3eb35 Check for AVPs with a list of values and a type that's not a 32-bit or 
shorter integral type.  Fixes bug 2027.

Rename the "bytes" pointer to "octetstring", and initialize it in a
fashion that makes it clearer that it points to the first of the basic
types, to make it clearer that it's for OctetString.

svn path=/trunk/; revision=23615
 2007-11-27 01:41:42 +00:00
Gerald Combs
7731b882f2 From Tuomas Maattanen: Fix a .11e QBSS IE endian error. 
svn path=/trunk/; revision=23614
 2007-11-27 01:02:03 +00:00
Gerald Combs
1064a1df35 Make sure we fully initialize a struct. Fixes bug 2021. 
svn path=/trunk/; revision=23613
 2007-11-27 00:36:41 +00:00
Jeff Morriss
1cd46ec7be Get rid of the global data structures populated by wiretap/mpeg-audio but 
used by the mpeg-audio dissector: instead keep the data inside the wiretap
module and add accessor functions.  I think this should fix
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677 and anyway it's
cleaner.

svn path=/trunk/; revision=23612
 2007-11-26 23:06:07 +00:00
Jeff Morriss
309f7503e5 Get rid of C++/C99 style comments--not all compilers support them 
svn path=/trunk/; revision=23608
 2007-11-26 18:55:17 +00:00
Stig Bjørlykke
86f278dda7 Use the offset and length for the interesting data. 
svn path=/trunk/; revision=23607
 2007-11-26 18:51:24 +00:00
Jeff Morriss
dd0a4750b0 s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows. 
svn path=/trunk/; revision=23605
 2007-11-26 18:35:37 +00:00
Jeff Morriss
c5ab162b37 gcc-4.1.1 thinks 'retval' might not get set inside the TRY(). Initialize it. 
svn path=/trunk/; revision=23603
 2007-11-26 17:28:12 +00:00
Stig Bjørlykke
a26ea5739a Use correct offset for subtree in dissect_spoolss_relstr. 
svn path=/trunk/; revision=23602
 2007-11-26 17:03:12 +00:00
Stig Bjørlykke
e5461f3307 From Kai Blin: 
Dissect the PRINTER_INFO structure in the SpoolssEnumPrinters call.

From me:
Add the level info to COL_INFO.

svn path=/trunk/; revision=23600
 2007-11-26 16:38:26 +00:00
Sebastien Tandel
d580971f07 Update error handling of UDP Light Illegal Checksum value 0 
* change expert group from PI_MALFORMED to PI_CHECKSUM (as it should be!!!).
  * set item hf_udp_checksum_[good|bad] as generated


svn path=/trunk/; revision=23599
 2007-11-26 14:42:38 +00:00
Sebastien Tandel
6c4f9f0479 iUpdate error handling of UDP Light Illegal Checksum value 0 
* Adding PI_MALFORMED expert field for this case.
  * Adding an error string in COL_INFO.


svn path=/trunk/; revision=23598
 2007-11-26 14:30:40 +00:00
Gerald Combs
3697704b62 Fix bug 2019: The SMB dissector was dereferencing a NULL pointer. 
svn path=/trunk/; revision=23593
 2007-11-25 23:08:09 +00:00
Stig Bjørlykke
4e9892cbfd Added checksum.good and checksum.bad items. 
svn path=/trunk/; revision=23590
 2007-11-25 21:30:57 +00:00
Stig Bjørlykke
a2b5cf9528 Added checksum.good and checksum.bad items. 
svn path=/trunk/; revision=23589
 2007-11-25 21:30:33 +00:00
Jaap Keuter
054ed14e67 Header field array and whitespace cleanup. 
svn path=/trunk/; revision=23588
 2007-11-25 19:20:32 +00:00
Sake Blok
9f829f4ba2 Bug 1997 From Timo Teras: 
Patch to do the following:
1) Dissect CIE Lists in NHRP Extensions
2) Dissect original NHRP packet in Error Indication
3) Support for Cisco NAT extensions
4) Support for Cisco NHRP Traffic Indication packet


svn path=/trunk/; revision=23587
 2007-11-25 18:10:01 +00:00
Graeme Lunt
a7dec11ce6 Changes suggested/provided by Anders so that fewer changes are required to the ASN modules. 
Also includes the MSAccessProtocol.asn to generate defines for the operation numbers.


svn path=/trunk/; revision=23586
 2007-11-25 17:46:42 +00:00
Jaap Keuter
f4054ad148 Based on suggestion from Stig Bjørlykke. Add CRC tree even when CRC is missing. 
svn path=/trunk/; revision=23584
 2007-11-25 15:36:38 +00:00
Stig Bjørlykke
6f1ab30f2f From Joe Eykholt: 
Show content even if the trailer is missing.

From me:
Add proto_tree_set_appendix for the checksum and EOF.

svn path=/trunk/; revision=23581
 2007-11-25 12:15:02 +00:00
Stig Bjørlykke
82041ad3b6 Set an initial value to make gcc 4.1.3 20070929 (prerelease) on Ubuntu happy. 
svn path=/trunk/; revision=23580
 2007-11-25 02:20:41 +00:00
Stig Bjørlykke
6341d80f07 From Graham Bloice: 
Show correct TCP segment data (and length) when multiple pdus.

svn path=/trunk/; revision=23572
 2007-11-24 23:04:49 +00:00
Stig Bjørlykke
0cb8d7e554 From Alex Burlyga: 
It looks like in dissect_nfs_open_claim_delegate_cur4() instead of dissection
stateid we are doing something wierd and dissecting uint64 instead(remnants of 
rfc3010 where stateid was 64 bit number?). We already have function for
dissecting stateids, so just a matter of making a different call. 

From me:
Also deleted the hf_nfs_stateid4_delegate_stateid entry.

svn path=/trunk/; revision=23571
 2007-11-24 22:45:57 +00:00
Stig Bjørlykke
6c090a68bf From J. Bruce Fields: 
Add basic support for NFSv4.1, as of about draft 13 of the current spec.
The protocol is not completely finished yet, and future patches will be
needed to bring it up to date.

From me:
- Add a check for valid pointers in nfsv4_operation_ett
- Always increase offset when calling dissect_nfs_devices4
- Added a default case in dissect_rpc_secparms4

svn path=/trunk/; revision=23570
 2007-11-24 22:09:01 +00:00
Gerald Combs
7d5b4af5d0 Make sure h225_pi is never NULL. 
svn path=/trunk/; revision=23568
 2007-11-24 19:13:54 +00:00
Jeff Morriss
330c9d0b4b Fix crash reported in http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2014 : when adding fragments to the linked list of end fragments, don't check the TSN of the begin fragment--it may not be there. Looks like a cut-n-pasteo. 
svn path=/trunk/; revision=23567
 2007-11-24 17:56:46 +00:00
Anders Broman
0d92db6781 Export classes from ROS - hopfully without breaking stuff. 
svn path=/trunk/; revision=23566
 2007-11-24 17:39:31 +00:00
Jeff Morriss
29cb0d329b Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2011 : check SSN in both Called and Calling addresses even when we know the direction of the messages 
svn path=/trunk/; revision=23564
 2007-11-24 15:43:39 +00:00
Jeff Morriss
8058db81b9 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2006 : use 0xffffff (reserved value) for unset xLRs 
svn path=/trunk/; revision=23563
 2007-11-24 15:38:19 +00:00
Gerald Combs
118f23a08a Catch a bad bLength, which may cause a loop. Fixes bug 2012. 
svn path=/trunk/; revision=23557
 2007-11-23 23:31:21 +00:00
Gerald Combs
4510d63626 Fix bug 2007 (a loop in IPv6). 
svn path=/trunk/; revision=23555
 2007-11-23 20:15:28 +00:00
Guy Harris
38ab1b8e7a Set the usual properties on packet-wps.[ch]. 
svn path=/trunk/; revision=23553
 2007-11-23 18:48:49 +00:00
Stig Bjørlykke
2ad24805fe No $Id:$ in new files? 
svn path=/trunk/; revision=23551
 2007-11-23 18:29:00 +00:00
Guy Harris
5586f6764a Include packet-wps.h, so it's part of the source tarball. 
svn path=/trunk/; revision=23550
 2007-11-23 18:25:39 +00:00
Stig Bjørlykke
d6f0b0c2af From Jens Braeuer: 
Added support for Wifi Simple Config aka Wifi Protected Setup

From me:
Added standard copyright header to packet-wps

svn path=/trunk/; revision=23549
 2007-11-23 17:48:28 +00:00
Stig Bjørlykke
5e1ffde520 Moved check for empty choice to make it work correctly. 
svn path=/trunk/; revision=23548
 2007-11-23 12:22:22 +00:00
Stephen Fisher
3b46983e9f Make previously removed ethertype preference obsolete. For inclusion in 
0.99.7 release.


svn path=/trunk/; revision=23545
 2007-11-22 19:02:31 +00:00
Stig Bjørlykke
92682d51de Added handling of octet-aligned data according to direct_reference. 
Implemented handling of ber_callback for tagged type octet-aligned
and arbitrary.  Renamed some functions.

svn path=/trunk/; revision=23539
 2007-11-21 23:33:13 +00:00
Sake Blok
ceaeb1f977 Bug 1994: From Keith Mercer : 
This bugfix is focused only in the Sender ID TLV segment of code.  This was to
address the possibility that the Sender ID TLV may not have a Management
Address Domain, and/or a Management Address.  This bug was discovered when
testing the dissector using CFM-enabled Netopia modems.


svn path=/trunk/; revision=23534
 2007-11-21 20:33:50 +00:00
Gerald Combs
f3fdef83d6 Don't try to overwrite read-only memory. Fixes bug 2001. 
svn path=/trunk/; revision=23529
 2007-11-21 17:00:24 +00:00
Tomas Kukosa
7c48c9ab80 more SSL debug info concerning conversation and ssl_session 
svn path=/trunk/; revision=23528
 2007-11-21 14:10:55 +00:00
Michael Tüxen
928bebeb01 Update to draft-ietf-rserpool-common-param-15.txt. (Will 
be published soon...)

svn path=/trunk/; revision=23520
 2007-11-20 21:21:56 +00:00
Gerald Combs
13a01fef37 Add a bounds check in order to try to fix bug #1998. 
svn path=/trunk/; revision=23517
 2007-11-20 19:17:19 +00:00
Jeff Morriss
be81aa150e Reindent some to improve readability 
svn path=/trunk/; revision=23510
 2007-11-20 16:51:14 +00:00
Tomas Kukosa
7eb5048da9 fix tag handling inside snmp trap 
svn path=/trunk/; revision=23508
 2007-11-20 13:55:39 +00:00
Stephen Fisher
1ab4398a47 Introduce use of the new FT_EBCDIC field type as a second display of 
text fields (data & sqlstatement).  Also fix the options on the FT_STRINGZ
items - change them to FT_STRING and change BASE_DEC to BASE_NONE.


svn path=/trunk/; revision=23505
 2007-11-19 21:28:17 +00:00
Jeff Morriss
53faa469bd Detect reneged acks or at least retransmissions after an ack was seen. Mark 
them with an expert info (PI_WARN).

Change "Duplicate TSN" expert info to "Retransmitted TSN" and make it PI_NOTE
instead of PI_WARN.

Change "More than 100 TSNs gap-acked" expert info to PI_WARN (from PI_NOTE).

Frame numbers (and count of retransmissions) are unsigned, display them that way.

svn path=/trunk/; revision=23502
 2007-11-19 20:34:57 +00:00
Stig Bjørlykke
8fc83d2cf3 Improved "BER Error" messages to be more uniform. 
svn path=/trunk/; revision=23501
 2007-11-19 20:23:49 +00:00
Martin Mathieson
38d450159f Only show direction field when its set to a valid value. 
svn path=/trunk/; revision=23498
 2007-11-19 19:04:19 +00:00
Stig Bjørlykke
9233fa7578 Second try to not stop processing if length==0 in choice. 
svn path=/trunk/; revision=23497
 2007-11-19 17:46:11 +00:00
Gerald Combs
cec11effb5 Fix an infinite loop, and be more paranoid about looping in general. 
svn path=/trunk/; revision=23496
 2007-11-19 17:33:59 +00:00
Stig Bjørlykke
cf5aa9d616 Added port range. 
Added a dissector assert on inconsistent data.
Do not align retransmission or duplicate acknowledgement data in COL_INFO.
Removed several _U_ for used variables.
Re-indented some if-blocks.

svn path=/trunk/; revision=23492
 2007-11-19 07:31:56 +00:00
Stig Bjørlykke
c787b310eb Added port range. 
svn path=/trunk/; revision=23491
 2007-11-19 07:26:53 +00:00
Stig Bjørlykke
f5b14b2f89 Initialize credentials. 
svn path=/trunk/; revision=23490
 2007-11-19 07:26:10 +00:00
Stig Bjørlykke
77e69e06e1 Reverted r23485 and r23486, this was not a correct fix. 
svn path=/trunk/; revision=23489
 2007-11-19 07:25:06 +00:00
Stig Bjørlykke
c3d985077e And dump internal ber fields for empty choice field. 
svn path=/trunk/; revision=23486
 2007-11-18 16:40:20 +00:00
Stig Bjørlykke
ddc4d639ba As proposed by Martin Peylo: 
Do not stop processing if the length of a choice has the (illegal)
value of zero.

svn path=/trunk/; revision=23485
 2007-11-18 16:20:51 +00:00
Ulf Lamping
7e98b70b3f fix bug 1459: make the filter string "ip.version == 6" possible, by adding a "pseudo" field 
svn path=/trunk/; revision=23483
 2007-11-18 08:16:49 +00:00
Martin Mathieson
970854aa6d Add ppp.direction field. 
svn path=/trunk/; revision=23481
 2007-11-17 22:08:27 +00:00
Graeme Lunt
cbba688f44 Comment out dissect_ascii_tpkt to keep the buildbot happy. 
svn path=/trunk/; revision=23480
 2007-11-17 18:22:49 +00:00
Graeme Lunt
0c571bb235 Basic P7 (X.400 Message Store Access Protocol) dissection after request from the list: 
http://www.wireshark.org/lists/wireshark-dev/200711/msg00228.html

Only a single (private) capture file is currently available which contains only a few of the P7 operations, so testing has been minimal.
General attribute types, containing information from the X.400 envelope, are also included.


svn path=/trunk/; revision=23479
 2007-11-17 18:08:01 +00:00
Anders Broman
d2545978d8 The asciitpkt checkin broke the TPKT dissector comment out create_dissector_handle() and 
dissector_add() for now.

svn path=/trunk/; revision=23478
 2007-11-17 09:17:06 +00:00
Gerald Combs
c2d537141a Fix a buffer overflow in the PPP dissector. Try to fix uninitialized 
variable warnings turned up by Valgrind.

svn path=/trunk/; revision=23475
 2007-11-16 23:56:18 +00:00
Martin Mathieson
24d6a39eb0 Embedding EAP inside wimaxasncp. 
svn path=/trunk/; revision=23474
 2007-11-16 23:03:09 +00:00
Jeff Morriss
3fa633d626 When reassembly is off, catch ReportedBoundsError when calling a subdissector 
on the first fragment of a fragmented message.  This allows us to continue
dissecting chunks even if one of the first chunks in the frame was fragmented.
(It's useful to keep doing this partial dissection just so we have some idea
what's in that chunk.)

(One could rightfully argue that you should only see a fragmented chunk
bundled with another chunk when retransmitting but, well, I'm staring at
traces of an implementation--to remain nameless to protect the guilty--which
is sometimes fragmenting and then bundling the fragments into one packet.)

svn path=/trunk/; revision=23471
 2007-11-16 22:04:27 +00:00
Jeff Morriss
03b581e921 When reassembly is turned off don't pass non-first fragments to subdissectors: they will have no idea what they're getting and will exception out anyway. 
svn path=/trunk/; revision=23469
 2007-11-16 19:32:59 +00:00
Anders Broman
c002250952 From Harmeet Sawhney: 
Parse MGCP over TCP with ASCII TPKT header
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1964

svn path=/trunk/; revision=23466
 2007-11-16 08:18:30 +00:00
Mike Duigou
07166afb69 From Yaniv Kaul : 
Adds application/rss+xml mime type as a recognized XML type. It is used by some RSS servers.


svn path=/trunk/; revision=23465
 2007-11-15 23:59:54 +00:00
Gerald Combs
09360857b8 Don't try to reassemble a huge number of fragments. 
svn path=/trunk/; revision=23463
 2007-11-15 19:38:04 +00:00
Martin Mathieson
fe11ad092b Add a generated lapd.direction field/filter. 
svn path=/trunk/; revision=23462
 2007-11-15 18:37:50 +00:00
Ronnie Sahlberg
d572ee6403 new t125 dissector 
svn path=/trunk/; revision=23461
 2007-11-15 10:39:16 +00:00
Ronnie Sahlberg
ab871e3551 new ldap dissector 
svn path=/trunk/; revision=23459
 2007-11-15 10:32:45 +00:00
Ronnie Sahlberg
c033ee2fc7 new x411 dissector 
svn path=/trunk/; revision=23457
 2007-11-15 10:11:09 +00:00
Ronnie Sahlberg
5770b859b6 updated snmp dissector 
svn path=/trunk/; revision=23455
 2007-11-15 09:50:36 +00:00
Ronnie Sahlberg
27306b29c7 updated mms dissector 
svn path=/trunk/; revision=23453
 2007-11-15 09:42:21 +00:00
Graeme Lunt
4a285928bb Changed to use the the packet-ber EXTERNAL decoding (into the ASN1 context). 
Uses the ber_callback mechanism to call the rtse oid callbacks, rather than the default ber oid callback list.
A couple of fixes to packet-ber.c to mark [in]direct references as present and call the ber_callback if it has been specified.


svn path=/trunk/; revision=23450
 2007-11-14 20:57:55 +00:00
Gerald Combs
7bed7953f6 Keep the MEGACO dissector from looping on a malformed events descriptor. 
svn path=/trunk/; revision=23449
 2007-11-14 19:28:29 +00:00
Anders Broman
76ebf7f248 From Dejan Bucar: 
Updated dissector for LINX protocols

* Linx Ethernet Connection Manager protocol is updated from version 2 to
version 3.
* Linx RLNH protocol has been updated from version 1 to version 2.

The updated dissector is backwards-compatible allowing correct dissection of
all versions.

svn path=/trunk/; revision=23444
 2007-11-13 22:05:43 +00:00
Anders Broman
524db0a082 From Florent DROUIN: 
Since the use of the function 'dissect_ber_tagged_type' for DialoguePortion,
the file tcap.cnf must be updated to remove the decoding of the tag and length.
This decoding is now done in the new function 'dissect_ber_tagged_type'.

The file tcap.cnf has been updated to take into account this change. 
But this leads to a change in tcap.asn too, for the definition of the
ExternalPDU.
I think this part of the ASN1 file is specific to Wireshark and can be
modified.

In the meantime, I did update the DEBUG part for packet_ber.c  for the function
(dissect_ber_tagged_type)

svn path=/trunk/; revision=23442
 2007-11-13 21:59:53 +00:00
Stig Bjørlykke
923630d743 Mark some generated items in ROS. 
svn path=/trunk/; revision=23441
 2007-11-13 10:26:30 +00:00
Gerald Combs
b8c7fa9bc6 Don't dereference a NULL pointer. 
svn path=/trunk/; revision=23438
 2007-11-12 20:02:24 +00:00
Gerald Combs
7d8064f548 Initialize var_list in dissect_smux(), so that we don't use previously 
ep_freed() memory and abort.

svn path=/trunk/; revision=23436
 2007-11-12 18:44:29 +00:00
Gerald Combs
5434b707e8 Replace strcpy()+strcat() with g_snprintf(). Make sure a string isn't 
NULL before we try to use it.  This fixes a crash found during fuzzing
and a possible buffer overrun.

svn path=/trunk/; revision=23435
 2007-11-12 17:02:46 +00:00
Anders Broman
45989dae89 Remove forgotten debug code. 
svn path=/trunk/; revision=23430
 2007-11-12 07:03:09 +00:00
Anders Broman
405be3098f From Valery Sigalov: 
New dissector for TPNCP protocol.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1853

svn path=/trunk/; revision=23428
 2007-11-11 13:23:17 +00:00
Anders Broman
c6b3bc723f Apply yet another set of the optimization patches: 
move TRY block in its own function.
 __attribute__((noinline)) does not compile with MS VC 6
nor does __declspec(noinline)
Applied the patch without it.

svn path=/trunk/; revision=23424
 2007-11-10 17:06:49 +00:00
Gerald Combs
8e45bbf506 Don't call tvb_set_child_real_data_tvbuff() + add_new_data_source() twice 
for the same tvb.  This keeps us from freeing the same memory twice and
crashing on some systems.

This might be the same bug Brian Vandenberg was looking for in
http://www.wireshark.org/lists/wireshark-dev/200705/msg00406.html .

svn path=/trunk/; revision=23415
 2007-11-09 20:04:40 +00:00
Anders Broman
6226035893 Apply yet another set of the optimization patches: 
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().

On the other hand 
	if (tvb_bytes_exist(tvb, 0, 20)
is more readable than
	if (tvb_length(tvb) >= 20

so only do it in heuristic function

svn path=/trunk/; revision=23412
 2007-11-09 06:01:18 +00:00
Anders Broman
29cf34d1c2 Apply yet another set of the optimization patches: 
janitor work, replace col_add_fstr/ col_set_fstr.

svn path=/trunk/; revision=23411
 2007-11-09 05:57:45 +00:00
Anders Broman
9da07f5246 Apply yet another set of the optimization patches: 
Only call get_hostname once.

svn path=/trunk/; revision=23410
 2007-11-09 05:56:42 +00:00
Anders Broman
9d316093f6 Apply yet another set of the optimization patches: 
-set_str2add_str_val_to_str

svn path=/trunk/; revision=23406
 2007-11-08 22:49:03 +00:00
Anders Broman
90753a169e Apply yet another set of the optimization patches: 
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().
non heuristic dissectors

svn path=/trunk/; revision=23405
 2007-11-08 22:40:20 +00:00
Anders Broman
94859ac29b Apply yet another set of the optimization patches: 
if tree is not NULL then proto_xxx_add_yyy functions can't return NULL.
Remove always true tests.

svn path=/trunk/; revision=23404
 2007-11-08 22:39:01 +00:00
Anders Broman
4d07f32a41 Apply yet another set of the optimization patches: 
- Move proto_tree_add_xxxx calls inside 'if (tree) {}' block

svn path=/trunk/; revision=23403
 2007-11-08 22:38:06 +00:00
Anders Broman
7b3debb40d Change dissecton of address type for AVP < 256 (RADIUS address). 
svn path=/trunk/; revision=23402
 2007-11-08 22:36:19 +00:00
Gerald Combs
4105173f0e Fix a couple of integer underflows. 
svn path=/trunk/; revision=23398
 2007-11-08 05:54:29 +00:00
Gerald Combs
544ca516b5 Add more TCP analysis struct checks. 
svn path=/trunk/; revision=23396
 2007-11-08 00:58:38 +00:00
Anders Broman
079e1446f9 Update to use the -X and -T asn2wrs flags. 
svn path=/trunk/; revision=23394
 2007-11-07 21:22:25 +00:00
Stig Bjørlykke
2e98c04584 Create a subset tvb for dissect_x411_ORName so it doesn't eat too much data. 
Removed some unnecessary int casts.

svn path=/trunk/; revision=23392
 2007-11-07 20:03:29 +00:00
Jörg Mayer
e47e42e10e Add VID VID_draft_ietf_ipsec_nat_t_ike_01, move 
VID_draft_ietf_ipsec_nat_t_ike_03 a bit down.

svn path=/trunk/; revision=23391
 2007-11-07 18:35:00 +00:00
Anders Broman
ce2a32dc6f Update to use the -X and -T asn2wrs flags. 
svn path=/trunk/; revision=23390
 2007-11-07 17:55:57 +00:00
Anders Broman
c822748454 Delete obsolete dissectors. 
svn path=/trunk/; revision=23389
 2007-11-07 17:55:06 +00:00
Jörg Mayer
9491dc16f1 Print VendorID string in payload summary line 
svn path=/trunk/; revision=23388
 2007-11-07 17:23:28 +00:00
Anders Broman
fb00aa074f as2wrs now handles EXTERNAL(direct-reference requires no special handling). 
svn path=/trunk/; revision=23386
 2007-11-06 21:52:26 +00:00
Anders Broman
e0937a5992 as2wrs now handles EXTERNAL(direct-reference requires no special handling). 
svn path=/trunk/; revision=23384
 2007-11-06 20:26:13 +00:00
Anders Broman
998eabe31f as2wrs now handles EXTERNAL(direct-reference requires no special handling). 
svn path=/trunk/; revision=23383
 2007-11-06 20:21:09 +00:00
Anders Broman
2555a2f6fb as2wrs now handles EXTERNAL(direct-reference requires no special handling). 
svn path=/trunk/; revision=23382
 2007-11-06 20:16:59 +00:00
Anders Broman
d3028865d3 From Keith Mercer: 
CFM dissector bugfixes and code update for ITU inclusion

svn path=/trunk/; revision=23380
 2007-11-06 19:47:38 +00:00
Anders Broman
a1347fde05 Set up RTP conversation when PORT is known. 
svn path=/trunk/; revision=23377
 2007-11-06 18:11:20 +00:00
Ronnie Sahlberg
8da1f94cca use strcasecmp instead of g_ascii_strcasecmp 
svn path=/trunk/; revision=23372
 2007-11-06 05:39:28 +00:00
Stephen Fisher
6785ffd796 Wake on LAN (WOL): New dissector from Chris Maynard via -dev list and 
enhancement bug #1968

Me: Added entries in epan/etypes.h and epan/dissectors/packet-ethertype.c
for WOL.


svn path=/trunk/; revision=23371
 2007-11-06 05:30:04 +00:00
Stephen Fisher
46e6e9ea0f Change instance of 0xCAFE to ETHERTYPE_LLT for consistency. No functional 
changes.


svn path=/trunk/; revision=23370
 2007-11-06 05:06:31 +00:00
Sake Blok
3c9a7b9dcd Bug 1954 From Mikael Magnusson : 
This patch updates the DTLS dissector to be compatible with OpenSSL 0.9.8f in
the following ways:
* Handle both SSL version number 0xfeff (RFC 4347 and OpenSSL 0.9.8f), and
0x100 (Used by OpenSSL 0.9.8e and earlier)
* Reassemble fragmented handshake messages.





svn path=/trunk/; revision=23369
 2007-11-05 23:05:20 +00:00
Anders Broman
3b1f0881e2 Update to use the -X and -T asn2wrs flags. 
svn path=/trunk/; revision=23366
 2007-11-05 20:41:44 +00:00
Anders Broman
8676c5cd9f Update do use the -X and -T asn2wrs flags. 
svn path=/trunk/; revision=23365
 2007-11-04 22:18:59 +00:00
Anders Broman
f6ba48b9fc Update do use the -X and -T asn2wrs flags. 
svn path=/trunk/; revision=23364
 2007-11-04 22:16:28 +00:00
Anders Broman
4184ef8b8d Update do use the -X and -T asn2wrs flags. 
svn path=/trunk/; revision=23363
 2007-11-04 22:14:35 +00:00