Commit graph

6050 commits

Author SHA1 Message Date
Jaap Keuter
7e262d1ccb From Francis Dupont:
DHCPv6 dissector is pretty old, i.e., it needs some updates (provided in the patch).
For instance, RFC 5007 (leasequery) is not taken into account.

svn path=/trunk/; revision=23950
2007-12-27 10:38:03 +00:00
Sake Blok
9ad27ce239 Fix for bug 1586: When proxying a tcp connection (mostly used with ssl over an
http proxy), let the proxied protocol take care of reassembly itself.


svn path=/trunk/; revision=23949
2007-12-26 18:28:31 +00:00
Jaap Keuter
05b530033e Defining INTERFACE causes a clash with Win32 defines. Moving to ATTR_*
svn path=/trunk/; revision=23946
2007-12-24 16:27:27 +00:00
Jaap Keuter
c84621caba From Abhik Sarkar:
In packet-gsm_sms.c, in function dis_field_ud_iei, it is assumed that the UDHL
must be greater than 2 (because it is expected that IEIa and IEIDLa will be 
one byte each and the rest will be IEIDa). 
However, there are some cases in which UDHL can be 2. For example, in 3GPP 23.048.

svn path=/trunk/; revision=23945
2007-12-24 11:16:06 +00:00
Jaap Keuter
93ef681227 From Andreas St:
In our communication systems, we make use of the RTP header extension to encode
signalling information in the form of a bit mask. To improve our debugging, we
extended the default RTP dissector to call back any subdissector registering
for a particular RTP payload type string. This allows to render the value of
the header extension in a different, more flexible way compared to the default
numeric representation, such as in form of a subtree.

svn path=/trunk/; revision=23943
2007-12-23 20:10:57 +00:00
Stephen Fisher
6b15e7971f Fix warning/error on Windows buildbot with conversion from unsigned short to
unsigned char at line 1958.


svn path=/trunk/; revision=23942
2007-12-23 19:32:08 +00:00
Jaap Keuter
68e1ecc758 From Silvia Cristina Tejedor:
New dissector for the protocol PCE

svn path=/trunk/; revision=23941
2007-12-23 14:19:48 +00:00
Jaap Keuter
f37c29c2f5 Use proto functions i.s.o. manipulating node data directly.
svn path=/trunk/; revision=23940
2007-12-23 14:18:27 +00:00
Michael Tüxen
dc167cef52 Add handling of "Rejected due to security considerations" error cause.
Reported by Holger Epper.

svn path=/trunk/; revision=23939
2007-12-22 20:30:23 +00:00
Stig Bjørlykke
382bedb6ca Added type=value to BuiltInDomainDefinedAttributes items.
svn path=/trunk/; revision=23933
2007-12-21 13:23:52 +00:00
Michael Tüxen
ec06660011 Fix the handling of error parameters. Reported by Holger Eppert.
svn path=/trunk/; revision=23932
2007-12-21 11:06:21 +00:00
Jaap Keuter
7a76c45b04 From Abhik Sarkar:
This patch adds initial support for statistics to the SMPP dissector using the Stats Tree API.

svn path=/trunk/; revision=23931
2007-12-21 08:16:47 +00:00
Gerald Combs
7a3bc302d9 Fix some casts.
svn path=/trunk/; revision=23930
2007-12-20 17:34:39 +00:00
Stig Bjørlykke
1dbf329466 Added Precedence and Importance to COL_INFO.
svn path=/trunk/; revision=23929
2007-12-20 14:18:38 +00:00
Stig Bjørlykke
1c68fd7a75 Added total retransmission time analysis field.
svn path=/trunk/; revision=23924
2007-12-19 11:25:47 +00:00
Martin Mathieson
2346d8280c Report duplicate IP addresses based on observed ARP requests & responses.
Turned on by default (otherwise no-one will find it).

svn path=/trunk/; revision=23923
2007-12-19 10:49:22 +00:00
Stig Bjørlykke
6f9241bca7 - Added first version of P_Mul sequence analysis.
- Added expert info for Discard_Message_PDU.

svn path=/trunk/; revision=23922
2007-12-19 10:05:42 +00:00
Stig Bjørlykke
88216b4940 Added total retransmission time analysis field.
svn path=/trunk/; revision=23920
2007-12-19 09:38:03 +00:00
Jaap Keuter
0eb257e087 No extended characters here please.
svn path=/trunk/; revision=23918
2007-12-18 22:43:29 +00:00
Jaap Keuter
38f3dff73b From Alex Burlyga:
When parsing nfsv4 GETATTR reply in attribute fs_location wireshark displays incorrect content for the attribute value. It looks like instead of parsing as rpc arrays, value gets parsed as 
rpc linked list. This patch which fixes the problem
I also noticed that FATTR4_MOUNTED_ON_FILEID attribute is not getting parsed, so I added parsing for that as well.

svn path=/trunk/; revision=23917
2007-12-18 22:41:25 +00:00
Tomas Kukosa
48eb58a0d4 do not align before enumerated extension
svn path=/trunk/; revision=23916
2007-12-18 10:15:31 +00:00
Tomas Kukosa
2dbe8bb2ac fix bug 2112
svn path=/trunk/; revision=23915
2007-12-18 09:51:49 +00:00
Guy Harris
255f856ec1 It appears that some fields in the Prism header might have a DID value
of 0, and that appears to mean that they're not present.  Check for
that, as well as the status.

svn path=/trunk/; revision=23914
2007-12-18 09:31:54 +00:00
Guy Harris
d51919864f Put radio information from a pseudo-header into its own protocol tree
item, as is done for radio information in a Prism, AVS, or radiotap
header.

svn path=/trunk/; revision=23913
2007-12-18 09:22:17 +00:00
Guy Harris
2def545803 Interpret the signal and noise values in an AVS header appropriately, as
per the signal type (and as per a noise value of 0xffffffff meaning no
noise value was provided).

svn path=/trunk/; revision=23912
2007-12-18 08:57:17 +00:00
Guy Harris
9198a2a166 Fold the Prism and AVS header dissectors into packet-ieee80211.c, and
have them use least some of the radio-information fields, so that the
same field name can be used for multiple radio header types.  The AVS
header can supply the data rate in bits/second, so have that field be in
those units, and make it 64 bits to leave room for the future, Just In
Case.  Display it as Mb/s, however.

svn path=/trunk/; revision=23911
2007-12-18 08:01:11 +00:00
Jörg Mayer
c2390c4ef7 Bugfix: Array overflow (found by gcc43)
svn path=/trunk/; revision=23907
2007-12-18 00:44:49 +00:00
Sake Blok
1d52172cd4 Bug 2116 - From Lawrence Reisler :
During a regular Wireshark trace of UCP packets running over ethernet, I noted
that Wireshark said the login packet was malformed, even though it looked OK
and the server responded correctly.  After looking at the UCP protocol, it
became clear that Wireshark was parsing a type 60 message which only has one
Reserverd field (RES1) and expecting it to have two Reserved fields (RES1 and
RES2) like a type 61 message.  This is because it is using the same function to
parse both messages, and does not have a conditional for the type 60 field.



svn path=/trunk/; revision=23903
2007-12-17 23:11:04 +00:00
Stephen Fisher
d00059d2bc From metatech:
New dissector for RTMP(T) protocol

via bug #2078


svn path=/trunk/; revision=23902
2007-12-17 20:43:38 +00:00
Jeff Morriss
407007d14a From Kaul: s/SERIAL_NUMBER_LENGTH/SCTP_SERIAL_NUMBER_LENGTH to fix a duplicate definition on Windows (not sure why Kaul is seeing that but oh well).
svn path=/trunk/; revision=23899
2007-12-17 19:25:16 +00:00
Tomas Kukosa
b433163b3f - use structure instead of many global variables for channel setup
- move channel setup code to one function
- support RFC2198 dynamic payload type setup

svn path=/trunk/; revision=23898
2007-12-17 12:16:38 +00:00
Guy Harris
80039e2976 For captures on a Linux GRE interface, put a field into the protocol
tree with the GRE protocol type value.

svn path=/trunk/; revision=23894
2007-12-16 22:46:42 +00:00
Stig Bjørlykke
e29ba5decf From Timo Teras:
The attached patch checks sll_hatype field type and if suggest capture on GRE
interface, the packet will be dissected using GRE dissector table. Also prints
physical addresses with length 4 as IPv4 addresses.

This fixes bug 2105.

svn path=/trunk/; revision=23892
2007-12-16 21:04:08 +00:00
Stig Bjørlykke
67261c278c Comment out unused code.
svn path=/trunk/; revision=23891
2007-12-16 20:27:55 +00:00
Anders Broman
8b342ea896 Update comments.
svn path=/trunk/; revision=23889
2007-12-16 17:43:10 +00:00
Anders Broman
e39e24d262 Add a few more bits.
svn path=/trunk/; revision=23888
2007-12-16 17:42:35 +00:00
Stig Bjørlykke
fa34d46851 From Fulko Hew:
1/ patches to support the libpcap/SITA format 'WTAP_ENCAP_SITA'.
2/ patches to the LAPB dissector to accept MLP (Multi-link protocol)
   (although MLP dissection has _not_ been added (yet)).
3/ New protocol dissectors for:
   a) SITA's WAN layer 0 status header,
   b) An airline protocol ALC,
   c) An airline (and other industry) protocol UTS.

These patches are submitted as a set since the new protocol dissectors are not
useful without the libpcap/SITA related changes, and there is no point in
having those changes without the additional dissectors.

This fixes bug/enhancement 2016.

svn path=/trunk/; revision=23885
2007-12-16 14:21:37 +00:00
Sake Blok
4f05930abe Big 2104 - From Benn Bollay:
This patch adds a heuristic dissector to the ethernet trailer under the
keystring "eth.trailer".  This allows for other protocol plugins which coopt
the ethernet trailer for their own devices to register for trailer traffic
without requiring any further changes to the executable.


svn path=/trunk/; revision=23880
2007-12-16 00:35:34 +00:00
Sake Blok
8f7d4aff96 Fixes the "follow tcp stream" output when there are frames missing in the
capture file that were actually on the wire. The reassembly code waited for 
the gaps to be filled in by retransmissions, which would never come.

With this fix all acknowledged data will be output with "[xxx bytes missing in 
capture file]" inserted in every gap.


svn path=/trunk/; revision=23878
2007-12-15 23:25:05 +00:00
Guy Harris
4b2ce71547 Get rid of another non-ASCII character.
svn path=/trunk/; revision=23877
2007-12-15 19:36:25 +00:00
Martin Mathieson
b54b6b4af0 Fix preference text (SDP isn't only carried over SIP).
svn path=/trunk/; revision=23876
2007-12-15 18:26:21 +00:00
Graeme Lunt
9c6ac3835f Revised DAP dissector using latest asn2wrs features (requiring fewer changes the ASN.1 module) and table-driven operations.
svn path=/trunk/; revision=23875
2007-12-15 15:21:25 +00:00
Anders Broman
16341e7365 - Add col info.
- Small bugfix (duplicated tree info).
- Dissect first few bits for more NAL units

svn path=/trunk/; revision=23870
2007-12-15 13:06:35 +00:00
Stig Bjørlykke
a6b218a489 Fixed comments.
svn path=/trunk/; revision=23869
2007-12-14 23:40:42 +00:00
Anders Broman
0d6f59f859 Some more dissection added.
svn path=/trunk/; revision=23868
2007-12-14 21:27:18 +00:00
Jaap Keuter
574dfb7f8c From Zbigniew Kopek:
Here are additional DHCP Suboptions for Option 43 introduced in new eDOCSIS
Cable Laboratories documentation:
( http://www.cablemodem.com/downloads/specs/CM-SP-eDOCSIS-I13-070803.pdf )
Also display suboptions for Option 43 for OpenCable devices.

svn path=/trunk/; revision=23867
2007-12-14 20:14:15 +00:00
Gerald Combs
4bf02de80a Wlancap enhancements and fixes from Solomon Peachy.
svn path=/trunk/; revision=23865
2007-12-14 19:10:01 +00:00
Jörg Mayer
0c797861ba Warning fixes: function declaration isn’t a prototype
svn path=/trunk/; revision=23862
2007-12-14 15:14:40 +00:00
Jörg Mayer
6869154121 If we implement new style dissectors, register them as such.
svn path=/trunk/; revision=23861
2007-12-14 14:58:28 +00:00
Stephen Fisher
5b1372aeff Fix compilation on Unix (unused variable passed to function)
svn path=/trunk/; revision=23859
2007-12-13 22:47:42 +00:00
Anders Broman
38f23ab4e6 Finish dissection of
- NAL unit - Sequence parameter set
- NAL unit - Picture parameter set
for the trace I have and also dissect those NAL units in the RTP stream.
For "elements coded as ue(v), me(v), or se(v) are Exp-Golomb-coded" only ue(v) is implemented.

svn path=/trunk/; revision=23858
2007-12-13 21:20:52 +00:00
Jörg Mayer
7303115b86 Replace // comments
svn path=/trunk/; revision=23856
2007-12-13 11:37:03 +00:00
Jörg Mayer
3c397a3459 Add airopeek dissector
svn path=/trunk/; revision=23855
2007-12-13 11:33:53 +00:00
Jörg Mayer
160d7b71af Update a comment about some flags
svn path=/trunk/; revision=23853
2007-12-12 23:59:31 +00:00
Jörg Mayer
68a28c4a97 The extra bytes seem to go away if I call wlan_datapad instead
of wlan.

svn path=/trunk/; revision=23852
2007-12-12 23:26:39 +00:00
Jörg Mayer
a1af5ede6f Beginnings of airopeek remote capture support.
The metainformation is not yet decoded, also, there
are problems with QoS frames (extra bytes).

svn path=/trunk/; revision=23851
2007-12-12 23:03:44 +00:00
Anders Broman
4d01fd05cb tvbuff.c - fix abug if reading last byte in tvb
Further H.264 decoding in SDP

svn path=/trunk/; revision=23847
2007-12-12 21:50:14 +00:00
Tomas Kukosa
a76ff82d70 - register RFC 2198 as RTP dynamic payload type "red"
- display dynamic payload type names inside RFC 2198

svn path=/trunk/; revision=23846
2007-12-12 10:51:09 +00:00
Tomas Kukosa
2ce05b41eb strings registered to dissector table have to be allocated permanently
svn path=/trunk/; revision=23838
2007-12-11 09:33:09 +00:00
Jaap Keuter
6016eab0bf From Jim Young:
Attached is a patch to packet-vlan.c to add "summary info" to the protocol tree.

svn path=/trunk/; revision=23837
2007-12-11 07:42:36 +00:00
Stephen Fisher
1479f03673 Make the EtherNet/IP (Industrial Protocol) I/O dissection a new type
of dissector that rejects packets it doesn't recognize (on udp port
2222).


svn path=/trunk/; revision=23836
2007-12-11 04:33:08 +00:00
Stig Bjørlykke
36c9b397d7 uint16_t -> guint16
uint32_t -> guint32

svn path=/trunk/; revision=23835
2007-12-10 22:22:15 +00:00
Stig Bjørlykke
5a1bb85a2c Mark some pinfo unused to make it compile.
svn path=/trunk/; revision=23833
2007-12-10 22:18:53 +00:00
Anders Broman
92e1ee3721 Decode more of H264 info in SDP.
svn path=/trunk/; revision=23832
2007-12-10 21:25:32 +00:00
Ronnie Sahlberg
9a3eeab4ee add some more names for Query/Set path info levels and add empty stubs
for these blobs


svn path=/trunk/; revision=23831
2007-12-10 21:16:17 +00:00
Jaap Keuter
1f272d5f5e From Masatake YAMATO:
This dissector supports version 3.0 of the dlm (Distributed Lock Manager) protocol.
Actual implementation for the protocol is in linux kernel. See files under linux/fs/dlm/.

svn path=/trunk/; revision=23828
2007-12-10 19:02:43 +00:00
Anders Broman
70aa312f01 Add OID:s related to H264.
svn path=/trunk/; revision=23827
2007-12-10 18:25:44 +00:00
Stig Bjørlykke
d450d9fe4e Added option to turn off SEQ/ACK analysis.
Moved some resend expert infos to correct entry.
Small fix in seq/ack analysis for report/notificacion.

svn path=/trunk/; revision=23825
2007-12-10 11:17:48 +00:00
Tomas Kukosa
1e794fc494 ANSI TCAP regenerated and tested with -T -X asn2wrs options
asn2wrs has -T (tagged types support) and -X (new BER sttructures) default behavior
remove all -T and -X usage

svn path=/trunk/; revision=23823
2007-12-10 08:35:41 +00:00
Gerald Combs
b7d8f269b2 Make sure we don't try to allocate a negative number.
svn path=/trunk/; revision=23820
2007-12-10 03:12:11 +00:00
Guy Harris
b2f28fb370 Get rid of non-ASCII character in a value_string table. (They might
upset MSVC++ if the wrong code page is selected, and there's no
guarantee that all forms of output of dissected packets are in any
particular character encoding.)

svn path=/trunk/; revision=23819
2007-12-09 21:10:25 +00:00
Anders Broman
e5f48395f1 Move the routines tvb_skip_wsp() to tvbuff.c
svn path=/trunk/; revision=23818
2007-12-09 17:41:16 +00:00
Jaap Keuter
006d1c446e From Márton Németh:
When an ISOCHRONOUS URB was captured the packet-usb.c does not handle it.
Case URB_ISOCHRONOUS was added at two different places to handle it also.

svn path=/trunk/; revision=23817
2007-12-09 10:59:09 +00:00
Jörg Mayer
1621df1080 Warning fix:
- No comma after last element in enum

Fix:
- Call new_dissector_register for new style dissector.

svn path=/trunk/; revision=23808
2007-12-08 17:45:02 +00:00
Stephen Fisher
f4fcd1b146 Fix TiVoConnect dissector, seemingly broken since rev 18415.
svn path=/trunk/; revision=23807
2007-12-08 09:15:23 +00:00
Gerald Combs
be6e31fa44 Register the "samr.nt_password" preference as obsolete.
svn path=/trunk/; revision=23794
2007-12-07 18:50:41 +00:00
Martin Mathieson
a73c7817f6 Fix build by creating dissect function that tcp_dissect_pdus(). My Windows build didn't miss the mismatched return type...
svn path=/trunk/; revision=23791
2007-12-07 13:26:15 +00:00
Martin Mathieson
f33ca55e00 Make stun2 over udp a new-style dissector, so that it can reject stun frames on the standard port they share (and let the heuristic dissector for stun run). Otherwise I needed to set UDP to try heuristic dissectors first or disable stun2 altogether...
svn path=/trunk/; revision=23789
2007-12-07 00:23:16 +00:00
Tomas Kukosa
1bef58264a fix field attributes handling for tagged types
regenerate involved dissectors

svn path=/trunk/; revision=23783
2007-12-06 11:23:35 +00:00
Guy Harris
a3d7a2c66f Squelch a warning about a variable getting clobbered by a longjmp.
svn path=/trunk/; revision=23780
2007-12-06 08:22:16 +00:00
Anders Broman
325b335505 fixe http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2064 GSM_MAP decodes SendRoutingInfov2 incorrectly
- Add TYPE_ATTR for RoutingInfo ( Fixes the choice problem).
- Dissect ExternalSignalInfo
- Use subtree for AddressStrings

svn path=/trunk/; revision=23776
2007-12-05 21:58:58 +00:00
Anders Broman
437bfb9910 Remove debug code.
svn path=/trunk/; revision=23775
2007-12-05 20:49:46 +00:00
Anders Broman
d639aace72 Insert asn1 code for SendRoutingInfov2 and update template
Partly fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2064 GSM_MAP decodes SendRoutingInfov2 incorrectly

svn path=/trunk/; revision=23774
2007-12-05 20:16:02 +00:00
Jeff Morriss
20a98a36f3 From Cliff Romash: TMR is not a mandatory parameter on an ANSI IAM but USI is.
svn path=/trunk/; revision=23773
2007-12-05 19:55:40 +00:00
Guy Harris
61eeae5de2 Clean up indentation.
Use G_GINT64_MODIFIER for gint64 and guint64 values.  Use "u", rather
than "d", for unsigned values.  Put whitespace in the proper place in
format strings.

svn path=/trunk/; revision=23762
2007-12-05 09:43:20 +00:00
Guy Harris
35fc0e7187 Make the "protocol" field big enough to hold the 3-character
null-terminated string that the format item used when scanning says it
is - i.e., 4 "char"s, including the null terminator.

(Thanks and a tip of the hat to "gcc (GCC) 3.3.5 (propolice)" on OpenBSD
4.2 for finding this.)

svn path=/trunk/; revision=23761
2007-12-05 09:31:05 +00:00
Ronnie Sahlberg
d55f6955d6 the GSS Checksum in secure onc-rpc contains the same blobs as GSS Tokens
does.

make wireshark decode these blobs


svn path=/trunk/; revision=23759
2007-12-05 08:37:51 +00:00
Mike Duigou
cb3f7e3f7d svn path=/trunk/; revision=23758 2007-12-05 04:20:21 +00:00
Greg Morris
6c87d3d49e Display textual explanation for printer and job values from RFC 2911.
svn path=/trunk/; revision=23752
2007-12-04 16:33:48 +00:00
Stig Bjørlykke
0f0c02bbae Duplicate packet # -> Retransmission #
svn path=/trunk/; revision=23751
2007-12-04 14:04:37 +00:00
Tomas Kukosa
08bbd29c71 Support for RPCAP features in GUI (from Boris Misenov, see Bug 1366)
- retrieving the list of remote PCAP interfaces
  - password authentication support
  - UDP data fransfer
  - packet sampling (available in WinPcap 4.x)
  etc.

fix problem if non-default rpcap port is used

svn path=/trunk/; revision=23750
2007-12-04 11:19:29 +00:00
Jaap Keuter
852d928901 Make mpeg2ts over UDP possible. Heuristic and Decode as.
svn path=/trunk/; revision=23743
2007-12-04 07:11:38 +00:00
Jaap Keuter
f4c89beb21 Remove superfluous buffer allocation.
svn path=/trunk/; revision=23742
2007-12-04 06:50:11 +00:00
Anders Broman
95d422156a Use common code for ASCII -> tvb.
svn path=/trunk/; revision=23741
2007-12-04 06:00:02 +00:00
Ronnie Sahlberg
ee6c98b8b2 update to new signature for string keyed trees
svn path=/trunk/; revision=23737
2007-12-04 03:27:27 +00:00
Anders Broman
b414c81f1f Fetch all fmtp parameters.
svn path=/trunk/; revision=23724
2007-12-03 22:40:04 +00:00
Anders Broman
063c688bc0 Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2057
The tag for PSTNTermination is [95].

svn path=/trunk/; revision=23723
2007-12-03 22:22:25 +00:00
Ronnie Sahlberg
b10403f13e add end of line to the last line of the file
svn path=/trunk/; revision=23718
2007-12-03 21:54:27 +00:00
Ronnie Sahlberg
830da048fc mark two unused parameters as _U_
svn path=/trunk/; revision=23717
2007-12-03 21:52:57 +00:00
Stig Bjørlykke
b958a1a124 Mark pinfo as unused.
svn path=/trunk/; revision=23713
2007-12-03 21:33:56 +00:00
Anders Broman
20b383c1b1 Dissect RTP payload of H.264 and SDP profile-leve-id for H.264.
svn path=/trunk/; revision=23709
2007-12-03 20:14:42 +00:00
Graeme Lunt
a58643173d Revised P7 dissector to use #.TABLE directive to generate tables for the ROS dissector from
the [ABSTRACT] OPERATIONS definitions in the ASN.1 file.


svn path=/trunk/; revision=23707
2007-12-03 19:32:28 +00:00
Graeme Lunt
5d8693069d Support table-based dissection of ROS operations.
This simplifies the generation of dissectors for ROS-based protocols using the asn2wrs #.TABLE directive.

See the P7 dissector for an example.


svn path=/trunk/; revision=23706
2007-12-03 19:29:24 +00:00
Jeff Morriss
aabf0f25d1 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2059 : reassemble XUDTS, too
svn path=/trunk/; revision=23705
2007-12-03 18:12:25 +00:00
Jeff Morriss
757b5e13e6 Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2063 : there's only 1 octet of FSN in non-ANSI COO/COA's.
svn path=/trunk/; revision=23704
2007-12-03 17:32:02 +00:00
Martin Mathieson
8a311e2320 Add "soap" -> "http" mapping.
svn path=/trunk/; revision=23703
2007-12-03 15:47:08 +00:00
Tomas Kukosa
0ba8976eb7 fix confusion in tag handling
svn path=/trunk/; revision=23702
2007-12-03 13:48:45 +00:00
Martin Mathieson
b8ef070e84 My compiler (I think wrongly) says that fnum could be used uninitialised.
svn path=/trunk/; revision=23701
2007-12-03 12:22:13 +00:00
Stig Bjørlykke
ecdb4359d2 From Florent DROUIN:
I just add a test for the index, to check we are in the element table.

This fixes bug 2051.

svn path=/trunk/; revision=23688
2007-11-30 16:01:08 +00:00
Stig Bjørlykke
8286c9a645 From Florent DROUIN:
There is a new check for the length, and the reported_length is added to the
offset, instead of the "theorical" length of the element.

This fixes bug 2052.

svn path=/trunk/; revision=23687
2007-11-30 15:55:28 +00:00
Tomas Kukosa
f9fae482f5 define ssl_debug_flush() for disabled debug
svn path=/trunk/; revision=23683
2007-11-30 12:41:23 +00:00
Tomas Kukosa
187864ff8f setup SRTP stream if MIKEY is detected in OLC
svn path=/trunk/; revision=23682
2007-11-30 12:37:30 +00:00
Tomas Kukosa
b19d4c9e42 use g_strconcat() which should be faster instead of g_strdup_printf()
svn path=/trunk/; revision=23681
2007-11-30 11:46:13 +00:00
Tomas Kukosa
aab2bf936e - fix warnings in prefs.c
- do not flush SSL debug output after each message but only once per packet

svn path=/trunk/; revision=23680
2007-11-30 11:12:55 +00:00
Stig Bjørlykke
c068f9acf2 From Jens Braeuer (bug 1999):
This patchs adds the 
- requested check of tlv_len at top of the disection-loop
- length check for fields w/ variable length (expert_add_info_format)

svn path=/trunk/; revision=23673
2007-11-29 17:25:36 +00:00
Anders Broman
b1370e46d0 Didier Gautheron:
Only call ether_to_str(), get_ether_name() if the tree is visible, they are slow.

svn path=/trunk/; revision=23666
2007-11-29 06:29:20 +00:00
Anders Broman
87503b059e Didier Gautheron:
Call subdissectors preference for retransmitted frames.

svn path=/trunk/; revision=23665
2007-11-29 06:28:07 +00:00
Bill Meier
b69928928f From Didier Gautheron: Fix for Bug #1862: JPEG (JFIF) packet always malformed
svn path=/trunk/; revision=23662
2007-11-29 00:01:09 +00:00
Anders Broman
5935bf73a4 Didier Gautheron:
icmp dissector must call subdissectors even if tree is NULL

svn path=/trunk/; revision=23653
2007-11-28 21:44:40 +00:00
Bill Meier
7f9585782d Fixes for Windows build w/o ZLIB
svn path=/trunk/; revision=23651
2007-11-28 20:06:21 +00:00
Jaap Keuter
fe11aff158 From Brian W. Antoine:
The Packet decoder for CFM has a couple of small bugs.
1) The frame rate for CCM's is wrong for rate=4, it's shown as 1ms and it should be shown as 1s.
2) The flags display for a LTM packet has the wrong title for bit 7.  It should be UseFDBonly, not RDI.

svn path=/trunk/; revision=23649
2007-11-28 18:59:37 +00:00
Gerald Combs
f07871ac79 Use guints instead of guint8s for counters.
svn path=/trunk/; revision=23646
2007-11-28 15:55:50 +00:00
Tomas Kukosa
ff7c20938e Various changes with focus to startup speedup
The startup timeout on Win32 is reduced to 80% without assembler and to 50% with assembler usage (which is optional)
proto.c
 - do not look up in filed tree and inserts in two steps but do it at once
 - next few small speedups
 - some often called elementary functions can be optionally implemented in assembler
 - dispart some functions to see more exact result from profiling
packet-tpnc.c
 - do not reallocate memory for each filed

svn path=/trunk/; revision=23643
2007-11-28 10:18:16 +00:00
Stig Bjørlykke
60686647d2 Fixed a possible infinite loop.
svn path=/trunk/; revision=23642
2007-11-28 09:30:10 +00:00
Ronnie Sahlberg
c79cf40b3b update to most recent wkssvc.idl from the samba4 repository
svn path=/trunk/; revision=23641
2007-11-28 06:21:28 +00:00
Stig Bjørlykke
111cedfc75 - Added SEQ/ACK analysis for reports and notifications.
- Identify ack type in COL_INFO.
- No analysis when in error packets.
- Some cleanup in hf_ names.

svn path=/trunk/; revision=23630
2007-11-27 22:54:15 +00:00
Anders Broman
95d8c7e2da Apply yet another of the optimization patches:
- Only call functions if they are needed or once.

svn path=/trunk/; revision=23628
2007-11-27 21:24:39 +00:00
Anders Broman
eeab60b75f Apply yet another of the optimization patches:
- Remove a spurious volatile.

svn path=/trunk/; revision=23627
2007-11-27 21:23:45 +00:00
Gerald Combs
e679376996 From Sam Leffler: Add support for IEEE80211_RADIOTAP_XCHANNEL.
svn path=/trunk/; revision=23625
2007-11-27 20:03:43 +00:00
Gerald Combs
e8fd375630 Fixes from Sam Leffler:
In capture_sync.c: Don't clobber the DLT value.

  In packet-cops.c (modified by me): Instead of adding an item as a static,
  mis-cast FT_UINT16 to the tree, add it as an FT_NONE.

  In packet-802.11.c: Add the right address to the tree.

svn path=/trunk/; revision=23624
2007-11-27 19:57:35 +00:00
Guy Harris
9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Michael Tüxen
d00e6fe59e Fix from Stephen Fisher for bug 2028.
svn path=/trunk/; revision=23621
2007-11-27 17:46:55 +00:00
Jeff Morriss
7b5c60314c Don't attach to any TCP/UDP ports if we weren't able to load the database--and thus the hf_ entries (which are required for dissection).
svn path=/trunk/; revision=23620
2007-11-27 16:08:24 +00:00
Guy Harris
7a4eb3eb35 Check for AVPs with a list of values and a type that's not a 32-bit or
shorter integral type.  Fixes bug 2027.

Rename the "bytes" pointer to "octetstring", and initialize it in a
fashion that makes it clearer that it points to the first of the basic
types, to make it clearer that it's for OctetString.

svn path=/trunk/; revision=23615
2007-11-27 01:41:42 +00:00
Gerald Combs
7731b882f2 From Tuomas Maattanen: Fix a .11e QBSS IE endian error.
svn path=/trunk/; revision=23614
2007-11-27 01:02:03 +00:00
Gerald Combs
1064a1df35 Make sure we fully initialize a struct. Fixes bug 2021.
svn path=/trunk/; revision=23613
2007-11-27 00:36:41 +00:00
Jeff Morriss
1cd46ec7be Get rid of the global data structures populated by wiretap/mpeg-audio but
used by the mpeg-audio dissector: instead keep the data inside the wiretap
module and add accessor functions.  I think this should fix
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1677 and anyway it's
cleaner.

svn path=/trunk/; revision=23612
2007-11-26 23:06:07 +00:00
Jeff Morriss
309f7503e5 Get rid of C++/C99 style comments--not all compilers support them
svn path=/trunk/; revision=23608
2007-11-26 18:55:17 +00:00
Stig Bjørlykke
86f278dda7 Use the offset and length for the interesting data.
svn path=/trunk/; revision=23607
2007-11-26 18:51:24 +00:00
Jeff Morriss
dd0a4750b0 s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows.
svn path=/trunk/; revision=23605
2007-11-26 18:35:37 +00:00
Jeff Morriss
c5ab162b37 gcc-4.1.1 thinks 'retval' might not get set inside the TRY(). Initialize it.
svn path=/trunk/; revision=23603
2007-11-26 17:28:12 +00:00
Stig Bjørlykke
a26ea5739a Use correct offset for subtree in dissect_spoolss_relstr.
svn path=/trunk/; revision=23602
2007-11-26 17:03:12 +00:00
Stig Bjørlykke
e5461f3307 From Kai Blin:
Dissect the PRINTER_INFO structure in the SpoolssEnumPrinters call.

From me:
Add the level info to COL_INFO.

svn path=/trunk/; revision=23600
2007-11-26 16:38:26 +00:00
Sebastien Tandel
d580971f07 Update error handling of UDP Light Illegal Checksum value 0
* change expert group from PI_MALFORMED to PI_CHECKSUM (as it should be!!!).
  * set item hf_udp_checksum_[good|bad] as generated


svn path=/trunk/; revision=23599
2007-11-26 14:42:38 +00:00
Sebastien Tandel
6c4f9f0479 iUpdate error handling of UDP Light Illegal Checksum value 0
* Adding PI_MALFORMED expert field for this case.
  * Adding an error string in COL_INFO.


svn path=/trunk/; revision=23598
2007-11-26 14:30:40 +00:00
Gerald Combs
3697704b62 Fix bug 2019: The SMB dissector was dereferencing a NULL pointer.
svn path=/trunk/; revision=23593
2007-11-25 23:08:09 +00:00
Stig Bjørlykke
4e9892cbfd Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23590
2007-11-25 21:30:57 +00:00
Stig Bjørlykke
a2b5cf9528 Added checksum.good and checksum.bad items.
svn path=/trunk/; revision=23589
2007-11-25 21:30:33 +00:00
Jaap Keuter
054ed14e67 Header field array and whitespace cleanup.
svn path=/trunk/; revision=23588
2007-11-25 19:20:32 +00:00
Sake Blok
9f829f4ba2 Bug 1997 From Timo Teras:
Patch to do the following:
1) Dissect CIE Lists in NHRP Extensions
2) Dissect original NHRP packet in Error Indication
3) Support for Cisco NAT extensions
4) Support for Cisco NHRP Traffic Indication packet


svn path=/trunk/; revision=23587
2007-11-25 18:10:01 +00:00