Commit graph

22176 commits

Author SHA1 Message Date
Jeff Morriss
ef2c84025c Don't call get_interface_descriptive_name() on a NULL iface: fixes a segfault when doing Statistics->Summary when you didn't capture anything (but rather read in a file)
svn path=/trunk/; revision=22788
2007-09-04 22:13:26 +00:00
Stig Bjørlykke
f1cf7ee6bf Fixed compiler warnings to get the buildbot going.
svn path=/trunk/; revision=22787
2007-09-04 21:49:14 +00:00
Stig Bjørlykke
6e94835848 Rewrote handling of parameters to get rid of "funky" oid strings.
Added expert info for unknown binding-parameters.

svn path=/trunk/; revision=22786
2007-09-04 21:46:41 +00:00
Anders Broman
b3521c5975 value_tvb=out_tvb, remove unused variables.
svn path=/trunk/; revision=22785
2007-09-04 19:36:07 +00:00
Anders Broman
a76efadf0c Get correct value for bitstrings.
svn path=/trunk/; revision=22784
2007-09-04 16:57:07 +00:00
Anders Broman
f7bed80d57 ANSI MAP systemMyTypeCode should be OPTIONAL
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1820

svn path=/trunk/; revision=22783
2007-09-04 16:55:48 +00:00
Bill Meier
fc162617f4 enable esc for new/edit/delete dialogs; remove some redundant code;
svn path=/trunk/; revision=22782
2007-09-04 12:37:19 +00:00
Jaap Keuter
970f34a557 From Munenori Ohuchi:
This patch adds a new feature to dissect HSRPv2 packets.

One of the main features of HSRPv2 can enable using HSRP on IPv6. In order to
achieve this new feature, HSRPv2 packet format is totally different from
HSRPv1. HSRPv2 introduces new TLV formats.

This patch can decode these new formats of HSPRv2.

svn path=/trunk/; revision=22781
2007-09-04 06:55:52 +00:00
Anders Broman
8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Anders Broman
654554a507 Wireshark packet-gtp.c error in decoding IMEI.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1536

svn path=/trunk/; revision=22779
2007-09-03 16:42:28 +00:00
Anders Broman
4e0cf23472 Incorrectly decoded IMSI in RANAP prot./id-CommonID procedure
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1713

svn path=/trunk/; revision=22778
2007-09-03 16:40:51 +00:00
Anders Broman
8f3a0cb862 BSSGP.TLLI is not recognized properly in filter
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384

svn path=/trunk/; revision=22777
2007-09-03 16:39:07 +00:00
Guy Harris
8084fb9e82 guint8, not gchar, is the appropriate type for a byte.
svn path=/trunk/; revision=22776
2007-09-03 06:44:54 +00:00
Jaap Keuter
bd56b304c6 Fix for bug 1816:
Add status value to LSSU info column.

svn path=/trunk/; revision=22775
2007-09-03 05:56:48 +00:00
Bill Meier
24c891ab1f default window_cancel_butoon_cb is not appropriate since a specific cancel cb is specified.
svn path=/trunk/; revision=22774
2007-09-03 00:17:47 +00:00
Guy Harris
522053f04b tvb_reported_length() returns a gint, so assign its value to a gint.
svn path=/trunk/; revision=22773
2007-09-02 23:51:51 +00:00
Bill Meier
30b61b7540 Fix my previous patch to enable esc on window
svn path=/trunk/; revision=22772
2007-09-02 23:37:40 +00:00
Guy Harris
d5ea683007 For bug 1685, check for the errors reported on at least some platforms
when an interface goes down or goes away, and, in that case, just report
that, rather than reporting a more technical error and indicating that
the error should be reported to the Wireshark developers.

Line-break the "please report this to the Wireshark developers" error
differently (so that it doesn't look weird if the dialog box line-wraps
it).

Fix indentation.

svn path=/trunk/; revision=22771
2007-09-02 23:32:43 +00:00
Guy Harris
6b45c4179d The actual length of the PPPoE payload is returned by
tvb_reported_length_remaining(), not by tvb_length_remaining() -
tvb_length_remaining() shows only the amount of *captured* data
remaining, but the capture might have been done with a snapshot length
that cut the packet data short.

The payload length from the PPPoE header could legitimately be different
from the actual length of the PPPoE payload if there's not enough PPPoE
payload to avoid padding at the E(thernet) level.  Only complain if
there shouldn't have been any padding.

Report an "expert" warning if the payload length looks wrong.

Update a comment to reflect current reality (as of many many years ago,
when we went all-tvbuff).

svn path=/trunk/; revision=22770
2007-09-02 22:49:56 +00:00
Bill Meier
c2d927e6a2 Verify existence of required downloaded library packages during make after Makefile.nmake updated
svn path=/trunk/; revision=22769
2007-09-02 20:53:15 +00:00
Guy Harris
0e09d21936 Fix indentation.
svn path=/trunk/; revision=22768
2007-09-02 20:37:39 +00:00
Bill Meier
0534c6982c macro_name_chk: return valid error string for fail return when empty macro name field;
fixes bug #1813

svn path=/trunk/; revision=22767
2007-09-02 12:37:24 +00:00
Jaap Keuter
770034f1d0 From Steve Karg:
Fix for bug 1807. This patch corrects the decoding of the NotificationParameters. 
I fuzz tested with these and other captures (Pass > 100).

svn path=/trunk/; revision=22766
2007-09-01 11:47:59 +00:00
Sake Blok
98be4e676e This patch solves two issue with the NetScreen wiretap routine:
- It accepts the "/" character in interface names
- It accepts EOF as delimiter for the last packet (when there is no more emptyline)

svn path=/trunk/; revision=22765
2007-09-01 11:14:01 +00:00
Guy Harris
81f968f748 Show unsigned quantities with %u, not %d.
svn path=/trunk/; revision=22764
2007-08-31 23:56:07 +00:00
Bill Meier
d5b126a552 Enable <esc> to cancel window; remove some redundant code
svn path=/trunk/; revision=22763
2007-08-31 23:22:45 +00:00
Sake Blok
2ef69333db When doing TCP_SEQ analysis, if the packet is a SYN, then it's
not a lost packet but the tcp ports are being reused. This is often 
seen in load-balanced environments where client ports are preserved 
on the server-side.

We only want to report port reusage once, so the SYN/ACK is excluded 
from TCP_SEQ analysis.

svn path=/trunk/; revision=22762
2007-08-31 15:06:27 +00:00
Sake Blok
27efb95042 This patch fixes the following two errors that appear when
configure is run with "--without-plugins"

cc1: warnings being treated as errors
about_dlg.c: In function ‘about_wireshark_cb’:
about_dlg.c:426: warning: unused variable ‘plugins_page’
make[2]: *** [about_dlg.o] Error 1

editcap.c: In function ‘main’:
editcap.c:663: error: ‘check_ts’ undeclared (first use in this function)
editcap.c:663: error: (Each undeclared identifier is reported only once
editcap.c:663: error: for each function it appears in.)
make[2]: *** [editcap.o] Error 1


svn path=/trunk/; revision=22761
2007-08-31 14:14:17 +00:00
Jaap Keuter
1a8fb7a459 Fix for bug 1244:
hf_isup_event_ind contains incorrect fieldbase.

svn path=/trunk/; revision=22760
2007-08-31 05:37:43 +00:00
Ulf Lamping
b57c83f6eb fix length calculation for 802.11 packets - the 802.11 dissector will strip off the 4 byte FCS at the end of a packet (while the Ethernet dissector does not).
svn path=/trunk/; revision=22759
2007-08-30 19:50:56 +00:00
Anders Broman
51460c5a5f fix dissect_per_bit_string() for unaligned PER, values ar still not correctly displayed.
svn path=/trunk/; revision=22758
2007-08-30 19:44:22 +00:00
Guy Harris
846633da41 Clean up "setuid-root.pl" when we do "make distclean".
svn path=/trunk/; revision=22757
2007-08-30 19:34:20 +00:00
Stig Bjørlykke
9703036496 Added capture_wlancap to libwireshark.def
svn path=/trunk/; revision=22756
2007-08-30 19:11:36 +00:00
Stig Bjørlykke
2b49760882 It seems like capture_stats is working as a correctly implemented pcap_stats.
Update the Packets count in Capture Interfaces according to this.

svn path=/trunk/; revision=22755
2007-08-30 17:36:38 +00:00
Stig Bjørlykke
debdff77c4 Huh. Fetch setuid-root.pl.in from srcdir instead.
svn path=/trunk/; revision=22754
2007-08-30 15:44:59 +00:00
Stig Bjørlykke
147e5afa74 Added setuid-root.pl.in to EXSTRA_DIST
svn path=/trunk/; revision=22753
2007-08-30 12:06:18 +00:00
Stig Bjørlykke
cb8dab02be And include packet-wlancap.h
svn path=/trunk/; revision=22752
2007-08-30 11:52:30 +00:00
Stig Bjørlykke
6d9c82338d Fixed a brace placement to enable the default case
svn path=/trunk/; revision=22751
2007-08-30 11:37:49 +00:00
Stig Bjørlykke
d25d82405e Count IEEE 802.11 WLAN AVS packets.
svn path=/trunk/; revision=22750
2007-08-30 11:28:27 +00:00
Greg Morris
1506ed6fcc Test to see if packet is actually a request by verifying the one byte function code is a non-zero value.
svn path=/trunk/; revision=22749
2007-08-30 10:33:24 +00:00
Greg Morris
82b75c4a19 Update to reflect new iteration verb 0x6e.
svn path=/trunk/; revision=22748
2007-08-30 10:26:20 +00:00
Greg Morris
a6aab98d1e Fix attribute *Print Checkpoint"
Fix Printer State Reasons in extended error codes.

svn path=/trunk/; revision=22747
2007-08-30 10:23:58 +00:00
Greg Morris
c8be509d6a Add eDirectory iteration verb 0x6e.
Fix eDirectory timestamps to display correctly.

svn path=/trunk/; revision=22746
2007-08-30 10:18:29 +00:00
Stig Bjørlykke
4f13ccf33b Added #include <sys/types.h>
svn path=/trunk/; revision=22745
2007-08-30 09:28:41 +00:00
Stig Bjørlykke
4a58028897 Fixed a typo: setuid-root.in -> setuid-root.pl.in
Added setuid-root.pl to svn:ignore

svn path=/trunk/; revision=22744
2007-08-30 08:50:05 +00:00
Anders Broman
039c84485d From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22743
2007-08-30 05:30:28 +00:00
Anders Broman
e600941645 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22742
2007-08-30 05:22:25 +00:00
Anders Broman
66465f99be From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22741
2007-08-30 05:05:45 +00:00
Anders Broman
f0fdcf55c4 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22740
2007-08-30 05:02:33 +00:00
Anders Broman
3d65e68a15 From Chris Maynard:
Incorrect display filter field naming convention.

svn path=/trunk/; revision=22739
2007-08-30 04:58:11 +00:00