Commit Graph

46817 Commits

Author SHA1 Message Date
Evan Huus edd3dfd6f8 From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8776
Two new DNS tree items: dns.count.labels and dns.qry.name.len.

svn path=/trunk/; revision=49856
2013-06-09 13:32:03 +00:00
Anders Broman 455381dace From Tommy Wu:
Correct VSA name.

svn path=/trunk/; revision=49855
2013-06-09 10:10:59 +00:00
Guy Harris f4f4e024bc libwireshark's add_new_ipv4() and add_new_ipv6() now silently ignore
requests to add an entry with a zero-length name; we don't have to
ignore them ourselves.

svn path=/trunk/; revision=49854
2013-06-09 06:44:47 +00:00
Michael Mann 2d37ec3cb0 Batch of filterable expert infos.
svn path=/trunk/; revision=49853
2013-06-09 03:28:05 +00:00
Guy Harris 5ea3858f53 Don't put zero-length names into our tables of resolved IPv4 and IPv6
addresses; they look weird, and can cause problems with existing
versions of Wireshark when written in a Name Resolution Block.

Should fix bug 8763.

svn path=/trunk/; revision=49852
2013-06-09 02:56:16 +00:00
Guy Harris 9f1f58745c Don't treat zero-length names in the NRB as errors, just silently ignore
them.

Works around the problem reported in bug 8763.

svn path=/trunk/; revision=49851
2013-06-09 02:32:30 +00:00
Guy Harris 0b8d569887 If, after editing the settings for a particular interface, we don't have
a Capture Options window to update, don't try to update it.

#BACKPORT

svn path=/trunk/; revision=49850
2013-06-09 00:24:28 +00:00
Luis Ontanon afe4c8e755 A further iteration on epan_child
svn path=/trunk/; revision=49849
2013-06-08 21:37:55 +00:00
Jakub Zawadzki a12ee2e673 Fix 'Misaligned columns in hex dump pane' [1]
Old code was broken for all pango version < 1.20

[1] http://www.wireshark.org/lists/wireshark-dev/201306/msg00015.html

svn path=/trunk/; revision=49848
2013-06-08 18:57:49 +00:00
Luis Ontanon 88184bc685 Another iteration...
svn path=/trunk/; revision=49847
2013-06-08 04:20:16 +00:00
Luis Ontanon dc0abfb9f8 some fixes
C comments



svn path=/trunk/; revision=49846
2013-06-08 02:42:06 +00:00
Michael Mann 6229ab6266 Batch of filterable expert infos.
svn path=/trunk/; revision=49845
2013-06-08 02:06:24 +00:00
Luis Ontanon 294ed52c65 Preliminary header file for an EPAN working-child interface...
Not yet in build process...


svn path=/trunk/; revision=49844
2013-06-07 23:29:37 +00:00
Chris Maynard e62f4cc4f6 Fix all errors and warnings found by podchecker.
svn path=/trunk/; revision=49837
2013-06-07 17:06:27 +00:00
Guy Harris f86c7712a3 Use g_try_malloc() for some memory allocations, and return an "out of
memory" indication if it fails.

Further fixes bug 8752.

Also, clean up indentation.

svn path=/trunk/; revision=49834
2013-06-07 08:34:44 +00:00
Guy Harris 2429df9c51 Prevent attempts to allocate huge amounts of memory by imposing an
artificial 16MB limit on blocks.

Do some sanity checks when reading options, to make sure we don't read
past the end of the block.

Make some variables unsigned so as not to get inappropriate
sign-extension (which, in practice, should never happen due to the 16MB
block size limit, although if the limit is raised above 2^31-1, the
limit won't protect you).

Fixes bug 8752.

svn path=/trunk/; revision=49833
2013-06-07 08:19:40 +00:00
Stig Bjørlykke e4893f0448 Ensure we only put private profiles directly in the profiles menu and
put global profiles in the "New from Global" menu.

svn path=/trunk/; revision=49830
2013-06-07 06:53:24 +00:00
Sake Blok f3ba09b543 Mark retransmitted SYN and FIN packets as retransmissions.
svn path=/trunk/; revision=49829
2013-06-07 06:49:15 +00:00
Pascal Quantin 506b417907 From Mark C. Brown via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8777 :
Add support for 10Gbe HP-UX drivers IOCXGBE and IQXGBE

svn path=/trunk/; revision=49820
2013-06-06 20:55:00 +00:00
Pascal Quantin f5f6293d28 From Andreas Bachmann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6126 :
Add dissection of PTP Signaling TLV types Request unicast transmission, Grant unicast transmission, Cancel unicast transmission and Acknowledge cancel unicast transmission

svn path=/trunk/; revision=49816
2013-06-06 19:50:55 +00:00
Gerald Combs 693bcb654c Have the NSIS installer run the existing uninstaller silently. This
should save a few mouse clicks during the installation process.

svn path=/trunk/; revision=49813
2013-06-06 19:04:46 +00:00
Guy Harris 57eb433a0b Pull all the code that reads and processes the packet header into
visual_process_packet_header() and call it in both the read and
seek-read routines.

Pull the post-processing code that guesses the encapsulation based on
the first few bytes in the packet into
visual_fill_in_chdlc_encapsulation() and call it in both the read and
seek-routines.  Add some length checks.

svn path=/trunk/; revision=49812
2013-06-06 18:57:22 +00:00
Gerald Combs 1a95757f46 I suspect "ie4uinit" got its name because "mysterious useful undocumented
system utility" would have been too obvious. Have UpdateIcons call
"ie4uinit -ClearIconCache" and move UpdateIcons to the "-{,Un.}Finally"
sections in the installer and uninstaller.

svn path=/trunk/; revision=49811
2013-06-06 18:46:37 +00:00
Alexis La Goutte 727f37e804 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=49810
2013-06-06 16:24:33 +00:00
Alexis La Goutte 0dca89c4f2 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=49809
2013-06-06 16:24:25 +00:00
Alexis La Goutte 96e874b4c3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=49808
2013-06-06 16:24:16 +00:00
Alexis La Goutte 2a89034b06 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=49807
2013-06-06 16:24:07 +00:00
Alexis La Goutte 8b52c9b2e5 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=49806
2013-06-06 16:23:59 +00:00
Alexis La Goutte 3eb44c5934 Fix typo (double include epan/ipproto.h)
svn path=/trunk/; revision=49805
2013-06-06 16:23:50 +00:00
Alexis La Goutte a4d78ca253 From report of IgorVK via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8736 Crash analyzing VoIP Calls
Wireshark crashes when analyzing Telephony->VoIP Calls from the pcap file attached.

From me :
Some packets is detect to be T38 and ->stop_fd is not initialize

#Backport 1.10 and 1.8

svn path=/trunk/; revision=49804
2013-06-06 16:00:23 +00:00
Guy Harris 59c3ab9cc9 Pull the code for setting the struct wtap_pkthdr into a
snoop_process_record_header() routine, and call it in both the read and
seek-read routines.

svn path=/trunk/; revision=49803
2013-06-06 08:14:44 +00:00
Evan Huus de3f2847f1 From myself and Julian Cable via (and fixing)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8717

Don't add a DCP-ETSI fragment for reassembly if the length is wrong.


svn path=/trunk/; revision=49802
2013-06-06 02:53:36 +00:00
Michael Mann 57fc882623 Simplify the "bad length" expert info into a single filterable item with formatting determining the particulars because the filter names just didn't make much sense to separate.
svn path=/trunk/; revision=49801
2013-06-06 02:10:22 +00:00
Guy Harris 311c8d346d Set the entire struct wtap_pkthdr, not just the pseudo-header, in the
seek-read routine.  Pull the code to do that into
netxray_set_pseudo_header(), and rename it netxray_set_phdr().

svn path=/trunk/; revision=49800
2013-06-06 00:10:36 +00:00
Gerald Combs 0c7b80da22 Forward-port part of r49794 from trunk-1.10.
svn path=/trunk/; revision=49799
2013-06-05 23:43:56 +00:00
Jeff Morriss 1cc0587d00 Add a -Y option to match test-captures.sh: it runs tshark with a read filter but without building the tree.
svn path=/trunk/; revision=49797
2013-06-05 21:30:08 +00:00
Chris Maynard 77cf790b76 Change leading spaces to tabs so all plugin_src's are now the same.
svn path=/trunk/; revision=49796
2013-06-05 21:13:30 +00:00
Chris Maynard b4414c61d9 As of r49659, StatisticsMenu is now just Statistics.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8770

svn path=/trunk/; revision=49788
2013-06-05 16:42:22 +00:00
Gerald Combs c891784de7 Quick fix for bug 8768. For now assume that only three logical channels
are valid. If we run into more add expert item and cap the channel
count.

svn path=/trunk/; revision=49787
2013-06-05 16:38:20 +00:00
Chris Maynard bb35c1c375 From Peter Van Eynde via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8635: Fix bugs found by Coverity: CID's 1026572-1026574 and 1026572.
From me: Dissector was a mix of tabs and spaces.  Replace tabs with spaces and set modelines to match.

svn path=/trunk/; revision=49785
2013-06-05 15:06:20 +00:00
Jeff Morriss 470bd4455a Add a new environment variable to cause abort()s if we add too many items
to the tree (to separate this case from the generic DISSECTOR_BUG case).

Enable this environment variable when fuzz testing.

Enable the 3rd (without tree but with a read filter) check (added in r49643)
when testing capture files but not when fuzz testing--not sure if we want to
add even more to the fuzzbot's work load now (OTOH I've been running it for
a while and it hasn't buried me in bugs).

svn path=/trunk/; revision=49784
2013-06-05 14:08:40 +00:00
Jeff Morriss 2a3013fbe1 wccp_version_val is not an extended value string; don't use BASE_EXT_STRING. Fixes a crash I got during fuzz testing.
svn path=/trunk/; revision=49783
2013-06-05 13:55:22 +00:00
Guy Harris a58b141062 The check for network_size < 4 is necessary only for those packets where
we're lopping 4 bytes off of the network_size.

Add a comment discussing the aformentioned lopping-off.

svn path=/trunk/; revision=49782
2013-06-05 08:12:06 +00:00
Chris Maynard fd1746412b Allow tshark to read a pcap file and either save it as a new pcap file or for packets to be read from the original pcap file, possibly filtered, then sent to stdout and piped to either tshark or wireshark, which can then read those filtered packets from stdin. Patch submitted by me in bug 2868, although it doesn't actually fix that bug.
#BACKPORT(1.10)

svn path=/trunk/; revision=49780
2013-06-05 03:07:57 +00:00
Guy Harris 1f2231da07 Move the code that fills in the struct wtap_pkthdr (other than the
pseudo-header) into a process_packet_header() routine, and call it in
both the read and seek-read routines.

svn path=/trunk/; revision=49779
2013-06-05 00:36:57 +00:00
Sake Blok 56cb987ef2 Fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7546
Make sure unresolved columns are indeed unresolved


svn path=/trunk/; revision=49776
2013-06-04 21:36:47 +00:00
Pascal Quantin 1bb2081fd2 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8746 :
Add procedure numbers to C12.22 dissection

svn path=/trunk/; revision=49775
2013-06-04 20:21:17 +00:00
Anders Broman 3bfeaff546 Add subdissection of:
- SNMPv2-MIB sysDescr
-  SNMPv2-MIB::sysName

svn path=/trunk/; revision=49774
2013-06-04 20:05:16 +00:00
Jakub Zawadzki 6bd6c5eed9 Add new dfilter function: size()
Make it return fvalue_length() of field.

[XXX, rename len() to strlen(), and size() to len()?!]

svn path=/trunk/; revision=49771
2013-06-04 19:29:10 +00:00
Chris Maynard 8df372bb6a Fix warning reported by MSVC:
to_str.c(262) : warning C4114: same type qualifier used more than once

svn path=/trunk/; revision=49770
2013-06-04 19:12:32 +00:00