Commit graph

1487 commits

Author SHA1 Message Date
Jaap Keuter
929a92a454 From Geoffrey Kimball:
DOCSIS 3.0 includes a new Bonded Initial Ranging Request (B-INIT-RNG-REQ) MAC
Management type (34).  A simple dissector is needed to decode this message.

svn path=/trunk/; revision=29487
2009-08-20 19:41:53 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
197d30a3b8 Use HFILL instead of hard coding the values
svn path=/trunk/; revision=29431
2009-08-15 11:21:36 +00:00
Kovarththanan Rajaratnam
2dfa5ccebe From Artem Tamazov via. 3899:
Remove superfluous /MP

svn path=/trunk/; revision=29410
2009-08-14 10:17:13 +00:00
Kovarththanan Rajaratnam
083729e02c Add PTREE_FINFO and use PITEM_FINFO when possible.
svn path=/trunk/; revision=29355
2009-08-09 17:57:31 +00:00
Bill Meier
d3174f0d03 (Trivial): Remove uneeded #includes; make a few fcns static;
svn path=/trunk/; revision=29353
2009-08-09 16:48:28 +00:00
Bill Meier
0a60e46adf 'if(proto_... == -1)' not req'd; Don't register ett[] more than once;
svn path=/trunk/; revision=29351
2009-08-09 15:07:35 +00:00
Kovarththanan Rajaratnam
ac463d2697 Don't guard col_clear with col_check
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Kovarththanan Rajaratnam
0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam
24ca3c44c9 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29341
2009-08-09 06:47:24 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Gerald Combs
53a24d94f9 Check TLV lengths before we try to add them to the tree. Fixes bug 3824.
svn path=/trunk/; revision=29338
2009-08-08 22:20:08 +00:00
Guy Harris
3d1e81ff3d Fix typo.
svn path=/trunk/; revision=29300
2009-08-05 00:13:38 +00:00
Guy Harris
6847b0b94d Put the initializers for the elements of value_string arrays into curly
brackets, so the API checks for non-terminated value_string arrays will
not falsely think the arrays are non-terminated.

svn path=/trunk/; revision=29299
2009-08-04 23:14:40 +00:00
Bill Meier
8589c2f11b Minor changes:
- Move proto_register...() to the end of the file as per convention;
- Move ett[] to be local to proto_register...();
- "if (...==-1)" not req'd in proto_register...();
- #include <moduleinfo.h> not req'd;
- Remove unneeded forward declarations.

svn path=/trunk/; revision=29296
2009-08-04 19:01:34 +00:00
Gerald Combs
9bc8469d96 Remove a couple of unused variables.
svn path=/trunk/; revision=29286
2009-08-03 23:50:55 +00:00
Gerald Combs
5bbd304601 Add some null checks.
svn path=/trunk/; revision=29285
2009-08-03 23:49:05 +00:00
Bill Meier
42a4efbb59 More minor cleanups:
- Move proto_register to near the end of the file as per convention;
- Remove unneeded #include <epan/reassemble.h>;
- Comment out unused ett[] array and associated;

svn path=/trunk/; revision=29284
2009-08-03 23:18:59 +00:00
Bill Meier
b9b8fad812 Minor cleanups:
- Comment out code which creates two dissector tables and then
   stores a preference value in each of them; 
   AFAICT the tables are not accessed elsewhere;
- Comment out the no longer required prefs callback specification
   in proto_register;
- "if (... == -1)" not req'd in proto_register;
- Remove unused proto_reg_wimax function.

svn path=/trunk/; revision=29283
2009-08-03 22:38:43 +00:00
Bill Meier
d6e5235eb4 Various minor cleanups:
- Do all find_dissector() calls only once during proto_reg_handoff 
   (not each time a sub-dissector is called when dissecting frames).
- Move proto_register & proto_reg_handoff to the end of the file as per convention;
- Move a global variables to be local;
- Change a global variable to be static; 
- Remove unneeded multiple #include <string.h>
- Remove an unneeded variable and a few unneeded lines of code.

svn path=/trunk/; revision=29282
2009-08-03 22:09:08 +00:00
Bill Meier
cc3a2c97a8 Use find_dissector() instead of create_dissector_handle();
Fix some indentation.

svn path=/trunk/; revision=29273
2009-08-03 16:18:06 +00:00
Anders Broman
617077e94a From Benjamin Meyer:
Profinet dissector does not decode all defined error codes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753

svn path=/trunk/; revision=29150
2009-07-21 06:08:45 +00:00
Stig Bjørlykke
221225e0f3 From Kovarththanan Rajaratnam via bug 3719:
This patch optimizes proto_tree_prime_hfid() + friends and
plugs a memleak in the process.

From me:
Removed unused hfindex in proto_tree_new_item()
Fixed ref_count entry in struct header_field_info.

svn path=/trunk/; revision=29137
2009-07-18 20:10:14 +00:00
Anders Broman
1196da707d From Rajasekhar Reddy Gali:
packet-wimaxasncp.c file need to update with latest wimax spec.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730

svn path=/trunk/; revision=29125
2009-07-16 21:27:56 +00:00
Anders Broman
91caa01090 Add /MP flag to make use of multi cores.
svn path=/trunk/; revision=29104
2009-07-15 20:55:31 +00:00
Stig Bjørlykke
618d8b517a Removed header_field.h
svn path=/trunk/; revision=28999
2009-07-07 20:40:28 +00:00
Bill Meier
4a3f420843 Fix the esl protocol enable/disable handling issue introduced in SVN #28986:
Use the standard "if (!initialized)..." logic in proto_reg_handoff().
Also: use "true_false_string flags_yes_no" as in the original patch.

svn path=/trunk/; revision=28994
2009-07-07 17:03:11 +00:00
Bill Meier
eac1f47fad Various fixes:
1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin;
2. proto_reg_handoff: remove unneeded code;
3. Change the prefs callback to call a function which just enables/disables
   the protocol; (using proto_reg_handoff means that the dissector
   was re-registered each time the pref was changed);
4. packet-esl.h: use #if 0 instead of /* ... */ to comment out code;

svn path=/trunk/; revision=28986
2009-07-07 14:26:38 +00:00
Stig Bjørlykke
87d24c9101 From Kovarththanan Rajaratnam:
Remove trailing spaces in protocol/field names

svn path=/trunk/; revision=28978
2009-07-07 11:37:15 +00:00
Stig Bjørlykke
09218f7338 From Richard Kummel:
- New dissector for EtherCAT Switch Link Header added to EtherCAT plugin
- Changed filtering of EtherCAT commands to the abbreviated form:
  e.g. ecat.cmd = APWR

From me:
- Mark unused variables
- Fixed a string warning
- Do not initialize a static struct
- Use tfs_yes_no
- Reorder files in Makefile

svn path=/trunk/; revision=28976
2009-07-07 11:13:22 +00:00
Stig Bjørlykke
7881d1ccd7 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28970
2009-07-07 09:00:33 +00:00
Stig Bjørlykke
6d472a50fc From Kovarththanan Rajaratnam via bug 3548:
Minor hf cleanup.

svn path=/trunk/; revision=28968
2009-07-07 07:46:57 +00:00
Stig Bjørlykke
3a6e56c25a From Kovarththanan Rajaratnam via bug 3548:
Move header_field.h into packet-unistim.c to align it with all other
dissectors.

svn path=/trunk/; revision=28967
2009-07-07 07:45:32 +00:00
Ulf Lamping
ea7fa021fa fix install step
svn path=/trunk/; revision=28945
2009-07-06 09:46:28 +00:00
Michael Tüxen
9518d53ab4 Make the compiler on Mac OS X happy...
svn path=/trunk/; revision=28934
2009-07-03 10:29:45 +00:00
Ulf Lamping
d180d37c8d update to the latest PROFINET drafts
(defragmentation of RT fragments "FRAG-PDU" is still not implemented)

svn path=/trunk/; revision=28932
2009-07-03 09:12:43 +00:00
Stig Bjørlykke
8531980952 From Kovarththanan Rajaratnam:
More hf_register_info related cleanup.

svn path=/trunk/; revision=28832
2009-06-24 02:17:12 +00:00
Stig Bjørlykke
b11f44c741 From Kovarththanan Rajaratnam:
Move hf_register_info declarations in packet-m2m.c to function scope

svn path=/trunk/; revision=28831
2009-06-24 02:12:13 +00:00
Stig Bjørlykke
7f77783e20 From Kovarththanan Rajaratnam:
More header field info cleanup in plugins/* and epan/dissectors/*

svn path=/trunk/; revision=28811
2009-06-22 18:23:58 +00:00
Stig Bjørlykke
f8c959dc8c From Kovarththanan Rajaratnam:
Move header field info declarations into function scope.

This is the first step. Another patch will be submitted which actually scrubs
the header field info declarations (remove empty blurbs, etc.)

svn path=/trunk/; revision=28797
2009-06-22 04:58:08 +00:00
Stig Bjørlykke
2bba6be84f From Kovarththanan Rajaratnam via bug 3548:
Cleanup header_field_info in plugins.

svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
Jörg Mayer
c321f29518 Trivial warning fixes:
- Might be used uninitialized
- not a prototype
- comma at end of enum


svn path=/trunk/; revision=28730
2009-06-15 02:34:53 +00:00
Stig Bjørlykke
0e1dc62fb0 Added missing $Id$ and convert to correct eol-style.
svn path=/trunk/; revision=28678
2009-06-09 21:30:41 +00:00
Guy Harris
cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Anders Broman
3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Anders Broman
fbd05f0fce Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28355
2009-05-13 19:44:44 +00:00
Bill Meier
3c84c0170e FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).
svn path=/trunk/; revision=28318
2009-05-08 20:45:29 +00:00
Jaap Keuter
f6122af9be From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28205
2009-05-01 06:59:37 +00:00
Jaap Keuter
b7dc0a3e51 From Reinhard Speyerer:
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.

svn path=/trunk/; revision=28204
2009-05-01 06:58:28 +00:00
Gerald Combs
17f0d877fa Fix Win64 compilation problems in the plugins directory.
svn path=/trunk/; revision=28064
2009-04-16 03:38:23 +00:00
Bill Meier
321506c076 (Trivial) Fix some spelling & etc in comments
svn path=/trunk/; revision=27996
2009-04-08 13:41:30 +00:00
Jaap Keuter
664ab35c79 Add missing header file of OpcUa plugin update.
svn path=/trunk/; revision=27978
2009-04-06 20:29:01 +00:00
Jaap Keuter
8ecf459611 From Gerhard Gappmeier:
This patch updates the plugin to fit the released OPCUA protocol version.

svn path=/trunk/; revision=27974
2009-04-06 18:30:04 +00:00
Bill Meier
a0eee8c299 Replace some unnecessary use of g_snprintf and g_strdup_printf
svn path=/trunk/; revision=27864
2009-03-27 14:46:54 +00:00
Bill Meier
e284ca63d5 (Minor): Remove unnecessary use of g_snprintf
svn path=/trunk/; revision=27863
2009-03-27 14:30:51 +00:00
Ulf Lamping
f681477e33 remove GPLv2 CRC code, the new epan CRC stuff is working well
svn path=/trunk/; revision=27803
2009-03-20 10:44:42 +00:00
Gerald Combs
dd903ca9c8 Create an "epan/crc" directory for CRC code. Add crc-16-plain.[ch],
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.

Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.

svn path=/trunk/; revision=27790
2009-03-18 21:59:30 +00:00
Bill Meier
4f34bb9b15 From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];
- As suggested actually use sizeof(...) rather than a numeric constant.
  - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1.

svn path=/trunk/; revision=27772
2009-03-18 15:03:46 +00:00
Ulf Lamping
870e139576 fix type
svn path=/trunk/; revision=27749
2009-03-16 22:36:34 +00:00
Ulf Lamping
dcdda03610 update to the latest PROTINET changes:
- add SubFrameBlock dissection
- add subframe heuristics and dissection
- update frame id "layout"
- raise plugin version to 0.2.4

crc16 algorithm copied from Linux sources (GPL V2 only!)

svn path=/trunk/; revision=27748
2009-03-16 21:40:00 +00:00
Gerald Combs
be943c8419 Go a little deeper into the Win64 rabbit-hole. Add tools/native-nmake.cmd
and use it as a wrapper to compile a native version of lemon.
Untested on Win32.

svn path=/trunk/; revision=27734
2009-03-15 22:40:29 +00:00
Gerald Combs
57dadc4664 More Windows compiler flag cleanups. Fix a problem with my last commit
that would break compilation for older compilers. Create a "DLL_LDFLAGS"
variable and use it in DLLs and plugins. Use PLUGIN_LDFLAGS and
DLL_LDFLAGS where needed. Don't force i386 code in the TPG plugin.

svn path=/trunk/; revision=27582
2009-03-02 21:33:11 +00:00
Gerald Combs
07e5df616e Disable manifest building for our DLLs. This attempts to fix bug 3272.
svn path=/trunk/; revision=27579
2009-03-02 18:57:35 +00:00
Jaap Keuter
ace93cb4bb From Robert Groenenberg:
As of version 0.99.8, there has been an annoying problem in the ASN.1 dissector: 
when using a 'type table' which discribes the ASN.1 syntax of the traced packets, 
wireshark would crash on the very first packet. The cause for the crash is an out-of-
boundry write, detected by g_free().

svn path=/trunk/; revision=27507
2009-02-22 12:22:28 +00:00
Jaap Keuter
23461c4382 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27506
2009-02-22 12:01:19 +00:00
Jaap Keuter
9da243b13c Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27505
2009-02-22 11:43:37 +00:00
Jaap Keuter
4683efcfe2 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27504
2009-02-22 11:25:16 +00:00
Jaap Keuter
80863f9568 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27503
2009-02-22 11:10:29 +00:00
Jaap Keuter
9fb248f1c0 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27502
2009-02-22 10:52:05 +00:00
Jaap Keuter
03bbd18a0b Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27501
2009-02-22 10:29:14 +00:00
Jaap Keuter
eb77f8a35e Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27500
2009-02-22 10:04:39 +00:00
Jaap Keuter
1948ad3985 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27499
2009-02-22 09:41:05 +00:00
Jaap Keuter
b171a36a4f Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27498
2009-02-22 09:24:27 +00:00
Jaap Keuter
56a1139bc0 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27497
2009-02-22 09:09:27 +00:00
Jaap Keuter
663f835c1e Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27496
2009-02-22 00:04:14 +00:00
Jaap Keuter
47f31f3f91 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27495
2009-02-21 22:22:16 +00:00
Jaap Keuter
715fd1d169 Incorporate plugin dissector into build in collection.
svn path=/trunk/; revision=27492
2009-02-21 20:22:40 +00:00
Jaap Keuter
60d78eefcf Update the documentation to reflect the current state of plugin development.
svn path=/trunk/; revision=27491
2009-02-21 16:33:48 +00:00
Jaap Keuter
cfd0be516b Rename source file to reflect Cisco specific protocol.
svn path=/trunk/; revision=27481
2009-02-18 07:46:28 +00:00
Jaap Keuter
56f631f9d0 Correct copyright statements.
svn path=/trunk/; revision=27480
2009-02-18 07:20:26 +00:00
Ulf Lamping
f904f42f9d Remove an ugly hack:
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created.

Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group.

svn path=/trunk/; revision=27407
2009-02-10 03:54:55 +00:00
Tomas Kukosa
79e68576f0 - remove reference to AMR (submitted by mistake)
- add new lines at the ends of headers
- fix struct usage

svn path=/trunk/; revision=27401
2009-02-09 12:54:40 +00:00
Stig Bjørlykke
863674322d From Peter Johansson:
Correct a misspelling.

svn path=/trunk/; revision=27399
2009-02-09 10:29:17 +00:00
Ulf Lamping
043532d63e add missing mt.exe calls, to include manifest files into exe / dll files
svn path=/trunk/; revision=27357
2009-02-02 23:09:36 +00:00
Guy Harris
2ba37de400 Fix uninitialized variable.
More indentation cleanups.

svn path=/trunk/; revision=27306
2009-01-26 23:48:10 +00:00
Guy Harris
248db0a42a Non-constant strings should not be used as format items; the format
should be "%s", with the string used as an argument, just in case the
string contains a "%" character.

Clean up indentation.

svn path=/trunk/; revision=27304
2009-01-26 22:58:47 +00:00
Ulf Lamping
f9e110d4cd fix a minor comment bug
svn path=/trunk/; revision=27299
2009-01-26 19:53:22 +00:00
Ulf Lamping
269cec3108 add some expert infos
svn path=/trunk/; revision=27298
2009-01-26 19:52:19 +00:00
Jaap Keuter
ba1cb8b69e Make the column check actually check the information column status.
svn path=/trunk/; revision=27224
2009-01-13 20:47:06 +00:00
Guy Harris
a2f9627d09 Fix the URL for the RLM stuff at Cisco.
Add some heuristics to the RLM LAPD-over-UDP dissector, so as not to
misdissect as many packets.

Fetch the LAPD dissector handle only once.

Change some Boolean arguments to gboolean from int.

svn path=/trunk/; revision=27217
2009-01-13 06:54:06 +00:00
Jaap Keuter
aa69531a1b From Didier Gautheron:
Add missing {0, NULL} tuples to value string declarations.

svn path=/trunk/; revision=27201
2009-01-09 07:39:13 +00:00
Jaap Keuter
013ab7897d Fix for bug 2902:
Remove global variables for packet information, pass these through function calls. 
Reduce label_SUB[M|A]_[Method|Attribute] routines.
Actually check column status before writing to it.

svn path=/trunk/; revision=27199
2009-01-08 20:40:08 +00:00
Jaap Keuter
4b6b4b672c Fix for bug 2902:
Actually check column status before writing to it.

svn path=/trunk/; revision=27192
2009-01-08 07:36:11 +00:00
Jeff Morriss
896b654b4a Don't look up the mtp3 dissector (twice) for every packet: do it once at
proto_reg_handoff time and store the result.

If we don't call the mtp3 dissector on the payload then call the data dissector
to make it easier to see the payload.

svn path=/trunk/; revision=27160
2009-01-05 20:37:04 +00:00
Anders Broman
f5bdbc6af9 Change install-plugins target to install plugins in "$(INSTALL_DIR)\plugins\$(VERSION)" instead.
svn path=/trunk/; revision=27124
2008-12-29 12:37:15 +00:00
Bill Meier
9a3563e807 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27085
2008-12-22 15:24:18 +00:00
Bill Meier
b3d131b43d Fixes for issues reported by Chris Maynard in bug #2813;
Also: fix a typo

svn path=/trunk/; revision=27082
2008-12-22 13:34:51 +00:00
Gerald Combs
6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs
fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Stig Bjørlykke
e4e7334be0 From Jim Young (bug 3105):
Trivial patch to change two C++ style comments to standard C style comments.

svn path=/trunk/; revision=26944
2008-12-09 13:42:00 +00:00
Ulf Lamping
4f46066fa0 add missing version check for new block
svn path=/trunk/; revision=26917
2008-12-04 21:26:35 +00:00
Ulf Lamping
6e0a9d6df0 add block dissections:
- PDIRBeginEndData
- PDIRData V1.1

svn path=/trunk/; revision=26916
2008-12-04 20:52:11 +00:00
Jörg Mayer
b719d7ac35 Unistim still eats the TAPA packets :-(
svn path=/trunk/; revision=26910
2008-12-04 09:31:44 +00:00
Jaap Keuter
f5b04f0124 From Don Newton:
Set default port of Unistim back to 5000; The Unistim dissector is made a heuristic dissector.

svn path=/trunk/; revision=26904
2008-12-02 23:02:32 +00:00
Jaap Keuter
7c65de9865 From Don Newton:
Flesh out call duration timer message.

svn path=/trunk/; revision=26898
2008-12-02 07:09:01 +00:00
Stig Bjørlykke
94e9e2b1ec Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Anders Broman
41671d662e From Marc Moussali:
Make it easier to add custom plugins.

svn path=/trunk/; revision=26627
2008-10-30 19:45:40 +00:00
Bill Meier
54b25b075a #include <emem.h>
svn path=/trunk/; revision=26602
2008-10-28 17:35:38 +00:00
Bill Meier
9c7e579d89 Minor cleanup for proto_register & proto_reg_handoff ...
svn path=/trunk/; revision=26601
2008-10-28 17:31:51 +00:00
Bill Meier
49a99b0fa0 proto_register & proto_reg_handoff related; remove unnecessary code ....
svn path=/trunk/; revision=26599
2008-10-28 15:04:44 +00:00
Bill Meier
278b32d71f Minor cleanup related to proto_register/proto_reg_handoff ...
svn path=/trunk/; revision=26596
2008-10-28 00:29:15 +00:00
Bill Meier
05c1929f1d proto_register/proto_reg_handoff; Various small cleanup and bug-fixing
remove unnecessary #include prefs.f and emem.h in a few cases...

svn path=/trunk/; revision=26554
2008-10-25 20:24:31 +00:00
Stig Bjørlykke
e08522f0dd From Florian Lohoff (bug 2959):
rudp looks up the ciscosm dissector for every single packet. Make this a one
time in proto_handoff and use the dissector handle.

While at it - decode the checksum when there is one. An indicator is that the
header length has space for the checksum.

Additionally we have seen "stray bytes" after the checksum we can't explain. So
decode them as data when there are some.

svn path=/trunk/; revision=26427
2008-10-13 12:55:16 +00:00
Guy Harris
ef51ff82fb Get one more pointer difference.
svn path=/trunk/; revision=26163
2008-09-07 17:49:03 +00:00
Guy Harris
bdec87026c To compute the difference between two addresses, cast the pointers
holding those addresses to "void *" and then to "char *" (so we don't
get warnings from casting directly to "char *" or errors from
subtracting two "void *"s), and subtract them, rather than casting the
pointers to an integral type possibly shorter than the pointers (to
avoid warnings and to avoid the admittedly-infinitesimal chance that the
two pointers don't differ in the bits that fit into the integral type).

svn path=/trunk/; revision=26151
2008-09-06 18:27:33 +00:00
Guy Harris
768b822f9b Use GINT_TO_POINTER() to cast integral values to gpointer in
g_hash_table_lookup() calls, in the hopes of suppressing warnings on
platforms with 32-bit ints and 64-bit pointers.

svn path=/trunk/; revision=26149
2008-09-06 17:27:20 +00:00
Bill Meier
a3a9ff5a2b #include <prefs.h> not required
svn path=/trunk/; revision=26103
2008-08-29 01:40:32 +00:00
Bill Meier
4aa1788a3b #include <emem.h> not req'd
svn path=/trunk/; revision=26095
2008-08-26 03:19:29 +00:00
Jaap Keuter
677ce2b209 From Frank Wang:
dl-map decoder error when decode HARQ_DLMAP_IE and normal IE.

svn path=/trunk/; revision=26020
2008-08-14 18:05:18 +00:00
Luis Ontanon
42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Martin Mathieson
ad16b7b403 Declare next_tvb volatile. This prevents the warning:
packet-infiniband.c:806: warning: variable 'next_tvb' might be clobbered by `longjmp' or `vfork'

seen with gcc 3.4.6 (building for 32-bits on a pentium 4).

svn path=/trunk/; revision=25916
2008-08-04 16:36:16 +00:00
Anders Broman
e2070d0efb From Stephen Donnelly:
Fences incorrectly set in source/destination columns in IB plugin.

svn path=/trunk/; revision=25880
2008-07-31 09:08:13 +00:00
Guy Harris
476c61472a No C++ comments - some compilers don't allow them (at least not by default).
svn path=/trunk/; revision=25878
2008-07-30 19:11:28 +00:00
Anders Broman
de0ca39861 From Stephen Donnelly:
Infiniband Dissector Plugin 1.2.0

svn path=/trunk/; revision=25876
2008-07-30 15:47:11 +00:00
Anders Broman
c954861fe5 From Bruno Verstuyft:
DOCSIS3.0 support in wireshark (MDD, REG-REQ-MP, REG-RSP-MP)

svn path=/trunk/; revision=25875
2008-07-30 15:13:12 +00:00
Jeff Morriss
688abd6e54 Fix checkapi target for the plugins
svn path=/trunk/; revision=25864
2008-07-29 23:16:04 +00:00
Jeff Morriss
b4d2c37635 Allow checkapis target to work in out-of-tree builds (s#../../#$(top_srcdir)).
Also use $(top_builddir) instead of ../../ in a couple of other spots.

svn path=/trunk/; revision=25863
2008-07-29 22:06:37 +00:00
Martin Mathieson
7921dca80d Fix DLMAP UL_interference_and_noise_level_IE decode error (bug 2737).
From Frank Wang.

svn path=/trunk/; revision=25816
2008-07-24 08:53:14 +00:00
Martin Mathieson
9c34677453 Fix HARQ_ULMAP_IE decoder padding error (bug 2738).
From Frank Wang.

svn path=/trunk/; revision=25815
2008-07-24 08:46:13 +00:00
Martin Mathieson
56455be25a This file predominantly uses spaces, so remove tabs that were making
indentation look wrong in my editor.


svn path=/trunk/; revision=25805
2008-07-23 14:32:24 +00:00
Martin Mathieson
ee1534f851 Fix bug 2663 (DLMAP HAEQ_DLMAP_UE decode error).
From Frank Wang.

svn path=/trunk/; revision=25801
2008-07-23 11:18:33 +00:00
Bill Meier
e2e72c7664 Add NULL termination element to value_string arrays
svn path=/trunk/; revision=25799
2008-07-22 21:53:50 +00:00
Bill Meier
f2fd24c9c0 Change C++ style comments to C style ...
svn path=/trunk/; revision=25762
2008-07-18 02:48:37 +00:00
Sake Blok
53bee63aa1 Oops... missed one ;
svn path=/trunk/; revision=25740
2008-07-14 21:02:30 +00:00
Sake Blok
03e0f71e8f From Richard Kuemmel (bug 2668):
Removed the line 
tvb_ensure_bytes_exist(tvb, offset, 44);
from  again. 
This is not correct, because the frame might have been captured before the
os added the padding bytes. E.g. in Windows the frames are captured on the
protocol layer. When another protocol driver sends a frame this frame does 
not include the padding bytes.  

Also the dataLength variable in case of bMox==TRUE  was not calculated
correctly.


svn path=/trunk/; revision=25738
2008-07-14 19:56:37 +00:00
Jeff Morriss
71c1e4faf0 Change the stats tree API to use signed chars instead of guint8s for all its
strings; this should fix a number of signed/unsigned char warnings.
Reindent a bunch, too.

svn path=/trunk/; revision=25716
2008-07-11 21:13:39 +00:00
Jaap Keuter
77c287a58c From Frank Wang:
The ULMAP decoder can get a wrong bit offset when decoding CQICH_Alloc_IE.
The finishing position shoud not pad to byte but pad to the length specified,
which can be nibble aligned.

svn path=/trunk/; revision=25703
2008-07-11 16:03:06 +00:00
Martin Mathieson
5283264092 Fix bug 2662 (ULMAP HARQ_ULMAP_IE decode error).
From Frank Wang.

I'd prefer to delete wrong code, but we'll see if anyone misses it.















svn path=/trunk/; revision=25675
2008-07-08 16:05:41 +00:00
Guy Harris
a04774395f Add Makefile.common files for epan/dfilter and epan/ftypes.
Add checkapi rules to Makefile.am files.

svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Guy Harris
40773753ad Get rid of a misleading comment (it says "no need to modify anything
under here", right above a comment that tells you what you need to
modify under there...).

svn path=/trunk/; revision=25655
2008-07-02 01:43:50 +00:00
Guy Harris
b6e20d89be Put printf into a separate "termoutput" API group. For most files,
check for it - but not for TShark plugins, as they are expected to
print to the standard output.

svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
Gerald Combs
83aacf0a09 Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.

svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
Martin Mathieson
7001a1564b For for compressed DLMAP decode error.
From Frank Wang (bug 2640).

svn path=/trunk/; revision=25599
2008-06-25 08:54:22 +00:00
Martin Mathieson
4aa522855d Make sure info column is set correctly when tree == NULL.
Fixes but 2561.













svn path=/trunk/; revision=25530
2008-06-23 13:02:50 +00:00
Martin Mathieson
d2036aca8a Try again to get labels matching function names.
svn path=/trunk/; revision=25529
2008-06-23 10:08:13 +00:00
Martin Mathieson
8d053ee86d Fix wimax UL-MAP ext IE decode error.
From Frank Wang (bug 2548).











svn path=/trunk/; revision=25528
2008-06-23 09:24:32 +00:00
Martin Mathieson
89ed3a03bb Wimax: support TLV type 48 in REG-REQ/REG-RSP.
From cfreeer, fixes bug 2571.










svn path=/trunk/; revision=25495
2008-06-20 15:55:32 +00:00
Martin Mathieson
2cddcc6b58 Fix wimax encoding err when packing subheader present.
From Frank Wang, fixes bug 2570.









svn path=/trunk/; revision=25494
2008-06-20 10:26:18 +00:00
Martin Mathieson
5da0fe48b0 Support TLV type 36 in wimax plugin.
From cfreeer (fix for bug 2569).








svn path=/trunk/; revision=25493
2008-06-20 10:17:13 +00:00
Ulf Lamping
bd8528644e fix BlockError strings
svn path=/trunk/; revision=25490
2008-06-19 18:44:23 +00:00
Bill Meier
9a53920530 Do plugins Checkapi only if the checkapi target is explicitly invoked.
svn path=/trunk/; revision=25382
2008-05-27 02:14:14 +00:00
Martin Mathieson
03d7032acd Show ops, etc even when no filter set.
Also avoid crash I was seeing when changing preferences.

svn path=/trunk/; revision=25379
2008-05-26 08:22:33 +00:00
Jaap Keuter
ab26f8d8a3 From cfreeer:
Wimax vals_tek_encryption_ids does not confirm the latest spec. Zero should be
"No TEK encryption" instead of "Reserved".

svn path=/trunk/; revision=25367
2008-05-23 05:36:09 +00:00
Jeff Morriss
a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Stig Bjørlykke
d1208e55e1 Initialize aitem.
svn path=/trunk/; revision=25302
2008-05-14 11:02:39 +00:00
Tomas Kukosa
1e82573549 fix missing brackets causing uninitialized hidden_item
svn path=/trunk/; revision=25300
2008-05-14 10:48:59 +00:00
Tomas Kukosa
19c327d160 From Anders Broman:
Patches for broken build

svn path=/trunk/; revision=25298
2008-05-14 10:21:41 +00:00
Stig Bjørlykke
38011c53da From cfreeer (bug 2541):
Add tlv_tree for PKM_FLOW_CONTROL and MAX_SUPPT_SECURITY_ASSNS.

svn path=/trunk/; revision=25297
2008-05-14 08:46:47 +00:00
Stig Bjørlykke
fe1738c394 From cfreeer (bug 2540):
Corrected use of hf_snp_auth_policy_support.

svn path=/trunk/; revision=25296
2008-05-14 08:38:58 +00:00
Jaap Keuter
9b0b67d6bb From cfreeer:
The offset need to be increased while decoding.

svn path=/trunk/; revision=25292
2008-05-14 05:52:32 +00:00
Anders Broman
d22975841b Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25283
2008-05-13 06:55:45 +00:00
Bill Meier
fe5c2d9820 g_string_sprintf --> g_string_printf and g_string_sprintfa --> g_string_append_printf
svn path=/trunk/; revision=25276
2008-05-11 18:33:49 +00:00
Jaap Keuter
cacee64927 From Hans-Peter Bock:
Attached to this post you find a patch for integration into wireshark that adds
a dissector for SERCOS III, ethertype 0x88cd.

svn path=/trunk/; revision=25270
2008-05-10 14:44:32 +00:00
Anders Broman
8db8e90221 Use PROTO_ITEM_SET_HIDDEN().
Fix ID marking
Add checkapi to makefiles

svn path=/trunk/; revision=25260
2008-05-09 07:07:50 +00:00
Anders Broman
db6d0b9a4c Run checkAPI in plugins dir.
svn path=/trunk/; revision=25259
2008-05-08 18:24:08 +00:00
Anders Broman
bc12adaf1b Add Id tag.
svn path=/trunk/; revision=25236
2008-05-05 19:06:31 +00:00
Anders Broman
ad890397cc Don't use proto_tree_add_item_hidden().
svn path=/trunk/; revision=25235
2008-05-05 18:58:53 +00:00
Anders Broman
57ebbbbb2c Dount use proto_tree_add_item_hidden().
svn path=/trunk/; revision=25233
2008-05-05 17:19:51 +00:00
Anders Broman
023a81709a Make it possible to run checkapi on all plugins trough makefile.nmake
Note: Commented out in the plugins giving errors for now.

svn path=/trunk/; revision=25231
2008-05-05 16:55:19 +00:00
Jaap Keuter
40b433984b Now with EAP dissector safety valve.
svn path=/trunk/; revision=25204
2008-04-30 10:59:48 +00:00
Jaap Keuter
6e9d862cd8 From cfreeer:
There is no EAP decoder to decode EAP messages packed in Wimax PKM messages. 
I called the EAP decoder found in the Wireshark.

svn path=/trunk/; revision=25203
2008-04-30 09:15:50 +00:00
Bill Meier
2bce8b248c Bug 2493: Fix (Part 3 of 3):
To prevent Windows compiler errors when using flex 2.5.35.
  Ignore 'signed /unsigned mismatch' warnings


svn path=/trunk/; revision=25174
2008-04-25 18:26:54 +00:00
Bill Meier
0d4b874b44 Bug 2493: Fix (Part 2):
To prevent Windows compiler errors when using flex 2.5.35.
 Fixes "missing unistd.h" and yywrap "mismatched parameter" warnings
 [Upcoming Part 3: ignore 'signed /unsigned mismatch' errors]

svn path=/trunk/; revision=25173
2008-04-25 17:40:29 +00:00
Stig Bjørlykke
b472360c7d From Mohan (bug 2501):
Add a missing break statement.

svn path=/trunk/; revision=25168
2008-04-24 21:51:14 +00:00
Jaap Keuter
81db026301 Fix for bug 2475:
Add a preference to the UNISTIM dissector so that you can set the default port back to 5000, even though this conflicts with other dissectors.

svn path=/trunk/; revision=25118
2008-04-19 10:41:45 +00:00
Jörg Mayer
abaea4e100 The generated code warns about 'input' being unused. -Werror turns this into a failure
svn path=/trunk/; revision=25027
2008-04-14 21:29:29 +00:00
Jörg Mayer
46efef6b04 Get rid of some unused functions to prevent -Werror from causing the compile to fail
svn path=/trunk/; revision=25026
2008-04-14 21:24:12 +00:00
Ulf Lamping
b3d55eb095 clarify the stats_tree menu items
svn path=/trunk/; revision=25009
2008-04-14 01:11:07 +00:00
Ulf Lamping
8b4f26afc6 fix the Win32 build: tfs_yes_no -> tfs_yes_no_sbc
svn path=/trunk/; revision=24840
2008-04-08 03:50:44 +00:00
Jaap Keuter
b3e4a7bb02 Fix for bug 2401:
Repair header field type definitions, based on a patch from Chris Yang.

svn path=/trunk/; revision=24839
2008-04-07 22:46:50 +00:00
Stephen Fisher
726a1caaf1 - Remove GLIB1 code
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
  g_strsplit code for the no longer supported GLIB1 builds


svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
Stephen Fisher
13802b1d84 Remove GTK1 code.
svn path=/trunk/; revision=24827
2008-04-07 04:34:54 +00:00
Martin Mathieson
50ea8167c1 Make wimax mac mgmt protocol findable by name.
Bug 2409.

svn path=/trunk/; revision=24782
2008-04-05 05:04:14 +00:00
Martin Mathieson
88744abd6f Don't load in files unless tree is set.
If a user wants to load or capture quickly, they won't want to wait
for the file to be processed after the first frame.

svn path=/trunk/; revision=24781
2008-04-05 04:48:36 +00:00
Martin Mathieson
4cfefcc5a4 Use proto_register_prefix() with wimaxasncp plugin.
Also fix a crash problem seen with no filters (i.e. NULL tree).

svn path=/trunk/; revision=24767
2008-04-04 05:38:13 +00:00
Jaap Keuter
b704bdcbc5 Remove the pre-release flag from FILEFLAGS in the resource file.
svn path=/trunk/; revision=24757
2008-03-29 23:04:33 +00:00
Anders Broman
1a2b14d60c In glib 2.16 g_malloc Changed from:
- gpointer g_malloc         (gulong	 n_bytes) G_GNUC_MALLOC;
to:
+ gpointer g_malloc         (gsize	 n_bytes) G_GNUC_MALLOC;

svn path=/trunk/; revision=24710
2008-03-21 16:10:47 +00:00
Gerald Combs
121e3d432e Try to fix distcheck again.
svn path=/trunk/; revision=24637
2008-03-15 00:21:02 +00:00
Gerald Combs
b1bd2972ff Fix distcheck.
svn path=/trunk/; revision=24636
2008-03-14 23:43:35 +00:00
Gerald Combs
7519d12f8f Make sure the Infiniband plugin is properly built and packaged.
svn path=/trunk/; revision=24634
2008-03-14 21:53:16 +00:00
Stig Bjørlykke
5d9ca601d8 Added missing Id keywords, eol-style and ignore targets.
svn path=/trunk/; revision=24632
2008-03-14 19:48:49 +00:00
Stig Bjørlykke
3351980a29 Make infiniband plugin compile.
svn path=/trunk/; revision=24631
2008-03-14 19:35:54 +00:00
Gerald Combs
68d23708bc From Stephen Donnelly via bug 2235:
This plugin implements a dissector for Infiniband. It is released 
under the GPL v2.

Rather than using say libpcap to capture raw (unframed) IP packets 
from near the top of an IPoIB stack, this plugin dissects link level
Infiniband frames.

Infiniband trace files can be read from Endace ERF format trace 
files, or from libpcap DLT_ERF files containing ERF TYPE_INFINIBAND 
records. There is currently no native DLT_INFINIBAND in libpcap.

Each record contains a hardware timestamp, capture metadata such as 
port Id, and a complete link level Infiniband frame starting from
the Local Route Header.

svn path=/trunk/; revision=24628
2008-03-14 17:47:53 +00:00
Jörg Mayer
dc6789a84f Set default port of Unistim from 5000 to 0: It grabs the TAPA
packets that I need.
The Unistim dissector should be made a heuristic dissector that
is willing to coexist with other dissectors. Until such a time
the port should remain 0.

svn path=/trunk/; revision=24573
2008-03-06 12:54:08 +00:00
Stephen Fisher
9ef2001f7b Fix the declaration of a true_false_string
svn path=/trunk/; revision=24572
2008-03-05 22:28:51 +00:00
Anders Broman
7a5b90df34 From Peter Johansson :
Support for EtherCAT subdissectors.

svn path=/trunk/; revision=24566
2008-03-05 20:42:58 +00:00
Jaap Keuter
fcf8509f69 Create proper dependancies for plugin.c
svn path=/trunk/; revision=24520
2008-03-01 12:31:01 +00:00
Stig Bjørlykke
fc5527ef6c Quote argument to test in plugins Makefiles, as proposed by Greg A. Woods.
svn path=/trunk/; revision=24488
2008-02-27 16:18:30 +00:00