osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

From Robert Groenenberg: 

As of version 0.99.8, there has been an annoying problem in the ASN.1 dissector: 
when using a 'type table' which discribes the ASN.1 syntax of the traced packets, 
wireshark would crash on the very first packet. The cause for the crash is an out-of-
boundry write, detected by g_free().

svn path=/trunk/; revision=27507
This commit is contained in:
Jaap Keuter 2009-02-22 12:22:28 +00:00
parent 23461c4382
commit ace93cb4bb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/asn1/packet-asn1.c
View File

@ -566,7 +566,7 @@ showoctets(guchar *octets, guint len, guint hexlen) /* if len <= hexlen, always
for (i=0; i<len; i++) {
p += g_sprintf(p, "%2.2X", octets[i]);
}
strncpy(p, endstr, len*2 + 5);
strncpy(p, endstr, 5);
} else {
if (len <= hexlen) { /* show both hex and ascii, assume hexlen < MAX_OTSLEN */
str = p = g_malloc(len*3+2);