Commit Graph

33 Commits

Author SHA1 Message Date
Chris Maynard 764cb1f99a Fix Coverity CID 719419: Dereference after null check.
svn path=/trunk/; revision=47932
2013-02-28 03:15:57 +00:00
Chris Maynard f05cc88f6f Don't bother to check if cdata is NULL; it has already been dereferenced.
Fixes Coverity CID 719420: Dereference before null check.

svn path=/trunk/; revision=45741
2012-10-23 21:00:34 +00:00
Chris Maynard bbfa21cc02 Don't mark used arguments with _U_. Whitespace: tabs -> spaces.
svn path=/trunk/; revision=45639
2012-10-18 18:03:04 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Ronnie Sahlberg b9d4af9675 SCSI: lots of MMC improvements and prettifications
svn path=/trunk/; revision=44745
2012-09-02 21:46:50 +00:00
Ronnie Sahlberg fb44903de7 SCSI: Improve decoding of GET_EVENT_STATUS_NOTIFICATION
svn path=/trunk/; revision=44744
2012-09-02 20:02:29 +00:00
Michael Mann 32ef0a1a18 Converted scsi dissectors display filter format from scsi.<protocol> to scsi_<protocol> (matching their registered filter name)
svn path=/trunk/; revision=43993
2012-07-25 13:56:15 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier 54b72021bb Fix encoding arg for various fcn calls:
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
Bill Meier 6d96a16932 Fix a few proto_tree_add_item() encoding args manually.
Some whitespace cleanup.

svn path=/trunk/; revision=39507
2011-10-21 14:33:43 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier 67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Chris Maynard c0565d8936 Improve dissection of bit-oriented fields. Patch from Richard Sharpe via
bug #5466 with some minor whitespace modifications from me and a fix of an
invalid offset introduced with the patch.  Fuzz testing still needs to be done.
I can't seem to get the fuzz tester to work with the capture files attached to
the bug report. 

svn path=/trunk/; revision=35137
2010-12-06 22:00:08 +00:00
Bill Meier 03b57df5a0 Fix various typos and spelling errors.
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Bill Meier 055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Stig Bjørlykke ab3e4adf8b Removed an unused variable.
svn path=/trunk/; revision=30904
2009-11-09 15:43:25 +00:00
Ronnie Sahlberg 3e5715008e add the name ModeSense6 to the list of known opcodes for mmc
svn path=/trunk/; revision=30207
2009-09-30 07:47:47 +00:00
Ronnie Sahlberg 06d5136beb Add initial support to decode the ADIP and PhysicalInformation for MMC
media


svn path=/trunk/; revision=29669
2009-09-02 17:24:52 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier 33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Bill Meier b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Bill Meier 77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Ronnie Sahlberg 22fe177634 add dissection of scsi/mmc close track (and fix a bug)
svn path=/trunk/; revision=24917
2008-04-11 23:14:22 +00:00
Sebastien Tandel 75d1cac3a9 ultimate declaration of a volatile variable to let gcc-3.4 happy.
svn path=/trunk/; revision=21414
2007-04-13 18:08:27 +00:00
Sebastien Tandel a7615a1afb another attempt to let windows buildbot becoming green
fix rev21398 (gcc warning fix)

svn path=/trunk/; revision=21412
2007-04-13 17:16:24 +00:00
Sebastien Tandel 42791e157b use of volatile for every functions and not only the ones using the Exception
mechanisms. (fix rev21398)

Windows buildbot sould be green again as formal parameters are the same as the
ones in the declaration now.

svn path=/trunk/; revision=21409
2007-04-13 15:23:47 +00:00
Stephen Fisher f002ac6db5 Fix various warnings
Move packet-cops.c out of clean dissectors due to a #define conflict
in the headers of net-snmp with our config.h


svn path=/trunk/; revision=21398
2007-04-13 00:50:23 +00:00
Ronnie Sahlberg f6f95ea6a0 remove the revision number from the spc symbols
change all spc2 and spc3 to spc



svn path=/trunk/; revision=20779
2007-02-11 00:45:15 +00:00
Ronnie Sahlberg 34824cb310 change all sbc2 references into sbc
svn path=/trunk/; revision=20100
2006-12-10 13:52:30 +00:00
Ronnie Sahlberg f53a3fb764 fixup WRITE 6,10,12,16
svn path=/trunk/; revision=20097
2006-12-10 12:01:36 +00:00
Ronnie Sahlberg 3dca5cbed9 break the SCSI SBC commandset out into its own dissector
svn path=/trunk/; revision=20000
2006-11-27 11:00:06 +00:00
Ronnie Sahlberg c0cccf43c2 start splitting the monolitic scsi dissector up into commandset dissectors
split the MMC commandset out of the main scsi dissector



svn path=/trunk/; revision=19738
2006-10-30 12:18:29 +00:00