osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Don't bother to check if cdata is NULL; it has already been dereferenced. 

Fixes Coverity CID 719420: Dereference before null check.

svn path=/trunk/; revision=45741
This commit is contained in:
Chris Maynard 2012-10-23 21:00:34 +00:00
parent c9b7d8c3c2
commit f05cc88f6f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-scsi-mmc.c
View File

@ -585,9 +585,7 @@ dissect_mmc4_readtocpmaatip (tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree
}
proto_tree_add_item (tree, hf_scsi_alloclen16, tvb, offset + 6, 2, ENC_BIG_ENDIAN);
if (cdata) {
cdata->itlq->alloc_len = tvb_get_ntohs(tvb, offset + 6);
}
cdata->itlq->alloc_len = tvb_get_ntohs(tvb, offset + 6);
proto_tree_add_bitmask(tree, tvb, offset+8, hf_scsi_control,
ett_scsi_control, cdb_control_fields, ENC_BIG_ENDIAN);