Commit Graph

84794 Commits

Author SHA1 Message Date
Alexis La Goutte f70546d111 radiotap-gen: Fix -Wmissing-prototypes
radiotap-gen.c:65:6: warning: no previous prototype for function 'gen_u_sig_pkts'
2022-07-15 13:45:52 +00:00
Alexis La Goutte b68acb6bff pcre2: Fix -Wmissing-prototypes
lpcre2.c:506:13: warning: no previous prototype for function 'luaopen_rex_pcre2'
lpcre2_f.c:207:5: warning: no previous prototype for function 'Lpcre2_config'
lpcre2_f.c:234:5: warning: no previous prototype for function 'Lpcre2_get_flags'
2022-07-15 13:45:52 +00:00
Alexis La Goutte 1ca19b3c38 Fix -Wmissing-prototypes found by Clang
ftype-double.c:89:1: warning: no previous prototype for function 'val_unary_minus'
ftype-double.c:96:1: warning: no previous prototype for function 'val_add'
ftype-double.c:103:1: warning: no previous prototype for function 'val_subtract'
ftype-double.c:110:1: warning: no previous prototype for function 'val_multiply'
ftype-double.c:117:1: warning: no previous prototype for function 'val_divide'
ftype-integer.c:670:1: warning: no previous prototype for function 'uint_bitwise_and'
ftype-integer.c:677:1: warning: no previous prototype for function 'uint_is_zero'
ftype-integer.c:683:1: warning: no previous prototype for function 'uint_is_negative'
ftype-integer.c:689:1: warning: no previous prototype for function 'uint_unary_minus'
ftype-integer.c:704:1: warning: no previous prototype for function 'uint64_bitwise_and'
ftype-integer.c:711:1: warning: no previous prototype for function 'uint64_is_zero'
ftype-integer.c:717:1: warning: no previous prototype for function 'uint64_is_negative'
ftype-integer.c:723:1: warning: no previous prototype for function 'uint64_unary_minus'
ftype-integer.c:738:1: warning: no previous prototype for function 'sint_bitwise_and'
ftype-integer.c:745:1: warning: no previous prototype for function 'sint_is_zero'
ftype-integer.c:751:1: warning: no previous prototype for function 'sint_is_negative'
ftype-integer.c:757:1: warning: no previous prototype for function 'sint_unary_minus
ftype-integer.c:764:1: warning: no previous prototype for function 'sint64_bitwise_and'
ftype-integer.c:771:1: warning: no previous prototype for function 'sint64_is_zero'
ftype-integer.c:777:1: warning: no previous prototype for function 'sint64_is_negative'
ftype-integer.c:783:1: warning: no previous prototype for function 'sint64_unary_minus'
packet-bpv6.c:2182:1: warning: no previous prototype for function 'proto_register_bpv6'
packet-bpv6.c:2766:1: warning: no previous prototype for function 'proto_reg_handoff_bpv6'
packet-bpv7.c:1978:6: warning: no previous prototype for function 'proto_register_bpv7'
packet-bpv7.c:2037:6: warning: no previous prototype for function 'proto_reg_handoff_bpv7'
packet-realtek.c:349:1: warning: no previous prototype for function 'proto_register_realtek'
packet-realtek.c:436:1: warning: no previous prototype for function 'proto_reg_handoff_realtek'
packet-tcpcl.c:2147:1: warning: no previous prototype for function 'proto_register_tcpclv3'
packet-tcpcl.c:2211:1: warning: no previous prototype for function 'proto_reg_handoff_tcpclv3'
2022-07-15 13:45:52 +00:00
easonweii 52ddd86929 BGP: Fix dissector bug when BGP Update packets containing BGP Flowspec updates
Add support for BGP Update packets containing BGP Flowspec updates
Fixs #18198
2022-07-15 13:28:56 +00:00
Guy Harris f15b7b0ccc proto: fix proto_tree_add_bitmask_list_ret_uint64 to always return a value.
A "proto_tree_add..._ret_..." routine *must* return the value through
the pointer, even if no protocol tree is being built, as there's no
guarantee that a protocol tree will be built under all circumstances
(for example, if the dissection is only being done to generate the
column values, no column is a custom column, there are no coloring
rules, etc., so that none of the named field values are of interest, and
the protocol tree isn't going to be displayed, no protocol tree will be
built).

Fixes #18203.
2022-07-15 00:24:58 -07:00
João Valverde 7bea636cd4 WSUG: Add display filter arithmetic operators 2022-07-15 00:11:38 +01:00
João Valverde 97ce9845c3 WSUG: Fix a heading level 2022-07-14 23:36:39 +01:00
João Valverde d5ec420bb5 WSUG: Add a note about the changes to "!=" 2022-07-14 23:29:08 +01:00
João Valverde 4c975b770e dfilter: Improve compatibility of integer types
Before:

$ dftest '_ws.ftypes.int64 == _ws.ftypes.int8'
Filter: _ws.ftypes.int64 == _ws.ftypes.int8
dftest: _ws.ftypes.int64 and _ws.ftypes.int8 are not of compatible types.
	_ws.ftypes.int64 == _ws.ftypes.int8
	                    ^~~~~~~~~~~~~~~

After:

$ dftest '_ws.ftypes.int64 == _ws.ftypes.int8'
Filter: _ws.ftypes.int64 == _ws.ftypes.int8

Syntax tree:
 0 TEST_ANY_EQ:
   1 FIELD(_ws.ftypes.int64 <FT_INT64>)
   1 FIELD(_ws.ftypes.int8 <FT_INT8>)

Instructions:
00000 READ_TREE		_ws.ftypes.int64 <FT_INT64> -> reg#0
00001 IF_FALSE_GOTO	5
00002 READ_TREE		_ws.ftypes.int8 <FT_INT8> -> reg#1
00003 IF_FALSE_GOTO	5
00004 ANY_EQ		reg#0 === reg#1
00005 RETURN
2022-07-14 20:12:30 +00:00
msweant 53dcf53ae5 EAP: Encrypted IMSI Memory Bug
Added complete CertificateSerialNumber string match
logic to prevent malformed strings.  Added ASCII compliance
check prior to identity parsing and expert info warning.  Added
3GPP realm string matching logic to optional Realm token in Encr.
IMSI identities.

Closes #18129.
2022-07-14 19:18:45 +00:00
Aeneas Jaißle f5d997fd2d PPPoE: add TLV 0x90 value 0x03 "Double-tagged Ethernet", fix typo in "Encaps 2" 2022-07-14 16:07:45 +00:00
Alexis La Goutte 61f433406f thrift: Fix -Wdocumentation
packet-thrift.h:118:15: warning: parameter 'thrift_opt' not found in the function declaration
packet-thrift.h:119:15: warning: parameter 'is_field' not found in the function declaration
packet-thrift.h:121:15: warning: parameter 'field_id' not found in the function declaration
packet-thrift.h:122:15: warning: parameter 'hf_id' not found in the function declaration
packet-thrift.h:124:15: warning: parameter 'encoding' not found in the function declaration
packet-thrift.h:167:15: warning: parameter 'elt' not found in the function declaration
packet-thrift.h:169:15: warning: parameter 'seq' not found in the function declaration
2022-07-14 15:45:14 +00:00
Alexis La Goutte 134809fd80 bpv7: fix -Wdocumentation
packet-bpv7.c:483:11: warning: parameter 'obj' not found in the function declaration
2022-07-14 15:45:14 +00:00
Joakim Karlsson bf8577b88c pfcp: change to utilize proto_tree_add_bitmask_list 2022-07-14 12:46:09 +00:00
Alexis La Goutte b97556fabf ebhscr: Fix conflict
'ebhscr.lin.wakeup' exists multiple times with incompatible types: FT_UINT64 and FT_BOOLEAN
2022-07-14 11:13:54 +00:00
Alexis La Goutte f70e58a2eb erldp: fix conflict
'erldp.big_ext_str' exists multiple times with incompatible types: FT_BYTES and FT_STRING
2022-07-14 11:13:54 +00:00
Alexis La Goutte 204916c390 gsm_file: fix duplicate entry
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 24380 is at indices 72 (DF.MExE) and 78 (DF.MexE)
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 24384 is at indices 73 (DF.EIA/TIA-533) and 80 (DF.WLAN)
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 20233 is at indices 194 (EF.EFSUPI_NAI) and 198 (EF.PBC)
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string: 20234 is at indices 195 (EF.Routing_Indicator) and 199 (EF.PBC1)
2022-07-14 11:13:54 +00:00
Alexis La Goutte 19bc326f1b erldp: Fix duplicate entry
Field 'Tag' (erldp.etf_tag) has a conflicting entry in its value_string: 70 is at indices 12 (NEW_FLOAT_EXT) and 29 (DIST_FRAG_CONT)
2022-07-14 11:13:54 +00:00
Alexis La Goutte 1ff01f18bb ieee802154: fix duplicate entry
Field 'Id' (wpan.header_ie.id) has a conflicting entry in its value_string: 29 is at indices 2 (RendezVous Time IE) and 5 (Rendezvous Time IE)
2022-07-14 11:13:54 +00:00
Kaige Ye a89696dc2d MySQL: support CLIENT_QUERY_ATTRIBUTES capability 2022-07-14 10:32:29 +00:00
Joakim Karlsson edab806981 pfcp: correction of UP Function Features IE 2022-07-14 09:32:07 +02:00
João Valverde a28a3150fd Update display filter bookmark examples
Write inequalities more clearly and naturally. Remove obsolete
admonition.

Rewrite DNS examples to be more pedagogical to avoid conflating
ports with protocols.
2022-07-13 22:48:17 +00:00
João Valverde d594743e4b dfilter: Fix "private_ethernet" macro
The macro expression is invalid because of the range used and looks
a bit wrong.

Use a simpler expression that should match the intended meaning,
filtering for unicast addresses with the U/L bit equal to 1.
2022-07-13 22:48:17 +00:00
Roland Knall 06cd84a6e9 Qt: Recommend 5.12 and enforce 5.10
In order to phase out older versions, we recommed 5.12 as a
minimum Qt version going forward. Although build support for
5.10 and 5.11 is not being removed at this point, it might
be for 4.x at a later time.
2022-07-13 21:26:46 +00:00
Alexis La Goutte 32a4a08683 lapd: Fix Clang Analyzer warning
Access to field 'state' results in a dereference of a null pointer (loaded from variable 'ptr')
2022-07-13 20:55:49 +00:00
Alexis La Goutte 69ea1930a7 BGP: fix typo for EVPN Router's MAC (RFC9135)
Reported by Joe Neville => https://twitter.com/joeneville_/status/1544020405530279938
2022-07-13 18:59:56 +00:00
Roland Knall 64549654db ExtcapExample: Harden and alternate mac address
Harden the code a little and alternate the mac address to allow
the code to be used for testing conversation and endpoint dialog.

Also transmit integer values not as ascii representations and include
a data packet that allows for reassembly to be tested
2022-07-13 18:40:57 +00:00
Anders Broman 4ea0e5de83 IPv6: Configurable IPv6 NAT64 prefixes 2022-07-13 18:24:36 +00:00
Chuck Craft 4ff209e881 Qt: Edit->Preferences resets titlebar and statusBar to defaults
Caused by a LanguageChange event - similar to #16356 /
!689
Not sure if enough to close issue #12966
2022-07-13 18:08:22 +00:00
Uli Heilmeier 51bf87a641 WSUG: Fix typo 2022-07-13 16:45:00 +00:00
João Valverde f68f172454 dfilter: Remove a debug message
Still too noisy even with noisy level.
2022-07-13 16:06:28 +00:00
João Valverde 6c8a8d7960 dfilter: Fix dfvm code string
All/any equal have their own symbols for operators so cannot
be handled in the same switch case.

Other comparisons don't have different symbols for any/all.
2022-07-13 00:37:12 +01:00
Gerald Combs 84d230d878 Tools: Add Qt5Concurrent to rpm-setup.sh.
Qt5Concurrent needs to be explicitly installed on openSUSE.

[skip ci]
2022-07-12 17:31:25 +00:00
Dirk Römmen 5a3b7488d9 BACnet: Added new vendor ID's, fixed BACnet SC decodings.
New vendor ID's up to june 22, 2022 have been added.
Decoding of the optional description field in BACnet SC BVLC's has been fixed.
Decoding of the exteded event parameters has been fixed.
2022-07-12 17:13:58 +00:00
Adrian Granados 3c29458a46 ieee80211: Update VHT channel width interpretation as in IEEE Std 802.11-2020 2022-07-12 16:42:23 +00:00
Chuck Craft f99b056025 Qt: Supported Protocols search - increase debounce timeout
Increase the Qtimer value added in !3325 to allow human typing speed.
See !3328 for typing speed math.
2022-07-12 15:25:06 +00:00
Chuck Craft e12954a637 epan: ws_debug log for heuristic that claims frame (len != 0)
It's possible for a dissector to claim a frame without adding to
the tree or being added to frame.protocols (see !6669)
Log a debug message showing the pinfo layers and the dissector that
claimed the tvb (frame/packet).
2022-07-12 14:15:33 +00:00
John Thacker 8ac995578c epan: Respect custom column resolved/unresolved status everywhere
Add a function to get the column text of the nth column, taking
into account whether the column is resolved or unresolved. Use
this function in the GUI, as well as in tshark, when writing
PSML, exporting dissection to PSML, etc., instead of accessing
col_data directly.

This removes the direct accesses of col_data from outside
column.c and column-utils.c

Fix #18168.
2022-07-12 00:22:11 +00:00
Uli Heilmeier 58b29b8f74 tshark: Respect -Q option
Suppress non-error messages when -Q is set.

Fixes: #18186
2022-07-11 23:06:35 +00:00
Gerald Combs b91079d3a6 GitLab CI: Fixup our make-version calls.
Call make-version.py on Windows using py.exe. Call it directly on other
platforms.
2022-07-11 17:33:08 -05:00
Tomasz Moń 0438fca96b Qt: Concurrently fill display filter expression dialog
Use QtConcurrent to create and sort widget items. The dialog window is
immediately visible and usable. Search becomes available once all items
are added to the tree.

When compiled with Qt5, all items are added in bulk. Qt6 features new
QPromise interface that makes it possible to add tree items one by one.
2022-07-11 16:36:43 +00:00
Tomasz Moń fc85196f61 Qt: Do not spin event loops in display filter dialog
Pass comparator function so the list gets sorted alphabetically. Without
the comparator function, the pointer values were sorted. Insert already
sorted data into tree widget and thus remove the redundant sort call.

Use std::stable_sort() instead of std::sort() as stable sort is actually
faster here. The std::stable_sort() tends to do fewer comparisons and
more moves than std::sort(). When sorting QTreeWidgetItem pointers, the
move is very low cost (only the pointer itself is moved) and string
comparison is quite heavy (especially because the strings share common
prefix).
2022-07-11 16:36:43 +00:00
Dr. Lars Völker 868492fd2a Addr-Resolv: close vlans file on changing profile (BUGFIX)
Currently Wireshark does not close the vlans file on profile change.
This leads to major problems, when vlan resolution is turned on:
- Deleting a profile (not even selected) is not possible without exiting
  Wireshark.
- Switching from one profile with vlans to another with vlans, does
  not switch the resolution but stays on the names of the old profile!
2022-07-11 15:42:19 +00:00
Uli Heilmeier 0a6eae4df1 X509if: Increase MAX_RDN_STR_LEN to 128
Fixes: #18183
2022-07-11 15:07:09 +00:00
Moshe Kaplan 87ca8c227a tools: Port make-version.pl to Python 2022-07-11 14:44:23 +00:00
Guy Harris b53044ea16 Get CPU type strings from the OS if possible.
Instead of using an OS-independent and (somewhat) toolchain-independent,
but x86-only, mechanism to fetch a string that identifies the type(s) of
CPU on the machine, use OS-dependent but instruction-set-independent
mechanisms.

That way, we can get CPU type strings for non-x86 processors - ARM
processors, in particular, but others as well (yes, you can run
Wireshark on an IBM mainframe...).

Fixes #18187.
2022-07-10 13:17:52 -07:00
Gerald Combs d10253ebea [Automatic update for 2022-07-10]
Update manuf, services enterprise numbers, translations, and other items.
2022-07-10 18:42:22 +00:00
Roland Knall 885d6b7f73 wiretap: Fix urls in comments
The old ones are no longer valid and lead to 404
2022-07-10 16:05:30 +00:00
Tomasz Moń 75196b5103 Qt: Fix Qt 6.3 Visual Studio build
Since Qt 6.3 the /permissive- option is required as otherwise the
compilation fails on static assert:
  "On MSVC you must pass the /permissive- option to the compiler."
2022-07-10 14:47:49 +00:00
Dr. Lars Völker 298a46446a SOME/IP: Make uats much more robust against faulty configs (BUGFIX)
This patch improves the uat config checking for SOME/IP:
- detecting simple endless loops
- better error output on faulty configs
- using uat resets to fix crash on faulty configs
2022-07-10 11:38:04 +00:00