Commit Graph

84794 Commits

Author SHA1 Message Date
Gerald Combs a113fd5c7b wslua: Remove unneeded empty lines from our markup. 2022-07-21 15:36:35 -07:00
Chuck Craft 26e1d3cdb2 cmake: copy profiles output check
Extend directory path used for RELATIVE comparison.

Closes #18204
2022-07-21 21:31:54 +00:00
Chuck Craft 9f59cae607 wslua: tapinfo - add state to debug info; update wsluarm
Test wth:
for _,tap_name in pairs(Listener.list()) do
  foo1 = Listener.new(tap_name)
  print (foo1)
end
2022-07-21 21:17:36 +00:00
Alexis La Goutte 0ed87211da proto.h: Fix -Wdocumentation
proto.h:3004:9: warning: parameter 'return_value' not found in the function declaration [-Wdocumentation]
2022-07-21 21:01:25 +00:00
Jirka Novak 476eb0e627 RTP player: fixed issue with no audio card available in Qt6 2022-07-21 20:09:52 +00:00
Jirka Novak ea91c5785a Qt6: Audio code review
Changes:
- audio rates are fixed, I selected common ones
- fixed signal names - they didn't matched expected autogenerated ones
- first play notification delay on Qt6 compensated
2022-07-21 20:09:52 +00:00
Gerald Combs b8d85227f6 Qt: Update the RTP stream UI to support Qt6Multimedia.
Fixes #18115
2022-07-21 20:09:52 +00:00
João Valverde d2b6b89b94 Update license file structure and GUI display
Add the text of the GPLv2 in HTML, taken from the FSF website,
and use rich text to display the license in the GUI.

Move the introductory note about the GPL from the COPYING
license text file to the README.

Remove various other license callouts at the end of the COPYING file
as unnecessary and unhelpful. This information is present in
each source file, where it belongs.
2022-07-21 19:10:06 +00:00
Balint Reczey 924076ed29 GitLab CI: Fix format of DEB_BUILD_OPTIONS passed to the Ubuntu build 2022-07-21 18:03:56 +00:00
Balint Reczey 18b0c379a3 Fix handling of DEB_BUILD_OPTIONS=nocheck
Run tests when nocheck is not set in DEB_BUILD_OPTIONS and skip
tests and building tests when nocheck is set.

Also make the check's style in sync with the official Debian package.
2022-07-21 18:03:56 +00:00
Roland Knall 5991a75d78 ReleasNotes: Add minimum version requirements
Adding an explanation on minimum required versions to the release
notes, as well as bumping c-ares to version 1.14.0

The previous minimum (1.5.0) has been released in 2008. The new
version has been choosen to correlate with those distros, that
also provide a minimum version of Qt5 higher than 5.9, as 5.9
is no longer supported in the main branch
2022-07-21 12:37:17 +00:00
Roland Knall 1f3f41391c addr_resolv: Add port correctly
Add the port correctly if only one dns server is configured
2022-07-21 09:59:16 +00:00
Uli Heilmeier 73ecb86f4c rpm-setup.sh: Improve messages
Give more detailed information to the user which package
is missing.

Fixes: #18166
2022-07-21 06:37:21 +00:00
Gerald Combs fbadb8c785 wslua: Capitalize words in our markup.
Capitalize words in our markup instead of depending on make-wsluarm.pl.
Add a single space after "Mode:".
2022-07-20 14:52:40 -07:00
Nardi Ivan 897bc6d27c HTTP2: display the full request URI
Close #18135
2022-07-20 16:32:47 +00:00
Dr. Lars Völker cadcd7d261 Signal-PDU: Add Header Field for Signal PDU Name
This patch allows to filter on the name of the PDU as well as add a
column based on the names.
2022-07-20 16:15:19 +00:00
Eugène Adell 2068ec0f95 TCP: Fix conversation overlapping when reusing ports 2022-07-20 15:53:46 +00:00
Ferry Huberts cab1ae7794 Locamation Interface Module dissector: simplify the Windows build fix 2022-07-20 15:29:49 +00:00
Roland Knall 596c8e9095 Addr_resolv: Use int for ports 2022-07-20 14:49:34 +00:00
John Thacker 0b780341cb tls: Show reassembled in for the first fragment
Similar to TCP, properly display what frame a fragmented
TLS message was reassembled_in for the first fragment on
a second pass. Also similar to TCP, don't bother to add the
reassembled_in field for fragments that are reassembled
in the same frame.
2022-07-20 14:13:59 +00:00
John Thacker 3a57dd522b Use WS_ROUNDUP_4 in more dissectors
Several more dissectors define their own "round up the length
to a 4 byte word boundary" macros. Use the new common macro
in wsutil/ws_roundup.h instead.
2022-07-20 13:59:56 +00:00
Roland Knall bf89153aa0 addr_resolve: Allow for port to be configured
If nameservers use a different default port than 53, Wireshark
is not able to resolve, as it always assumes the default port.

This allows to configure both tcp/udp ports for name resolutions,
with the udp port being asked first and tcp only used for fallback

Implements #18214
2022-07-20 13:46:15 +00:00
Ferry Huberts 6699b33276 Locamation Interface Module dissector for IM1: fix the Windows build 2022-07-20 13:43:32 +00:00
Ferry Huberts 0a42b0976b Locamation Interface Module dissector for IM1
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
2022-07-20 06:25:51 +00:00
John Thacker f4fb92745e Diameter: Allow diameter command code text to be added to custom column
Create the command value string when loading the dictionary and
assign it to the command code field when registering it. This
makes it behave like any other value_string for adding to a custom
column (allowing resolved and unresolved), etc.

It could be changed to use a wmem_array instead of a GArray, as is
currently done with the AVPs.

Fix #16833. (Note that solving the analogous issue for the AVP
code text is more complicated, since the interpretation depends
on the vendor ID.)
2022-07-20 00:58:43 +00:00
Gerald Combs 3acd20fabe CMake+lrexlib: Another include path fix attempt. 2022-07-19 13:57:54 -07:00
Gerald Combs 9d96b301de CMake+lrexlib: Add another include path.
Include paths will be added until morale improves.
2022-07-19 13:04:44 -07:00
Gerald Combs 56a9666a3a wslua: Fix our argument definitions.
Make sure our argument definitions match their corresponding function
names.
2022-07-19 18:53:11 +00:00
João Valverde 84f54d54e5 dfilter: Fix a crash using abs()
Passing a literal value to abs() on the LHS segfaults, because it
is incorrectly assumed to be a valid field.

We need to check if we actually have a field. While at it improve
the diagnostic of literals.
2022-07-19 19:11:47 +01:00
Dr. Lars Völker 9e84721c1a TECMP: Updating to TECMP 1.7
The following changes are part of this patch:
- Make signed integer for analog default
- Analog Sample Time 0 is reserved now
- Updating Data Flags TX for CAN, CAN-FD, LIN, FlexRay, UART
- Show Parity Bits of LIN
- Expert Warning, when FlexRay Header CRC overflows into reserved bits
2022-07-19 15:25:56 +00:00
Dr. Lars Völker dec99a5f42 UDS: Adding IDs and Names for 2020 standard
This patch adds IDs and Names for:
- New UDS Services (0x29, 0x84, 0x86, 0x87)
- New ReadDTCInformation SubFunctions
- New Negative Response Codes

This patch does not dissection support for the new UDS Services.
2022-07-19 15:12:19 +00:00
John Thacker aa1c6db337 Diameter: Remove dead code for pre Internet Draft 16 protocol
There's some code intended to decode an older Internet Draft version
of Diameter, before December 2002. It's supposed to be set by an
obsolete enum preference, but due to a misunderstanding, it's
been dead code for the last 15 years. No one has complained in that
time, so instead of bringing the preference back and resurrecting
it, remove it and shrink the memory usage of the diameter dissector.

Related to #16833, as it will make adding the command code value
string simpler.
2022-07-18 23:31:41 -04:00
Gerald Combs 953c6f73aa CMake+lrexlib: Fix our include paths.
Try to fix

C:\gitlab-builds\builds\-fyeYoMP\0\wireshark\wireshark\epan\wslua\lrexlib\pcre2\../../wslua.h(52,1): fatal error C1083: Cannot open include file: 'epan/wslua/declare_wslua.h': No such file or directory [C:\gitlab-builds\builds\-fyeYoMP\0\wireshark\wireshark\build\epan\wslua\lrexlib\lrexlib.vcxproj]
C:\gitlab-builds\builds\-fyeYoMP\0\wireshark\wireshark\epan\wslua\lrexlib\pcre2\../../wslua.h(52,1): fatal error C1083: #include <epan/wslua/declare_wslua.h> [C:\gitlab-builds\builds\-fyeYoMP\0\wireshark\wireshark\build\epan\wslua\lrexlib\lrexlib.vcxproj]
C:\gitlab-builds\builds\-fyeYoMP\0\wireshark\wireshark\epan\wslua\lrexlib\pcre2\../../wslua.h(52,1): fatal error C1083: ^ [C:\gitlab-builds\builds\-fyeYoMP\0\wireshark\wireshark\build\epan\wslua\lrexlib\lrexlib.vcxproj]
2022-07-18 09:47:34 -07:00
Roland Knall b90fb0da55 Qt: Fix jump on packetlist
If the packetlist is navigated via the up/down keys, the viewport
may jump, if the cell that is being navigated to, has content that
is greated than what is currently displayed

Fixes #16363
2022-07-18 15:25:12 +02:00
Roland Knall ddcb429979 Qt: remove unnecessary method from FunnelStatistics 2022-07-18 15:08:23 +02:00
John Thacker 66978182d0 epan: Fix typo in conversation_create_endpoint_by_id 2022-07-18 12:00:42 +00:00
Kaige Ye c7afb52c84 MySQL: fix Auth Swith Request dissection 2022-07-18 09:37:17 +00:00
Alexis La Goutte c2b53b7680 NSIS(logray): Remove QUICK LAUNCH too 2022-07-17 19:55:33 +00:00
Alexis La Goutte ca178cf03a NSIS(wireshark): Remove QUICK LAUNCH
It is not longer (really) supported with Windows 10, now it is pinned Taskbar
2022-07-17 19:55:33 +00:00
João Valverde b50880f329 Qt: Update display filter expression dialog with any/all 2022-07-17 19:23:15 +00:00
Gerald Combs a6b09b52b4 [Automatic update for 2022-07-17]
Update manuf, services enterprise numbers, translations, and other items.

services failed.
2022-07-17 16:38:11 +00:00
John Thacker 0749873c70 decode as: Add data dissector to all tables that support Decode As
Register the data dissector to all dissector tables that support
Decode As. This provides a way to disable decoding for table
entries that have a default dissector registered to a value.
It is particularly useful when a dissector is registered by default
to several values (e.g. HTTP), to be able to disable decoding
for one port without disabling the dissector in general.

It is also useful to prevent payloads from being handed off
to heuristic dissectors, and is thus distinguished from the
fallback to data when no dissector is set.  N.B.: that this has no
effect on dissectors that have a "Try heuristic sub-dissectors first"
preference set to TRUE.

It does not solve a second issue for table entries with a default
dissector - setting the dissector to "none" in order to force
payloads to be sent to heuristic dissectors without setting a
preference as above. (Note that in some cases one will wish to
send dissection on some ports to heuristics without enabling
heuristics first for _all_ ports.)

Fix #17518. Fix #15717. Related to #12098, which also needs the
last issue mentioned above addressed.
2022-07-16 16:02:36 -04:00
Roland Knall 7935734d61 ReleaseNotes: add maxminddb improvement
Add note about the improvement for maxminddb

[skip ci]
2022-07-16 15:38:59 +00:00
Tomasz Moń 22f7f56151 MaxMind DB: Significantly speed up stdout reader
Non-blocking reads were used to workaround Windows pipe handle leaks.
Now that the underlying issue is fixed (i.e. Wireshark no longer leaks
child process stdin/stdout/stderr handles), we can use blocking reads.

Using blocking reads is the main performance improvement. Reading more
than one byte at a time gives additional 15% performance improvement (on
top of enormous speedup due to blocking reads).

Avoid stdin and stdout file descriptor race conditions by closing the
descriptors only after the respective threads exit.
2022-07-16 14:55:22 +00:00
Tomasz Moń 1323544f65 Win32: Fix child process pipe handle leaks
Close pipe handles when spawning asynchronous processes, so only the
child process holds handle to the other end of the pipe. Closing the
handles makes it possible to use pipes the same way as on other OS, that
is to rely on blocking read() to end when child process finishes.

Do not call CloseHandle() on signal pipe in capture sync after the
handle ownership was transferred to file descriptor. Close the file
descriptor instead.
2022-07-16 14:55:22 +00:00
Gerald Combs 3a989f2e72 Debian: Add missing symbols. 2022-07-15 13:10:26 -05:00
steve71 496dc0fcb3 TWAMP Test Frames: Adds dissection of PTP timestamps RFC8186
RFC8186 adds PTP timestamp option for TWAMP test frames. This small
change decodes these and the Z-bit which indicates their presence
2022-07-15 13:59:11 +00:00
Alexis La Goutte b9bc750fd8 conversation: fix -Wmissing-prototypes
conversation.c:339:1: warning: no previous prototype for function 'conversation_hash_element_list'
2022-07-15 13:45:52 +00:00
Alexis La Goutte b448b6a591 semcheck: fix -Wmissing-prototypes
semcheck.c:1110:1: warning: no previous prototype for function 'check_arithmetic_entity'
2022-07-15 13:45:52 +00:00
Alexis La Goutte bd28c19ad6 dvfm: Fix -Wmissing-prototypes
dfvm.c:206:1: warning: no previous prototype for function 'dfvm_value_tostr'
dfvm.c:550:1: warning: no previous prototype for function 'filter_finfo_fvalues'
dfvm.c:645:1: warning: no previous prototype for function 'filter_refs_fvalues'
2022-07-15 13:45:52 +00:00