Support Extended Key ID for Individually Addressed Frames from
IEEE 802.11 - 2016.
Extended Key ID allows unicast (PTK) keys to also use key ID 1 and has
an additional RSN attribute "KeyID" in EAPOL #3.
Add the additional attribute KeyID to the RSN parser, stop assuming
unicast keys are only using key ID 0 and add a test case to verify
Extended Key ID parsing and decoding.
Change-Id: I43005c74df561be5524fa3738149781f50dafa14
Reviewed-on: https://code.wireshark.org/review/34883
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
The buffer needs to be big enough to include the trailing '\0', so we
need to compare the buffer's length against strlen(name) + 1, not
against strlen(name).
Bug: 15751
Change-Id: I75ae65f8c818284834d761d9dd911d029cfca3b1
Reviewed-on: https://code.wireshark.org/review/34892
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The offset logic was incorrect leading to systematic call of data_dissector for facilities.
packet-its.c was generated using asn2wrs.py
Change-Id: Id49b031d757f4b0fde9e789b98226efbf044d4da
Reviewed-on: https://code.wireshark.org/review/34888
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Allow the drag/drop of filter buttons in the dialog
Change-Id: Ie2d5987ecdb626a8f12e8f17e6967f937bdf4648
Reviewed-on: https://code.wireshark.org/review/34885
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Initial member as count is only in ioctl call, not in the wire format.
Change-Id: Ic44b7ccf6510df91e5df78587a84fc502bbd7623
Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
Reviewed-on: https://code.wireshark.org/review/34880
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Allow for filtering of enabled/disabled protocols in the
EnabledProtocols dialog
Change-Id: Ib9a8bbe2a23fdcd3ecd2b9ca08de17f77e85049c
Reviewed-on: https://code.wireshark.org/review/34878
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Speed up the filtering, by only taking rows once
Change-Id: I6123b2974fd58480463e4a0bd02524f6b5c0a353
Reviewed-on: https://code.wireshark.org/review/34879
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
If a ProtoExpert object was created, but not linked to a Proto, then the
object and some fields (abbrev, text) would leak.
This is a follow-up to g79fef2ae.
Change-Id: Ic0b44e8b70895a19d9b52a0e44064a1e76a58fa0
Reviewed-on: https://code.wireshark.org/review/34876
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Adding a field of "Reassembled RLC Data" like other reassembling dissectors have (such as TCP)
Also cosmetic changes to the reassembled tree 'root' item
Change-Id: I6642ea2ef79f3783f4bcd2d544c34f7b0c1e7ade
Reviewed-on: https://code.wireshark.org/review/34814
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
If a ProtoField object was created, but not linked to a Proto, then the
strings field and all elements (depending on type) would leak.
This is a follow-up to g79fef2ae and fixes the real issue in g44870fb1.
Change-Id: I01880a92bb20fae45f68c754b07daeb07630deec
Reviewed-on: https://code.wireshark.org/review/34872
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com>
Reviewed-by: Roland Knall <rknall@gmail.com>
The MNC is encoded in little endian format, not big endian.
The IEs impacted are 5GS tracking area identity list, service area list
and SOR transparent container.
Bug: 16162
Change-Id: I05acc5fb7d1c4a84f53cc5b2a21ee12c4813593d
Reviewed-on: https://code.wireshark.org/review/34874
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Get MMTYPE MSB from the three most significant bits, bits 5 through 7,
instead of bits 1 and 2. Get FMI Fragment count from the four most
significant bits instead of the four least significant bits. Get FMI
Fragment index from the four least significant bits instead of the four
most significant bits.
Bug: 16158
Change-Id: Ib51789486be4562f76114081cbbf3aa22a41ff2e
Reviewed-on: https://code.wireshark.org/review/34868
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Have dissect_kafka_string_new() set a flag if the length was negative.
If the length is negative, don't try to process what comes afterwards.
Make the length argument to decompression routines unsigned, and do
various checks. Don't try to decompress a zero-length block, and quit
if the decompressed block is zero-length.
Bug: 16082
Change-Id: I34c2ea99aa096b3f5724d9b113171b105bd6c60b
Reviewed-on: https://code.wireshark.org/review/34867
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Do not reset multiselect configuration to defaults on every extcap
configuration window open.
Change-Id: I04036ad6723f66c2ac036aae5bf70ded5029a66b
Reviewed-on: https://code.wireshark.org/review/34864
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
If boolean flag is active by default, then when launching extcap without
opening configuration dialog it would be added to extcap call regardless
of user configuration. Modify the logic so default value is used only if
there is no stored user configuration available.
Change-Id: I1855a058a99e2395da5593486411e160d48fca4b
Reviewed-on: https://code.wireshark.org/review/34865
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
The format argument (third argument) is used with the numerical value
passed to val_to_str(), so it should have a numerical format item, not a
string format item.
Bug: 16146
Change-Id: I91ae0edd7fe06fb95ae74697b06bd4f50b696f9f
Reviewed-on: https://code.wireshark.org/review/34866
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add support to Wireshark for new hop-by-hop option defined in:
https://tools.ietf.org/html/draft-ietf-6man-mtu-option-01
This Hop-by-Hop IPv6 option is designed to be used to
record the minimum Path MTU along the forward path between a source
host to a destination host. This collects a minimum recorded MTU
along the path to the destination. The value can then be
communicated back to the source using the return Path MTU field in
the option.
Change-Id: I5dfc1a70aedd347b128bc3c5cd96f9d5a0752e3b
Reviewed-on: https://code.wireshark.org/review/34786
Reviewed-by: João Valverde <j@v6e.pt>
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
They complain because of an uninitialized variable.
../epan/dissectors/packet-synphasor.c: In function ‘config_3_frame_fast’:
../epan/dissectors/packet-synphasor.c:782:7: error: ‘ai’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
ai[i].conv = 1;
^
../epan/dissectors/packet-synphasor.c:767:7: error: ‘pi’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
pi[i].unit = phasor_unit & 0x00000800 ? A : V;
^
Change-Id: I2013ca9ddff5551328d2b86decc5e52fe052b6d0
Reviewed-on: https://code.wireshark.org/review/34859
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
../epan/dissectors/packet-nfs.c:7070:48: error: format specifies type 'long' but the argument has type 'guint64' (aka 'unsigned long long') [-Werror,-Wformat]
proto_item_append_text(attr_tree, " = %ld", size);
~~~ ^~~~
%llu
Change-Id: Iab7c6e026e9e5668e5d744eaedc67cd055f5e3cc
Reviewed-on: https://code.wireshark.org/review/34860
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Config 3 frames are optional in the synchrophasor standard.
Add support so that they get dissected correctly.
Bug: 16140
Change-Id: I6e0f7f653b99a9fd817736d69687132ae9a8537d
Reviewed-on: https://code.wireshark.org/review/34800
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add dissector for the MDS threshold attribute for the
files layout type. For any other layout type just display
the bitmap mask and the bitmap opaque data.
Change-Id: I3325218eb0e8b29d20b1bb540148f3b18cd4ef8f
Reviewed-on: https://code.wireshark.org/review/34845
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fill out MDS HSM opcode processing.
Lustre 2.13/2.12.3 has added MDS_RMFID RPC.
Reorder MDS opcodes to numeric order.
Change-Id: I732b55f62195358b860ca7403f699fc4ff10faaf
Signed-off-by: Nathaniel Clark <nathaniel.clark@misrule.us>
Reviewed-on: https://code.wireshark.org/review/34826
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add the newly create ProtoField to the test_proto.fields in order to be freed.
ERROR: LeakSanitizer: detected memory leaks
Direct leak of 64 byte(s) in 1 object(s) allocated from:
#0 0x55e041f5ef86 in realloc (/home/vasko/sources/wireshark/build_clang/run/tshark+0x222f86)
#1 0x7fd8e0919e7d in g_realloc gmem.c:164:16
#2 0x7fd8e08e457b in g_array_maybe_expand garray.c:820:21
#3 0x7fd8e08e4b49 in g_array_append_vals garray.c:428:3
#4 0x7fd8ef112b6e in value_string_from_table /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:294:9
#5 0x7fd8ef10ee10 in ProtoField_new /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:646:24
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x55e041f5ef86 in realloc (/home/vasko/sources/wireshark/build_clang/run/tshark+0x222f86)
#1 0x7fd8e0919e7d in g_realloc gmem.c:164:16
#2 0x7fd8e08e457b in g_array_maybe_expand garray.c:820:21
#3 0x7fd8e08e4b49 in g_array_append_vals garray.c:428:3
#4 0x7fd8ef111e2e in range_string_from_table /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:226:17
#5 0x7fd8ef10e43f in ProtoField_new /home/vasko/sources/wireshark/epan/wslua/wslua_proto_field.c:642:24
Fixes: v3.1.1rc0-497-g0371994223 ("wslua: Improve parameter check in ProtoField.new()")
Change-Id: I05b8bf3d78c8a540c6cf33d11dc3f3e01f83b8c5
Reviewed-on: https://code.wireshark.org/review/34834
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Allow filterbuttons to be dragged to the display filter
bar
Change-Id: I25e87d0ca86fc7437a20994800bec164ccffef27
Reviewed-on: https://code.wireshark.org/review/34838
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Those are no longer needed by the GUI
Change-Id: I5eb12c2ebe84885ddba510b9d2b49679a292e7f0
Reviewed-on: https://code.wireshark.org/review/34855
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Not queueing up as most likely only one of these would pop up.
Not trying to show every possible error - only really verifying
that the binary and top-level config file are specified correctly.
Change-Id: I2adf2557989bfc67874f5ac2648b1ba8d2a3eb25
Reviewed-on: https://code.wireshark.org/review/34851
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Initially added feature to match linux kernel hash value of
stateid to the wireshark in
commit 05c47d755a
change id I70c6d2b88822b6f735e8bc506a1bfcb421f6ddb9
[NFS] adding stateid hash based on stateid.other
This has been broken by
commit b913bcc13a
change id I3bf7caefc3341887a4c9137500dfeac0115af8cf
NFSv4: Fix for duplicate StateId hashes
This patch fixes it to again calculate a crc32 hash to
make it to the linux kernel output.
Change-Id: Ibb29516de61bd9bdf2dd1164da4b14412aa7a71c
Reviewed-on: https://code.wireshark.org/review/34842
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
When using wiretap to create a pcapng file,
the drop_count field from the wtap_packet_header
in wiretap/wtap.h is not being dumped to the file
in pcapng_write_enhanced_packet_block function.
Bug: 16062
Change-Id: Id9b8dbd1f7406e019fab00ff7a4167ab27543f62
Reviewed-on: https://code.wireshark.org/review/34836
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
When parsing the description
ExpectedActivityPeriod ::= INTEGER (1..30|40|50|60|80|100|120|150|180|181,...)
asn2wrs.py was generating some code where the has_extension flag was
wrongly set to false, leading to a decoding error.
Bug: 16145
Change-Id: I0d54994c0656f5b48f3dcd1864218c45a4ebc308
Reviewed-on: https://code.wireshark.org/review/34837
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Alexander Wetzel