Commit Graph

1247 Commits

Author SHA1 Message Date
Ulf Lamping 6861d6351a code cleanup
svn path=/trunk/; revision=9794
2004-01-23 01:10:24 +00:00
Ulf Lamping bedcdae5e3 make some of the new menuitems insensitive,
if no capture file/data is available

svn path=/trunk/; revision=9792
2004-01-23 00:43:29 +00:00
Guy Harris 7f727e9119 From Lars Roland:
- "Refresh" button is back again.  Everything should work fine now
	  with multiple windows on the same streams.
	- made packet list sortable by column.
	- show a warning when user chooses "RTP Streams/Analyze"
	  without having a RTP packet selected instead of displaying the
	  streams box.
	- minor GUI updates, renamed button "Next" to "Next non-Ok" for
	  more clarity.

svn path=/trunk/; revision=9788
2004-01-23 00:29:52 +00:00
Jörg Mayer 872b3d7bcd Slight formatting change
Reorder lists alphabetically

svn path=/trunk/; revision=9786
2004-01-22 23:09:55 +00:00
Guy Harris e51338c5bb Fix the RCS ID.
svn path=/trunk/; revision=9785
2004-01-22 21:32:54 +00:00
Guy Harris 7b4e42978b We can't save "child_process" as a HANDLE on UNIX - save it as an "int",
and cast it in the "GetExitCodeProcess()" call (rather than converting
it when assigning it).

svn path=/trunk/; revision=9784
2004-01-22 20:47:37 +00:00
Guy Harris 89e496d1ab Fix a typo.
svn path=/trunk/; revision=9781
2004-01-22 20:33:21 +00:00
Guy Harris cfdb7ee9c6 Move the list of headers to "Makefile.am" (it's not used by
"Makefile.nmake"), and rename it to "noinst_HEADERS", as that's what
automake requires.

svn path=/trunk/; revision=9780
2004-01-22 20:31:44 +00:00
Ulf Lamping a0f78e3b8f moved GTK specific parts from capture.c to ui_util.c,
implemented Win32 "Capture Stop" when using
"update list of packets in realtime" while capturing

svn path=/trunk/; revision=9777
2004-01-22 18:13:57 +00:00
Ulf Lamping f799c98aa5 added new Makefile.common just like in root,
including sources common in Makefile.am and Makefile.nmake

svn path=/trunk/; revision=9776
2004-01-22 18:08:58 +00:00
Ulf Lamping 503a830e48 The progressbar had a parameter to specify the text of the Cancel/Stop button.
As this will always be a Cancel of a running operation, this parameter was removed.
This makes us also able to use a stock button for this.

svn path=/trunk/; revision=9774
2004-01-21 22:00:28 +00:00
Ulf Lamping 76d25fca7d this dialog isn't used any longer.
All setting moved to direct menuitems under View

svn path=/trunk/; revision=9773
2004-01-21 21:56:12 +00:00
Ulf Lamping 8e2a930023 implemented dlg_button_row_new to get a standard function for
layouting the dialog buttons, and use it where appropriate.
This will help us with the GTK1/2 conflict on button layouts and
will also result in a more consistent look of the dialogs at all.

svn path=/trunk/; revision=9771
2004-01-21 21:19:34 +00:00
Ulf Lamping d4b591b7dd display_opts.c / .h no longer needed, all items moved to menuitems
svn path=/trunk/; revision=9770
2004-01-21 19:21:28 +00:00
Olivier Abad 7728b2c563 gtk_font_selection_set_font_name doesn't work when run before appending
the font selection widget to the notebook (at least in GTK2).

svn path=/trunk/; revision=9769
2004-01-21 12:19:19 +00:00
Guy Harris e338b18e4f Don't include some xpm's when built with GTK+ 1.2[.x] - the icons they
define aren't used with 1.2[.x].

svn path=/trunk/; revision=9768
2004-01-21 09:02:09 +00:00
Guy Harris 9c9fd17906 Squelch some compiler warnings.
"font_point_size_l" is a "long", so use "strtol()" to set it (note that
even "strtoul()", for some not-entirely-obvious reason, accepts numbers
starting with a "-" as input - ANSI C requires it!).

svn path=/trunk/; revision=9767
2004-01-21 09:00:48 +00:00
Ulf Lamping 1584a12114 moved remaining display options dialog settings to menuitems,
to get rid of the options dialog completely
still need to think, how the whole thing should work with these settings

svn path=/trunk/; revision=9765
2004-01-21 06:41:03 +00:00
Ulf Lamping 514f438bc7 redesign of capture/display filter dialog.
didn't change the behaviour of the edit buttons,
although they should be changed

svn path=/trunk/; revision=9764
2004-01-21 05:35:42 +00:00
Ulf Lamping e3dd2f5472 use stock buttons whereever possible,
added some ethereal specific stock icons

svn path=/trunk/; revision=9763
2004-01-21 03:54:32 +00:00
Ulf Lamping 76910636e0 don't try to set font size <= 0
svn path=/trunk/; revision=9762
2004-01-21 03:02:19 +00:00
Guy Harris fe71c130e7 "Go To {First,Last} Packet" don't pop up dialog boxes, they Just Do It -
don't give their menu items a "...", as that's for menu items that pop
up dialog boxes to ask you for more information.

Give them menu accelerators that don't clash with other accelerators.

svn path=/trunk/; revision=9760
2004-01-20 21:20:29 +00:00
Ulf Lamping b21d225252 prevented GTK-warning, as the column index was too high
svn path=/trunk/; revision=9756
2004-01-20 19:33:23 +00:00
Ulf Lamping 1108d88e29 commented out refresh_bt, as it's currently unused
svn path=/trunk/; revision=9755
2004-01-20 19:31:46 +00:00
Ulf Lamping ef57df088f a.) saving GTK1 and GTK2 fontnames in different preference setting, to prevent problems when switching between GTK1 and GTK2 ethereal versions
b.) added new feature "Edit->Go To First Packet" "Edit->Go To Last Packet" with corresponding menu and toolbar items
c.) added new feature "View->Zoom In" / "View->Zoom Out" / View->Normal Size" with corresponding menu and toolbar items
This feature will act as a "size offset" to the current fontsize, so that the packet list/tree view/... will have a larger/smaller font size.
The value is stored inside the recent file.
d.) Win32 only: Try to get the win32 system font and fontsize at program startup and show the menus/dialogs and such with the same font and fontsize like other win32 windows.
This makes the program make a *lot* more feel like a normal win32 program.

svn path=/trunk/; revision=9753
2004-01-20 18:47:25 +00:00
Guy Harris 618c0e5e8b Get rid of declaration of no-longer-extant routine.
svn path=/trunk/; revision=9750
2004-01-20 02:36:04 +00:00
Guy Harris 290edaadd4 Put in missing GTK_STOCK_STOP #define for GTK+ 1.2[.x].
svn path=/trunk/; revision=9749
2004-01-20 02:35:31 +00:00
Ulf Lamping 1b852172e2 minor tooltip changes
svn path=/trunk/; revision=9748
2004-01-20 02:26:00 +00:00
Ulf Lamping ef9d4ada2d code cleanup and added some more
application specific stock items in toolbar.c,
use them where appropriate

svn path=/trunk/; revision=9747
2004-01-20 02:21:17 +00:00
Guy Harris e28a53d402 DCE RPC statistics are maintained only by major version, not by major
and minor version.

svn path=/trunk/; revision=9743
2004-01-19 23:43:29 +00:00
Olivier Biot bc8d20be32 From Lars Ruoff: temporarily comment out the code for the "refresh" button;
register and unregister the tap listener in a thread-safe manner.

svn path=/trunk/; revision=9742
2004-01-19 23:35:32 +00:00
Guy Harris d4ab584f0f Move "ts_type_text" out of "epan/timestamp.h into "gtk/recent.c", as
it's only used in the latter; that avoids lots of warnings about
"ts_type_text" being defined but not used in other source files that
include "epan/timestamp.h".  (If it's going to be used in more than one
file, make it non-static and declare it "extern" in "epan/timestamp.h".)

Define TS_NOT_SET as ((ts_type)-1), and use that when initializing
"timestamp_type" in Ethereal and when checking to see whether
"timestamp_type" was set, to avoid signed vs. unsigned comparison
warnings.

Clean up indentation.

svn path=/trunk/; revision=9740
2004-01-19 23:03:20 +00:00
Guy Harris 439159f73d Make the signatures of "dcerpcstat_reset()", "dcerpcstat_packet()", and
"dcerpcstat_draw()" match what "register_tap_listener()" expects, to
squelch warnings.

svn path=/trunk/; revision=9739
2004-01-19 23:00:12 +00:00
Jörg Mayer db29a705cb Trivial signed/unsigned warning fixes
svn path=/trunk/; revision=9732
2004-01-19 18:23:01 +00:00
Jörg Mayer da5f6f9472 The current year is 2004
svn path=/trunk/; revision=9731
2004-01-19 18:21:18 +00:00
Ulf Lamping 0353c5823f move timestamp format options from "View->Options" dialog into
menuitems under "View->Time Display Format".
renamed timestamp enum items e.g. from ABSOLUTE to TS_ABSOLUTE,
to prevent conflicting definitions with MSVC

svn path=/trunk/; revision=9729
2004-01-19 03:46:43 +00:00
Guy Harris 7909c22d49 Include <string.h> to declare "strcasecmp()".
svn path=/trunk/; revision=9727
2004-01-19 01:00:58 +00:00
Ulf Lamping 453309c0c6 added some menuitems "View->Show" including show/hide of all main widgets,
saving the states in the recent file

svn path=/trunk/; revision=9726
2004-01-19 00:42:12 +00:00
Jörg Mayer e68ca30d10 Fix warnings found by -Wstrict-prototypes
svn path=/trunk/; revision=9722
2004-01-18 16:21:12 +00:00
Jörg Mayer 5972f31427 Output the result of -h to stdout, not stderr
svn path=/trunk/; revision=9703
2004-01-18 02:19:07 +00:00
Olivier Biot 8db6fb47cd Nice rendering of the CVS version as "(cvs 200401181200003000)".
The make-version.pl script only defines CVSVERSION if this was a build
from CVS.

svn path=/trunk/; revision=9701
2004-01-18 01:41:14 +00:00
Ulf Lamping 0c34d1105a make the column preferences page look a bit more like the color rules dialog
svn path=/trunk/; revision=9699
2004-01-18 00:53:57 +00:00
Ulf Lamping 59125a7304 no more differences, wether display filter dialog is called from
menu "Analyze->Display Filter" or statusbar "Filter:" button.

svn path=/trunk/; revision=9698
2004-01-18 00:40:39 +00:00
Ulf Lamping 993b096e21 complete redesign of color dialog
svn path=/trunk/; revision=9697
2004-01-18 00:33:03 +00:00
Ulf Lamping 116bb3c25e Select first row in column list by default,
fixed sensitivity of option_menu

svn path=/trunk/; revision=9692
2004-01-17 12:12:57 +00:00
Guy Harris ae92ea0b12 Clean up some compiler warnings.
Clean up white space.

Have "font_fetch()" return a Boolean indicating whether it succeeded or
not.  If it failed, don't use "new_font_name", as it hasn't been set.

svn path=/trunk/; revision=9689
2004-01-17 03:09:24 +00:00
Ulf Lamping af78977df5 new "Font" preferences page instead of a font dialog in "User Interface"
svn path=/trunk/; revision=9686
2004-01-17 00:26:22 +00:00
Ulf Lamping 3f37d207e7 column preferences page now looks similar to the color dialog layout,
as it's doing the same thing

svn path=/trunk/; revision=9680
2004-01-16 21:25:21 +00:00
Jörg Mayer 0ac74ed036 In case of CVS sources, add the date of the last change to the version
number.

2do: Add support to Makefile.nmake
     Enforce the generation of cvsversion.h on each run of make

svn path=/trunk/; revision=9679
2004-01-16 20:04:21 +00:00
Ulf Lamping 87f4ff7354 bugfix: use correct size of global value
svn path=/trunk/; revision=9674
2004-01-16 11:53:40 +00:00
Ulf Lamping 065edac68b move "marked packet color" setting from gui_prefs to Colors page.
remove the Color dialog from gui_prefs.c

svn path=/trunk/; revision=9667
2004-01-15 01:13:51 +00:00
Ulf Lamping d0efc49be5 Change labels from "TCP Streams" to "Colors", to add other color values later
Later, file has to be renamed to color_prefs.dlg (function renaming similar)

svn path=/trunk/; revision=9666
2004-01-14 23:32:48 +00:00
Ulf Lamping 4676bb5bac destroy the "save as" dialog only, if it's existing
svn path=/trunk/; revision=9665
2004-01-14 14:28:25 +00:00
Guy Harris a093c75b59 Use "retap_packets()" rather than "redissect_packets()".
svn path=/trunk/; revision=9660
2004-01-13 22:49:15 +00:00
Guy Harris 4dd10c6687 Add a routine "retap_packet()" that runs through all packets, dissecting
them and running all taps on them, but not reconstructing the packet
list.  Use that in the IO-stat tap rather than "redissect_packet()"; the
latter does more work and redraws the display, neither of which are
necessary.

Call the filter callback when the Calc field is changed, to redraw the
graphs; that change also fixes things so that it's called when the
Filter field is changed.

Rename the "filter_button" member of an io_stat_graph_t to
"filter_field", as it's not the "Filter:" button, it's the text field
containing the filter expression.

svn path=/trunk/; revision=9659
2004-01-13 22:34:10 +00:00
Guy Harris 053ec89a5d "dfilter_compile()" supplies a null dfilter pointer for an empty filter
expression; don't assume it always supplies a non-null pointer.

svn path=/trunk/; revision=9657
2004-01-13 21:10:38 +00:00
Guy Harris 982a4976c7 Add a routine "io_stat_reset()" to reset an io_stat_t; have
"gtk_iostat_reset()" call it, and have calls to
"gtk_iostat_reset(&io->graphs[0])" just call "io_stat_reset(io)".

Add a routine "io_stat_draw()" to draw an io_stat_t; have
"gtk_iostat_draw()" call it, and have calls to
"gtk_iostat_draw(&io->graphs[0])" just call "io_stat_draw(io)".

Add a routine "io_stat_redraw()" to set the "needs_redraw" flag on an
io_stat_t and call "io_stat_draw()" on it, in order to force a redraw.
Use that in place of set flag/io_stat_draw pairs.

Add a routine "enable_graph()" to set an io_stat_graph_t's display flag
to TRUE and register a tap listener for it, and add a routine
"disable_graph()" to, if an io_stat_graph_t's display flag is set, clear
it, remove its tap listener, and turn its display button off.  Use
"disable_graph()" to disable graphs, rather than just turning the
display flag off, so that we ensure that the invariant "tap listener
present iff graph enabled" is preserved - the code to destroy an io-stat
window only removes tap listeners for enabled graphs, so it depends on
that invariant being preserved.

Check the validity of a display filter by compiling it, not by going
through the whole sequence of registering a tap listener.

svn path=/trunk/; revision=9656
2004-01-13 21:04:52 +00:00
Guy Harris d3ee83c0a0 Make the variable into which values from
"gtk_spin_button_get_value_as_float()" be doubles rather than floats -
GTK+ 2.x's "gtk_spin_button_get_value_as_float()" actually returns
doubles.

svn path=/trunk/; revision=9654
2004-01-13 08:25:00 +00:00
Guy Harris b97626862e Rename DISSECTOR_HELPER_{SRC,OBJECTS} to
DISSECTOR_SUPPORT_{SRC,OBJECTS}.

Add some additional files, required by dissectors, to those lists.

Extract the stuff to get version information strings for libraries and
the OS, which is *not* needed by dissectors, from "util.c", which
contains routines that *are* needed by dissectors, and put it into a
separate file.

Make "dftest" link only with the dissector support stuff, not with all
of the Ethereal common files.

svn path=/trunk/; revision=9645
2004-01-11 22:17:43 +00:00
Jörg Mayer 8e6ece35e6 #if 0 out test that causes an always false warning
svn path=/trunk/; revision=9644
2004-01-11 10:02:39 +00:00
Ulf Lamping a6ff7799a2 close the Save (As) dialog, when the capture file is closed
svn path=/trunk/; revision=9642
2004-01-10 17:29:26 +00:00
Ulf Lamping a25df4f95f add a "Save As" button to the toolbar,
changed some tooltips

svn path=/trunk/; revision=9641
2004-01-10 17:10:06 +00:00
Ulf Lamping 685a68e597 using button compatibility macros
svn path=/trunk/; revision=9638
2004-01-10 16:35:10 +00:00
Ulf Lamping 949f1f2d07 using button compatibility macros
svn path=/trunk/; revision=9636
2004-01-10 16:27:43 +00:00
Ulf Lamping b9cde84cac using button compatibility macros
svn path=/trunk/; revision=9633
2004-01-10 14:11:58 +00:00
Ulf Lamping 02d575db13 added various button compatibility macros,
to be used in the dialogs and elsewhere

svn path=/trunk/; revision=9632
2004-01-10 14:10:43 +00:00
Ulf Lamping 4c047130c8 removed two MSVC warnings (GTK2 related)
svn path=/trunk/; revision=9628
2004-01-10 12:43:04 +00:00
Guy Harris 3f75fe3291 Export "remove_color_filter()", as it's used in "color_dlg.c".
svn path=/trunk/; revision=9615
2004-01-09 20:39:26 +00:00
Guy Harris 6b61f72a9d Include <string.h> to declare "strcmp()".
svn path=/trunk/; revision=9614
2004-01-09 20:36:47 +00:00
Olivier Biot d82c95c87a Part 2 of the "unmarking a packet matching a color filter does not apply
the color filter's colors" bug: keep a list of removed color filters, so
there's no problem if we delete a color filter for which there are one or
more packets that have its colors. Only get rid of the lists when they
ar no longer needed.

svn path=/trunk/; revision=9613
2004-01-09 20:20:42 +00:00
Ulf Lamping ea0a32e92f use the same packet range things for "Print" dialog, as already implemented
in the "Save As" dialog and some other minor changes

svn path=/trunk/; revision=9610
2004-01-09 18:11:21 +00:00
Ulf Lamping 7e20ddc9f6 some code cleanup in range.c
svn path=/trunk/; revision=9609
2004-01-09 14:05:20 +00:00
Guy Harris 563f423d76 Turn the GTK+ 1.2.10 clist code into our own widget; that lets us modify it
to add functionality or improve performance, although, until we make it
work on GTK+ 1.3[.x] and 2.x, we shouldn't count on the performance
improvements, or make its API different from that of the GtkClist API
(other than names).

Move all the code that knows about the packet list into
gtk/packet_list.c, so that the GtkClist vs. EthClist stuff is
encapsulated inside it.

svn path=/trunk/; revision=9608
2004-01-09 08:36:23 +00:00
Olivier Biot f5f60f1ba3 Fix the "unmarking a packet matching a color filter does not apply the color
filter's colors" bug, by storing the pointer to the matching color_filter_t
structure in the frame_data structure.

Replace "frame" and "frames" by "packet" and "packets" in many places.

svn path=/trunk/; revision=9607
2004-01-09 02:57:54 +00:00
Guy Harris c0b33a22f9 If building without libpcap, exclude some stuff that builds only if
you're building with libpcap or that's not necessary if you're not
building with libpcap.

svn path=/trunk/; revision=9601
2004-01-08 20:39:51 +00:00
Ulf Lamping e8232af246 Save As and range: don't use global vars in range.c,
as this will be also used for the print dialog later.
Calculate packet count for user specified ranges

svn path=/trunk/; revision=9598
2004-01-08 10:40:33 +00:00
Jörg Mayer df49dc9409 Include string.h to import strerror
svn path=/trunk/; revision=9597
2004-01-07 22:16:17 +00:00
Guy Harris 1493331f5f Get rid of "gtk_box_pack_start()" call to put the range table into the
range frame - we already have a "gtk_container_add()" call that does that.

svn path=/trunk/; revision=9596
2004-01-07 21:29:59 +00:00
Ulf Lamping bd37ba81eb added some simple_dialogs, if save of raw data fails for some reasons
svn path=/trunk/; revision=9594
2004-01-07 20:14:17 +00:00
Olivier Biot 219940011c Remove extraneous parameters of packet count in case the end-user manually
enters a range of packets. Comment this in the code.

svn path=/trunk/; revision=9590
2004-01-07 19:10:49 +00:00
Jörg Mayer 9422e256ef Not that it really matters as the test still alwas evaluates to false:
An array with 256 elements should not be accessed with an index >= 256,
as we do not count as normal people do.

svn path=/trunk/; revision=9581
2004-01-07 01:44:23 +00:00
Ulf Lamping bba39ed952 save dialog with "Captured" and "Displayed" buttons in packet range
svn path=/trunk/; revision=9580
2004-01-07 00:10:52 +00:00
Guy Harris 73d47925eb Widgets get freed when the reference count goes to zero; we don't need
to explicitly destroy menu items when we remove them from the "recent
files" list.

Clean up indentation.

svn path=/trunk/; revision=9578
2004-01-06 22:38:07 +00:00
Ulf Lamping 65dd8f05bc an enum represents the radio buttons much better,
than an "array" of gbooleans

svn path=/trunk/; revision=9564
2004-01-05 22:21:53 +00:00
Ulf Lamping ba3b94790d removed some MSVC warnings (level 3)
svn path=/trunk/; revision=9560
2004-01-05 18:11:28 +00:00
Richard Sharpe cc1987cf9f User Specified Decodes, since it brings up a dialog box, should be User Specified Decodes...
svn path=/trunk/; revision=9543
2004-01-04 06:16:57 +00:00
Guy Harris 405f9b5f46 A missing piece of Tadaaki Nagao's patches to add a global "disabled
protocols" file.

svn path=/trunk/; revision=9539
2004-01-04 02:24:58 +00:00
Richard Sharpe fa9874ef73 Apply the patches from Tadaaki Nagao for a global version of disabled
protocols ...

svn path=/trunk/; revision=9538
2004-01-03 18:40:08 +00:00
Richard Sharpe 5d7261eb78 Make Analyze/Statistics have an accelerator of Alt+A S and move
Analyze/Summary to Alt+A Y.

svn path=/trunk/; revision=9537
2004-01-03 18:05:57 +00:00
Guy Harris af8cfdb6aa Mark arguments as unused.
Clean up indentation.

svn path=/trunk/; revision=9532
2004-01-03 05:13:12 +00:00
Ulf Lamping 480cf33874 hide save dialog, while saving
svn path=/trunk/; revision=9527
2004-01-02 21:48:24 +00:00
Ulf Lamping b81609e779 recent files: make submenu insensitive if empty and
add a menu item to clear the list

svn path=/trunk/; revision=9524
2004-01-02 17:27:00 +00:00
Ulf Lamping 976b0a3be3 From Didier: don't update the progress bar more often than every 100ms
svn path=/trunk/; revision=9522
2004-01-02 13:27:00 +00:00
Richard Sharpe ee3018cca3 Tweak the name of the Coloring Rules dialog box to be more consistent ...
svn path=/trunk/; revision=9517
2004-01-02 00:19:59 +00:00
Ulf Lamping af1096b14c label texts changed (tip from Richard)
svn path=/trunk/; revision=9510
2004-01-01 13:41:09 +00:00
Ulf Lamping 20ae160191 rearranged prefs topics
svn path=/trunk/; revision=9509
2004-01-01 13:29:16 +00:00
Ulf Lamping 864fbca295 moved recent files pref, as it splits corresponding dir entries
svn path=/trunk/; revision=9508
2004-01-01 13:16:40 +00:00
Ulf Lamping b14477c11c comment fixed
svn path=/trunk/; revision=9507
2004-01-01 13:10:45 +00:00
Ulf Lamping c8cddf7163 minor changes and a small bugfix
svn path=/trunk/; revision=9492
2003-12-30 01:19:02 +00:00
Guy Harris d177c7d731 Nothing in "range.c" is GTK+-specific, so move it to the top-level
directory.

svn path=/trunk/; revision=9487
2003-12-29 22:43:33 +00:00