Commit Graph

9813 Commits

Author SHA1 Message Date
Ronnie Sahlberg e72747325c update to ndmp if there is an error, put the error string in the packet summary
svn path=/trunk/; revision=9910
2004-01-30 10:51:07 +00:00
Ulf Lamping d3316d2834 slightly higher polling rate, to detect stop condition from capture task
svn path=/trunk/; revision=9909
2004-01-30 06:43:16 +00:00
Ulf Lamping 3c76ec1aa2 every GUI action, which will erease a currently unsaved capture file,
will now raise a dialog "Save xy before z?" with Yes/No/Cancel buttons.

svn path=/trunk/; revision=9908
2004-01-29 23:11:38 +00:00
Ulf Lamping 419837e531 added "Yes" and "No" buttons to the simple_dialog,
added a callback method, to be called if a button was pressed

svn path=/trunk/; revision=9907
2004-01-29 23:07:17 +00:00
Ulf Lamping e66b849e23 added GTK_STOCK_YES and GTK_STOCK_NO to the dlg_button_row
svn path=/trunk/; revision=9906
2004-01-29 22:37:45 +00:00
Olivier Biot cdc1804bfe From Chris Wilson:
- Do not reassemble if the fragmentation IE is available but there is
   only one fragment reported.
 - Add a preference to disallow sub-dissectors to update the columns.

Also: fix white-space at 2 places (tabs to spaces).

svn path=/trunk/; revision=9905
2004-01-29 21:19:10 +00:00
Guy Harris cf131d9e16 The DLT_ value 127 is being used for the BSD radio header, and the
current CVS libpcap uses 163 for the AVS radio header (127 was never
used for the AVS radio header).  Redo the Wiretap encapsulation values
for that (and shuffle them to put the 802.11 Wiretap values together).

svn path=/trunk/; revision=9904
2004-01-29 10:58:28 +00:00
Guy Harris ff641180dd From Shusaku Ueda:
- show all Home Agent Addresses of DHAAD Reply
	- show ICMP options of Mobile Prefix Advertisement

svn path=/trunk/; revision=9903
2004-01-29 03:59:04 +00:00
Guy Harris 073a422f61 From Shinsuke Suzuki: add the payload type code for IPv6.
svn path=/trunk/; revision=9902
2004-01-29 03:51:25 +00:00
Guy Harris b024612ad9 From Shinsuke Suzuki:
- updated the IETF spec names
	- changed Prefix-Delegation related DHCPv6 option
	  numbers from temporary one to the official one
	- fixed typo in DHCPv6 message type

svn path=/trunk/; revision=9901
2004-01-29 03:46:36 +00:00
Guy Harris 073a8b42ca Clean up whitespace, and use "%u" to print unsigned quantities.
svn path=/trunk/; revision=9900
2004-01-29 03:37:31 +00:00
Ulf Lamping ba33382482 commented out setting the packet_info srcport and destport fields,
as this will prevent "ISO on TCP" (RFC1006) packet from using:
"follow TCP stream" function

svn path=/trunk/; revision=9899
2004-01-28 22:14:19 +00:00
Guy Harris 7d2d5048ec If we don't have any of the packet padding in the tvbuff, don't even try
to add the trailer - that avoids the problem with throwing an exception
inside a CATCH* clause for that same exception.  (XXX - is this a
problem with our exception mechanism? What happens in languages with
built-in exceptions if a

	try
		XXX
	catch YYY
		ZZZ
	end

construct throws exception YYY inside code block ZZZ?  If it doesn't
re-enter ZZZ, that argues that our exception mechanism is buggy or, at
least, violates the Principle of Least Surprise.)

Move the code to put the trailer information into the protocol tree out
of the CATCH2 clause, so the trailer shows up if we *do* have the
trailer information.

svn path=/trunk/; revision=9898
2004-01-28 20:09:44 +00:00
Guy Harris d2e4e9ecc9 Fix a comment.
svn path=/trunk/; revision=9897
2004-01-28 10:37:14 +00:00
Guy Harris a92d9edf0f Clean up the comparison code a bit.
svn path=/trunk/; revision=9896
2004-01-28 10:19:36 +00:00
Guy Harris a66012b68c For columns whose data comes from the frame_data structure for a packet,
sort the columns based on that data, rather than on the raw text of the
column - that's probably faster, and also doesn't get rudely surprised
by "atof()" being locale-dependent.

svn path=/trunk/; revision=9895
2004-01-28 09:53:09 +00:00
Guy Harris a06e94af42 "gtk/main.c" no longer has any code to manage the packet list, so it no
longer needs to define the "column_arrows" structure.

svn path=/trunk/; revision=9894
2004-01-28 09:10:50 +00:00
Gerald Combs fa5b2237f9 Catch any exceptions that add_ethernet_trailer() throws in add_dix_trailer().
Otherwise, they're caught by ethertype() which results in an infinite loop.

svn path=/trunk/; revision=9893
2004-01-28 03:36:37 +00:00
Guy Harris 677db2dadd From Tomas Kukosa: reserve private WTAP_ENCAP values and map them to
reserved private DLT_ values.

svn path=/trunk/; revision=9892
2004-01-28 01:24:30 +00:00
Ulf Lamping bd0c381cfd "Export Selected Packet Bytes" -> change all appearances to this text,
don't show up this dialog if no data *is* selected (didn't find an easy way
to control sensitivity of the menus by some mechanism :-(

svn path=/trunk/; revision=9891
2004-01-27 20:58:19 +00:00
Guy Harris b179725c39 Make "{byte,tree}_view_select()" return "gboolean", not "gint", as they
return TRUE or FALSE as a success/failure indication.

svn path=/trunk/; revision=9890
2004-01-27 20:36:48 +00:00
Guy Harris cdc2d3d318 From Alastair Maw: the IAX2 type is unsigned, not signed.
svn path=/trunk/; revision=9889
2004-01-27 20:25:06 +00:00
Guy Harris 2a2c7f6c07 Update Andy Hood's e-mail address.
svn path=/trunk/; revision=9888
2004-01-27 20:13:31 +00:00
Ulf Lamping aa34344c3c always select the current item under cursor, before showing up the
corresponding context menu (right mouse click)

svn path=/trunk/; revision=9887
2004-01-27 19:46:52 +00:00
Olivier Biot 6dd857b59c From Lars Ruoff:
- use create_tempfile() to create the temporary files (causes temp files to be
  created at the same location as other Ethereal temp files). Changed temp
  filenames to "ether_rtp_dXXXXXX", where d is the stream direction.
- fixed a bug with temp files not being removed

svn path=/trunk/; revision=9886
2004-01-27 18:05:32 +00:00
Olivier Biot 8b8db29111 From Chris Wilson: add missing initialization of CL-WSP dissector handle.
As proposed by some postings on Ethereal-Dev, remove the email addresses
from the authors and refer to the AUTHORS file or the man page.

svn path=/trunk/; revision=9885
2004-01-27 17:17:31 +00:00
Guy Harris 2528c053ce Supply a pseudo-header for all 802.11 packets; add an "fcs_len" field to
it, similar to the Ethernet pseudo-header's "fcs_len" field, and use it
in the 802.11 dissector.

svn path=/trunk/; revision=9884
2004-01-27 08:06:12 +00:00
Guy Harris 70e3d8a097 Add a detail-pane context menu item for "Export As Raw Packet Data", so
you can select something and export it without shoving the rodent up to
the menu bar.

svn path=/trunk/; revision=9883
2004-01-27 05:05:58 +00:00
Guy Harris 83cafdc1d6 For EtherNet/IP-over-TCP, handle multiple PDUs in a TCP segment and PDUs
split across segment boundaries.

svn path=/trunk/; revision=9882
2004-01-27 04:43:35 +00:00
Guy Harris 90b9aa5b64 Update Jaime Fournier's address.
svn path=/trunk/; revision=9881
2004-01-27 04:24:41 +00:00
Guy Harris 5e6ae703c7 From Jaime Fournier: update his e-mail address.
svn path=/trunk/; revision=9880
2004-01-27 04:15:49 +00:00
Guy Harris a31ced6662 Map SMPP and smpp-gsm-sms preferences to their new homes in gsm-sms-ud.
svn path=/trunk/; revision=9879
2004-01-27 04:11:48 +00:00
Guy Harris 2e56c9ad21 Update from Jaime Fournier.
svn path=/trunk/; revision=9878
2004-01-27 03:55:24 +00:00
Guy Harris 99b9c9d72e From David Richards: don't stuff the packet length into a guint8, as it
can be bigger than 255.

svn path=/trunk/; revision=9877
2004-01-27 03:49:35 +00:00
Guy Harris f97ed617de Clear the Info column.
svn path=/trunk/; revision=9876
2004-01-27 01:43:41 +00:00
Guy Harris 580a8706eb From Alastair Maw: IAX2 support.
svn path=/trunk/; revision=9875
2004-01-27 01:35:25 +00:00
Olivier Biot 13147843ba Add a correct RCS ID (starts with capitalized "i").
svn path=/trunk/; revision=9874
2004-01-27 00:30:46 +00:00
Olivier Biot dad66aaa99 Get rid of a debug printf statement.
svn path=/trunk/; revision=9873
2004-01-27 00:26:24 +00:00
Olivier Biot 4293724ef5 From Chris Wilson:
Separate the GSM SMS User Data dissector from the SMPP dissector.

	Rename the protocol.

svn path=/trunk/; revision=9872
2004-01-27 00:20:37 +00:00
Olivier Biot f63fd700f8 Add application/smil to the registered line-based text media dissector.
svn path=/trunk/; revision=9871
2004-01-26 23:49:43 +00:00
Guy Harris 0694894f57 Rename "dissect_t38_tcp()" to "dissect_t38_tcp_pdu()" to make it
clearer what it does (dissect a single T.38-over-TCP or T.38-over-TPKT
PDU).

Have "dissect_t38_udp()" that does T.38-over-UDP dissection and
"dissect_t38_tcp()" that does T.38-over-TCP dissection; register handles
for them for the appropriate protocols, rather than having a single
dissector that checks the IP protocol type.

Use -1 rather than "tvb_length(tvb)" as the length for top-level
protocol tree items.

Clean up indentation.

svn path=/trunk/; revision=9870
2004-01-26 22:52:22 +00:00
Guy Harris 5633166fbe Newlines in filter strings are a Bad Idea, as they don't display well in
the title or contents of the filtering progress bar window and don't
work very well in files such as "recent" or "dfilters".

svn path=/trunk/; revision=9869
2004-01-26 22:34:55 +00:00
Olivier Biot 0c81a75ed3 From Martin Regner:
- support both T.38IFP/TCP and T38IFP/TPKT/TCP

There is one new preference setting tpkt_usage where you can specify if TPKT
header is used. With the default setting (tpkt_usage=Maybe) the dissector
will look on the first four octets and try to determine if TPKT is used or
not. This setting seems to work well with the captures I have tried,
but there might be some scenarios where it will be better to set the value
to 'Always' or 'Never' dependant on if TPKT header is used or not.

There is also a new preference setting regarding TCP desegmentation. TCP
desegmentation is currently only supported when TPKT header
is used.
You will need to set the preference setting "Allow subdisectors to desegment
TCP streams" for TCP and also the "Desegment all TPKT
messages spanning multiple TCP segments" for TPKT if you want to use this
feature. I don't have any T.38 captures with segmented packets
so I have not been able to test this so much.

- Support for T.38 (2002) ASN.1 specification
http://www.itu.int/ITU-T/asn1/database/itu-t/t/t38/2003/T38(2002).html
 Note: This ASN.1 specification is incompatible with the Pre-Corigendum T.38
ASN.1 specification (1998) so you will need to set the preference setting
accordingly.

- When there are extra octets after the T.38 UDPTL packet you will now see
[Malformed?] in the Info-column. I thought that it
was quite irritating that non-T.38 packets could look like they were
correctly coded T.38 packets.

- There might be several T.38 IFP packets in a TCP packet for the T.38
directly over TCP scenario. There is now at least some support for this, but
since
TCP desegmentation is only supported for the TPKT scenario this will not
work if an IFP packet is splitted into several TCP packets.

svn path=/trunk/; revision=9868
2004-01-26 22:16:43 +00:00
Guy Harris 1c8f8924ac Fix a compiler warning.
svn path=/trunk/; revision=9867
2004-01-26 21:26:52 +00:00
Ulf Lamping c6201489da updated NSIS generation to build GTK version 1 or 2,
added new target "packaging" to root Makefile.nmake,
which will generate version 1 or 2 or both,
depending on config.nmake GTK?_DIR setting

svn path=/trunk/; revision=9866
2004-01-26 21:12:41 +00:00
Olivier Biot a165b0d6be Add support for the "matches" operator if HAVE_LIBPCRE is defined.
svn path=/trunk/; revision=9865
2004-01-26 21:02:36 +00:00
Guy Harris 1f078d0fff Add a dissector table for LAPD SAPIs, and move the #defines for them
into "lapd_sapi.h".  Use that to register the Q.931 dissector atop LAPD.

From Rolf Fiedler: ISDN TEI management frame support.

svn path=/trunk/; revision=9864
2004-01-26 20:48:39 +00:00
Olivier Biot 3b1f5f17b3 From Lars Ruoff:
- made streams list sortable by column
- added a button "Find Reverse" that finds the reverse stream to the
  selected forward stream. (If different reverse streams available,
  pushing the button repeatedly will cycle through all of them,
  one after the other.)
- tidied up lots of superflous code.

Also get rid of a const pointer cast warning, and remove the _U_ attribute
from rtpstream_reset().

svn path=/trunk/; revision=9863
2004-01-26 19:16:30 +00:00
Ulf Lamping 359fb7d5f6 added a tooltip to explain the behaviour of the syntax check in the filter string
svn path=/trunk/; revision=9862
2004-01-26 18:51:04 +00:00
Ulf Lamping c1a7c24df3 added a tooltip to explain the behaviour of the syntax check in the filter toolbar
svn path=/trunk/; revision=9861
2004-01-26 18:40:44 +00:00