Anders Broman
e6b7af69b5
From Evan Huus: There were two cases where we could underflow an unsigned subtraction, leading to huge values and near-infinite loops. Catch them and add an expert_info warning that the packet is bad. Also fix some other expert_info messages to hang off of the right dissection tree. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7125
...
svn path=/trunk/; revision=42122
2012-04-18 05:29:02 +00:00
Anders Broman
67c79aea50
From Evan Huus: Catch impossible sub-field counts. Fixes LTP infinite loop https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7124
...
svn path=/trunk/; revision=42121
2012-04-18 05:24:32 +00:00
Guy Harris
477185a387
If we see a 5View time-stamped header with a bad key, make sure we
...
return the right error code and information string.
InfoVista bought Accellent Group, and, at least according to the
InfoVista Web site, it's "5View", not "5Views".
svn path=/trunk/; revision=42119
2012-04-18 02:48:23 +00:00
Guy Harris
81209da65b
Fix some indentation errors from the previous change.
...
svn path=/trunk/; revision=42118
2012-04-18 00:54:11 +00:00
Guy Harris
e3053e0105
Get rid of tabs, so we don't have to worry about 4-space vs. 8-space tabs.
...
svn path=/trunk/; revision=42117
2012-04-18 00:51:18 +00:00
Guy Harris
55b4bc0061
Might as well make the loop indices just guint; the generated code's
...
unlikely to be worse, and could be better on the 32-bit-and-bigger
machines on which Wireshark runs.
svn path=/trunk/; revision=42116
2012-04-17 23:08:23 +00:00
Guy Harris
defd6f9852
Flag too-short TLVs with an expert info item - and treat any TLV length
...
less than 4 as "too short", as the TLV length includes the type and
length fields.
svn path=/trunk/; revision=42115
2012-04-17 22:36:50 +00:00
Anders Broman
cc650868af
From Evan Huus: We were using guint8s as loop counters based on field lengths, and they were overflowing/wrapping falsely. Making them guint16s fixes the problem. Bug 7122 -HCIEVT infinite loop https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7122
...
svn path=/trunk/; revision=42114
2012-04-17 21:09:10 +00:00
Anders Broman
dc49bf04c0
From Evan Huus: Break from the loop if the length is zero. Fix [Bug 7120] ASF infinite loop https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7120
...
svn path=/trunk/; revision=42113
2012-04-17 21:00:56 +00:00
Anders Broman
3a95e4cd8b
From Francesco Fondelli: fixes up issue 1) and 3) described in the bug report https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7089
...
svn path=/trunk/; revision=42112
2012-04-17 20:49:56 +00:00
pascal
4a530904f8
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7131 :
...
Always store UDL/length in hash table and check pointer coming from lookup before using it
svn path=/trunk/; revision=42111
2012-04-17 13:17:39 +00:00
ruengeler
61e2ac924d
Fix bug #7112 , where the interface ids were not saved
...
svn path=/trunk/; revision=42110
2012-04-17 13:13:30 +00:00
ruengeler
c37ae40436
Fix a typo in my name
...
svn path=/trunk/; revision=42109
2012-04-17 13:04:07 +00:00
pascal
8391900c9e
From Bertho Stultiens:
...
Use certificate values from RFC 4398
From me: rename fields according to RFC and update references to RFC
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7130
svn path=/trunk/; revision=42108
2012-04-17 12:44:04 +00:00
Alexis La Goutte
193386b281
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7115
...
802.11s Decoding Bug (Mesh Control Field)
Wrong offset use to dissector Mesh Extended Address(bug from the revision 39314)
svn path=/trunk/; revision=42105
2012-04-17 07:40:11 +00:00
Anders Broman
26bc6e72d7
From Evan Huus:
...
Do the right thing with conversation hash chains.
Adds two new functions: conversation_insert_into_hashtable() and
conversation_remove_from_hashtable() that do the right thing with conversation
hash table chains and ordering and all that. Converts conversation_new(),
conversation_set_addr2() and conversation_set_port2() to use the new functions.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7085
svn path=/trunk/; revision=42104
2012-04-17 07:17:37 +00:00
Anders Broman
bb562d518a
From Jakub Zawadzki: fix, which changes types from FT_STRING to FT_DOUBLE. Fixes GeoIP: Display Filter comparisons operators do not seem to work for negative latitude or longitude values... https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5077
...
svn path=/trunk/; revision=42103
2012-04-17 04:51:07 +00:00
pascal
570d20a978
From Nick Lowe:
...
Add a security warning if EAP-LEAP or EAP-MD5 is seen.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020
svn path=/trunk/; revision=42102
2012-04-16 18:36:01 +00:00
pascal
a4232cc6bd
Remove non-ASCII character
...
svn path=/trunk/; revision=42101
2012-04-16 18:13:34 +00:00
Chris Maynard
3f7146a937
Define ISUP_ITU_STANDARD_VARIANT before using it.
...
svn path=/trunk/; revision=42100
2012-04-16 17:17:18 +00:00
Anders Broman
b365941321
Introduce a preference to set Standard or National ITU ISUP variant.
...
svn path=/trunk/; revision=42099
2012-04-16 15:52:32 +00:00
Anders Broman
3f87ab8e85
Add dissection of French national messages.
...
svn path=/trunk/; revision=42098
2012-04-16 15:28:57 +00:00
Alexis La Goutte
2f41d15871
Make checkhf happy (a bad copy/paste ?)
...
Add Modelines information
svn path=/trunk/; revision=42097
2012-04-16 15:18:51 +00:00
Alexis La Goutte
4c3c50613b
From Paco via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7111
...
HIP dissector of the HIP_CIPHER parameter is wrong
From me:
Add a hf_tlv_cipher_id and use proto_tree_add_item
svn path=/trunk/; revision=42096
2012-04-16 15:17:33 +00:00
Anders Broman
d7192a8bac
Use content_type_parameter_str in dissect_application_isup()
...
to determine ISUP standard and ISUP variant(French).
Also fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6258
svn path=/trunk/; revision=42095
2012-04-16 14:11:32 +00:00
Anders Broman
4d897229f6
bool value should be FALSE.
...
svn path=/trunk/; revision=42094
2012-04-16 13:29:57 +00:00
Anders Broman
a43d44f907
Separate ANSI and ITU messages.
...
svn path=/trunk/; revision=42093
2012-04-16 13:28:41 +00:00
Anders Broman
d5f59e4efa
From Nick Lowe:
...
Improve names for the EAP types, add missing definition.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020
svn path=/trunk/; revision=42092
2012-04-16 08:47:18 +00:00
Anders Broman
fc41d4ad51
From Evan Huus:
...
Duplicate and misplaced 'break' statements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7106
svn path=/trunk/; revision=42091
2012-04-16 08:39:34 +00:00
Alexis La Goutte
9380f962a2
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=42090
2012-04-16 07:59:48 +00:00
Guy Harris
53155a11c0
Get rid of the error code argument to scan_local_interfaces(); nobody
...
uses it once it's filled in.
From Evan Huus: in scan_local_interfaces(), pass NULL to
capture_interface_list(), as we don't use the error string (and don't
free it, either).
In fill_capture_box(), for CANT_GET_INTERFACE_LIST, include the error
string in the report, and free it, in all cases, when we're done with
it.
svn path=/trunk/; revision=42089
2012-04-15 23:03:58 +00:00
Guy Harris
70f67d065f
From Evan Huus: fix a memory leak. Fixes bug 7097.
...
svn path=/trunk/; revision=42088
2012-04-15 22:21:50 +00:00
Guy Harris
a93f134b99
checkapi said
...
Error: the blurb for field "NMO I" ("gsm_a.nmo_1") has trailing
space in packet-gsm_a_common.c
so remove the trailing space.
svn path=/trunk/; revision=42087
2012-04-15 17:37:16 +00:00
Alexis La Goutte
9a988f7de5
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=42086
2012-04-15 17:27:50 +00:00
Gerald Combs
5758c2cd32
[Automatic manuf, services and enterprise-numbers update for 2012-04-15]
...
svn path=/trunk/; revision=42083
2012-04-15 14:03:31 +00:00
pascal
24559a876c
Fix compilation error under Windows
...
svn path=/trunk/; revision=42082
2012-04-15 12:07:47 +00:00
pascal
1e2f3bb55a
Update RRC to V10.7.0 and add dissection of Core Network System Information IEs
...
svn path=/trunk/; revision=42081
2012-04-15 11:51:40 +00:00
Michael Tüxen
bacf81ff06
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7048
...
Write timetamps for the interface statistic blocks the way specified
by http://www.winpcap.org/ntar/draft/PCAP-DumpFileFormat.html
svn path=/trunk/; revision=42080
2012-04-15 11:11:36 +00:00
Michael Tüxen
587e0213eb
Whitespace cleanup (done while debugging).
...
svn path=/trunk/; revision=42079
2012-04-15 11:08:40 +00:00
Martin Mathieson
82a2fc4934
Set the extent of the tagged parameters.
...
svn path=/trunk/; revision=42078
2012-04-15 03:41:15 +00:00
Martin Mathieson
722c68ec90
Fix a typo (just clearing my client out before I start doing diffs).
...
svn path=/trunk/; revision=42077
2012-04-15 01:38:12 +00:00
Martin Mathieson
4d256e6628
Getting closer to deleting old ROHC from PDCP dissector.
...
Don't register ROHC fields there (so its easier to find real fields with
auto-completion).
svn path=/trunk/; revision=42076
2012-04-15 01:37:08 +00:00
Guy Harris
cb8edf66a6
From Even Huus: free a strduped string. Fixes bug 7094.
...
svn path=/trunk/; revision=42074
2012-04-14 18:16:56 +00:00
Guy Harris
6b1c5a9e0d
From Evan Huus: free if_string when we're done with it. Fixes bug 7093.
...
From me: don't bother initializing if_string in its definition, as if
it's used at all it's set to a different value before all uses.
svn path=/trunk/; revision=42073
2012-04-14 18:04:12 +00:00
Guy Harris
04cd90e99e
From Evan Huus: add a missing free. Fixes bug 7092.
...
svn path=/trunk/; revision=42070
2012-04-14 17:45:03 +00:00
Guy Harris
f3c2e6087e
More double-free fixes - destroy_k12_file_data() frees its argument, so
...
calling g_free() on that argument after calling destroy_k12_file_data()
is always an error.
svn path=/trunk/; revision=42067
2012-04-14 17:20:22 +00:00
Anders Broman
514092549c
Cosmetic changes
...
svn path=/trunk/; revision=42066
2012-04-14 12:17:06 +00:00
pascal
7ded30acc1
Set direction according to destination address field also (and not only originating address).
...
svn path=/trunk/; revision=42065
2012-04-14 11:59:14 +00:00
pascal
a01bf60abf
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6202 :
...
Stop applying a specific treatment when receiving a SMS-DELIVER packet with an unknown direction (no such treatment is done for SMS-SUBMIT).
Store SMS fragment length in hash table to avoid mangling the output when displaying the reassembled SMS.
svn path=/trunk/; revision=42064
2012-04-14 11:56:12 +00:00
Anders Broman
7d1cef1a06
From Tyson Key: Support for PN532 InDeselect, Release, and InSelect Command and Response Packets. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7083
...
svn path=/trunk/; revision=42063
2012-04-14 07:58:59 +00:00