Commit graph

17414 commits

Author SHA1 Message Date
Anders Broman
e4f01d2051 From Martin Mathieson:
> > This patch adds a hidden 'sip.auth' field, that will be present 
> > whenever one of the authenticiation/authorization headers is 
> > present.
> >
> > I believe this is one place where hidden fields are justified:
> > - it is a substring of several sip.auth.* fields, so its reassuring 
> > to see the field turn green as you're typing in one of the visible 
> > fields
> > - it lets you quickly find all of the frames with any of these fields
> > (there are 4 different SIP headers that can contain the auth fields)

svn path=/trunk/; revision=17766
2006-03-30 05:02:06 +00:00
Anders Broman
901f07af60 From Martin Mathieson:
wiretap/README.developer
- the referenced default seek_read function doesn't exist now

wiretap/wtap.c
- a "hole" in encap_table was causing the wrong encap value for later 
types to be looked up (by name)

mergecap.c
- fix a couple of program name copy+paste errors from editcap.c

svn path=/trunk/; revision=17765
2006-03-30 04:58:06 +00:00
Guy Harris
015b486dc9 Get rid of an unused variable.
svn path=/trunk/; revision=17764
2006-03-29 22:11:42 +00:00
Guy Harris
01606f6114 Get rid of some unused variables.
svn path=/trunk/; revision=17763
2006-03-29 22:05:57 +00:00
Guy Harris
3ea3ee1fa2 Get rid of an unused function argument.
Clean up indentation.

svn path=/trunk/; revision=17762
2006-03-29 22:04:37 +00:00
Guy Harris
31e5e71b90 Close a comment to squelch a compiler warning.
svn path=/trunk/; revision=17761
2006-03-29 22:03:21 +00:00
Guy Harris
25ff28766f Squelch a compiler warning (for a problem that can't happen).
Fix up indentaton.

svn path=/trunk/; revision=17760
2006-03-29 21:57:58 +00:00
Guy Harris
16614b4ed1 Squelch a compiler warning.
svn path=/trunk/; revision=17759
2006-03-29 21:54:22 +00:00
Guy Harris
3b34a4f260 Squelch a compiler warning (for a problem that doesn't actually occur).
svn path=/trunk/; revision=17758
2006-03-29 21:53:26 +00:00
Anders Broman
9c5ac889e7 sccp - fix a typo
gre - fix a length error, and change the way to display 3GPP atributes.

svn path=/trunk/; revision=17757
2006-03-29 17:00:16 +00:00
Jaap Keuter
9daa63d451 The header will be there, just make sure the date is put in.
Coverity bug 148

svn path=/trunk/; revision=17756
2006-03-29 16:06:57 +00:00
Jaap Keuter
a5a7b06e54 Get elua to build on IA32
svn path=/trunk/; revision=17755
2006-03-29 10:03:50 +00:00
Gerald Combs
0c92125f1b Make sure the export dialog is large enough. Fix a Unicode issue while
we're at it.

svn path=/trunk/; revision=17754
2006-03-28 23:06:11 +00:00
Jaap Keuter
9734da71a8 From Ming Zhang: the track # in read toc command dissector should be 1 instead of 4.
svn path=/trunk/; revision=17753
2006-03-28 21:03:01 +00:00
Jaap Keuter
6d34f7ea92 Function should return a value.
svn path=/trunk/; revision=17752
2006-03-28 20:54:59 +00:00
Gerald Combs
071b5507c2 Fix compilation under Windows.
svn path=/trunk/; revision=17751
2006-03-28 19:25:48 +00:00
Tomas Kukosa
b3e0969367 exort functions related to bitfield and GUID
svn path=/trunk/; revision=17750
2006-03-28 10:35:26 +00:00
Luis Ontanon
75a342667b elua_field.c was added to $MODULES but not to $OBJECTS
svn path=/trunk/; revision=17749
2006-03-27 22:47:20 +00:00
Luis Ontanon
cb24ac2121 Some compilers do not handle very long lines...
Shouldn't this  preference description be somewhere else?


svn path=/trunk/; revision=17748
2006-03-27 22:37:11 +00:00
Jaap Keuter
6a093bd4a3 Major properties cleanup
svn path=/trunk/; revision=17747
2006-03-27 21:00:16 +00:00
Gerald Combs
19b5882af3 The SIP statistics bug was limited to the UI.
svn path=/trunk/; revision=17746
2006-03-27 20:36:22 +00:00
Gerald Combs
b32b775cdd Updates for CID 42.
svn path=/trunk/; revision=17745
2006-03-27 19:45:07 +00:00
Gerald Combs
1b468857b8 Be more paranoid about dereferencing pointers (and improve readability
IMHO).  This should hopefully take care of bug 826 / CID 42.

svn path=/trunk/; revision=17744
2006-03-27 19:43:17 +00:00
Luis Ontanon
dafdb5ef62 This worked because I've edited elua_field.h as .c and the only thing in elua_field was #include "elua_field.h"
This is the actual elua_field.c 


svn path=/trunk/; revision=17743
2006-03-27 19:35:57 +00:00
Luis Ontanon
01ecb3e457 Improve Field Extraction by returning a handle to a field_info instead of just the value.
svn path=/trunk/; revision=17742
2006-03-27 19:31:30 +00:00
Luis Ontanon
850dfe8fa2 add proto_all_finfos() that will return a GPtrArray containing every finfo found in a tree.
svn path=/trunk/; revision=17741
2006-03-27 19:28:02 +00:00
Luis Ontanon
c9179bea2e Forgotten in previuous commit....
svn path=/trunk/; revision=17740
2006-03-27 19:24:34 +00:00
Anders Broman
2bf7bd3a45 From Jacques, Olivier
Here is a patch for gsm_map dissector that adds USSD string decoding (mainly used in processUnstructuredSS-Request, UnstructuredSS-Request, UnstructuredSS-Notify). For now, it assumes that it will be GSM 7 bits.
It re-use packet-gsm_sms.c "gsm_sms_char_7bit_unpack" and "gsm_sms_char_ascii_decode" functions, as well as packet-smpp.c "smpp_handle_dcs" function.

svn path=/trunk/; revision=17739
2006-03-27 18:48:33 +00:00
Anders Broman
57880f531c Add W. Borgert to Authors.
svn path=/trunk/; revision=17738
2006-03-27 18:37:20 +00:00
Anders Broman
2502e30bc1 From Martin Warnes:
> I've attached a fix that cleans up this code, actually since my last 
> update of this module the particular call in question was fairly 
> redundant so I just went ahead and removed it and updated the constant 
> that specifies the maximum possible line length instead.
>
> Thanks for bring this to my attention.

svn path=/trunk/; revision=17737
2006-03-27 18:24:26 +00:00
Gerald Combs
642706ce97 Remove some unused #defines.
svn path=/trunk/; revision=17736
2006-03-27 16:57:05 +00:00
Anders Broman
43e97ddcc8 Comment out the unused code.
svn path=/trunk/; revision=17735
2006-03-27 16:28:43 +00:00
Anders Broman
4facedb3ee From Frederic Roudaut:
With a change :

#ifdef HAVE_LIBCRYPT
#define __USE_LIBGCRYPT__ 
#endif

>> > finally, I have updated my dissector using libgcrypt.
>> > It does not use openssl anymore.
>> > If gnutls is installed, all should work.
>> > Thus, now it should decrypt and dissect (transport/tunnel/several 
>> > encapsulations ...) :
>> >
>> > - NULL Encryption Algorithm
>> > - TripleDES-CBC [RFC2451] : keylen 192 bits.
>> > - AES-CBC with 128-bit keys [RFC3602] : keylen 128 and 192/256 
>> > bits.
>> > - AES-CTR [RFC3686] : keylen 160/224/288 bits. The remaining
>> > 32 bits will be used as nonce.
>> > - DES-CBC [RFC2405] : keylen 64 bits
>> >
>> > I also have added :
>> >
>> > - BLOWFISH-CBC : keylen 128 bits.
>> > - TWOFISH-CBC : keylen 128/256 bits.
>> >
>> > You have to indicate the Authentication algorithm even if all 
>> > Algorithms since it uses 12 bytes in the Auth field should work 
>> > (have a look to the README to understand why I put it
>> > ;-) ). If you consider I have to throw it away please tell me.
>> >
>> > HMAC-SHA1-96 [RFC2404]
>> > NULL
>> > AES-XCBC-MAC-96 [RFC3566]
>> > HMAC-MD5-96 [RFC2403]

svn path=/trunk/; revision=17734
2006-03-27 16:25:35 +00:00
Anders Broman
f4ef555b75 From Ravi Valmikam:
a minor fix for 3GPP2 A11 Session Updat

From me:
 a fix to packet-ppp.c to dissect the payload
and some changes in the gre dissector to display the 3GPP values.

svn path=/trunk/; revision=17733
2006-03-27 16:23:00 +00:00
Gerald Combs
480818a431 Fix a possible NULL dereference (bug 827 / CID 145). Add an SVN
ID.  Fix up whitespace.

svn path=/trunk/; revision=17732
2006-03-27 16:09:47 +00:00
Gerald Combs
aa82a38e12 Add the recent fix for CID 105.
svn path=/trunk/; revision=17731
2006-03-27 15:44:09 +00:00
Jaap Keuter
ec3f23a3a2 Fix for bug 840
svn path=/trunk/; revision=17730
2006-03-26 08:08:51 +00:00
Ulf Lamping
0990c4f2c0 fix a wrong comment: AF_INET -> AT_IPv4
svn path=/trunk/; revision=17729
2006-03-25 19:04:52 +00:00
Graeme Lunt
4dd0ac18bc Support for otherName and x400address in a GeneralName
svn path=/trunk/; revision=17728
2006-03-25 17:10:07 +00:00
Graeme Lunt
c51f4fa887 Support for P1 Strong Authentication
svn path=/trunk/; revision=17727
2006-03-25 16:48:28 +00:00
Graeme Lunt
011ced394c Support for Session Extended User Data and IMPLICIT APPLICATION tagged bitstrings
svn path=/trunk/; revision=17726
2006-03-25 16:32:46 +00:00
Jaap Keuter
719b8effbe From Ming Zhang: fix for several wrong use of ntohs in packet-scsi.c
svn path=/trunk/; revision=17725
2006-03-25 07:57:11 +00:00
Luis Ontanon
b833808fb8 - Actually Fix Coverity CID 105 It is true...
- avoid derreferencing an uninitialized leg->dest_nsap

svn path=/trunk/; revision=17724
2006-03-24 23:26:10 +00:00
Gerald Combs
eb2751cdff Finish adding the Coverity IDs. That brings us to 29 security flaws.
svn path=/trunk/; revision=17723
2006-03-24 21:48:00 +00:00
Ronnie Sahlberg
fd58413224 start decoding PA_PW_SALT in the PA-DATA structure.
for the time being   since i have never seen this salt being used elsewhere,
assume everything is the MS style salt:

guint32 nt_status
guint32 unknown
guint32 unknown


if the MS KDC does nopt allow a client to grab a ticket (due to policy   client can only log in at certain hours or such)
KDC will repsond with a failuer with edata like above   and nt-status ==  STATUS_LOGON_HOURS




svn path=/trunk/; revision=17722
2006-03-24 21:41:01 +00:00
Ronnie Sahlberg
54f9da2135 the edata field is PA-DATA for error PREAUTH_FAILED just the same as for PREAUTH_REQUIRED
add decode of edata field for the error code PREAUTH_FAILED



svn path=/trunk/; revision=17721
2006-03-24 21:16:47 +00:00
Jaap Keuter
b21337192c From Olivier Jacques:
- to_str.c: add support of "AT_NONE" address type in address_to_str_buf (avoid the assert failed later on
when messages have address type of AT_NONE - which can be the case for an MTP2 capture with FISU messages)
- packet-isup.c: changed source and destination addresses from (net_src and net_dst) to (src and dst) so 
that addresses taken into account in the statistics are the SS7 point codes

svn path=/trunk/; revision=17720
2006-03-24 14:26:01 +00:00
Ulf Lamping
de0981f611 disable the call to sync_pipe_errmsg_to_parent for now, if execv failed (so at least the *NIX versions compile again)
svn path=/trunk/; revision=17719
2006-03-24 11:05:46 +00:00
Anders Broman
8d61e9b902 Mark the value_strings static.
svn path=/trunk/; revision=17718
2006-03-24 07:10:22 +00:00
Anders Broman
9a6f6e7d37 From Ravi Valmikam
1. Decode A11 Session Update message
 
2. Decode A10 3GPP2 (GRE Payload Type 0x88D2) packets with the following attributes
    - Flow Control
    - Segmentation
    - SDI Indicator
    - Flow Discriminator

svn path=/trunk/; revision=17717
2006-03-24 07:09:35 +00:00