Commit Graph

50343 Commits

Author SHA1 Message Date
Michael Mann e2d2d12098 Replace "btsdp" tap with function to query service_infos tree, since that's all dissectors were doing with it. Not used outside of dissectors and cuts down on a few redundant global variables.
svn path=/trunk/; revision=53677
2013-11-30 19:26:18 +00:00
Michael Mann d1e4422a4a Add G.722, G.726 and SBC codecs. G.722 and G.726 are from bug 5619 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5619) and SBC is from bug 7893 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893).
Codecs are added, but (intentionally) not hooked to the RTP player as a "more generic architecture" is desired.  There are some discussions in bug 7893 on how to do this.  One thing to add would be how to handle codecs that may not be supported on all platforms.  Should the codec not be "registered" at all (with a #define over the whole module) or should it's register functions be stubbed (with a #define in each function that requires a non-supported library)

svn path=/trunk/; revision=53676
2013-11-30 15:42:14 +00:00
Pascal Quantin 021efe411c Try to please GCC 4.3.2
svn path=/trunk/; revision=53675
2013-11-30 12:31:36 +00:00
Guy Harris d62b116380 Make the code testing the Rx MCS Bitmask subfield of the Supported MCS
Set field of the HT Capabilities element a bit clearer, and add
comments.

Fix it so it doesn't assign a variable to itself, as clang warns about
that.

svn path=/trunk/; revision=53674
2013-11-30 10:17:30 +00:00
Pascal Quantin 4e3d8291fe From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9490 :
Couple packets in RTPproxy dissector not only with CookieID but also with Call-IDs

svn path=/trunk/; revision=53673
2013-11-30 09:50:04 +00:00
Pascal Quantin 8b179962d5 Update release notes
svn path=/trunk/; revision=53672
2013-11-30 08:30:04 +00:00
Michael Mann 0e669d534d README update. Bug 9174 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9174)
From Peter Wu

svn path=/trunk/; revision=53671
2013-11-30 01:50:12 +00:00
Michael Mann e1532f39ec Tx MCS set is not interpreted properly in WLAN beacon frame. Bug 8894 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8894)
#BACKPORT

svn path=/trunk/; revision=53670
2013-11-30 01:35:03 +00:00
Michael Mann 6d3d1556dc STANAG 5066 DTS Layer dissector. Bug 9217 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9217)
From İbrahim Can Yüce

From me: Update to new tcp_dissect_pdus format, minor whitespace issues noticed in wiretap files.

svn path=/trunk/; revision=53669
2013-11-30 01:18:22 +00:00
Guy Harris e52bce9f1f Fix indentation.
svn path=/trunk/; revision=53668
2013-11-30 00:53:03 +00:00
Michael Mann 00737f834b Add wifi display port to the RTSP dissector. Bug 9339 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9339)
From chaitanya

From me: Add another obsolete preference and cleanup whitespace

svn path=/trunk/; revision=53667
2013-11-30 00:30:56 +00:00
Guy Harris c6efc227a5 Strings are usually unwritable; squelch "constness is being assigned
away" warnings.

svn path=/trunk/; revision=53666
2013-11-30 00:10:18 +00:00
Guy Harris 8c338ea543 Squelch a "parentheses suggested" warning.
Casts from void * are required in C++.

svn path=/trunk/; revision=53665
2013-11-30 00:07:15 +00:00
Guy Harris 216f631e8a Casts required from void * in C++.
svn path=/trunk/; revision=53664
2013-11-30 00:05:24 +00:00
Guy Harris 1d80b1e16c Constify to squelch some warnings.
svn path=/trunk/; revision=53663
2013-11-30 00:02:46 +00:00
Guy Harris 52cfff996e Squelch some "use parentheses" warnings.
Use tab indentation uniformly.

svn path=/trunk/; revision=53662
2013-11-29 23:57:23 +00:00
Guy Harris 488e61fea0 Rename variable to avoid collisions with standard function names.
Use the st_format_type type.

svn path=/trunk/; revision=53661
2013-11-29 23:54:12 +00:00
Chris Maynard 8a849e82e1 When a snaplength isn't specifically set by the user, the default snaplength is used. In this case, rather than display the text, "default", display the actual value so the user always knows which value will be used. Other tools (tcpdump, for example) uses a different default snaplength, so it may not have been obvious to all users which value Wireshark uses for its default snaplength (even if it is documented in the man pages).
svn path=/trunk/; revision=53660
2013-11-29 23:52:32 +00:00
Guy Harris 1ca96130b3 A typedef has to actually define a type.
svn path=/trunk/; revision=53659
2013-11-29 23:46:48 +00:00
Pascal Quantin 68c8c7ef0a From Peter Lemenkov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9487 :
Use RTP payload descriptions from RTP dissector in RTPproxy codec param value

svn path=/trunk/; revision=53658
2013-11-29 22:56:34 +00:00
Michael Mann 60d6b05e23 Stats_tree enhancements for sorting, averages and burst rate. Bug 9452 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452)
From Deon van der Westhuysen

- Bug fix: object leak in stats_tree after a tap reset (for example apply statistics preferences with a stats_tree window open)
- Bug fix: correct sample code in README.stats_tree
- Add: slash in plug-in name now creates submenu as docs describe (was a bug?)
- Add: menu separator before the stat_tree registered plug-ins
- Add: stats_tree can now calculate averages for nodes; automatically calculated for range nodes. Add section in README.stats_tree describing averages.
- Add: stats_tree can now calculate burst rate of each node (like rate but with a shorter, sliding time window)
- Add: sorting for stats_tree plug-ins. Can sort on node name, count, average, min, max values and burst rate.
- Add: preferences for stats_tree system (default sort column, burst calc params)
- Add: stats_tree window copy to clipboard and export and plain text, csv and XML.
- Added sample of new functionality in $srcdir/plugins/stats_tree/pinfo_stats_tree.c
- Moved all stats_tree sample plug-ins to "IP Statistics" submenu.

svn path=/trunk/; revision=53657
2013-11-29 22:47:59 +00:00
Jörg Mayer eaaf4437ab Graham Bloice
Ensure we use the correct value for MSC_VER_REQUIRED (similar to
nmake build)

svn path=/trunk/; revision=53656
2013-11-29 21:07:23 +00:00
Jakub Zawadzki 82e2675f45 Avoid including <wiretap/wtap.h> in dissectors.
svn path=/trunk/; revision=53655
2013-11-29 20:53:00 +00:00
Jörg Mayer fb22ecce8d Graham Bloice
I've now got tshark to build from a VS solution file, had to do some hacks
to get there though, patch files attached for others to peruse, as I'm not
sure if they are the optimal solutions:

   3. As mentioned in my previous message, the VS solution chops out every
   8192nd byte from the command line passed to make-dissector-reg.py.  My
   patch (make-reg.patch) gets CMake to write out the required source file
   list to a file and modifies the python script to read in the file.  The
   python changes *should* be backwards compatible.

Me: Small fix to UseMakeDissectorReg.cmake (elseif() -> else())

svn path=/trunk/; revision=53654
2013-11-29 19:57:00 +00:00
Jakub Zawadzki d99fdfda63 Replace macros: BSWAP16, BSWAP32, BSWAP64 with glib-version.
XXX, people are not aware that expression of this macros might be evaluated multiple times, like:
 -  BSWAP16(tvb_get_letohs(tvb, off)) : \
 +  GUINT16_SWAP_LE_BE(tvb_get_letohs(tvb, off)) : \

Should be tvb_get_ntohs() called?


svn path=/trunk/; revision=53653
2013-11-29 19:21:20 +00:00
Jakub Zawadzki 5ac6474c94 Rename some of pint.h macros to match common style (bits number on the end).
pntohs  -> pntoh16
   pntohl  -> pntoh32
   pletohs -> pletoh16
   pletohl -> pletoh32
   phtons  -> phton16
   phtonl  -> phton32


svn path=/trunk/; revision=53652
2013-11-29 18:59:06 +00:00
Jakub Zawadzki 288efa5128 Expand macros: htoles(), htolel(), htolell()
svn path=/trunk/; revision=53651
2013-11-29 18:44:00 +00:00
Michael Mann 9c9a038428 General "Prosody" placeholder parameter ("prosody-") is broken down to a 6 new "Prosody" specific parameters. Bug 9425 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9425)
From zeljko

svn path=/trunk/; revision=53650
2013-11-29 17:51:56 +00:00
Martin Mathieson 73f042aa35 Fix number of selected bytes for gtp.teid_data. Also remove some stray tabs and unneeded _U_
svn path=/trunk/; revision=53649
2013-11-29 17:42:08 +00:00
Gerald Combs 27089d62a9 Clean up whitespace.
svn path=/trunk/; revision=53648
2013-11-29 15:46:50 +00:00
Jörg Mayer 718568b4ff Graham Bloice:
Always include the "true" zlib includes first. This works around a
bug in the Windows setup of GTK[23] which has a faulty zconf.h.


svn path=/trunk/; revision=53647
2013-11-29 15:40:04 +00:00
Michael Mann bf9fdc8e8f Bugfix timestamp formatting of Gigamon trailer. Bug 9433 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9433)
From Sandeep Dahiya

svn path=/trunk/; revision=53646
2013-11-29 14:55:49 +00:00
Michael Mann 8821cb7e2d Bugfixes of r53636, part of bug 9423 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9423)
From DSR Corporation

svn path=/trunk/; revision=53645
2013-11-29 13:42:09 +00:00
Pascal Quantin 9a48c7e8da Improve request / response tracking in case you have several open / close commands in the capture
svn path=/trunk/; revision=53644
2013-11-29 10:38:00 +00:00
Jörg Mayer 09770dbff4 At least winpcap checks for WIN32 and not for _WIN32, so
define it. This copies the behaviour of Makefile.nmake.

svn path=/trunk/; revision=53643
2013-11-29 09:45:44 +00:00
Alexis La Goutte 5cb8483d82 Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
svn path=/trunk/; revision=53642
2013-11-29 08:33:51 +00:00
Alexis La Goutte 09e1e860d4 Enable by default UDP conversation (Needed by udp.stream)
svn path=/trunk/; revision=53641
2013-11-29 08:02:39 +00:00
Alexis La Goutte 7e0645563a Add udp.stream display filter
The result is the same filter used by Follow UDP (may be reuse the new filter in Follow)

svn path=/trunk/; revision=53640
2013-11-29 08:02:30 +00:00
Alexis La Goutte e2f4b545d7 When clean remove also *.moc.cpp / *.rrc.ccp and ui_*.h ...
svn path=/trunk/; revision=53639
2013-11-29 08:02:19 +00:00
Alexis La Goutte 110795132b Add HTTP2 heuristic when it is encapsulated in SSL
the heuristic may be leak (only check if type > 10...)

svn path=/trunk/; revision=53638
2013-11-29 08:02:09 +00:00
Anders Broman f60aba38a4 Add an application id.
svn path=/trunk/; revision=53637
2013-11-29 07:14:13 +00:00
Michael Mann 563cf65155 Improved ZCL dissectors. Bug 9423 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9423)
From DSR Corporation

svn path=/trunk/; revision=53636
2013-11-29 03:40:16 +00:00
Gerald Combs 5acdfae070 Restore disabled "decode as" settings.
svn path=/trunk/; revision=53635
2013-11-29 03:14:24 +00:00
Jakub Zawadzki 9e0cd5d1d8 Fix typo (r53633) in one more place, fix typo in filename, make hex numbers capital.
svn path=/trunk/; revision=53634
2013-11-28 23:09:55 +00:00
Guy Harris 26446f8882 Fix (presumed) tpyo.
svn path=/trunk/; revision=53633
2013-11-28 22:36:10 +00:00
Jakub Zawadzki 3bbfb68ffa Move MPEG section table id defines to packet-mpeg-sect.h
svn path=/trunk/; revision=53632
2013-11-28 22:31:55 +00:00
Pascal Quantin 37660f413b Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9478 :
GSM SMS User Data header fill bits are wrong when using a 7 bits ASCII / IA5 encoding

svn path=/trunk/; revision=53631
2013-11-28 21:59:02 +00:00
Guy Harris 710feed2e0 GUINT_TO_POINTER() does just enough casting to suppress complaints about
32-bit integers and 64-bit pointers, so it needs to be handed a guint
(or equivalent type); it doesn't suppress warnings about 8-bit or 16-bit
integers, so those have to be cast up to guint first.

svn path=/trunk/; revision=53630
2013-11-28 20:40:46 +00:00
Michael Mann a31d10208b Bluetooth: HSP: Add support for HSP. Bug 9446 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9446)
HSP is modest version of HFP.

From Michal Labedzki.

svn path=/trunk/; revision=53629
2013-11-28 18:33:26 +00:00
Michael Mann 8dab82556c Bluetooth improvements. Bug 9446 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9446)
From Michal Labedzki.

1. Bluetooth: HFP: Fix recognizing roles. There is need to check which side SDP record is, then it is possible to recognize roles.
2. Bluetooth: RFCOMM/HFP: Fix recognizing services and roles. Direction bit means only that device is initiator of connection or not. But need information who is owner of connection (remote device or localhost), so use this information from L2CAP.
3. Bluetooth: HFP: Fix unexpected expert info
4. Bluetooth: HCI: Set addresses to host/controller. Also optimize a little handing of dissectors handles.

svn path=/trunk/; revision=53628
2013-11-28 18:11:02 +00:00