osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
12954 commits 23 branches 0 tags 1.3 GiB
Commit graph

818 commits

Author SHA1 Message Date
Guy Harris
31cbbecd00 Don't assign the const pointers passed to hash routines to non-const 
pointers.

Now that "col_set_str()" takes a "const char *" as the second argument,
we don't have to cast away the constness of strings passed to it.

svn path=/trunk/; revision=12892
 2004-12-31 02:11:13 +00:00
Guy Harris
b39dd4b7cc Don't assign a const pointer argument to a non-const pointer variable. 
svn path=/trunk/; revision=12891
 2004-12-31 02:09:48 +00:00
Guy Harris
caf46302c8 Don't assign the const pointers passed to hash routines to non-const 
pointers.

svn path=/trunk/; revision=12890
 2004-12-31 02:08:01 +00:00
Jörg Mayer
9522cf61c0 Make sure print_buff is \0-terminated 
svn path=/trunk/; revision=12886
 2004-12-31 01:56:22 +00:00
Jörg Mayer
22dad47c9a As pointed out by Guy: We should be able to filter on the original SSID, 
so use a copy of the existing one for printing.

svn path=/trunk/; revision=12885
 2004-12-31 01:37:54 +00:00
Guy Harris
a0de9d34c7 Add a "tvb_bytes_to_str_punct()" routine, which wraps 
"bytes_to_str_punct()", and use it instead of extracting the bytes and
formatting them by hand.

svn path=/trunk/; revision=12876
 2004-12-30 23:47:52 +00:00
Anders Broman
d7bda80c71 Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh 
svn path=/trunk/; revision=12873
 2004-12-30 22:40:21 +00:00
Gerald Combs
3969acf046 From Vincent Jardin: Fix the dissection of relayed messages. 
svn path=/trunk/; revision=12868
 2004-12-30 16:45:37 +00:00
Guy Harris
d1fd7820b4 In the "capture_null()" routine, handle IPv6. 
svn path=/trunk/; revision=12865
 2004-12-30 02:27:00 +00:00
Guy Harris
7e7d12b446 Update a URL. 
svn path=/trunk/; revision=12864
 2004-12-30 02:21:33 +00:00
Guy Harris
0ccf418724 Add a "get_addr_name()" routine that takes an "address *" and attempts 
to resolve it to a name.

Fix up some const-pointer-to-non-const-pointer, and
function-pointer-to-void-*, conversions.

Fix some comments.

svn path=/trunk/; revision=12863
 2004-12-30 02:10:24 +00:00
Guy Harris
0e6504201f From Albert Chin: get rid of C99/GCCisms (initializing automatic 
structures with non-constant values).

svn path=/trunk/; revision=12861
 2004-12-29 22:17:04 +00:00
Guy Harris
a16a9d2096 Add Ethernet type for DEC Local Area Systems Transport. 
svn path=/trunk/; revision=12850
 2004-12-29 00:44:45 +00:00
Ulf Lamping
89c7567797 fix a freebsd buildbot compile error, caused by myself :-( 
svn path=/trunk/; revision=12845
 2004-12-27 21:35:09 +00:00
Ulf Lamping
c8a328e2b9 fix a solaris buildbot compile error 
svn path=/trunk/; revision=12844
 2004-12-27 16:11:08 +00:00
Ulf Lamping
5bcad85d01 Again, some warnings removed. 
svn path=/trunk/; revision=12842
 2004-12-27 13:17:20 +00:00
Ulf Lamping
b026aa4bc2 Again, another warning (hopefully) removed. 
svn path=/trunk/; revision=12841
 2004-12-27 10:11:28 +00:00
Guy Harris
c6bdaa41c6 From Jouni Malinen: use a length field from the packet to determine how 
much data is available, rather than using "tvb_length_remaining()".

svn path=/trunk/; revision=12840
 2004-12-26 22:52:16 +00:00
Guy Harris
1220516388 From Yaniv Kaul: add Ethernet address-to-name (or, at least, address-to- 
vendor-name-and-next-three-bytes-in-hex) resolution for Ethernet/802.x
hardware addresses.

Move the ARP hardware types into a header file, for use by dissectors
other than the ARP dissector.

svn path=/trunk/; revision=12839
 2004-12-26 22:26:02 +00:00
Gerald Combs
dce666e0d1 From Vincent Jardin: 
- support for new DHCPv6 options
 - fix for the support of OPTION_RELAY_MSG 

svn path=/trunk/; revision=12838
 2004-12-26 18:58:52 +00:00
Ulf Lamping
bf5bf359e0 Again, some warnings removed. 
svn path=/trunk/; revision=12837
 2004-12-26 10:11:42 +00:00
Guy Harris
355c52a0b3 From Jouni Malinen: dissect TLS extensions (RFC 3546) for ClientHello 
and ServerHello.

svn path=/trunk/; revision=12836
 2004-12-26 00:28:47 +00:00
Guy Harris
ce604cf8f0 From Luis Ontanon: add more filterable fields to DNS, PGM, GTP, and RADIUS. 
svn path=/trunk/; revision=12835
 2004-12-26 00:22:16 +00:00
Ulf Lamping
5a89cfc00b Again, some warnings removed. 
svn path=/trunk/; revision=12834
 2004-12-25 18:35:21 +00:00
Ulf Lamping
872a860814 Fix a core dump causing the buildbot test menagerie to fail. It was caused by incorrectly trying to proto_tree_add_item() with a very huge length. However, someone with more SQL knowledge than me should have a qualified look at that place and do a better fix. 
svn path=/trunk/; revision=12833
 2004-12-25 14:46:40 +00:00
Ulf Lamping
78ff68d4b5 a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros 
svn path=/trunk/; revision=12832
 2004-12-25 13:49:30 +00:00
Ulf Lamping
e8459f4ea1 Again, some warnings removed. 
svn path=/trunk/; revision=12831
 2004-12-25 10:30:58 +00:00
Ulf Lamping
dc0fc1896e use GLib's pointer to int conversion macros to prevent compiler warnings 
svn path=/trunk/; revision=12830
 2004-12-24 23:17:38 +00:00
Guy Harris
ed556cd7c4 Note the RFC that describes VJ compression. 
svn path=/trunk/; revision=12829
 2004-12-24 22:21:23 +00:00
Ronnie Sahlberg
e0945a4762 New protocol RFC2510 PKIXCMP Certificate Management Protocol 
svn path=/trunk/; revision=12828
 2004-12-24 12:39:21 +00:00
Ronnie Sahlberg
0d1474e9a7 export ResonFlags from pkix1implicit 
svn path=/trunk/; revision=12827
 2004-12-24 12:22:52 +00:00
Ronnie Sahlberg
03ded18485 export Certificate and CertificateList from pkix1explicit 
svn path=/trunk/; revision=12826
 2004-12-24 12:16:27 +00:00
Ronnie Sahlberg
131c4164b4 New "protocol" the support functions from RFC2511 Certificate Request Message Format CRMF 
svn path=/trunk/; revision=12825
 2004-12-24 11:32:13 +00:00
Ronnie Sahlberg
69dd4345c1 export EnvelopedData 
svn path=/trunk/; revision=12824
 2004-12-24 11:24:35 +00:00
Ronnie Sahlberg
6b8c77703e RST segmetns are never WindowFull segments. 
svn path=/trunk/; revision=12823
 2004-12-23 19:56:29 +00:00
Ronnie Sahlberg
0b6ae100fe add another error code to dcerpc 
svn path=/trunk/; revision=12822
 2004-12-23 19:53:24 +00:00
Ulf Lamping
0da82dce11 Again, some warnings removed. 
svn path=/trunk/; revision=12819
 2004-12-23 00:27:20 +00:00
Richard Sharpe
8190410fb3 Clean up one more instance of 8-byte timestamps in SMB. Have to work on 
the 4-byte ones soon.


svn path=/trunk/; revision=12818
 2004-12-22 19:44:42 +00:00
Guy Harris
9e176608c5 RFC 2868 says that the length of a "tagged string" field must be at 
least 3 - 2 for type+length and 1 for the tag - so treat a "tagged
string" field as bad if there isn't at least one byte of data.  (It's a
bit odd that the RFC says that the tag must be in the range 0x01-0x1F -
that sounds suspiciously as if they're saying "printable characters
aren't valid tags", to allow untagged strings, which might suggest that
a field with a length of 2 should be interpreted as an empty string.)

svn path=/trunk/; revision=12817
 2004-12-22 19:27:09 +00:00
Guy Harris
e501ee7f01 Check for all bogus ACE lengths, i.e. all lengths < 4. 
Clean up indentation.

Add a comment asking whether the revision in an ACL is *really* 2 bytes
and the ACE count is *really* 4 bytes.

svn path=/trunk/; revision=12816
 2004-12-22 10:44:20 +00:00
Guy Harris
af7dca469a Add only one protocol tree item for the "weak IV" flag - add it as a 
non-hidden Boolean, and use "proto_tree_add_boolean_format()" to add it
to include the key byte.

svn path=/trunk/; revision=12815
 2004-12-22 09:58:28 +00:00
Richard Sharpe
80e3a2ed9c Add a dissection for the GET_NETWORK_FILE_OPEN_INFO and make some stuff that 
we do in several places into a subroutine. We need to do it also with the 
4-byte time stamps that are dissected all over the place. 

I had thought that that last unknown in the returned structure might be 
a count of the number of clients that have the file open, but a simple test
suggests that that is not the case.


svn path=/trunk/; revision=12812
 2004-12-22 02:40:33 +00:00
Guy Harris
d7ba617f71 In the "rdconvertXXXtostr()" routines, check that the length passed in 
is >= 0 (if it's not, that's a bug), and make the buffer index and total
length variables int as well, to match the length.

svn path=/trunk/; revision=12811
 2004-12-22 01:51:00 +00:00
Guy Harris
88cbf869eb Move the RADIUS_TIMESTAMP, RADIUS_INTEGER4_TAGGED, and RADIUS_UNKNOWN 
case branches up, so the case branches are in the same order as the
elements of the enum are, and add length checks to RADIUS_TIMESTAMP and
RADIUS_INTEGER4_TAGGED.

svn path=/trunk/; revision=12810
 2004-12-22 01:42:54 +00:00
Guy Harris
ce604f09d8 Properly declare a variable as volatile, as the longjmp done by the 
exception mechanism might clobber it otherwise.

svn path=/trunk/; revision=12809
 2004-12-22 00:30:39 +00:00
Guy Harris
7402efa058 Add some checks to make sure the AVP length is large enough for the item 
we're fetching from the AVP.

In the case of a tagged string, if the length is 2 (meaning the data
length is 0), assume there's no tag.

svn path=/trunk/; revision=12808
 2004-12-22 00:23:55 +00:00
Guy Harris
6270a8e27b Fix one comment, and put in another one giving a note about where you 
can get the protocol specs.

svn path=/trunk/; revision=12807
 2004-12-21 23:26:01 +00:00
Olivier Biot
7661effba5 From Victor Stratan: GSM SMS fixes: 
- Corrected incorrect Timezone output due to byte overflow.

 - Added descriptions for address string decoding.


svn path=/trunk/; revision=12806
 2004-12-21 21:17:44 +00:00
Guy Harris
c415e09f20 Use "format_text()" on strings, to better handle non-printable 
characters.

svn path=/trunk/; revision=12805
 2004-12-21 20:36:50 +00:00
Guy Harris
5694ead821 Put the strings for the X-Mms-Previously-Sent-By header under the MMSE 
tree rather than at the top level.

svn path=/trunk/; revision=12804
 2004-12-21 20:03:47 +00:00
Guy Harris
9461951d50 Make the array for the "setup method" for RTP, RTCP, and T.38 
conversations large enough to hold the maximum setup method size plus a
trailing '\0'.  Make the maximum setup method size 7, so that when the
trailing '\0' is included the total array length is a power of 2.  (The
longest string currently used is "Skinny", which fits in 7 characters).

This fixes problems in the RTP and RTCP dissectors similar to the one
found in the T.38 dissector.

Undo the previous change to packet-t38.c, as it's now safe to store in
method[MAX_T38_SETUP_METHOD_SIZE], because the array now has
MAX_T38_SETUP_METHOD_SIZE+1 characters.

(Should we use "strlcpy()", and supply our own "strlcpy()" if the system
and/or C library doesn't supply it?  Its semantics are a bit cleaner
than those of the "strncpy()"/null-terminate idiom, perhaps making it
less likely that mistakes of this sort will be made.)

svn path=/trunk/; revision=12803
 2004-12-21 19:28:48 +00:00
Ronnie Sahlberg
97755f83fc from metze 
make ethereal handle gss-api encrypted ldap blobs


svn path=/trunk/; revision=12802
 2004-12-21 17:05:14 +00:00
Ronnie Sahlberg
cba7da7b6c abs_time_to_str() returns a staticly allocated string. dont g_free() it. 
fix two instances of wrong parameter list to proto_tree_add_string_format()

if we call proto_tree_string()  the hf field has to be of a string format as well.



now it dissects christophe's capture without dumping core  but it looks weird.
mmse and telco people can read the specs and find ut what it wrong.



svn path=/trunk/; revision=12801
 2004-12-21 16:44:11 +00:00
Jörg Mayer
337d6a27f0 Abhijit Menon-Sen: 
- Make port configurable via prefs
        - Highlight keywords in addition to values in hexpane

svn path=/trunk/; revision=12800
 2004-12-21 13:18:08 +00:00
Jörg Mayer
773681fca3 Giles Scott: Add Wlan tap 
svn path=/trunk/; revision=12799
 2004-12-21 12:30:24 +00:00
Ulf Lamping
dc3f1c1c2a Again, some warnings removed. 
svn path=/trunk/; revision=12797
 2004-12-21 10:02:42 +00:00
Gerald Combs
687a2d71eb Fix an off-by-one error when terminating a string. 
svn path=/trunk/; revision=12796
 2004-12-21 03:50:14 +00:00
Jörg Mayer
f774652d9b Abhijit Menon-Sen: Postgres v3 support 
svn path=/trunk/; revision=12795
 2004-12-20 23:24:13 +00:00
Guy Harris
b40e2e4dfb Get rid of extra include of <string.h>. 
svn path=/trunk/; revision=12794
 2004-12-20 22:51:05 +00:00
Ulf Lamping
da27f1fac3 Removed some of the unix related warnings. I'll remove the remaining DCOM related ones in the next days, step by step (by looking at the buildbot output). 
svn path=/trunk/; revision=12793
 2004-12-20 22:29:24 +00:00
Guy Harris
65d7e1d97c Include <string.h> to declare various functions. 
svn path=/trunk/; revision=12792
 2004-12-20 22:25:13 +00:00
Guy Harris
e20d80ea57 Use "plurality()" rather than locally-defined "PLURALIZE()" macros, and 
get rid of the definition of "PLURALIZE()" in modules that don't use it.

svn path=/trunk/; revision=12791
 2004-12-20 22:13:48 +00:00
Gerald Combs
8e36c366f8 Remove an unneeded "ntohl()" call. 
svn path=/trunk/; revision=12790
 2004-12-20 16:15:29 +00:00
Jörg Mayer
d9c383275a Found by Buildbot Solaris: isprint.h include only works on glib2 systems 
svn path=/trunk/; revision=12787
 2004-12-20 10:49:12 +00:00
Guy Harris
4cc0fdc5dd Put in a stub "dissector" for LDAP_FILTER EXTENSIBLE, so we can at least 
dissect packets containing that filter type.

Note that if a dissector for a particular operation fails, we should
stop dissecting rather than trying to dissect the controls.

svn path=/trunk/; revision=12786
 2004-12-20 09:53:27 +00:00
Ronnie Sahlberg
1574f4dd5e g_strescape only takes one parameter in glib 1.x 
this makes ethereal compile for those of us that are not on the bleeding edge.
(gtk1 is much better anyway)


svn path=/trunk/; revision=12785
 2004-12-20 08:44:10 +00:00
Jörg Mayer
4ba6d382b7 - Diplay SSID in mangemntframes 
- Display unprintable characters in SSID as '.' (SSID charaters
  are of type octet, not alphanum).

svn path=/trunk/; revision=12784
 2004-12-20 00:00:06 +00:00
Ulf Lamping
b2c9c74aed removed some gcc warnings (hopefully) 
svn path=/trunk/; revision=12783
 2004-12-19 17:26:23 +00:00
Ulf Lamping
2b02b27b29 add some IRemUnknown dissectors 
svn path=/trunk/; revision=12782
 2004-12-19 16:49:34 +00:00
Ulf Lamping
1143f7e2ca tweak some comments 
svn path=/trunk/; revision=12781
 2004-12-19 16:30:25 +00:00
Ulf Lamping
519e81d46c add dissection of RemoteActivation method 
svn path=/trunk/; revision=12780
 2004-12-19 16:29:08 +00:00
Ulf Lamping
e3f96e79e7 add a lot of dissect stuff to the OXID resolver, moved some details of the DUALSTRINGARRAY to packet-dcom.c 
svn path=/trunk/; revision=12779
 2004-12-19 16:13:05 +00:00
Ulf Lamping
ae802a6a02 bugfix: remove empty line, probably caused by eol confusion 
svn path=/trunk/; revision=12778
 2004-12-19 16:04:09 +00:00
Ulf Lamping
f2fd0e2424 renamed all DCOM related interface dissectors from packet-dcerpc-... to packet_dcom_... and add DCOM IDispatch dissector (incomplete, but better than nothing... ;-) 
svn path=/trunk/; revision=12777
 2004-12-19 14:08:03 +00:00
Ulf Lamping
ea0baf468e (on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland): 
another part of the PROFINET dissectors (PN-CBA, including a lot of generic DCOM dissection) still some work to be done ...

svn path=/trunk/; revision=12776
 2004-12-19 13:46:09 +00:00
Ulf Lamping
1f73d0df93 Merge dissection of EndpointMapper interfaces of version 3 and 4 into one file, as the dissection of both interface versions are (currently) identical. (Jaime, could you please check, if EPM4 dissection is still working well?) 
svn path=/trunk/; revision=12775
 2004-12-19 10:30:33 +00:00
Ronnie Sahlberg
d0fbb2596a add detection to TCP Analysis to detect and flag segments that will completely fill the window advertized from the other side. 
I.e. when a segment is seen that would (as far as ethereal can tell from the ACKs it has seen in the other direction) fill the window completely.

It is similar to but not exactly the same as the XeroWindow detection since there are many instances where ZeroWindow detection would not work (i.e. an ACK where win==0    since many many situations occur where the window is full but no zerowindowack is ever generated)


Someone that has good english could, please, update the Wiki with this option.
It is very very useful to spot performance issues where the tcp window size is too small to accomodate the enmd-to-end latency.





svn path=/trunk/; revision=12774
 2004-12-19 07:18:04 +00:00
Ronnie Sahlberg
62f26aaeb4 abort trying to dissect ldap controls if the header doesnt look right. 
it will not solve the problem in the c06-  testmenageri capture that
contains unknown types of ldap commands   but it will at least 
stop the ldap controls dissector from dumping core.

someone interested in ldap might want to look at those "unknown ldap packets"
in the trace.



svn path=/trunk/; revision=12773
 2004-12-19 04:10:05 +00:00
Jörg Mayer
1e51ddbae3 Giles Scott: Port weak key detection from Airsnort 
svn path=/trunk/; revision=12772
 2004-12-19 04:04:49 +00:00
Ronnie Sahlberg
9f87afbca5 mark some fields as GENERATED fields 
svn path=/trunk/; revision=12771
 2004-12-19 03:30:46 +00:00
Ronnie Sahlberg
7def0aa70c the mid values in smb are too unreliable for request/response matching since they wrap so quickly. 
This has the effect that if you have a capture file with a hole in it, sa say when snoop or similar stops capturing packets for a while while writing the data to disk   you often end up with a packet just after the hole that is a response packet  and which ethereal mistakenly matches with a request/response from before the hole.


now,  when the first response is seen to a request   remove the entry from the unmatched table so that no other response can match the same request.



svn path=/trunk/; revision=12770
 2004-12-19 03:19:53 +00:00
Ronnie Sahlberg
5d1b339131 make ndmp use tcp_dissect_pdus() 
so that it will track pdu boundaries properly

not tracking pdu boundaries caused pain since it would miss too many
commands


svn path=/trunk/; revision=12769
 2004-12-18 22:09:06 +00:00
Guy Harris
b321d9fbfe When the LMP dissector rejects a packet because it {is, isn't} UDP, let 
some other dissector have it.

svn path=/trunk/; revision=12766
 2004-12-17 19:27:46 +00:00
Guy Harris
3609ea96c3 From Stefan Metzmacher: basic decoding for LDAP Controls. 
svn path=/trunk/; revision=12765
 2004-12-17 19:14:24 +00:00
Guy Harris
14c5bed304 From Yaniv Kaul: add the CCM_POST method. 
Tweak indentation.

svn path=/trunk/; revision=12761
 2004-12-15 17:50:11 +00:00
Guy Harris
c2b55b8d97 From Yaniv Kaul: DCERPC-over-HTTP(!) support. (But why didn't whoever 
came up with that not go whole hog and implement RFC 3093?)

svn path=/trunk/; revision=12756
 2004-12-15 09:10:07 +00:00
Jörg Mayer
adf24fd4b1 Fix the following gcc-4 error: 
==============
packet-ocsp.c:191: error: static declaration of 'Version_vals' follows non-static declaration
packet-x509af.h:39: error: previous declaration of 'Version_vals' was here
packet-ocsp.c: In function 'dissect_ocsp_T_response':
packet-ocsp.c:398: warning: pointer targets in passing argument 5 of 'dissect_ber_identifier' differ in signedness
packet-ocsp.c:398: warning: pointer targets in passing argument 7 of 'dissect_ber_identifier' differ in signedness
make[4]: *** [packet-ocsp.lo] Error 1
==============

This fix is in the generated file only - please fix in the right
source file too.


svn path=/trunk/; revision=12751
 2004-12-14 13:41:36 +00:00
Guy Harris
4fef292099 From Victor Stratan: correct offset calculation and add TP-PID decoding 
in SMS-SUBMIT-REPORT decoding based on 3GPP TS 23.040 V6.5.0 9.2.3.11.

svn path=/trunk/; revision=12750
 2004-12-14 08:20:32 +00:00
Guy Harris
21a206c37f In the "PPP in HDLC-Like Framing" items, consider the starting delimiter 
part of the packet's data.

If a packet has a starting and ending frame delimiter - i.e., the
delimiter at the end is followed by another delimiter - consider the
ending delimiter part of the first packet's raw data.

svn path=/trunk/; revision=12749
 2004-12-14 08:15:13 +00:00
Anders Broman
6ced79161a Don't display the end delimiter as a fragment and change the bytes higligted with "PPP DATA" to exclude 
the delimiters(or shold they both be included?)

svn path=/trunk/; revision=12748
 2004-12-13 22:19:03 +00:00
Ronnie Sahlberg
fed43e3c12 get rid of some asn2eth warnings for x509ce 
svn path=/trunk/; revision=12745
 2004-12-13 12:53:35 +00:00
Ronnie Sahlberg
eeeadf7b7b remove some asn2eth warnings 
svn path=/trunk/; revision=12744
 2004-12-13 12:43:48 +00:00
Ronnie Sahlberg
d5ed983336 change the incorrect BER_UNI_TAG_TeletextString into BER_UNI_TAG_TeletexString 
svn path=/trunk/; revision=12743
 2004-12-13 11:59:48 +00:00
Ronnie Sahlberg
396ae4d70d remove some asn2eth warnings 
svn path=/trunk/; revision=12742
 2004-12-13 11:51:20 +00:00
Guy Harris
3f0412a729 Add a protocol layer for the raw byte stream for PPP in HDLC-like 
framing, and put the raw packet and fragment data at that layer.

Add a common routine to dissect un-escaped PPP data that might have 0xff
0x03, and use it both for the raw PPP in HDLC-like framing and for
processing un-escaped data.

Check for an escape byte not followed by another byte (e.g., because the
packet is too short).

Handle the case where a chunk of that raw byte data doesn't begin with
0x7e, but starts with cruft from a previous PPP packet split across
lower-level packets.

svn path=/trunk/; revision=12741
 2004-12-13 10:10:51 +00:00
Ronnie Sahlberg
8afae320de update of the asn2eth compiler to use the types ber_[choice|sequence]_t instead of ber_[choice|sequence] 
regenerated all dissectors


fixed the choice/sequence struct to use unsigned entities for class and tag
(to reduce some compiler warning and because it should be signed quantities)



svn path=/trunk/; revision=12740
 2004-12-13 08:15:34 +00:00
Guy Harris
b14f3dbba8 Get rid of an unused parameter. 
svn path=/trunk/; revision=12736
 2004-12-13 01:34:35 +00:00
Ronnie Sahlberg
593131d132 some cmip updates to handle m-Action and m-Action-confirmed 
svn path=/trunk/; revision=12734
 2004-12-12 23:33:40 +00:00
Ronnie Sahlberg
97f465c157 make the unknown_ber helper try to dissect NumericString and ENUMERATED when it encounters them 
svn path=/trunk/; revision=12733
 2004-12-12 22:59:43 +00:00
Ronnie Sahlberg
896737c467 update the helper for BER GeneralizedTime to handle implicit tag and update all dissectors using GeneralizedTime 
svn path=/trunk/; revision=12732
 2004-12-12 22:47:24 +00:00
Ronnie Sahlberg
4490217530 update to the ber CHOICE helper to make it handle (i hope) a CHOICE inside a CHOICE properly. 
svn path=/trunk/; revision=12731
 2004-12-12 22:19:00 +00:00
Anders Broman
d44941ac8d Dissect PPP messages of ethertype 0x8881 
svn path=/trunk/; revision=12730
 2004-12-12 20:28:18 +00:00
Anders Broman
e0245dbffd Add IMSI to the tree if it's built. 
svn path=/trunk/; revision=12727
 2004-12-12 16:46:09 +00:00
Ronnie Sahlberg
bc3979ee23 minor updates, get rid of temporary files during dissection 
svn path=/trunk/; revision=12725
 2004-12-12 01:29:21 +00:00
Ronnie Sahlberg
0e528dc7a1 updates from tomas and anders 
create some missing makefiles for autogenerated dissectors

finish the transition to the new ber integer dissetor helper signature
and regenerate all ber dissectors



svn path=/trunk/; revision=12724
 2004-12-12 01:14:03 +00:00
Ronnie Sahlberg
dab0fabcad remove the function with the old signature for ber integer dissection 
svn path=/trunk/; revision=12723
 2004-12-12 00:24:21 +00:00
Ronnie Sahlberg
549fcbe6e4 i couldnt find the source to this one so i changed the autogenerated one. switch to use the new signature for ber integer dissection 
svn path=/trunk/; revision=12722
 2004-12-12 00:20:49 +00:00
Ronnie Sahlberg
8bb437f0ee update gsmmap to use the new signature for the ber integer dissection helper 
svn path=/trunk/; revision=12721
 2004-12-12 00:17:15 +00:00
Ronnie Sahlberg
bdf35ecfc1 move kerberos over to use the new signature for ber integer dissection helper 
svn path=/trunk/; revision=12720
 2004-12-12 00:12:23 +00:00
Ronnie Sahlberg
e9bd26c0d0 update h248 to use the new integer dissector phasing out useage ofg the old dissector so we later can switch over. 
svn path=/trunk/; revision=12719
 2004-12-12 00:09:05 +00:00
Olivier Biot
718c4f1ef2 From Victor Stratan: 
GSM SMS fixes:

 - Made Timezone view human readable based on 3GPP TS 23.040 V6.5.0 (9.2.3.11).

 - TP-UDHI field - located within bit no 6 one more place was left over from
   previous patch by Viorel Suman made on 9 Dec 2004.


svn path=/trunk/; revision=12718
 2004-12-11 23:47:12 +00:00
Anders Broman
fb77ff6d54 Fix another lengt issue, and comment out some other faulty code - to tired to fix it now. 
svn path=/trunk/; revision=12717
 2004-12-11 23:15:25 +00:00
Anders Broman
8de59f7fa7 Don't add the length twice if tree is built. 
svn path=/trunk/; revision=12713
 2004-12-10 17:26:11 +00:00
Gerald Combs
5d3012bd86 PacketCable byte view highlighting was offset 4 bytes for many tree view items. 
Fix the offset.

svn path=/trunk/; revision=12712
 2004-12-10 16:14:08 +00:00
Ulf Lamping
f8b0e05555 add dissection of PN-IO IOxS field (should removed the gcc warning), some more code cleanup 
svn path=/trunk/; revision=12711
 2004-12-10 15:18:29 +00:00
Guy Harris
bebb2b7705 Get rid of C++/C99-style comments - not all C compilers accept them. 
Fix some indentation.

svn path=/trunk/; revision=12710
 2004-12-10 11:20:48 +00:00
Gerald Combs
ff7494014b The PacketCable MM code was displaying the secondary record keeping server 
IP address where it should have displayed the CCC ID.

svn path=/trunk/; revision=12708
 2004-12-09 23:25:01 +00:00
Gerald Combs
d528c62de1 From Brian Caswell: 
The ACL parser will attempt to decode as many ACE structures as are
specified in the ACL structure.  If the number of ACE structures is
sufficiently large with one of the ACE structures specifying a size of
0, then the ACL parser will parse that ACE structure repeatedly,
eventually causing a denial of service to Ethereal.

I've attached a diff against HEAD that corrects the problem.  The diff
also corrects a few decoding errors in the NT ACL & ACE structures.  A
pcap is attached that reproduces the problem.

svn path=/trunk/; revision=12706
 2004-12-09 22:17:50 +00:00
Olivier Biot
7799a91851 From Viorel Suman. 
Various GSM SMS fixes:

 - Wrong positions of the fields, located within the first octet
   of the GSM SMS TPDU.

 - One byte is skipped during RP-ERROR vs. RP-ACK detecting:
   Offset must be increased only when RP-ERROR is detected in
   order to avoid one byte skipping.

 - Improper dissect method is used to dissect SMS-DELIVER-REPORT.

svn path=/trunk/; revision=12703
 2004-12-09 21:50:27 +00:00
Gerald Combs
6c8707b255 Add PacketCable Event Message information to the "Info" column. 
svn path=/trunk/; revision=12702
 2004-12-09 21:06:03 +00:00
Gerald Combs
f1857c511c Terminate value_strings with "{ 0, NULL }" instead of "{ 0, "Unknown" }". 
Otherwise, "tethereal -G values" fails on some platforms.

svn path=/trunk/; revision=12701
 2004-12-09 19:52:59 +00:00
Gerald Combs
eae0fb9b98 Improve the byte length check from the last commit, and check for the same 
problem in other parts of the code.

svn path=/trunk/; revision=12699
 2004-12-09 19:06:59 +00:00
Gerald Combs
d888d28671 Check for a bogus byte length. 
svn path=/trunk/; revision=12698
 2004-12-09 18:46:27 +00:00
Gerald Combs
c3a4d2b14f Add another token size check. 
svn path=/trunk/; revision=12697
 2004-12-09 16:37:46 +00:00
Anders Broman
ec085fdae9 Add a value string for 3gpp2 Service option values. 
svn path=/trunk/; revision=12696
 2004-12-08 19:43:21 +00:00
Guy Harris
6224fde4b4 Fix the RCS ID. 
The "if()" gets rid of one GCC warning, but adds another one - we could
leave the warning in place, as a reminder that the dissector needs to be
finished, or we could just tag the parameter with _U_ to suppress the
warning.

svn path=/trunk/; revision=12695
 2004-12-08 19:25:09 +00:00
Guy Harris
f92f3a7512 Squelch some compiler warnings. 
svn path=/trunk/; revision=12694
 2004-12-08 19:23:30 +00:00
Gerald Combs
9283135b8b Check for an invalid header length. 
svn path=/trunk/; revision=12693
 2004-12-08 15:19:10 +00:00
Jörg Mayer
9c75e56ac7 Fix the following: 
packet-ipmi.c:3568: warning: ISO C forbids initialization
        between function pointer and 'void *'
by declaring a proper function variable.

svn path=/trunk/; revision=12692
 2004-12-08 13:11:46 +00:00
Ulf Lamping
998f36cdd8 (hopefully) removed some gcc warnings 
svn path=/trunk/; revision=12691
 2004-12-08 12:35:55 +00:00
Anders Broman
ca5d55eb0b From Susanne Edlund: I have rewritten the bssgp dissector to comply with 3GPP v 6.5.0. 
svn path=/trunk/; revision=12690
 2004-12-08 07:15:46 +00:00
Guy Harris
c37fb7fabd Add a URL for an old I-D for Etheric, and ask some questions about how 
much ISUP stuff we should use?

svn path=/trunk/; revision=12689
 2004-12-08 06:21:47 +00:00
Guy Harris
3404da87fd Just use the parameter type definitions, and value_string table, from 
the ISUP dissector; if that's not the right thing to do, put the old
tables back and *don't* include "packet-isup.h".

svn path=/trunk/; revision=12688
 2004-12-08 05:58:59 +00:00
Jörg Mayer
9c43367b5a Undo previous patch: It was wrong 
svn path=/trunk/; revision=12687
 2004-12-08 05:26:40 +00:00
Jörg Mayer
66e18465ee When we #include the prototype of a function/variable, it should not 
be declared static.

svn path=/trunk/; revision=12686
 2004-12-08 05:05:05 +00:00
Ronnie Sahlberg
0cdac27ea2 aoe update 
svn path=/trunk/; revision=12685
 2004-12-07 22:52:54 +00:00
Guy Harris
e0f053ec94 From Rene Pilz: 
add the protocols GPRS Mobility Managment and GPRS Session
	Mangement to gsm_a (dtap);

	bug fix (RAND->128Bits=16Bytes != 12 Bytes).

svn path=/trunk/; revision=12682
 2004-12-07 21:09:05 +00:00
Gerald Combs
3bbde0ecd2 The standard environment separator character under Windows is ";". 
Net-SNMP expects this in the MIBS environment variable, so don't use
":" in the default MIB list if we're running under Windows.

svn path=/trunk/; revision=12681
 2004-12-07 21:06:55 +00:00
Guy Harris
4d98722689 Get rid of an unused true_false_string value. 
svn path=/trunk/; revision=12680
 2004-12-07 18:21:21 +00:00
Guy Harris
61db2c8cc2 From Brett Kuskie: add more HTTP headers as filterable fields. 
svn path=/trunk/; revision=12679
 2004-12-07 17:59:58 +00:00
Gerald Combs
1bdc52af46 Check for a bogus length value. 
svn path=/trunk/; revision=12677
 2004-12-07 16:17:50 +00:00
Jörg Mayer
97c3a23beb svn propset svn:keywords Id svn:eol-style native ..... 
Add $Id: $ where missing

svn path=/trunk/; revision=12676
 2004-12-07 11:13:58 +00:00
Ronnie Sahlberg
9b35ad5564 update one of the command names 
svn path=/trunk/; revision=12675
 2004-12-07 04:28:37 +00:00
Ronnie Sahlberg
2625d6d3e9 create a proper ETHERTYPE for ATAoverEthernet 
svn path=/trunk/; revision=12674
 2004-12-07 03:16:34 +00:00
Ronnie Sahlberg
ab3d6214d5 new protocol: ATAoverETHERNET (AoE) 
svn path=/trunk/; revision=12673
 2004-12-07 03:00:21 +00:00
Gerald Combs
ced793054b Add more suboption length checks to dissect_bap_phone_delta_opt(). 
svn path=/trunk/; revision=12672
 2004-12-06 23:12:32 +00:00
Gerald Combs
aeee8356b7 Check for a bogus authentication subheader length. 
svn path=/trunk/; revision=12671
 2004-12-06 22:32:50 +00:00
Ulf Lamping
c87fb7a010 (on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland): 
first part of the PROFINET dissectors (PN-RT, PN-DCP and PN-IO) still some work to be done ...

svn path=/trunk/; revision=12670
 2004-12-06 18:05:14 +00:00
Ronnie Sahlberg
c20df95fd5 updates to pkix1implicit (we have to think about how to rewrite both pkix1eplicit and pkix1implicit to avoid the crap with duplicate definitions from x509) 
New protocol : RFC3161  PKIX TimeStamp Protocol



svn path=/trunk/; revision=12669
 2004-12-05 21:47:49 +00:00
Gerald Combs
ba475d8c35 Grab the last (and null) byte of the content type value. 
svn path=/trunk/; revision=12668
 2004-12-05 18:40:35 +00:00
Guy Harris
da632922f3 Add a URL for the BitTorrent protocol spec. 
svn path=/trunk/; revision=12664
 2004-12-03 20:51:10 +00:00
Guy Harris
cfde79b7de From Tomasz Mrugalski: 
- option values updated to match RFC3898 (NIS/NIS+ options)
- FQDN option added (draft-ietf-dhc-dhcpv6-opt-fqdn-00.txt)
- Lifetime option added (draft-ietf-dhc-dhcpv6-opt-lifetime-00.txt)
- Long lasting typo corrected (those are identiTy associations, not
  identiFy associations)
- Fixed bug always reporting SIP DOMAIN option to be malformed (break was
  missing)
- Domains names are now parsed (in DOMAIN_LIST, SIP_SERVER_A, NIS_DOMAIN
  and NISPLUS_DOMAIN options). 

svn path=/trunk/; revision=12663
 2004-12-03 09:51:16 +00:00
Ronnie Sahlberg
aef13dcde6 make the tcp dissector distinguish between duplicate acks and window updates 
svn path=/trunk/; revision=12662
 2004-12-03 05:53:09 +00:00
Guy Harris
4437245d30 From David Fort: the DNS RR type number for IPSECKEY will be changing to 
45, so update the dissector.

svn path=/trunk/; revision=12655
 2004-12-02 08:28:10 +00:00
Gerald Combs
594c47b14d Replace GRE_FR with ETHERTYPE_RAW_FR. 
svn path=/trunk/; revision=12649
 2004-12-01 23:18:20 +00:00
Anders Broman
e29f2ac105 Make the Ericsson internal decode of IP addresses a preference instead of IF DEFS, default off. 
svn path=/trunk/; revision=12648
 2004-12-01 21:59:03 +00:00
Guy Harris
d76db3fb6e Fix a typo. 
svn path=/trunk/; revision=12644
 2004-12-01 21:05:45 +00:00
Anders Broman
1f92ee7aea Add some ethertypes 
svn path=/trunk/; revision=12643
 2004-12-01 20:58:22 +00:00
Gerald Combs
c12298c668 Catch a couple of integer overflows. 
svn path=/trunk/; revision=12641
 2004-12-01 20:51:19 +00:00
Gerald Combs
df3a7623c9 Don't access memory that may have been freed. 
svn path=/trunk/; revision=12640
 2004-12-01 19:34:51 +00:00
Guy Harris
679479be68 From Jelmer Vernooij: BitTorrent support. 
svn path=/trunk/; revision=12638
 2004-12-01 12:41:43 +00:00
Guy Harris
ea3aa64618 From Marc Poulhies: fix the handling of the authentication option when 
the authentication information is missing (which it can be), and fix a
typo.

svn path=/trunk/; revision=12637
 2004-12-01 12:15:16 +00:00
Guy Harris
cecacdb16f From Martin Regner: support for the parts of H.245 version 10 that are 
related to H.239.

svn path=/trunk/; revision=12634
 2004-12-01 11:29:57 +00:00
Guy Harris
766fcf0ba9 From Yaniv Kaul: adds LZS as a compression method, per 'Transport Layer 
Security (TLS) Protocol Compression UsingLempel-Ziv-Stac (LZS)' RFC (RFC
3943).

svn path=/trunk/; revision=12633
 2004-12-01 11:19:04 +00:00
Guy Harris
fee19e1413 Squelch some compiler warnings. 
svn path=/trunk/; revision=12632
 2004-12-01 06:48:52 +00:00
Guy Harris
7b81bb17f3 According to the part of the DCE RPC spec at 
http://www.opengroup.org/onlinepubs/009629399/chap12.htm#tagcjh_17_06_01

the number of transfer syntaxes is a u_int8, with an alignment pad byte
following it, not a u_int16.

svn path=/trunk/; revision=12631
 2004-12-01 06:44:54 +00:00
Guy Harris
cb900b4d1a Get rid of a long-obsolete comment. 
svn path=/trunk/; revision=12630
 2004-12-01 03:42:55 +00:00
Gerald Combs
077795e8fa bytes_to_str() returns a static value. Don't g_free() it. 
svn path=/trunk/; revision=12629
 2004-12-01 01:21:22 +00:00
Anders Broman
20404ffaa4 Fix port preference handling. 
svn path=/trunk/; revision=12628
 2004-11-30 22:11:56 +00:00
Anders Broman
196f22e273 New dissector for NSIP from Susanne Edlund, default port2 changed to unallocated port 19999 
svn path=/trunk/; revision=12626
 2004-11-30 21:19:25 +00:00
Gerald Combs
d45961b73f Replace a few instances of match_strval() with val_to_str(). 
svn path=/trunk/; revision=12625
 2004-11-30 16:52:21 +00:00
Ronnie Sahlberg
8f73759eef Make ethereal dissect application/pkix-crl CertificateRevocationLists over HTTP. 
svn path=/trunk/; revision=12624
 2004-11-30 04:08:16 +00:00
Ronnie Sahlberg
f07b25895b when creating a new subset tvb for a field for further dissection by child dissectors, then if the original tvb is short and doesnt contain enough data, try to create a new subset tvb with as much data we do have instead of just bailing out. 
svn path=/trunk/; revision=12623
 2004-11-30 03:39:34 +00:00
Gerald Combs
795a28ec7c Add another length check. 
svn path=/trunk/; revision=12621
 2004-11-29 19:30:12 +00:00
Guy Harris
1b96812a61 Get rid of a debug message. 
svn path=/trunk/; revision=12620
 2004-11-29 18:02:07 +00:00
Gerald Combs
37667ae337 Check for an overly large header length value in order to avoid an integer 
overflow.

svn path=/trunk/; revision=12619
 2004-11-29 17:52:38 +00:00
Ronnie Sahlberg
e433dc13c2 new protocol : RFC2560 Online Certificate Status Protocol 
svn path=/trunk/; revision=12618
 2004-11-29 09:58:16 +00:00
Ronnie Sahlberg
8b4a9a21e1 export some more sympols from PKIX1EXPLICIT 
svn path=/trunk/; revision=12617
 2004-11-29 08:43:19 +00:00
Ronnie Sahlberg
748784dc6b Export AuthorityInfoAccessSyntax from pkix1implicit 
svn path=/trunk/; revision=12616
 2004-11-29 07:57:19 +00:00
Anders Broman
d607cdb1e4 From LEGO if Mate is pressent call it. 
svn path=/trunk/; revision=12615
 2004-11-28 20:52:52 +00:00
Anders Broman
d7f54a23e8 Bugfixes- handle zero length bytecode, handle end-off-message with implied parameters(udvm initialised to zero). 
svn path=/trunk/; revision=12614
 2004-11-28 19:41:17 +00:00
Ronnie Sahlberg
43f6f484ac new protocol : RFC3820 PKIXProxy 
svn path=/trunk/; revision=12610
 2004-11-28 04:26:27 +00:00
Gerald Combs
a0ad7be1d1 The recent length check added to proto_tree_add_string() revealed a 
couple of problems when reading the PROTOS SNMP captures.  Check for
integer overflows in dissect_snmp_pdu and asn1_null_decode.

svn path=/trunk/; revision=12609
 2004-11-28 04:21:30 +00:00
Ronnie Sahlberg
a95e6e0407 it appears that a SES_REFUSE spdu actually contains a CMIP-A-ASSOCIATE and not a CMIP-A-ABORT 
svn path=/trunk/; revision=12608
 2004-11-27 00:11:52 +00:00
Ronnie Sahlberg
c0e68bf50c prettify the printing of the octet_format field which is really just a BCD 
svn path=/trunk/; revision=12607
 2004-11-26 23:14:30 +00:00
Ronnie Sahlberg
c4b39a818f New protocol: RFC3709 LogotypeCertificateExtensions 
svn path=/trunk/; revision=12606
 2004-11-26 00:56:22 +00:00
Ronnie Sahlberg
222ba89923 update dissection of unknown blobs to try to dissect even more stuff. 
svn path=/trunk/; revision=12605
 2004-11-25 22:27:52 +00:00
Ronnie Sahlberg
43045f122d updates to prettify a bit when attempting to dissect an unknown blob 
svn path=/trunk/; revision=12604
 2004-11-25 21:30:38 +00:00
Ronnie Sahlberg
d10fa2e070 try to print an IPAddress as an ip address and not as a 4 byte octet string 
svn path=/trunk/; revision=12603
 2004-11-25 21:00:17 +00:00
Ronnie Sahlberg
9d81458421 from Stig: change the draft number for NAT-D 
svn path=/trunk/; revision=12602
 2004-11-25 20:44:17 +00:00
Ronnie Sahlberg
311c02124c From Giles Scott : updates to packet-nt-sonmp.c 
svn path=/trunk/; revision=12601
 2004-11-25 20:38:10 +00:00
Ronnie Sahlberg
776ca2b654 From LEGO: make the request id and operation filterable 
svn path=/trunk/; revision=12599
 2004-11-24 21:26:52 +00:00
Anders Broman
a8487d1bc3 add some 3gpp2 AVP:s to packet-radius.c and use "vendor" table packet-3g-a11.c 
svn path=/trunk/; revision=12595
 2004-11-24 12:25:37 +00:00
Guy Harris
7c3027c5e9 Export two versions of the Ethereal dissector, for use with encapsulated 
Ethernet frames, one for encapsulated frames that include an FCS and one
for encapsulated frames that don't include an FCS.  Use the appropriate
versions.

In the ISL dissector, do the same sort of processing we do in the
Ethernet dissector to figure out whether the frame has a trailer or not
and whether it has an FCS or not.

svn path=/trunk/; revision=12593
 2004-11-24 09:13:52 +00:00
Guy Harris
b3b1679a57 Fix some typoes. 
svn path=/trunk/; revision=12592
 2004-11-24 09:00:23 +00:00
Guy Harris
ad2583dcd9 Only interpret a frame as an FW1 header if it looks like one, as per a 
patch from Yaniv Kaul.

svn path=/trunk/; revision=12590
 2004-11-24 06:04:43 +00:00
Guy Harris
f0bb45622b From Yaniv Kaul: the authentication token might be NTLMSSP or it might 
be GSS-API.

svn path=/trunk/; revision=12589
 2004-11-24 04:14:56 +00:00
Guy Harris
8747b8e544 From Lane Hu: add support for more IPMI commands. 
svn path=/trunk/; revision=12588
 2004-11-24 03:54:40 +00:00
Guy Harris
ff3efbb9ff From Francisco Alcoba: handle RTP over IPv6. 
svn path=/trunk/; revision=12586
 2004-11-24 03:18:30 +00:00
Guy Harris
b0993663a1 From Jeff Morriss: SSCOP over UDP and SSCF-NNI support. 
svn path=/trunk/; revision=12585
 2004-11-24 02:59:49 +00:00