it as such.
Clear the Info column when dissecting cells for an AAL we handle before
dissecting the cell, and set the Info column for OAM cells.
svn path=/trunk/; revision=13222
packet-redback.c(63) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data
packet-redback.c(64) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data
packet-redback.c(65) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data
packet-rmt-fec.c(108) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data
svn path=/trunk/; revision=13221
- remove duplicate fields from VSAs (every defined field in VSAs was set twice)
- dissect radius packet with avplen == 0 (did not decode authenticator when no AVPs were present)
svn path=/trunk/; revision=13216
the really really old one which is never used
and there is the DCE/RPC one that is used by all windows/cifs implementations.
We used to reserve the protocol name NETLOGON for the old obsolete protocol
and since we can not have two protocols with the same name, called
the current protocol RPC_NETLOGON instead.
that does not exactly make sense.
This renames the old obsolete protocol to SMB_NETLOGON to make way and allow
the real netlogon protocol take the name NETLOGON
svn path=/trunk/; revision=13215
Don't check, in the dissectors for particular Gnutella packets, whether
the packet goes past the end of the tvbuff - let that throw an exception
so unreassembled packets are shown as such.
Clean up indentation.
Boost GNUTELLA_MAX_SNAP_SIZE to 4096 (one Gnutella spec suggests that
packets should be < 4K), and use it to
1) clamp the length of packets (so we don't do huge reassembly
or have problems when the total packet length, including the
header, overflows 32 bits)
and
2) check the length of packets before using tcp_dissect_pdus(),
to distinguish between packets to be reassembled and a
transfer stream.
Pass the correct value to tcp_dissect_pdus() as the header length.
svn path=/trunk/; revision=13211
change its signature to match the autogenerated signatures.
add a small wrapper function so tha tthe handwritten lsa can still call the
function through dissect_ndr_pointer()
no changes in functionality, essentially just a rename of a function and signature change
svn path=/trunk/; revision=13207
Do more, and more careful, AVP length checks.
Use tvb_format_text() to display strings.
Just use "col_add_fstr()" to set the Info column - there's no need to
format into a buffer and then set the column to that buffer.
Make the L2TP dissector a "new-style" dissector and have it reject
packets with an unknown version number - the dissection effect is the
same if no other dissector claims the packet (it just gets displayed as
data), but this allows other dissectors to claim it.
Don't use the length field if the length bit isn't set.
svn path=/trunk/; revision=13201
If the information that we used to guess the payload type is part of the
payload, don't make it correspond to the "Payload Type" protocol tree
item - it's covered by the dissected payload.
If we don't succeed in guessing the protocol type, just dissect the
payload as data.
svn path=/trunk/; revision=13200
I might later add something like "View/Auto Resize Columns" with a checkbox menu item, so this is done everytime a capture file finished loading. However, I don't know how well this will work together with "Update list of packets in real time" while doing a capture.
svn path=/trunk/; revision=13192
this construct is aligned on 4 byte boundaries in ndr and NOT
8 bytes as a real uint64 (== hyper) would be.
rename the existing dissect_ndr_uint64 ro dissect_ndr_duint32 (double uint32) to make it reflect better the alignment of the type.
svn path=/trunk/; revision=13184