Commit Graph

80744 Commits

Author SHA1 Message Date
Gerald Combs dacbfc4ae9 Tools: Try to exit more gracefully from fuzzing.
If we catch a signal while we're fuzzing, exit with a successful status
and clean up after ourselves.
2021-05-11 11:07:27 -07:00
Guy Harris bc8bb0152e commview: add support for newer NCFX file format. 2021-05-11 07:40:51 +00:00
Preston Hunt 3fb0a46319 IEEE 802.11: correct name of FTM
According to 802.11-2020, the frame is "Fine Timing Measurement" (FTM)
and not "Fine Timing Measurement Response".
2021-05-10 08:40:39 -07:00
Andreas Schultz a6dfdef9b5 PFCP: add dissector for Broadband Forum TR-459 2021-05-10 15:24:45 +00:00
Andreas Schultz 9e8e4f3ed3 PFCP: rework Enterprise IE decoder to be reusable
Add generic, table driven enterprise IE decode that can be reused
by all enterprise specific IEs.
2021-05-10 15:24:45 +00:00
Andreas Schultz 40d2584b46 PFCP: update Travelping vendor IEs 2021-05-10 15:24:45 +00:00
Gerald Combs 3a62834f46 IEC104: Initialize a variable.
Make sure "tm" is initialized. This should fix

*** CID 1484550:  Uninitialized variables  (UNINIT)
/builds/wireshark/wireshark/epan/dissectors/packet-iec104.c: 1120 in get_CP32TimeA()
1114
1115     	/* The CP32Time2a structure does not contain any mm/dd/yyyy information.  Set these as default to 1/1/2000 */
1116     	tm.tm_mday = 1;
1117     	tm.tm_mon = 0;
1118     	tm.tm_year = 100;
1119
>>>     CID 1484550:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "tm.tm_isdst" when calling "mktime".
1120     	datetime.secs = mktime(&tm);
1121
1122     	ti = proto_tree_add_time(tree, hf_iec60870_5_103_cp32time2a, tvb, *offset, 4, &datetime);
1123     	cp32time2a_tree = proto_item_add_subtree(ti, ett_iec60870_5_103_cp32time2a);
1124
1125     	proto_tree_add_item(cp32time2a_tree, hf_iec60870_5_103_cp32time2a_ms, tvb, *offset, 2, ENC_LITTLE_ENDIAN);
2021-05-10 05:38:47 +00:00
John Thacker 1701a2db5d S1AP: Use specific MCC/MNC fields
Use the specific MCC/MNC fields for the LAI, CGI, ECGI, NR-CGI, TAI,
and 5GS-TAI IEs, continuing to use E212_NONE for PLMNidentity in all
other cases. Add fields and an enum value for 5GS-TAI to packet-e212.
(The 5GSTAC has an additional octet compared to the original TAC.)
2021-05-09 23:07:19 -04:00
John Thacker a106ba9d27 F1AP: Use specific MCC/MNC fields for NRCGI
Use specific MCC/MNC fields for NRCGI IE, continue to use E212_NONE
by default for everything else.
2021-05-09 10:02:36 -04:00
Dr. Lars Völker 02fc9ea059 SOME/IP: Cleanup formatting and fixed typos
This patch makes the formatting a bit more consistent as well as
fixes and optimizes the help strings a bit.
2021-05-09 11:59:05 +00:00
Anders Broman 2fe4f1af76 gtpv2: Use the correct name for Remaining Running Service Gap Timer 2021-05-09 13:03:40 +02:00
Gerald Combs 1d3a3491ec [Automatic update for 2021-05-09]
Update manuf, services enterprise numbers, translations, and other items.
2021-05-09 09:29:13 +00:00
Chris Bontje 37e7f331c3 Clear final build warning (hopefully) 2021-05-09 05:21:40 +00:00
Chris Bontje 81ecbc0cb5 Clear build warnings 2021-05-09 05:21:40 +00:00
Chris Bontje 0ad284cbbc packet-iec104.c - Add IEC 60870-5-103 Protocol Dissection
- IEC 60870-5-103 is a derivative protocol of the main 101/104 variants.
- It is used primarily for RTU to IED communication and facilitates
collection of basic status, metering and fault data with several same or
similar field types and data formatting.
- This protocol is primarily serial-only but it can be present on
Ethernet-tunneled-serial communication circuits if port servers are used.
- This initial version supports the following ASDU Types:
Prim-to-Sec (RTU-to-IED): Types 6, 7, 20, 45/46 (private)
Sec-to-Prim (IED-to-RTU): Types 1, 5, 6, 8, 9, 205 (private)
2021-05-09 05:21:40 +00:00
John Thacker 0b8051db67 E1AP: Use specific MNC/MCC fields for NR-CGI
Use E212_NRCGI for the NR-CGI IE, continue to use E212_NONE by default
otherwise.
2021-05-08 19:38:39 -04:00
John Thacker 7f4c33d634 RANAP: Use specific MNC/MCC fields when applicable
When the PLMNidentity information element is part of the CGI, LAI, RAI,
SAI, or TAI, use the specific MNC/MCC field types as appropriate.
Otherwise, use E212_NONE as before.
2021-05-08 17:26:04 -04:00
John Thacker 7c1efdf712 SABP: Use SAI specific MCC/MNC fields
The field here is always part of a Service Area Identifier (as expected
in the Service Area Broadcast Protocol), so use E212_SAI instead of
E212_NONE.
2021-05-08 15:45:05 -04:00
Volodymyr Khomenko 3994d52b82 NFS4: added dissector for fattr4.FS_Charset_Cap
Implemented dissector for FS_Charset_Cap attribute of fattr4.bitmap4;
it is needed for NFS4 GETATTR or READDIR Reply packets
when FS_Charset_Cap attr was used in request. Closes #17377
2021-05-08 18:47:27 +00:00
Anders Broman 71e6b0498a http: Add dissection of HTTP2-Settings
Closes #17370
2021-05-08 17:14:45 +00:00
Dr. Lars Völker 1dc5579366 WIP: SOME/IP: Adding support for WireType-Length-Value encoding
This patch adds support for a WTLV encoding. While this feature is
not part of the original SOME/IP standard, it got later added as
experimental/draft feature to the AUTOSAR specification.
2021-05-08 15:28:46 +00:00
Preston Hunt be3d6ed23c IEEE 802.11: indicate termination for FTM Response
Add (Termination) to the summary when dissecting an FTM Response with
Dialog Token == 0 (which indicates a termination).
2021-05-08 07:26:57 +00:00
Tomas Kukosa 9a31ed93c0 ITS: fix unused LongitudinalAccelerationValue_vals 2021-05-08 06:57:44 +00:00
Tomas Kukosa f04c6d3b18 ITS: use custom formatters for better readability 2021-05-08 06:57:44 +00:00
Gerald Combs 9c6aef746a GitLab CI: Adjust the Documentation rules.
GitLab CI annoyingly shows "⚙ blocked" in the pipeline UI if you have
any jobs that can be run manually instead of a green checkmark even if
all of the other jobs in the pipeline have passed. It's not clear that
"blocked" means "you can run this manually if needed," so adjust the
Documentation rule so that this doesn't happen.
2021-05-07 21:51:24 +00:00
Gerald Combs 4266e1e9ba Tools: Show only filenames when fuzzing.
Show only the basename of each capture file when fuzzing, which is less
noisy than the full pathname.
2021-05-07 14:21:09 -07:00
Gerald Combs 7c6df3848f GitLab CI: Give our jobs proper names.
GitLab's job YAML parser allows spaces in key names and our jobs are
visible in the web UI, so give them proper names.
2021-05-07 19:26:31 +00:00
Gerald Combs bedf0eb21c GitLab CI: Restore the ability to run pipelines from the web UI. 2021-05-07 11:49:51 -07:00
Gerald Combs ae37347103 GitLab CI: Simply our fuzz run times. 2021-05-07 09:21:30 -07:00
Gerald Combs 826e03c9f4 CMake: Apply AUTO{MOC,UIC,RCC} more selectively.
Set CMAKE_AUTO{MOC,UIC,RCC} if we're running CMake 3.20.0 or 3.20.1 in
order to work around CMake issue 22085, otherwise set the AUTOMOC,
AUTOUIC, and AUTORCC properties for the qtui target. The latter is
preferred since it keeps us from running Qt's meta-object, user
interface, or resource compilers on code outside of ui/qt. Ping #17314.
2021-05-06 19:14:15 -07:00
Gerald Combs 0c3db4c9fd GitLab CI: Install valgrind.
Install valgrind in the fuzz-valgrind job.
2021-05-06 14:49:31 -07:00
Gerald Combs 458bc93171 GitLab CI: Fix the fuzzing before and after scripts. 2021-05-06 09:24:35 -07:00
Vadim Yanitskiy ca86d0ab38 GSM A-bis/OML: show Manufacturer ID in vendor-specific messages 2021-05-06 14:49:34 +00:00
Tomas Kukosa 7291d7f951 R09: use tvb_get_bcd_string() 2021-05-06 14:09:39 +00:00
Tomas Kukosa 016a95721a R09: add license 2021-05-06 14:09:39 +00:00
Tomas Kukosa a84d08734b R09: new dissector for R09.x public transport priority telegrams 2021-05-06 14:09:39 +00:00
Pascal Quantin 98673850a4 GTPv2: add dissection of Mapped UE Usage Type IE
Fixes #17373
2021-05-06 13:52:22 +00:00
Anders Broman 607aeb5416 HTTP2: Make it possible to configure a port range. 2021-05-06 13:33:55 +00:00
Andreas Schultz 2afa79a14d PFCP: fix UE IP address Pool Identity
Fix multiple problems with UE IP address Pool Identity
* the length of the length field needs to be added to offset
* the length field is two bytes long
* the bitmask on the lenght field is wrong
* add "Length" to the description of the length field
* decode UE IP address Pool Identity as string

Decoding the field as string makes sense because it originates from
a DIAMETER attrbiute that would usually also be decoded as string.
2021-05-06 11:37:57 +00:00
Tomas Kukosa 5af925e013 ITS: fix asn2wrs #.NO_EMIT
asn2wrs accepts #.NO_EMIT using module specific $Module$TypeName identifier
2021-05-06 07:36:08 +00:00
Tomas Kukosa be6aff9e11 ITS: fix - do not emit unused vals
Change-Id: I2c84dc965485ad12ea6703b4c11dce92b668b545
2021-05-06 07:36:08 +00:00
Tomas Kukosa 9d2f37a651 ITS: add Collective Perception Service (CPS) - ETSI TR 103 562 V2.1.1 (2019-12)
Change-Id: Ic0ddd713527ef60d49af5ac08388ce976d86c735
2021-05-06 07:36:08 +00:00
Alexis La Goutte 5682a264c1 isis(clv): Fix Dead Store (unused variable) 2021-05-06 07:18:22 +00:00
Alexis La Goutte 750563e356 vj-comp: Fix Dead Store (unused variable) 2021-05-06 07:18:22 +00:00
Alexis La Goutte 8aec509a22 nvme: Fix Dead Store (unused variable) 2021-05-06 07:18:22 +00:00
Alexis La Goutte 57024cdc0a icmp: fix Dead Store
packet-icmp.c:878:3: warning: Value stored to 'offset' is never read [deadcode.DeadStores]
2021-05-06 07:18:22 +00:00
Alexis La Goutte b4898e653a wtap_opttypes(wiretap): Fix Dead Store
Value stored to 'block_type' is never read
2021-05-06 07:18:22 +00:00
Vasily Utkin 8d0e1b798d packet-wow: Correct protocol_version field
Fixes a very small part of #11398.

The fields were incorrectly identified as error fields because Mangos,
the most popular open source emulator in 2009 incorrectly identified it
as such.

Reverse engineering of the client revealed that the fields were protocol
versions.

As well as misidentifying the field, the WOW_SERVER_TO_CLIENT version
also read the wrong field. The actual error field is the one that comes
after the protocol version field.

Correct packets are in Ember
WOW_CLIENT_TO_SERVER
03c130d3d6/src/login/grunt/client/LoginChallenge.h (L39)

WOW_SERVER_TO_CLIENT
03c130d3d6/src/login/grunt/server/LoginChallenge.h (L33)

As well as the Wiki
https://wowdev.wiki/Packets/Login/Vanilla#Challenge_packets
2021-05-06 04:10:13 +00:00
Gerald Combs 4397eed75c GitLab CI: Add Valgrind and randpkt fuzzing.
Move common fuzzing configuration items to .fuzz-ubuntu. Build using
Clang, which is what the Buildbot fuzzers did. Add jobs for fuzzing
using Valgrind and randpkt.
2021-05-05 18:54:34 -07:00
Gerald Combs da66bae61b GitLab CI: Fix a path. 2021-05-05 17:36:55 -07:00