Leave most of the content intact for now.
Change-Id: I78f47b8310cb41ac5a07d352e56ec907b36665f8
Reviewed-on: https://code.wireshark.org/review/5209
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Change-Id: I60fd9c6c486b9b3b90e32fb9ccce3973569cc2ee
Reviewed-on: https://code.wireshark.org/review/5204
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Move it to the Developer's Guide while we're here.
Nudge the markup in epan/wslua where needed. Note that we should
probably convert it to AsciiDoc (if we're going to keep it in the DG) or
Doxygen.
Change-Id: Ie175111043f98b7a37eeeb8d185a833d8e866f8b
Reviewed-on: https://code.wireshark.org/review/5203
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Implementation for this event parameter type was missing
Bug: 9625
Change-Id: I575d387ec4764fa1ecd365624d13e3f41e2473c6
Reviewed-on: https://code.wireshark.org/review/5189
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
Bug: 10676
Change-Id: I5614c640d3fd23196984eb2bb013ba15fb318305
Reviewed-on: https://code.wireshark.org/review/5200
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Bug: 10676
Change-Id: I442aa2ce44309655190752e715279d7325647336
Reviewed-on: https://code.wireshark.org/review/5199
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: I79ee9413b87722bfe4782342737cff03cfc34495
Reviewed-on: https://code.wireshark.org/review/5179
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: Ifafdc150c655caf4c7046e3038a6b5e4eeb3cf80
Reviewed-on: https://code.wireshark.org/review/5193
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
compile Wireshark with GeoIP enabled
load a USB capture
open Statistics / Endpoints
the tree is empty, USB is not amongst the selected Enpoint Types
select USB in the Endpoint Types list
-> crash
to fix this, add a NULL check for cur_tree to EndpointDialog::tabChanged()
Change-Id: I43d963ae5cd451120ac354e89e37ccbbbc2c5910
Reviewed-on: https://code.wireshark.org/review/5192
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: Ib4a5cc3b783d3a4a1477624678964a9627d582e6
Reviewed-on: https://code.wireshark.org/review/5191
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: I5a24de9a12e301d472e701140299304e2cb4fcfc
Reviewed-on: https://code.wireshark.org/review/5190
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
Change-Id: I34d8aa7034a4aacc2a95b35a30f25356b33a51b9
Reviewed-on: https://code.wireshark.org/review/5187
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
The already frozen packet format of batman-adv for Linux 3.5 was rejected by
David S. Miller. The 4addr format v14 was therefore changed after the freeze
and published in his final form in Linux 3.8.
Change-Id: I519476c4c6d62b403e197fae6a853d9bbe61f9bc
Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
Reviewed-on: https://code.wireshark.org/review/5174
Reviewed-by: Michael Mann <mmann78@netscape.net>
The type of the value of the Downlink-Granted-QoS is defined as tlv, but the
TLV definition has not given in the file.
This changeset adds the definition as per WiMAX Forum specification.
As per the spec, the TLV definition is same as the QoS-Descriptor TLV.
<Reference>
Section 5.4.2.29 QoS-Descriptor and 5.4.2.63 Downlink Granted-QoS in
WMF-T33-001-R010v05.
Change-Id: I72d97ed6f7532239cba62cc4cd1b6693fcd43123
dictionary: change type of WiMAX-Uplink-Granted-QoS VSA
This changeset changes the type of WiMAX-Uplink-Granted VSA to tlv and
provides the TLV definition as per WiMAX Forum Specification.
The TLV definition is same as the QoS-Descriptor VSA.
<Reference>
Section 5.4.2.30 Uplink Granted-QoS and 5.4.2.29 QoS-Descriptor in
WMF-T33-001-R010v05.
Change-Id: If6b505bc985c0fb41b19cf2d2fc7b4f887c72b7a
Reviewed-on: https://code.wireshark.org/review/5158
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
In the attached pcap file, there's a single DNS packet with WKS RR in the Prerequisites section.
The Protocol field of this RR is read as if it is 4 bytes long instead of 1, which actually reads part of the bytes of the following RR.
Found by boaz
Bug:10675
Change-Id: Icf12c7f3864b629a242598373c06eee4de0ca098
Reviewed-on: https://code.wireshark.org/review/5170
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This should make it possible to add checkfiltername.pl to the pre-commit script.
Change-Id: Icdee7e4ea3381fa1467bb4b5caf0f60c255adec0
Reviewed-on: https://code.wireshark.org/review/5166
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fixed an error that retransmitted frames were added to the
reassembly table.
Change-Id: I314412cb8f2ce49142e4b7f001613948f5e03bf6
Reviewed-on: https://code.wireshark.org/review/4916
Reviewed-by: Roland Knall <rknall@gmail.com>
Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
That more correctly describes it - it doesn't do any form of automatic
detection of anything, it just picks up the system settings from
wherever Qt picks them up.
Change-Id: I62d40719728cc9735e3b8f3e4202b7e61fc3f43b
Reviewed-on: https://code.wireshark.org/review/5165
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Note there can be some extra data in the CLID_INUSE case.
(Future work: dissect_nfs_clientaddr4 could use some improvement.)
Ping-Bug: 10649
Change-Id: I92f34c6cc7a9328458f1e4391b04009f5e47290b
Reviewed-on: https://code.wireshark.org/review/5141
Reviewed-by: Bruce Fields <jbrucefields@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
The code checks whether the tag AND class are matching with their expected values, but only the tag information is shown in the error message.
When the class is not matching, the error message shows the given and expected tags which are the same, confusing the user what is wrong with it.
Furthermore, the messages for SEQUENCE and SEQUENCE OF are made the same/similar.
Change-Id: I6c1d0968c903105ec7f6e0648d589a4263a8ca18
Reviewed-on: https://code.wireshark.org/review/5162
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Bug fix: do initial calls to col_...() *before* the dissection code so
that proper column info is displayed even if the dissector
exits early because of an exception, etc.
Cleanup:
- Use wmem_strbuf instead of static fixed length char arrays;
- Create/use an extended value_string;
- Use %u (not %d) when formatting unsigned values;
- Use strchr() to search a string for a character;
- Misc ...
Change-Id: I57ca584f989c3ab1cf141270cc50160f9fb980ae
Reviewed-on: https://code.wireshark.org/review/5153
Reviewed-by: Bill Meier <wmeier@newsguy.com>
value can be NULL, in which case memduping it will crash
Bug: 10667
Change-Id: I8950fae94d80a2f06f24a785532536ad73f1855d
Reviewed-on: https://code.wireshark.org/review/5152
Reviewed-by: Evan Huus <eapache@gmail.com>
This is a bit simpler and makes the field searchable.
Ping-Bug: 10649
Change-ID: I68386f987c419c0b6cbc181f29c6bce6c04fcfdb
Reviewed-on: https://code.wireshark.org/review/5145
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
NFSv4.2 is still a draft, but these three ops are implemented at least
for Linux now and are very unlikely to change any further.
Ping-Bug: 10649
Change-Id: Ia2917de59fb2b0ed7191c9f362b7eb60756d7634
Reviewed-on: https://code.wireshark.org/review/5143
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It's not an interesting attribute but I've occasionally been annoyed by
having to look it up just to verify a server isn't doing something nuts.
Ping-Bug: 10649
Change-Id: I660b62039075a4044946e590ee75ed5690290bc5
Reviewed-on: https://code.wireshark.org/review/5146
Reviewed-by: Michael Mann <mmann78@netscape.net>
Currently it's hard to tell which field is the name of the symlink and
which is the target; both are labeled just "Name".
Ping-Bug: 10649
Change-Id: I1322a3652ffbcee920a6808dcc5613cefe8d8588
Reviewed-on: https://code.wireshark.org/review/5142
Reviewed-by: Michael Mann <mmann78@netscape.net>
The protocol values here are all wrong, and miss new flags from rfc
5661.
Ping-Bug: 10649
Change-Id: I03fb2b521b415dbca5d4b77eda609eb8084da57c
Reviewed-on: https://code.wireshark.org/review/5140
Reviewed-by: Michael Mann <mmann78@netscape.net>
in not found plugins (lib/wireshark/plugins/1.99.1).
Change-Id: Ie81f3c4450789ff7e37c99e197b44e7df47d8df5
Reviewed-on: https://code.wireshark.org/review/5149
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
allow for unusual paths for Qt's rcc program (FreeBSD ports puts it in
/usr/local/lib/qt5/bin). This matches the existing functionality of the
MOC and UIC variables/programs.
Change-Id: I885d61bce54d9e893e0c2fc496a9ff767a096ae6
Reviewed-on: https://code.wireshark.org/review/5139
Petri-Dish: Stephen Fisher <stephenfisher@centurylink.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
Changed the entries so that users have access to the whole certificate in
tshark. This allows developers to process the certs in custom ways
Change-Id: I113d60b2b3f12c6b15a644ec02bbebf7134f0ece
Reviewed-on: https://code.wireshark.org/review/5119
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
We have direct access to every entry (action) in ContextMenu.
Use it instead of storing "actions" and checking its name.
Change-Id: I97a1723898409faf13280c5655b7738661ab594b
Reviewed-on: https://code.wireshark.org/review/5135
Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Gerald Combs