Commit Graph

83386 Commits

Author SHA1 Message Date
Martin Mathieson d7d2994228 check_typed_item_calls.py: fix matching of calls 2022-01-21 21:59:50 +00:00
Uli Heilmeier 81b57b29ab PPP: Fix failed assertion for tvb_bytes_to_str()
Check size before calling tvb_bytes_to_str()

Related to wireshark/wireshark#17890
2022-01-21 20:54:53 +00:00
John Thacker f57919d6ba GTP: Dissect CSG related IEs
Dissect User CSG Information (UCI), CSG Information Reporting Action,
CSG ID, and CSG Membership Indication IEs. Related to #17839.
2022-01-21 20:38:06 +00:00
Jaap Keuter f37d8bad53 GTP: add dissection of various IE's 2022-01-21 20:26:48 +00:00
John Thacker b2f78b47b4 GTP: Don't include padding in the RAC in ULI
From 3GPP TS 29.06 V 17.1.0 7.7.51:
The routing area code consists of 2 octets and is found in octet 10
and octet 11. Only the first octet (10) contains the RAC and the
second octet (11) is coded as "11111111".

Don't include the spare octet 11 in the RAC field. The RAC is only
one octet.
2022-01-21 08:49:36 -05:00
John Thacker 56f1ee5c3a GTP: Support Cell Identification IE
Related to #17839.
2022-01-21 07:48:18 -05:00
Dr. Lars Völker a05d35fd4f SOCKS: Allow SOCKS over TLS 2022-01-21 10:39:47 +00:00
John Thacker f5bb44f75f GTP: Add CAMEL Charging Information Container IE
Add CAMEL Charging Information Container IE (type 155) from
ETSI TS 129 060 7.7.54. Related to #17839
2022-01-20 09:33:29 -05:00
Dirk Ziegelmeier de0fde6e46 Profinet Plugin: Improve dissecting PDPortDataReal block 2022-01-20 05:07:08 +00:00
Dirk Ziegelmeier 74255a072f Profinet plugin: Dissect Neighbors block 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier c1a2cbcf05 Profinet Plugin: Dissect OwnPort block 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier 74d522d8d3 Profinet Plugin: Decode PDPortDataRealExtended block 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier bb34f30d56 Profinet Plugin: Cleanup diagnosis data decoding 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier 5b666b874a Profinet Plugin: Add 10BASET1L and APL MAU Type 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier 6100e284cf Profinet Plugin: Update Block Type List
According to PN AL Protocol d24MU2 Oct 2020
2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier 7efd80327d Profinet Plugin: Decode ControlBlockPlug 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier 239d9de7ad Profinet plugin: Correctly name ModuleDiffBlock bits 2022-01-20 05:07:07 +00:00
Dirk Ziegelmeier 6db8b0e4cc Profinet plugin: Decode QualifiedChannelDiagnosis 2022-01-20 05:07:07 +00:00
John Thacker feebf6bc65 GTP: Add some undecoded IEs
Add some undecoded IEs from 3GPP TS 29.060 V17.1.0:
Hop Counter (163), Signaling Priority Indication (203), Signaling
Priority Indication with NSAPI (204), ULI Timestamp (214),
and LHN-ID with NSAPI (215). Related to #17839.
2022-01-19 21:40:29 -05:00
Martin Mathieson 4720967c4a tools/check_typed_item_calls.py improvements 2022-01-19 22:32:04 +00:00
John Thacker 0729f96fdd GitLab CI: Fix Commit Check gitrevision for multiple commits
commit^N means the Nth parent of a commit object (after a merge,
for example.) It is not the same as the Nth generation ancestor
(following only the first parents), which is commit~N, or
alternatively commit^^^^^ (N times), or even commit^1^1^1....
(See 'man gitrevisions' for details.)
When the number of commits is N, we want the Nth generation ancestor.

Fixes error messages like:
fatal: ambiguous argument 'HEAD^3': unknown revision or path not
in the working tree.
2022-01-19 18:06:56 +00:00
Martin Mathieson 73b94e7aef Improvements to check_typed_item_calls.py 2022-01-19 17:14:59 +00:00
John Thacker 3e2c79d924 dumpcap: Fix segfault when failing to create temporary file
g_file_open_tmp() does not set name_used unless the temp file
is successfully created (cf. to our old hand written library
pre commit 2925fb0850). Initialize it so that g_free doesn't
free a random memory location in that case, and don't use it
otherwise after failure. Fix #17828.
2022-01-19 13:57:08 +00:00
Dario Lombardo f7b6ebcc04 tvbuff: assert the called len is > 0.
This assert will notify the higher layers that the dissector needs
to be fixed. ieee1722 and zbee-zcl dissectors have been updated to
prevent such a call.

Ref: #17882.
2022-01-19 13:22:01 +00:00
Pascal Quantin c6de71552a GSM RP: fix dissection of SMS in 5G Nf interface
Closes #17784
2022-01-19 06:46:56 +00:00
Dr. Lars Völker 1bf7904223 UDS: adding diagnostic address resolution
This patch adds diagnostic address resolution to UDS.
2022-01-19 06:32:17 +00:00
zhang zhilei 13b6cbb9cf TLCP:support GB/T 38636-2020 TLCP 2022-01-19 06:31:34 +00:00
Jaap Keuter e1f025d9f4 TVB: Don't uncompress zero sized buffers 2022-01-19 05:19:45 +00:00
John Thacker 8202125fe3 SRTCP: Warn about undecoded, not length error
If we are decoding as SRTCP with encrypted payload but srtcp_info
wasn't set up (e.g. because this was done by Decode As or a heuristic),
then since we can't calculate the length, add the expert info about
an undecoded payload rather than the expert info about an incorrect
length.

Related to #17892
2022-01-19 04:18:13 +00:00
Gerald Combs 91463dde4d NSIS: Use the correct Visual C++ Redistributable file name.
Make sure the file we attempt to execute is the one we include with
our installer. Fixes #17893.
2022-01-18 18:25:26 -08:00
Michael Tuexen 9a887cc909 macos-setup.sh: bump libssh version 2022-01-18 22:01:30 +01:00
Anders Broman fe09d8e7e5 version info: Update for Microsoft Visual Studio 2022. 2022-01-18 17:28:28 +00:00
Pascal Quantin ae1ee2f0c0 E2AP: remove an obsolete comment 2022-01-18 15:45:53 +00:00
Pascal Quantin 26d2cb085d NGAP: stop clearing the fence
Closes #17886
2022-01-18 15:45:53 +00:00
Pascal Quantin 4165159263 S1AP: stop clearing the fence
Related to #17886
2022-01-18 15:45:53 +00:00
Dario Lombardo 0461354906 sctp: fix indentation. 2022-01-18 14:48:17 +00:00
Dr. Lars Völker 2170f8e51b PTP: Clean up code to reduce warnings 2022-01-18 14:35:17 +00:00
Jerome-PS 269e662442 Adding dissection for subsystem sftp. 2022-01-18 13:09:06 +00:00
Robert Frohl ca61ee833a
wmem_alloc() moved from libwireshark.so to libwsutil.so with 3.6.x
Some external plugins use wmem_alloc() like wireshark-plugin-libvirt.
The linker needs to find it it after the move.

Fixes wireshark/wireshark#17889
2022-01-18 10:34:24 +01:00
Dr. Lars Völker 9db22e8439 EAP: Adding EAP-IKEv2 support
This patch adds basic EAP-IKEv2 support.
This does not include EAP-IKEv2 fragmentation support.
2022-01-18 07:45:53 +00:00
Dr. Lars Völker 1af0178afd PTP: Analysis of Message Intervals (Sync and PDelay_Req)
This patch adds analysis of the Sync intervals and Pdelay-Req intervals.
2022-01-18 06:02:40 +00:00
Jaap Keuter 3c4d2a28ea tvbuff: add robustness to tvb search related functions 2022-01-18 06:01:54 +00:00
Alexis La Goutte 7843c1fa89 GTP: Add Extended Commong Flags IE
from https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1595

Fix #17855
2022-01-18 05:35:44 +00:00
Dr. Lars Völker 6d5a961414 ISO15765: change addresses to 32bit
Currently the dissector maps 29bit addresses to 16bit. This limitation
is being resolved by allowing 32bit addresses to be passed on.
2022-01-18 05:25:16 +00:00
Martin Mathieson 3bbcf76d30 ORAN FH-CUS: Show I/Q values in U-Plane PRBs. 2022-01-18 05:24:35 +00:00
Gerald Combs 46cb5d5252 BLF: Make sure a struct is completely initialized.
Initialize infstream. Fixes

```
*** CID 1497282:    (UNINIT)
/builds/wireshark/wireshark/wiretap/blf.c: 506 in blf_pull_logcontainer_into_memory()
500             }
501
502             int ret = inflate(&infstream, Z_NO_FLUSH);
503             /* Z_OK should not happen here since we know how big the buffer should be */
504             if (Z_STREAM_END != ret) {
505                 ws_debug("inflate failed (return code %d) for LogContainer %d", ret, index_log_container);
>>>     CID 1497282:    (UNINIT)
>>>     Using uninitialized value "infstream.msg".
506                 if (infstream.msg != NULL) {
507                     ws_debug("inflate returned: \"%s\"", infstream.msg);
508                 }
509                 return FALSE;
510             }
511
/builds/wireshark/wireshark/wiretap/blf.c: 514 in blf_pull_logcontainer_into_memory()
508                 }
509                 return FALSE;
510             }
511
512             if (Z_OK != inflateEnd(&infstream)) {
513                 ws_debug("inflateEnd failed for LogContainer %d", index_log_container);
>>>     CID 1497282:    (UNINIT)
>>>     Using uninitialized value "infstream.msg".
514                 if (infstream.msg != NULL) {
515                     ws_debug("inflateEnd returned: \"%s\"", infstream.msg);
516                 }
517                 return FALSE;
518             }
519
/builds/wireshark/wireshark/wiretap/blf.c: 496 in blf_pull_logcontainer_into_memory()
490             infstream.avail_out = (unsigned int)tmp.real_length;
491             infstream.next_out  = buf;
492
493             /* the actual DE-compression work. */
494             if (Z_OK != inflateInit(&infstream)) {
495                 ws_debug("inflateInit failed for LogContainer %d", index_log_container);
>>>     CID 1497282:    (UNINIT)
>>>     Using uninitialized value "infstream.msg".
496                 if (infstream.msg != NULL) {
497                     ws_debug("inflateInit returned: \"%s\"", infstream.msg);
498                 }
499                 return FALSE;
500             }
501
```
2022-01-18 00:15:36 +00:00
Gerald Combs fad709a582 Docs: Use modern Asciidoctor section IDs.
Change our legacy block anchors to section IDs as described at

https://docs.asciidoctor.org/asciidoc/latest/sections/custom-ids/
2022-01-17 18:56:26 +00:00
John Thacker 92c8c2f7a0 rpm: RHEL 8 update macros
RHEL 8 and derivatives have supported the various CMake macros since
8.4 (June 2021, see https://access.redhat.com/errata/RHEA-2021:1747)
Use them there as well, so that we have a unified spec file for all
recent distributions (with the older RHEL/CentOS 7 and SLES 12 being
the only exceptions.)
2022-01-17 17:10:50 +00:00
Dario Lombardo d6a6cc72a0 cmake: fix indentation. 2022-01-17 16:38:11 +00:00
Dr. Lars Völker ea21ffdb88 ISAKMP: Fix Typo 2022-01-17 16:13:46 +00:00