osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
47,401 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

47401 Commits

Author SHA1 Message Date
Jeff Morriss e9c8d4119b Add a cast to squelch a warning. 
svn path=/trunk/; revision=50267
 2013-06-30 20:56:28 +00:00
Jeff Morriss bdd5588ed6 Fix up a mixup of the declaration of hf_vnc_auth_error_length and 
hf_vnc_auth_error.

svn path=/trunk/; revision=50264
 2013-06-30 20:06:05 +00:00
Jeff Morriss 7a767ed9c4 From Matthias Benesch via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8869 : 
This patch adds dissection of the following VNC extensions:
 - MirrorLink messages (http://mirrorlink.com/)
 - Context Information pseudo encoding (http://mirrorlink.com/)
 - Scan Line based Run-Length encoding (http://mirrorlink.com/)
 - LibVNCServer additions (http://libvncserver.sourceforge.net/)
 - H.264 encoding

From me: fix encoding arguments.

svn path=/trunk/; revision=50263
 2013-06-30 20:04:10 +00:00
Michael Mann 8723265c1d Minor improvements to VTP dissector. 
1. More items "filterable" through proto_tree_add_item and expert_add_info_format_text
2. Update protocol spec reference
3. Remove some length checks to allow for malformed packets within dissect_vlan_info since the entire "vlan info structure" is necessary. 

svn path=/trunk/; revision=50262
 2013-06-30 18:03:43 +00:00
Jeff Morriss 7fa41b815c Add a question about whether hf_pn_rt_frag_data should be FT_STRING or FT_BYTES. 
svn path=/trunk/; revision=50261
 2013-06-30 16:59:58 +00:00
Jeff Morriss c3aab70dd8 Fix the infinite loop fuzz failure reported in 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8875 :

Don't let a negative item_length decrement our offset.

svn path=/trunk/; revision=50258
 2013-06-30 16:28:52 +00:00
Jeff Morriss 772b17a6c6 Actually use the new environment variable created in r49784--apparently I forgot to check in this file (sigh). 
svn path=/trunk/; revision=50257
 2013-06-30 16:16:13 +00:00
Gerald Combs 08ba0370f9 [Automatic manuf, services and enterprise-numbers update for 2013-06-30] 
svn path=/trunk/; revision=50254
 2013-06-30 14:03:40 +00:00
Jakub Zawadzki 33abb4e091 proto_custom_set: don't fetch values twice. 
svn path=/trunk/; revision=50252
 2013-06-30 13:23:31 +00:00
Jeff Morriss df5c2548dd ip_proto.h now requires expert.h. 
svn path=/trunk/; revision=50249
 2013-06-30 11:06:32 +00:00
Michael Mann 4d18fdf67d Add expert info to dissect_ip_tcp_options(). The proto_tree_add_text seems a bit duplicative, but the byte highlighting over the whole option is nice. 
svn path=/trunk/; revision=50248
 2013-06-30 03:16:32 +00:00
Alexis La Goutte b6adc8798d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50247
 2013-06-29 22:01:21 +00:00
Alexis La Goutte 1a364db097 Fix warning from fix-encoding-args 
epan/dissectors/packet-scsi.c:  FT_BYTES:         proto_tree_add_item(tree, hf_scsi_report_opcodes_cdb_usage_data,                            tvb_v, offset_v+4, length, [[ENC_BIG_ENDIAN]-->[ENC_NA]]);

svn path=/trunk/; revision=50246
 2013-06-29 22:01:13 +00:00
Alexis La Goutte 397ab1dbb7 Fix indent (Tabs => Spaces) and add modelines info for follow_* files 
svn path=/trunk/; revision=50245
 2013-06-29 22:01:01 +00:00
Alexis La Goutte 1dfecc041c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50244
 2013-06-29 22:00:50 +00:00
Alexis La Goutte 70dde30fe9 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50243
 2013-06-29 22:00:42 +00:00
Alexis La Goutte 5da25f80b4 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50242
 2013-06-29 22:00:31 +00:00
Alexis La Goutte 6680177541 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50241
 2013-06-29 22:00:22 +00:00
Alexis La Goutte c18eb788c2 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50240
 2013-06-29 22:00:13 +00:00
Alexis La Goutte e5d0603e0b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50239
 2013-06-29 22:00:03 +00:00
Alexis La Goutte 43be7b67aa Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50238
 2013-06-29 21:59:53 +00:00
Alexis La Goutte 391f902f44 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50237
 2013-06-29 21:59:44 +00:00
Alexis La Goutte 484bf76753 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50236
 2013-06-29 21:59:35 +00:00
Alexis La Goutte e0343b57c3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50235
 2013-06-29 21:59:25 +00:00
Alexis La Goutte 229771bdc6 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50234
 2013-06-29 21:59:15 +00:00
Alexis La Goutte 64834ebbb5 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50233
 2013-06-29 21:59:06 +00:00
Alexis La Goutte a5e8bb116c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50232
 2013-06-29 21:58:57 +00:00
Alexis La Goutte e66457472d Update .gitignore to add some Windows specific build stuff to ignore list. 
svn path=/trunk/; revision=50231
 2013-06-29 21:58:46 +00:00
Michael Mann e5af2f55ee Separate IP option header fields for each dissector that uses dissect_ip_tcp_options(). Bug 8823 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8823) 
svn path=/trunk/; revision=50230
 2013-06-29 19:59:08 +00:00
Evan Huus 04f8906be3 From Fabio Tarabelloni via 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718

Zigbee dissectors for the power profile cluster and the appliance control
cluster

svn path=/trunk/; revision=50229
 2013-06-29 15:57:44 +00:00
Michael Mann 7c72e1c5ce Improvements for the KDSP dissector. Bug 8864 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8864) 
From Yuri Schaeffer

It addresses the following issues:

- Payload was included for all CAPPACKET messages. Even when not flagged by bitmap (bug).
- Frame Checksum (FCS) was not read from bitmap all following data is off by 4. (bug)
- Headers indicated in bitmap could use own subtree
- Payload is malformed because it is assumed the span 'the rest of the packet'. In reality more commands can follow. (bug)

svn path=/trunk/; revision=50228
 2013-06-29 02:54:58 +00:00
Luis Ontanon a3c320fd75 One further iteration, get things right, put placeholders for things to do. 
svn path=/trunk/; revision=50227
 2013-06-29 01:16:48 +00:00
Evan Huus 487ff8806d Callers to dissect_ndr_* functions expect pdata to be initialized on return from 
the function, so make sure it is even in error conditions and other anomaly
cases. Fixes the valgrind errors with the capture from
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8828

svn path=/trunk/; revision=50226
 2013-06-28 23:54:53 +00:00
Guy Harris 67f849fcbc Rename octet_to_hex() to low_nibble_of_octet_to_hex() to indicate what 
it actually does (it takes the low-order nibble of an octet and returns
a single character).

Cast away some warnings.

svn path=/trunk/; revision=50225
 2013-06-28 22:52:24 +00:00
Guy Harris 882db1c5fb Squelch a warning. 
Rename the "is_int" argument to fill_label_number() to make it clearer
what it indicates, i.e. whether the number is signed or unsigned.

svn path=/trunk/; revision=50224
 2013-06-28 22:47:50 +00:00
Jakub Zawadzki 832745df70 Use octet_to_hex() in another place. 
svn path=/trunk/; revision=50223
 2013-06-28 22:29:08 +00:00
Guy Harris 70075fa70f Rename AC_WIRESHARK_GCC_CFLAGS_CHECK to 
AC_WIRESHARK_COMPILER_FLAGS_CHECK, because it doesn't just affect CFLAGS
and it doesn't just affect the flags for GCC.

svn path=/trunk/; revision=50222
 2013-06-28 22:00:52 +00:00
Guy Harris eea87ac6e7 Change formatting in the hopes of making the code a bit easier to figure 
out, and update a comment.

svn path=/trunk/; revision=50221
 2013-06-28 21:51:31 +00:00
Jakub Zawadzki d0c862bfa6 Merge fill_label_[u]int to fill_label_number, hfinfo_[u]int_value_format to hfinfo_number_value_format 
svn path=/trunk/; revision=50220
 2013-06-28 21:46:41 +00:00
Guy Harris 623cca3634 When checking whether a given option should be added to the compiler 
flags, if the option should be added to the flags for both C and C++,
test both the C and C++ compilers and, if the answers are different,
print a warning; the user might have (intentionally or unintentionally)
selected mismatched compilers, e.g. clang and g++ on OS X.

svn path=/trunk/; revision=50219
 2013-06-28 21:38:51 +00:00
Luis Ontanon cf647de6a1 MS: new child 
MS: ping child
MS: set/get child parameter


svn path=/trunk/; revision=50218
 2013-06-28 21:10:52 +00:00
Jakub Zawadzki 8ccfc17cf2 Merge _hfinfo_int_value_format and _hfinfo_uint_value_format to one function hfinfo_number_vals_format 
In hfinfo_number_vals_format check how hf should be formatted.

svn path=/trunk/; revision=50217
 2013-06-28 19:54:04 +00:00
Jakub Zawadzki eecbadecf4 #micro-optimization, remove g_snprintf()'s from _hfinfo_[u]int_value_format with some new fresh replacements. 
svn path=/trunk/; revision=50216
 2013-06-28 19:34:48 +00:00
Guy Harris c0fa736323 Do the "is $CXX actually a C++ compiler" test as early as possible, so 
that it doesn't fail due to the C++ compiler not supporting -W options
that the C compiler does.

(We should fix that, too, by having separate checks for whether the C
and C++ compilers support particular options.)

svn path=/trunk/; revision=50215
 2013-06-28 19:34:35 +00:00
Pascal Quantin b5187b496b Use newly assigned DLT for PDU export functionality 
svn path=/trunk/; revision=50212
 2013-06-28 13:05:12 +00:00
Jeff Morriss 8d29106ffb From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8850 : 
The attached patch fixes the integer type of the WCCP identity mask value.
This is a bitmask which should be printed as hex, it doesn't make sense to
print it as an IPv4 address. See
http://tools.ietf.org/id/draft-wilson-wrec-wccp-v2-01.txt section 5.7.7 and
the attached capture file as an example.

The current draft http://tools.ietf.org/html/draft-mclaggan-wccp-v2rev1-00#section-6.15
doesn't mention "mask" in the names of the field any more, but the description
still describes them as mask values.

svn path=/trunk/; revision=50211
 2013-06-28 13:04:01 +00:00
Jeff Morriss 0d75d64949 From Lorand Jakab via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8852 : 
The I and R flags in Map-Notify LISP control packets are shown at an incorrect
position.  The attached patch fixes the bug.

svn path=/trunk/; revision=50210
 2013-06-28 12:52:19 +00:00
Michael Mann c1ddd6046d replace object_identifier_id with actx->external.direct_reference 
svn path=/trunk/; revision=50209
 2013-06-28 12:52:13 +00:00
Michael Mann 9009944d51 Remove all global variables in P1 dissector. Bug 8515 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515) 
Added a "subtree context" structure to asn1_ctx_t. This should allow other ASN.1 dissector global variables to be replaced when only used for transferring data between fields in a subtree.

svn path=/trunk/; revision=50208
 2013-06-28 12:43:29 +00:00
Jeff Morriss c29fb44886 From Niels de Vos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8861 : 
Recent versions of GlusterFS have extended the RPC protocol with new
procedures. The RPC-program-version has not been updated (yet?).

The attached adds support dissecting the FREMOVEXATTR, FALLOCATE and
DISCARD procedures.

svn path=/trunk/; revision=50207
 2013-06-28 12:42:41 +00:00