osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
47,401 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

47401 Commits

Author SHA1 Message Date
Alexis La Goutte 0a8f75a63f Fix some warnings from fix-encoding-args tools. 
svn path=/trunk/; revision=50367
 2013-07-03 16:46:01 +00:00
Alexis La Goutte 3220474d52 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50366
 2013-07-03 16:45:52 +00:00
Alexis La Goutte 4f2a033098 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50365
 2013-07-03 16:45:42 +00:00
Alexis La Goutte 16bd4e733d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50364
 2013-07-03 16:45:33 +00:00
Alexis La Goutte 647bad86fd Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50363
 2013-07-03 16:45:24 +00:00
Alexis La Goutte d8a21fe1db Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50362
 2013-07-03 16:45:14 +00:00
Alexis La Goutte 4da8927735 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50361
 2013-07-03 16:45:05 +00:00
Alexis La Goutte 3a1c338213 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50360
 2013-07-03 16:44:55 +00:00
Alexis La Goutte 915a81155a Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50359
 2013-07-03 16:44:45 +00:00
Alexis La Goutte a7a2017b62 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50358
 2013-07-03 16:44:36 +00:00
Alexis La Goutte 97ba22acff Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50357
 2013-07-03 16:44:26 +00:00
Alexis La Goutte bfd7c94851 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50356
 2013-07-03 16:44:17 +00:00
Alexis La Goutte dc00c8fc94 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50355
 2013-07-03 16:44:08 +00:00
Alexis La Goutte 890da55c94 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50354
 2013-07-03 16:43:58 +00:00
Alexis La Goutte 327ca65ae2 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50353
 2013-07-03 16:43:49 +00:00
Alexis La Goutte a06cccbe25 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50352
 2013-07-03 16:43:40 +00:00
Alexis La Goutte d58b0bf1a1 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50351
 2013-07-03 16:43:31 +00:00
Alexis La Goutte 82bef2abe7 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50350
 2013-07-03 16:43:21 +00:00
Alexis La Goutte 172b0237a3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50349
 2013-07-03 16:43:12 +00:00
Alexis La Goutte 88211d30ae Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50348
 2013-07-03 16:43:02 +00:00
Alexis La Goutte d34f4c3b53 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50347
 2013-07-03 16:42:53 +00:00
Alexis La Goutte 58c328100d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50346
 2013-07-03 16:42:44 +00:00
Alexis La Goutte fb9d8134c6 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50345
 2013-07-03 16:42:35 +00:00
Alexis La Goutte bfa7acca05 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=50344
 2013-07-03 16:42:25 +00:00
Alexis La Goutte 3dac733fb0 There dissectors is not ASN1 dissectors.... ! 
svn path=/trunk/; revision=50343
 2013-07-03 16:42:15 +00:00
Alexis La Goutte d9b440a07a Fix typo (Missing CR) 
svn path=/trunk/; revision=50342
 2013-07-03 16:42:00 +00:00
Irene Rüngeler 88ae57458f Attachment #11134 proposed as fix for bug #8899 by Peter Hatina 
svn path=/trunk/; revision=50341
 2013-07-03 14:12:44 +00:00
Michael Mann 0bad33df96 Fix infinite loop in VTP dissector. Bug 8887 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8887) 
svn path=/trunk/; revision=50340
 2013-07-03 12:42:17 +00:00
Pascal Quantin b00abd1c43 Check actx->private_data validity before using it 
svn path=/trunk/; revision=50339
 2013-07-03 12:01:12 +00:00
Pascal Quantin b91b990a77 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8880 : 
Check actx->private_data validity before using it

svn path=/trunk/; revision=50338
 2013-07-03 08:53:47 +00:00
Michael Mann 98492c5619 expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable 
svn path=/trunk/; revision=50337
 2013-07-03 02:59:31 +00:00
Chris Maynard fdead4df94 Fix Coverity CID 660 (Negative array index read) by holding off the assignment to yytos until after we check that pParser->yyidx is non-negative. 
See also: http://cwe.mitre.org/data/definitions/129.html
#BACKPORT(1.10)

svn path=/trunk/; revision=50336
 2013-07-03 02:28:26 +00:00
Chris Maynard 83b4b73dd1 Fix Coverity CID 280323 (Free of array-typed value) by ensuring that tpltname doesn't point to the buf[] stack array before attempting to free it. 
#BACKPORT(1.10)

svn path=/trunk/; revision=50335
 2013-07-03 01:47:18 +00:00
Guy Harris 5d87a8c461 WS_DLL_PUBLIC is now always WS_DLL_PUBLIC_NOEXTERN with "extern" added; 
just define WS_DLL_PUBLIC_NOEXTERN inside the ifdefs, and define
WS_DLL_PUBLIC as WS_DLL_PUBLIC_NOEXTERN followed by "extern".

Then rename WS_DLL_PUBLIC_NOEXTERN to WS_DLL_PUBLIC_DEF, to clarify that
it's what should be used for definitions; at least on Windows, you
*have* to use it when declaring arrays without a size, and, whilst you
might be able to use WS_DLL_PUBLIC for definitions of functions and
perhaps data definitions other than no-size arrays, it might be clearer
to rename WS_DLL_PUBLIC to WS_DLL_PUBLIC_DECL and use it only for
declarations.

svn path=/trunk/; revision=50334
 2013-07-03 01:43:39 +00:00
Evan Huus a3543e6050 From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8881 
Follow-up to r50308: misc bug fixes and tweaks to OSD2 dissection.

svn path=/trunk/; revision=50333
 2013-07-03 01:22:54 +00:00
Guy Harris 219c37c45a OK, try having WS_DLL_PUBLIC always say "extern". If *that* doesn't 
work, because it can't be used with definitions, we'll probably have to
have separate macros for declarations and definitions, as I don't think
MSVC likes

	int foo[];

in a header file but should be fine with

	extern int foo[];

Add some more comments while we're at it; you are in a twisty little
maze of #ifdefs, all different.

svn path=/trunk/; revision=50332
 2013-07-03 00:38:41 +00:00
Guy Harris f4361b8e38 If the LHS of an "expr LHS : RHS" expression has an X added to avoid 
confusing expr if the LHS is an empty string, the RHS needs it as well.

Also, fix some typoes ("$X" rather than "X$"), and use lower-case "x",
as that's what's used elsewhere when doing that sort of thing.

svn path=/trunk/; revision=50331
 2013-07-02 23:56:32 +00:00
Stephen Fisher b4dca0fbd2 Change additions from r50178 from if expr "$GCC_OPTION" to if expr 
"X$GCC_OPTION" so expr doesn't get confused by the GCC_OPTION that 
starts with a hyphen and spit out messages like this (on FreeBSD): 

checking whether we can add -fexcess-precision=fast to CXXFLAGS... expr:
illegal option -- f
expr: usage: expr [-e] expression

expr: illegal option -- f
expr: usage: expr [-e] expression

no


svn path=/trunk/; revision=50330
 2013-07-02 23:28:51 +00:00
Guy Harris 717b358639 Methinks the "not GCC 4 or later" #defines for WS_DLL_PUBLIC and 
WS_DLL_LOCAL were reversed; that might be what's causing a build error
with ui/qt/main_status_bar.cpp.

Add some comments for #else's while we're at it, so it's easier to
figure out when particular sets of #defines are used.

svn path=/trunk/; revision=50329
 2013-07-02 22:08:23 +00:00
Jakub Zawadzki 9c58621893 - rename and optimize proto_data_add_maybe_interesting_field 
- proto_tree_add_node() double checks if tree_type is valid remove second one (first one is more verbose)

svn path=/trunk/; revision=50328
 2013-07-02 21:26:14 +00:00
Michael Mann a6acb73611 Make expert items filterable. First use of proto_tree_add_expert. 
svn path=/trunk/; revision=50327
 2013-07-02 21:16:10 +00:00
Jakub Zawadzki 68c2c57037 Remove tree argument from TRY_TO_FAKE_THIS_REPR macro 
PTREE_DATA should be the same for both *tree* and *pi*

svn path=/trunk/; revision=50326
 2013-07-02 20:51:58 +00:00
Michael Mann e5cb4d84cc proto_malformed SHOULD NOT be used outside of show_exception.c 
svn path=/trunk/; revision=50325
 2013-07-02 20:43:21 +00:00
Michael Mann a19eaef617 Remove "global" proto_malformed and update some of the expert_info items that really aren't "malformed". 
svn path=/trunk/; revision=50324
 2013-07-02 20:25:14 +00:00
Michael Mann 7ae263b9e4 Differentiate "Disabled" from "Unknown" and provide macros for the enumerated values. 
svn path=/trunk/; revision=50323
 2013-07-02 20:08:49 +00:00
Michael Mann e16933f496 Add proto_tree_add_expert and proto_tree_add_expert_format. This was added to expert.h instead of proto.h because the underlying code to process expert info is static (and should probably remain so). Also, proto_tree_add_expert and proto_tree_add_expert_format follow "expert info" rules in that they should be called regardless of tree status (even though they take a tree as an argument), unlike the functions in proto.h 
Also added an enumeration for checksum validation status, as verifying checksums is considered "expert" functionality.

svn path=/trunk/; revision=50322
 2013-07-02 19:53:28 +00:00
Jakub Zawadzki b0e04aca73 Rewrite proto_lookup_or_create_interesting_hfids() and rename to proto_data_add_maybe_interesting_field 
Now proto_data_add_maybe_interesting_field:
- it actually add field_info to interesting hash_tree
- accept only required parameters
- is called only by proto_tree_add_node

svn path=/trunk/; revision=50321
 2013-07-02 19:23:10 +00:00
Jakub Zawadzki 1d2409dd69 Micro-optimize common case for proto_tree_add_pi() assume tree != NULL, pfi != NULL 
Fix calles.

svn path=/trunk/; revision=50320
 2013-07-02 18:56:48 +00:00
Jakub Zawadzki cce4ad3c66 tree == NULL check is already done by TRY_TO_FAKE_THIS_ITEM() macro. 
svn path=/trunk/; revision=50319
 2013-07-02 18:45:47 +00:00
Jakub Zawadzki 874f119225 Remove not needed TRY_TO_FAKE_THIS_ITEM() from proto_tree_*_format & proto_tree_*_format_value 
Right now for proto_tree_add format & _format_value TRY_TO_FAKE_THIS_ITEM() is called twice
one from 'format' function, second time from 'no format' function.

This reduces size of .text by 10K:
   text    data     bss     dec     hex filename
  76012     112      56   76180   12994 proto-after.o
  86324     112      56   86492   151dc proto-before.o


svn path=/trunk/; revision=50318
 2013-07-02 18:36:00 +00:00