osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
27340 commits 23 branches 0 tags 1.3 GiB
Commit graph

3895 commits

Author SHA1 Message Date
Ulf Lamping
df3c99a109 Windows only: for some typical capture interface names (with a "built in" heuristic), show specific icons in the interface list and the welcome page (this helps to find the right interface) 
svn path=/trunk/; revision=27335
 2009-01-30 22:55:52 +00:00
Ulf Lamping
9e846eaad2 do not show the telephony icon in any of the telephony menu entries 
svn path=/trunk/; revision=27334
 2009-01-30 22:48:56 +00:00
Jaap Keuter
cb80f883f7 From Carlos Mendioroz: 
Enhanced the skinny dissector to expose a tap, and added SKINNY call control
protocol support to gtk/call_voip to show those calls.

svn path=/trunk/; revision=27332
 2009-01-30 21:25:52 +00:00
Ulf Lamping
5375b5f476 add a new "Telephony" main menu entry and move the telephony specific statistics stuff over there 
svn path=/trunk/; revision=27326
 2009-01-29 01:38:08 +00:00
Gerald Combs
cc5357bee8 Add a comment about possible Windows 7 support. 
svn path=/trunk/; revision=27288
 2009-01-22 21:26:54 +00:00
Gerald Combs
5ff80e9b5f Use the correct data type for the range string in the Win32 file dialog. 
Have value_is_in_range() to gracefully handle a NULL range. This might
fix bug 3208.

svn path=/trunk/; revision=27281
 2009-01-20 23:33:38 +00:00
Gerald Combs
05c5a60f63 More work on modernizing the column prefs. 
svn path=/trunk/; revision=27278
 2009-01-20 20:49:33 +00:00
Gerald Combs
ea9d93e7a9 Since we're not bound to GTK1 any more, let the user drag and drop column 
specifiers to change the order. Get rid of the up/down buttons.

svn path=/trunk/; revision=27274
 2009-01-20 05:14:57 +00:00
Bill Meier
89db5fe608 Change indentation as needed to be consistent for the whole file. 
svn path=/trunk/; revision=27271
 2009-01-19 22:37:14 +00:00
Jaap Keuter
0855f501cc Set the packet details counter column to 1, as it's one expert info per packet. 
svn path=/trunk/; revision=27261
 2009-01-18 14:51:22 +00:00
Jaap Keuter
fe7ea8526e From Jim Young: 
The attached patch is an enhancement to the Expert Info Composite dialog's tab labels.
On the four severity level tabs a second number is displayed that represents the total 
number of detail records associated with each severity level.

svn path=/trunk/; revision=27260
 2009-01-18 14:47:51 +00:00
Jaap Keuter
3278bafd5b From Jim Young: 
Confine status bar widgets to module.

svn path=/trunk/; revision=27259
 2009-01-18 13:51:00 +00:00
Gerald Combs
6553661db0 Clarify the GeoIP path tooltip. 
svn path=/trunk/; revision=27230
 2009-01-14 17:40:30 +00:00
Balint Reczey
8022776680 Disable MEGACO service response time statistics when context tracking is disabled. 
svn path=/trunk/; revision=27167
 2009-01-06 14:42:20 +00:00
Bill Meier
a392d821db Minor rewording of a few comments; fix a few typos. 
svn path=/trunk/; revision=27151
 2009-01-04 14:21:54 +00:00
Balint Reczey
43e5bd228f Include unknown commands in MEGACO service response time statistics on GUI, too. 
svn path=/trunk/; revision=27146
 2009-01-01 15:49:20 +00:00
Balint Reczey
ae51123939 Service response time statistics for MEGACO (CLI part). 
Refactored GUI part to avoid code duplication.

svn path=/trunk/; revision=27143
 2008-12-31 17:47:36 +00:00
Balint Reczey
43ac3652a3 Service response time statistics for MEGACO (GUI only). 
svn path=/trunk/; revision=27140
 2008-12-31 15:26:48 +00:00
Bill Meier
ea5cd2d8ff Check for preview timeout only every 1000 frames 
svn path=/trunk/; revision=27110
 2008-12-24 14:21:03 +00:00
Bill Meier
819a458161 On Windows: use prefs.gui_fileopen_preview for preview timeout 
svn path=/trunk/; revision=27109
 2008-12-24 14:18:59 +00:00
Bill Meier
24c4589098 Check current time only every 100 frames during file preview file read 
svn path=/trunk/; revision=27108
 2008-12-24 13:59:51 +00:00
Gerald Combs
c30c410fa5 Add GeoIP to the Windows build. Fix a remaining geoip_ -> geoip_db_ 
conversion.

svn path=/trunk/; revision=27098
 2008-12-23 18:56:31 +00:00
Gerald Combs
218ec164c6 GeoIP expects IPv4 addresses in host byte order. 
svn path=/trunk/; revision=27097
 2008-12-23 18:17:01 +00:00
Bill Meier
2fd064d68d Add some missing g_free() [for certain error code paths]. 
svn path=/trunk/; revision=27086
 2008-12-22 16:05:24 +00:00
Jaap Keuter
4692f6cae7 When destroying the RTP player make sure to terminate the use of PortAudio library. 
At least that is what the documentation says.

svn path=/trunk/; revision=27073
 2008-12-21 18:49:20 +00:00
Bill Meier
6fee0f704e Fix some typos and spelling 
svn path=/trunk/; revision=27070
 2008-12-20 01:39:16 +00:00
Gerald Combs
3bb0df12f5 From babi: Fix three overflows (bugs 3150 and 3151). 
From me: Use a #define for the RTP analysis field name lengths.

svn path=/trunk/; revision=27064
 2008-12-20 00:07:21 +00:00
Gerald Combs
7d22c0fb7f Rename geoip.[ch] to geoip_db.[ch] so we don't collide with GeoIP.h. Rename 
some functions to match.

Add GeoIP lookups to the IP dissector. Add a preference for GeoIP lookups,
which is disabled by default.

svn path=/trunk/; revision=27063
 2008-12-19 23:49:03 +00:00
Jaap Keuter
c95944a16a Correct language. 
svn path=/trunk/; revision=27060
 2008-12-19 11:31:28 +00:00
Jaap Keuter
0c7d516955 Cleanup sourcecode. 
svn path=/trunk/; revision=27059
 2008-12-19 11:30:50 +00:00
Bill Meier
1a0a4d28c2 Add a few_missing calls to g_free() 
svn path=/trunk/; revision=27012
 2008-12-15 21:42:49 +00:00
Bill Meier
f2dbebb885 Fix for bug #3119 (follow_tcp crash when stream filter creation fails) 
svn path=/trunk/; revision=26995
 2008-12-14 17:06:25 +00:00
Tomas Kukosa
99295ee0d2 put the SCTP PPI for current DATA chunk into packet_info (and ppid array renamed to ppids) 
svn path=/trunk/; revision=26958
 2008-12-10 11:04:36 +00:00
Stig Bjørlykke
f596c7da35 Untabify and code cleanup. 
svn path=/trunk/; revision=26942
 2008-12-09 00:03:09 +00:00
Jörg Mayer
4149a23cc5 Trivial warning fixes 
svn path=/trunk/; revision=26899
 2008-12-02 08:11:23 +00:00
Jörg Mayer
2ec0f32654 Display the settings for not-compiled-in features: 
It's not a good idea to refer people in the snmp section to
the name resultion section for mibs configuration and then
not provide any clue that they are there correctly if mib
support wasn't compiled in.


svn path=/trunk/; revision=26889
 2008-12-01 09:47:41 +00:00
Stig Bjørlykke
e3660ee423 Restructured the flow graph dialog to make it easier to read. 
svn path=/trunk/; revision=26888
 2008-12-01 08:50:37 +00:00
Stephen Fisher
3e60203474 Fix a few more problems found by checkAPIs.pl 
svn path=/trunk/; revision=26887
 2008-12-01 07:31:07 +00:00
Stephen Fisher
5f707964bd Remove call to deprecated perror() and a check to see if g_malloc() failed 
since g_malloc will terminate the program if it cannot allocate memory instead
of returning NULL.


svn path=/trunk/; revision=26886
 2008-12-01 07:16:32 +00:00
Stig Bjørlykke
680daffcaa Removed an unused argument to prefs_tree_page_add(). 
svn path=/trunk/; revision=26875
 2008-11-29 12:43:16 +00:00
Jaap Keuter
2621a14a34 Plug memory leak. 
svn path=/trunk/; revision=26873
 2008-11-28 22:54:08 +00:00
Stig Bjørlykke
8e568cd895 Save preferences when selected from menu, unless having enabled the save button. 
Added a preferences icon to the menu.

svn path=/trunk/; revision=26872
 2008-11-28 21:22:25 +00:00
Stephen Fisher
6b9154b31f Fix a typo. 
svn path=/trunk/; revision=26862
 2008-11-27 09:33:17 +00:00
Stig Bjørlykke
1e79b967de Improved the Protocol Preferences entry in the tree view popup menu 
with a submenu containing all preferences for the protocol.  

Implemented directly change for bool, enum and UAT popup.
Integer, string and range TBD.

svn path=/trunk/; revision=26856
 2008-11-26 23:28:06 +00:00
Tomas Kukosa
3c6f280db4 - export tvb_memeql() 
- update callsinfo->call_comment in VoIP Calls

svn path=/trunk/; revision=26844
 2008-11-25 14:21:04 +00:00
Jaap Keuter
ec03288647 Fix for bug 3079: 
Remove memory leaks from allocated labels by making full use of graph helper functions, and 
from unneeded address copies. 
Avoid GLIb warning on empty dynamic RTP payload type hash table.

svn path=/trunk/; revision=26841
 2008-11-25 08:21:53 +00:00
Jaap Keuter
e301f6542e MGCP is no longer a plugin. 
svn path=/trunk/; revision=26839
 2008-11-25 06:41:15 +00:00
Stig Bjørlykke
28f7b7f6cc Added doubleclick to expand/collapse tree row in packet window. 
svn path=/trunk/; revision=26836
 2008-11-24 22:05:23 +00:00
Stig Bjørlykke
290ec47c55 Invalidate cfile.current_row when forcing byte view update. 
svn path=/trunk/; revision=26835
 2008-11-24 20:27:57 +00:00
Stig Bjørlykke
68a6ac1954 Handle double-click and enter in "decode as" list as OK. 
Reindent some blocks.

svn path=/trunk/; revision=26831
 2008-11-23 19:34:28 +00:00
Stig Bjørlykke
f0b45897ff Do not popup an empty menu in the Packet Bytes pane. 
svn path=/trunk/; revision=26807
 2008-11-18 16:39:49 +00:00
Stig Bjørlykke
5498ec1dce Optimized finding current row from cfile.current_frame. 
svn path=/trunk/; revision=26804
 2008-11-18 14:50:51 +00:00
Stig Bjørlykke
bfd1d4e42b Check if selected packet is already selected before doing any updates. 
svn path=/trunk/; revision=26803
 2008-11-18 14:36:48 +00:00
Sake Blok
ff621064aa Open the packet in a new window when it is double-clcked upon in the 
packet-list.

(as noted in bug 3059)


svn path=/trunk/; revision=26800
 2008-11-17 23:03:58 +00:00
Guy Harris
d33354edcd Don't put underscores in a phrase that's just shown to users. 
svn path=/trunk/; revision=26793
 2008-11-16 21:43:32 +00:00
Stig Bjørlykke
4a9957df9e Fill the scrollbar when the graph is empty. 
svn path=/trunk/; revision=26790
 2008-11-16 14:41:35 +00:00
Anders Broman
68ef96b3bf From Abhik Sarkar: 
Support for Diameter conversations and service response time.

svn path=/trunk/; revision=26785
 2008-11-15 15:52:39 +00:00
Stig Bjørlykke
6c068534c2 Improved filter autocompletion when having one exact match to be more 
like other autocompletion implementations.
Check for case match before removing a popup with one entry.

svn path=/trunk/; revision=26768
 2008-11-13 12:59:31 +00:00
Stig Bjørlykke
f9c07203cb Still support GTK 2.4.0. No separator in combo box for GTK 2.4.0 :( 
svn path=/trunk/; revision=26748
 2008-11-11 12:46:16 +00:00
Stig Bjørlykke
053dd12cbd Rewrote interface type option_menu to gtk_combo_box, this fixes the bug 
showing the correct type on connect failure or cancel in the remote
interface dialog.

Added list of recent remote hosts to interface type combo box.
Save the recent remote hosts in the recent file.
Fixed some indents.

svn path=/trunk/; revision=26747
 2008-11-11 11:37:53 +00:00
Tomas Kukosa
608e51ef4c explicit cast to avoid warning which stops Windows build 
svn path=/trunk/; revision=26737
 2008-11-10 13:22:18 +00:00
Guy Harris
aa81efc51c Use the standard I/O routines to write out audio files, rather than 
doing 1-byte, 2-byte, and 4-byte read() and write() calls.

svn path=/trunk/; revision=26735
 2008-11-08 23:36:12 +00:00
Anders Broman
04f9b031ef From Pascal Quantin: 
Add 3GPP 44.018 RR Short Protocol Discriminator dissection.

svn path=/trunk/; revision=26730
 2008-11-07 17:37:22 +00:00
Stig Bjørlykke
0132b9a092 Save the remote interfaces list to be able to show the remote IP addresses 
without fetching a new list each time the interface changes.

Catch the "activate" signal on the text boxes in the remote interfaces dialog.

svn path=/trunk/; revision=26727
 2008-11-07 15:52:14 +00:00
Stig Bjørlykke
7d8a21da5a Initialize the interface type value key to fix updating the local interface 
list when changing from remote to local interfaces.

svn path=/trunk/; revision=26720
 2008-11-06 22:36:43 +00:00
Anders Broman
e95a3f43c8 From Pascal Quantin: 
Add 3GPP Special Conformance Testing Procedures to GSM statistics

svn path=/trunk/; revision=26716
 2008-11-06 21:49:21 +00:00
Stig Bjørlykke
2e3656d31a Fixed a check button text. 
svn path=/trunk/; revision=26709
 2008-11-06 15:33:44 +00:00
Stig Bjørlykke
2207381990 Changes in the "Capture Options" window: 
- Moved all RPCAP settings to a "Remote Settings" dialog
- Rearranged "Buffer size" and "Wireless Settings" on win32
- Fall back to local interfaces when error listing remote interfaces
- Fixed setting correct sampling type when reopening the capture dialog
- Aligned some widgets in the "Capture Options" frame 
- Added some tooltips

svn path=/trunk/; revision=26687
 2008-11-04 18:50:34 +00:00
Stig Bjørlykke
32d411be1d Do not set buffer size for remote interfaces or when using default value. 
Do not get link-layer for remote interfaces.

svn path=/trunk/; revision=26683
 2008-11-03 21:38:53 +00:00
Stig Bjørlykke
1655ca17d0 Do not use functions for remote capture on local interfaces. 
This makes it possible to compile with remote capture features on unix.

svn path=/trunk/; revision=26681
 2008-11-03 20:04:01 +00:00
Stig Bjørlykke
da4327b2ea Always show version in black. 
svn path=/trunk/; revision=26678
 2008-11-03 14:25:39 +00:00
Stig Bjørlykke
395bad32ac gtk_tree_view_set_hover_selection only for gtk 2.6 and above. 
svn path=/trunk/; revision=26675
 2008-11-03 07:52:42 +00:00
Stig Bjørlykke
d3164c3f78 Adjustments to the filter autocompletion window: 
- Do not default select the first entry
- Use the same window width as the filter widget
- Better support for PageUp and PageDown

svn path=/trunk/; revision=26673
 2008-11-02 20:44:19 +00:00
Stig Bjørlykke
ab557c4f30 Fix some "format not a string literal and no format arguments" warnings. 
svn path=/trunk/; revision=26643
 2008-10-31 10:33:20 +00:00
Stig Bjørlykke
8608c8f1de Fix some "format not a string literal and no format arguments" warnings. 
svn path=/trunk/; revision=26641
 2008-10-31 09:53:56 +00:00
Stephen Fisher
002716a7cf Fix bug #3022: Fix potential memory leak 
svn path=/trunk/; revision=26638
 2008-10-31 00:45:01 +00:00
Stephen Fisher
7901fd3b99 Fix bug #3021: Fix potential memory leak 
svn path=/trunk/; revision=26637
 2008-10-31 00:41:48 +00:00
Stephen Fisher
d8e451b946 Fix bug #3019: Fix potential memory leaks 
svn path=/trunk/; revision=26635
 2008-10-31 00:30:23 +00:00
Stephen Fisher
43524ae6f7 Fix bug #3018: Fix potential memory leaks 
svn path=/trunk/; revision=26634
 2008-10-31 00:23:40 +00:00
Balint Reczey
4995d58135 show the type of the filter (Display/Capture Filter) on filter dialog 
This fixes bug 1703.

svn path=/trunk/; revision=26622
 2008-10-30 13:19:07 +00:00
Stephen Fisher
e103054f47 Fix a few (not all) of the current checkapi errors in gtk/ 
- Non-ASCII characters in a few filess
 - Missing $Id$ tag in one file


svn path=/trunk/; revision=26616
 2008-10-29 07:31:45 +00:00
Jaap Keuter
7ae1591787 Fix for bug 1854: 
Even though not perfect, this effectively doubles the width of the header labels
without changing the rest of the layout.

svn path=/trunk/; revision=26615
 2008-10-29 07:28:44 +00:00
Stig Bjørlykke
7bd9f5f483 Cleanup by using a common function for building the autocompletion list. 
Untabify.

svn path=/trunk/; revision=26595
 2008-10-27 23:17:22 +00:00
Jaap Keuter
920794d199 Fix the GeoIP preference description. 
svn path=/trunk/; revision=26594
 2008-10-27 21:59:50 +00:00
Gerald Combs
1d1dcb604b Allow more characters in each column. 
svn path=/trunk/; revision=26592
 2008-10-27 21:38:40 +00:00
Stig Bjørlykke
2ec94c8f7c Show configured GeoIP paths in About->Folders 
svn path=/trunk/; revision=26587
 2008-10-27 20:35:52 +00:00
Stig Bjørlykke
7024e2be7c Do not popup the autocompletion window with only one exactly matching entry. 
svn path=/trunk/; revision=26585
 2008-10-27 19:36:00 +00:00
Stig Bjørlykke
40271a29a5 Removed a g_warning(). 
svn path=/trunk/; revision=26583
 2008-10-27 19:13:07 +00:00
Stig Bjørlykke
749f4359eb From Bahaa Naamneh and me: 
Check if the filter string being typed is a beginning of a protocol name
before calling the autocomplete functionality.

svn path=/trunk/; revision=26581
 2008-10-27 18:49:34 +00:00
Stig Bjørlykke
9676190af1 Uh, new attempt to sort hostlist correct... 
svn path=/trunk/; revision=26577
 2008-10-27 14:40:44 +00:00
Stig Bjørlykke
164b61e7b0 Sort hostlist columns correct. 
Temporary fix for adding GeoIPCity names with norwegian characters,
so we do not crash in gtk_clist_insert(). 

svn path=/trunk/; revision=26576
 2008-10-27 14:17:04 +00:00
Stephen Fisher
e7057d72d8 Remove random ; at the end of preprocessor directive. 
svn path=/trunk/; revision=26572
 2008-10-27 05:24:01 +00:00
Gerald Combs
1b7064bb6a Add support for the GeoIP library. Using different database files, 
GeoIP can map IP addresses to Countries, Cities, AS numbers, ISPs,
etc. If any library paths are defined AND any database files are found,
corresponding columns are added to the endpoint tables in the GUI.

To do:
  - Add columns to the conversation list
  - Add GeoIP info to "-z conv,..."
  - Create a default UAT file.

svn path=/trunk/; revision=26571
 2008-10-27 04:50:57 +00:00
Gerald Combs
09bf9e6946 ETH -> WS updates. 
svn path=/trunk/; revision=26570
 2008-10-27 04:47:57 +00:00
Stephen Fisher
b8b74f901d Add About, Preferences and a working Quit option to the OS X application menu 
when ige mac integration is used.


svn path=/trunk/; revision=26569
 2008-10-27 04:40:54 +00:00
Guy Harris
93f9555975 #ifdef out variable used only if we have the Immendio OS X integration 
for GTK+.

svn path=/trunk/; revision=26566
 2008-10-27 00:18:43 +00:00
Stephen Fisher
1fa606decf More updates to the IGE Mac OS X integration feature: 
- Adds preference "MacOS X style" to the (G)UI preferences pane
 - When the preference above is enabled, the menu bar is moved from
   the Wireshark window to the top of the screen.  It is no longer displayed
   in both places at once.  This preference defaults to on.
 - Calls function to enable shortcut keys for OS X top of screen menus.
 - NOTE: The IGE Mac Integration functions change the Control key to Command
         key in the menus.  This may or may not be desirable.


svn path=/trunk/; revision=26565
 2008-10-26 23:07:37 +00:00
Stig Bjørlykke
3a14d073c0 Correct the include for ige-mac-menu.h 
svn path=/trunk/; revision=26564
 2008-10-26 22:33:43 +00:00
Stig Bjørlykke
63309c74b8 Do not autocomplete when editing capture filter. 
svn path=/trunk/; revision=26563
 2008-10-26 21:53:24 +00:00
Stephen Fisher
812ecb21c3 Tweak Mac IGE integration detection so that it can find the functions not 
only in the Gtk+ OS X framework, but also in the separate igemacintegration
library.  Also add call to ite_mac_menu_set_menu_bar() to synchronize the
OS X menu bar with the Gtk menu bar in Wireshark.  The Gtk menu bar in
Wireshark will remain there.


svn path=/trunk/; revision=26560
 2008-10-26 20:09:54 +00:00
Stig Bjørlykke
6eedb9577b Make a new popup when appending a dot to an existing filer entry without 
an existing popup.

svn path=/trunk/; revision=26552
 2008-10-25 11:50:01 +00:00
Bill Meier
0e7d674d23 Fix for SVN #26535 so that building Wireshark with VC6 doesn't fail. 
svn path=/trunk/; revision=26545
 2008-10-24 22:13:09 +00:00
Stig Bjørlykke
ee48afbc74 Always select an entry in the autocomplete list. 
svn path=/trunk/; revision=26544
 2008-10-24 22:13:07 +00:00
Stig Bjørlykke
674d209dbe Added autocomplete and autocompletion list of protocol names in the filter 
entry.  This still has some side effects, but hopefully not too bad.

svn path=/trunk/; revision=26542
 2008-10-24 20:36:09 +00:00
Stig Bjørlykke
5e5a674e76 Show both short and long protocol name in the Filter Expression dialog. 
svn path=/trunk/; revision=26537
 2008-10-24 07:48:09 +00:00
Bill Meier
8afa208ffb Windows build: #include winsock2.h only when needed. 
#include winsock2.h pulls in about 90 distinct .h files
and about 140 total .h files. 
Currently winsock2.h is (mostly unnecessarily) included
for each dissector via packet.h/wtap.h.
This patch removes #include winsock2.h from wtap.h and 
then includes winsock2.h (or windows.h) in the 
few specific places required. 
With this patch, my Windows Wireshark build takes 
about 30% less time.


svn path=/trunk/; revision=26535
 2008-10-24 00:42:09 +00:00
Jaap Keuter
8a32775150 Set a title on the splash window even though it's not decorated. 
This sets the title/icon of the taskbar item created when the splash screen is up.

svn path=/trunk/; revision=26533
 2008-10-23 21:13:58 +00:00
Stig Bjørlykke
3cd4e0ad4d Only use the statusbar for filter messages from the main window. 
Updating the statusbar from popup windows is confusing.

svn path=/trunk/; revision=26523
 2008-10-23 14:30:35 +00:00
Jaap Keuter
784ca2bd43 Clean up the whitespace. 
svn path=/trunk/; revision=26503
 2008-10-20 20:24:01 +00:00
Stig Bjørlykke
32b542de4f Use invisible event boxes so the preferences looks good when using themes. 
svn path=/trunk/; revision=26502
 2008-10-20 19:18:12 +00:00
Stig Bjørlykke
71e81ef3f6 Fixed a small issue using esc and backspace in filter autocompletion. 
svn path=/trunk/; revision=26496
 2008-10-19 14:56:25 +00:00
Stig Bjørlykke
0e3e22851a Add filter autocomplete for filter in color edit dialog. 
svn path=/trunk/; revision=26494
 2008-10-19 14:40:16 +00:00
Stig Bjørlykke
2aebbfb9f4 Add filter autocomplete for filter in file->open and file->merge windows. 
svn path=/trunk/; revision=26493
 2008-10-19 14:12:58 +00:00
Stig Bjørlykke
c8d3fe7cbe Remove a misplaced comment... 
svn path=/trunk/; revision=26492
 2008-10-19 14:07:00 +00:00
Stig Bjørlykke
381285f61c Add filter autocomplete for more places we use filter entries. 
svn path=/trunk/; revision=26491
 2008-10-19 13:40:52 +00:00
Stig Bjørlykke
51ac347364 Construct a new autocomplete popup window again if pressing backspace 
while having no existing popup window.

svn path=/trunk/; revision=26490
 2008-10-19 12:37:38 +00:00
Gerald Combs
92ae7f9c87 When we set the channel and offset entries in the wireless toolbar, 
set the offset first.  This makes sure the offset entry is initialized
correctly.  In the advanced wireless settings dialog, don't bother
enabling/disabling the toolbar.  Remove some leftover debugging
code. Remove some checks for data we don't use (and mark it as unused).
Fixup whitespace.

svn path=/trunk/; revision=26487
 2008-10-17 23:48:33 +00:00
Stig Bjørlykke
73ad418699 Removed some "statement not reached" warnings. 
svn path=/trunk/; revision=26480
 2008-10-16 14:16:21 +00:00
Jaap Keuter
cddb781f53 Various corrections, as in: typos, whitespace, few return values, _U_ markers. 
svn path=/trunk/; revision=26472
 2008-10-15 23:17:40 +00:00
Gerald Combs
41d39d4f33 If we click on an interface in the welcome screen, correctly enable/disable 
the wireless toolbar.

svn path=/trunk/; revision=26471
 2008-10-15 22:51:17 +00:00
Gerald Combs
9a41723b2b Keep the wireless toolbar extension channel entry from inadvertently 
setting its value to -1. Fix a bug that kept the wireless toolbar from
being enabled if HAVE_PCAP_REMOTE was defined. Fix a couple of other
minor issues.
--Thisr line, and those below, will be ignored--

M    airpcap_loader.c
M    gtk/airpcap_dlg.c
M    gtk/main_airpcap_toolbar.c

svn path=/trunk/; revision=26469
 2008-10-15 21:43:00 +00:00
Jaap Keuter
be90b5571c Clean up conversation filter code. 
Make it work in the intended cases and add IPv6 support.

svn path=/trunk/; revision=26461
 2008-10-15 07:43:24 +00:00
Gerald Combs
c99312dae0 Use a more accurate variable name for the wiretap file type. Add the file 
encapsulation to the summary display.

svn path=/trunk/; revision=26459
 2008-10-14 22:55:16 +00:00
Jaap Keuter
0367cd7768 Fix for bug 2964. 
When right click on any packet (From Packet List) - > "Export Selected Packet Bytes" you 
get "No data selected to save!" MessageBox. This option should not be in this menu at all.

svn path=/trunk/; revision=26458
 2008-10-14 20:04:06 +00:00
Anders Broman
917c091669 Make verion in startscreen a visible preference. 
svn path=/trunk/; revision=26453
 2008-10-14 18:18:21 +00:00
Stig Bjørlykke
13843b56df Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26439
 2008-10-13 18:59:21 +00:00
Stig Bjørlykke
f9c4288e09 Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26438
 2008-10-13 18:37:00 +00:00
Stig Bjørlykke
b4d9a5c868 Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26436
 2008-10-13 18:16:35 +00:00
Stig Bjørlykke
489b5e1fec Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26435
 2008-10-13 17:38:28 +00:00
Stig Bjørlykke
6d6288fae9 Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26434
 2008-10-13 17:28:48 +00:00
Stig Bjørlykke
b19ba53f35 Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26433
 2008-10-13 17:28:36 +00:00
Anders Broman
939367b801 Bring the windows to front when rescanning of packets are done. 
svn path=/trunk/; revision=26423
 2008-10-12 16:56:38 +00:00
Stig Bjørlykke
2046b2731d Rewrote to use gtk_widget_modify_text() and gtk_widget_modify_base() 
to change the background color for filter text edit boxes, because
gtk_widget_set_style() interacts badly with themes.

Go back to default values when filter is empty (instead of white).

Also rewrote the same in the "Edit Color Filter" dialog.

svn path=/trunk/; revision=26421
 2008-10-12 13:41:04 +00:00
Stig Bjørlykke
426f90cbe9 Forgot this for the Display Filter dialog: 
Ensure we initialize the colorized filter text entries before we show the
widget, so we don't get wrong foreground color when using a dark theme.

svn path=/trunk/; revision=26418
 2008-10-11 15:50:29 +00:00
Stig Bjørlykke
828f6baa42 Ensure we initialize all colorized filter text entries before we show the 
widget, so we don't get wrong foreground color when using a dark theme.

svn path=/trunk/; revision=26414
 2008-10-11 14:32:46 +00:00
Anders Broman
93a0edf6dd From David Aggeler: 
packet-dcm, improved DICOM Tag support, misc fixes.

svn path=/trunk/; revision=26413
 2008-10-11 14:25:02 +00:00
Stig Bjørlykke
6b0c906c19 Added check for a valid field name in the advanced field. 
svn path=/trunk/; revision=26407
 2008-10-10 17:10:15 +00:00
Stig Bjørlykke
d4e9b3742f Only check for a valid field name in the custom column. 
svn path=/trunk/; revision=26406
 2008-10-10 17:01:36 +00:00
Stig Bjørlykke
6012a91ebb Added an option to syntax check only a single field name. 
svn path=/trunk/; revision=26405
 2008-10-10 17:00:38 +00:00
Balint Reczey
172d8448e8 temporary fix for return type warning 
svn path=/trunk/; revision=26404
 2008-10-10 16:29:09 +00:00
Balint Reczey
feed6d124f fixed conversion warning 
svn path=/trunk/; revision=26403
 2008-10-10 16:06:04 +00:00
Stig Bjørlykke
91977bfa15 Add a "Field name" label for the custom column. 
svn path=/trunk/; revision=26402
 2008-10-10 15:50:08 +00:00
Balint Reczey
8ae1ce5822 support float and double values in IO Graph calculations 
svn path=/trunk/; revision=26400
 2008-10-10 15:18:37 +00:00
Stig Bjørlykke
7e3514c200 Add a hidden preference to show the version in the welcome page. 
svn path=/trunk/; revision=26371
 2008-10-07 15:18:40 +00:00
Stig Bjørlykke
66f160728f Fix printing of version in welcome page. 
svn path=/trunk/; revision=26370
 2008-10-07 14:06:44 +00:00
Gerald Combs
a6bb39afe3 Add a hidden preference to set the welcome screen title. 
svn path=/trunk/; revision=26366
 2008-10-06 22:49:01 +00:00
Anders Broman
cee238507d From Kari Tiirikainen: 
Req/resp tracking and service response time stats for GTP-C

svn path=/trunk/; revision=26361
 2008-10-06 20:11:44 +00:00
Ronnie Sahlberg
24b76bdc14 add a -K command line option to provide the name of the kerberos keytab 
file to use for decryption of Krb5 and GSS-KRB


svn path=/trunk/; revision=26343
 2008-10-03 05:21:28 +00:00
Sake Blok
0996e23a81 Fix for Bug 2891: 
Read the capture setting from the preferences *before* parsing the
capture command line arguments.


svn path=/trunk/; revision=26268
 2008-09-25 06:21:02 +00:00
Anders Broman
dc8a11f7bb Fix:About dialog: all text selected when switching tabs 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1349
Hopfully the right thing to do :)

svn path=/trunk/; revision=26247
 2008-09-22 21:28:55 +00:00
Jeff Morriss
4dcba9a359 Don't define a static variable (the_tapinfo_struct) in a header file; instead declare it in each C file that needs it. 
svn path=/trunk/; revision=26244
 2008-09-21 14:50:05 +00:00
Gerald Combs
ba485a4163 Add /D_BIND_TO_CURRENT_CRT_VERSION=1 to LOCAL_CFLAGS in modern versions 
of Visual C++. (How did this "feature" ever see the light of day?) Make
sure we use LOCAL_CFLAGS *everywhere*. This should fix problems with
building a usable installer under Visual Studio 2008 SP1.

Add comments with links to Visual C++'s idiotic handling of assemblies
and deployment using xcopy. Move to c-ares 1.5.3. Make sure we remove
all of our manifests in epan and packaging/u3/tools.

svn path=/trunk/; revision=26219
 2008-09-16 21:08:18 +00:00
Sake Blok
bb4173e140 Close filter autocompletion list when it's empty. This re-enables 
entering a filter like this:

ip.addr==1.1.1.1<ENTER>


svn path=/trunk/; revision=26154
 2008-09-06 23:22:50 +00:00
Guy Harris
af49f01616 The AFP field containing the command is "afp.command", not "afp.cmd". 
Fixes bug 2847.

svn path=/trunk/; revision=26126
 2008-09-03 10:24:38 +00:00
Guy Harris
28971d38fc Fix typo in #define. 
Fix indentation (a tab doesn't necessarily expand to 4 spaces).

svn path=/trunk/; revision=26118
 2008-09-02 18:20:36 +00:00
Anders Broman
f3fd97dc39 Make it easy to put the version on the Welcom page if wanted. 
svn path=/trunk/; revision=26117
 2008-09-02 17:41:47 +00:00
Bill Meier
c9898d7f6b #include <emem.h> not req'd 
svn path=/trunk/; revision=26094
 2008-08-26 02:53:21 +00:00
Bill Meier
99c797748e Fix minor typo/spelling ... 
svn path=/trunk/; revision=26048
 2008-08-20 19:27:07 +00:00
Gerald Combs
1ac736e634 Simplify the PortAudio section. 
svn path=/trunk/; revision=26030
 2008-08-15 00:07:16 +00:00
Gerald Combs
bb8e507f31 From cjkelly1: Add "/MD" to the PortAudio compilation flags. Fixes 
bug 2791.

Don't use "-o" in the PortAudio compilation flags. If we're running Visual
C++ 2008, don't use "/Zd" when compiling packet-rrc.c. Fixes bug 2795.

svn path=/trunk/; revision=26023
 2008-08-14 20:56:34 +00:00
Bill Meier
871036f49d Fix a spelling error 
svn path=/trunk/; revision=26016
 2008-08-14 16:37:44 +00:00
Guy Harris
ce89de75da If capture_dlg_prep() finds an error, don't continue with the capture. 
Get rid of an extra g_strdup() (get_if_name() doesn't mangle its
argument and doesn't modify prefs.capture_device).

If there's no interface on which to capture, pop up a dialog to indicate
that.

svn path=/trunk/; revision=25997
 2008-08-13 08:15:47 +00:00
Jaap Keuter
bfc12627c9 From Alexey Neyman: 
Start Wireshark without a preference file saved. Open the capture options dialog, 
then click "Start" button without selecting any interface. Wireshark segfaults while
dereferencing NULL pointer in get_if_name() called from capture_start_cb().

svn path=/trunk/; revision=25987
 2008-08-12 05:14:29 +00:00
Anders Broman
3eadb385c3 From Alexey Neyman: 
Implement dissector for IPMB (DLT_IPMB_LINUX, 209).

svn path=/trunk/; revision=25986
 2008-08-12 04:44:35 +00:00
Luis Ontanon
55e3c847cf try to avoid: 
funnel_stat.c:528: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
funnel_stat.c:535: error: expected ‘)’ before ‘*’ token
funnel_stat.c:541: error: expected ‘)’ before ‘*’ token
funnel_stat.c:572: error: ‘funnel_new_progress_window’ undeclared here (not in a function)


svn path=/trunk/; revision=25978
 2008-08-11 01:55:27 +00:00
Luis Ontanon
dfd6dd53a4 Add a slightly modified version of Paolo Abeni's funneled progress dialog (ref https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2725) and its wslua interface. 
svn path=/trunk/; revision=25977
 2008-08-11 01:33:31 +00:00
Stig Bjørlykke
e0740e22e5 Remove the "Save column widths" option so we always save the widths. 
svn path=/trunk/; revision=25968
 2008-08-09 16:14:34 +00:00
Stig Bjørlykke
d182dfab21 Check if the recent_common file exists instead of having a setting in 
the recent file.

svn path=/trunk/; revision=25967
 2008-08-09 16:12:41 +00:00
Sake Blok
b08d70271d From Alexey Neyman (Bug 2786): 
Make "stop" button in the capture info dialog work


svn path=/trunk/; revision=25966
 2008-08-09 08:17:53 +00:00
Jaap Keuter
d6df3a1f1c Fix for bug 2780: 
Correct reverse direction payload save.

svn path=/trunk/; revision=25961
 2008-08-08 19:57:50 +00:00
Sake Blok
643d1baa53 From Kovarththanan Rajaratnam (Bug 2660): 
Make display filter max recent entries a preference

(From me: fixed an off by one bug in saving to the recent file)


svn path=/trunk/; revision=25960
 2008-08-08 19:41:35 +00:00
Gerald Combs
021a926793 Add support for the c-ares asynchronous DNS resolution library to the 
Windows build. Add support for async IPv6 lookups. Update the ADNS
code slightly.

This is not supported (yet) on the UNIX side.

svn path=/trunk/; revision=25953
 2008-08-07 21:41:48 +00:00
Bill Meier
4b53209990 Remove some obsolete comments related to GTK 1. 
svn path=/trunk/; revision=25949
 2008-08-07 12:31:43 +00:00
Jeff Morriss
c77c787122 Merge files chronologically by default which: 
- makes (much) more sense to me
	- makes the GUI's default behavior the same as mergecap's

For whatever reason the default behavior was to append the new file
/if transport resolution was enabled/ (not sure what those two things have to
do with each other).

svn path=/trunk/; revision=25947
 2008-08-06 14:11:46 +00:00
Luis Ontanon
a8ddad6d91 Have the window being resizable 
svn path=/trunk/; revision=25946
 2008-08-06 12:03:16 +00:00
Luis Ontanon
a4412aa3c1 Make the buttons of the UAT dialog usable again, and get rid of some gtk warnings. 
svn path=/trunk/; revision=25940
 2008-08-06 00:43:01 +00:00
Luis Ontanon
42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org 
svn path=/trunk/; revision=25937
 2008-08-05 21:03:46 +00:00
Jeff Morriss
dd6a15e1c7 Don't put (non-extern'd) prototypes for protect_thread_critical_region() and 
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).

This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702

svn path=/trunk/; revision=25933
 2008-08-05 17:33:14 +00:00
Gerald Combs
7d8e29f501 From Pascal Quantin via bug 2719: Fix support for Microsoft Visual C++ 2008. 
From me:

Instead of adding adns_config.h, place it a custom adns package in
wireshark-win32-libs. Update tools/win32-setup.sh accordingly.

Split the MSVC2008EE variant into MSVC2008 and MSVC2008EE, similar to
MSVC2005 and MSVC2005EE. We have to worry about vcredist_x86.exe in
both cases.

Add Pascal to AUTHORS.

Update the Developer's Guide.

svn path=/trunk/; revision=25921
 2008-08-04 23:05:32 +00:00
Anders Broman
96aa45646d First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy) 
rename the "old" one to gsm_a_common.

svn path=/trunk/; revision=25915
 2008-08-04 16:11:17 +00:00
Anders Broman
449e40f6b1 From Abhik Sarkar: 
Some buttons are always disabled in the "User DLTs Table" dialog.

svn path=/trunk/; revision=25904
 2008-08-02 13:47:31 +00:00
Anders Broman
8db1e7a8b2 From David Aggeler: 
Follow-up from SVN 25825 check in

The g_slist_free() is really needed in export_object.c, otherwise, the export
list has false (repetitive) entries in it, that cause a crash when selecting
them.

Whether false entries are in the list, only depends on the speed of the export
processing, since this tap is 

Replaced all guchar with gchar. This should eliminate the warnings on solaris. 
I guess I used the wrong reference.

Added patch for 'Authors' in case I need to add myself to the list.

svn path=/trunk/; revision=25834
 2008-07-25 22:58:05 +00:00
Anders Broman
b7f89ecec1 From David Aggeler: 
Patch to enable DICOM Export

svn path=/trunk/; revision=25825
 2008-07-25 13:45:31 +00:00
Bill Meier
7631d2b494 Add NULL termination element to value_string array 
svn path=/trunk/; revision=25798
 2008-07-22 20:20:17 +00:00
Bill Meier
3b6cd83389 Add NULL termination element to value_string arrays; 
Fix some indentation

svn path=/trunk/; revision=25797
 2008-07-22 20:19:17 +00:00
Martin Mathieson
75890548d7 Filter autocompletion from Bahaa Naamneh (bug 2581). 
There are still display filter controls where this isn't being used
yet, but I'm committing it now so hopefully people can report any
problems.

Some commenting and formatting was done by myself.

svn path=/trunk/; revision=25788
 2008-07-22 15:19:10 +00:00
Gerald Combs
a7d388325e From Dustin Johnson: Don't pop up a warning dialog every time we can't save 
our AirPcap configuration. Just print out a warning to the console instead.

svn path=/trunk/; revision=25781
 2008-07-21 18:51:05 +00:00
Jaap Keuter
e86825b8f8 From Francesco Fondelli: 
Attached is a patch for:
- PW Associated Channel Header dissection as per RFC 4385
- PW MPLS Control Word dissection as per RFC 4385
- mpls subdissector table indexed by label value
- enhanced "what's past last mpls label?" heuristic
- Ethernet PW (w/o CW) support as per RFC 4448

svn path=/trunk/; revision=25730
 2008-07-13 17:19:33 +00:00
Stig Bjørlykke
b1e0d8edc5 Correct help topic for firewall dialog. 
svn path=/trunk/; revision=25725
 2008-07-12 19:28:08 +00:00
Jeff Morriss
c50b4aec09 More (mostly stats tree) unsigned->signed char cleanup 
svn path=/trunk/; revision=25717
 2008-07-12 01:48:24 +00:00
Guy Harris
08b4f712c8 Note bug 2699, which reports a bug in xdg-open. 
svn path=/trunk/; revision=25700
 2008-07-10 18:36:19 +00:00
Gerald Combs
98f5096bbd Replace r25638 with a better fix. On Windows, don't open a console window if 
we've been passed "-i -", since it clobbers stdio.

svn path=/trunk/; revision=25695
 2008-07-09 23:28:18 +00:00
Bill Meier
c18d922045 Fix compile error 
svn path=/trunk/; revision=25674
 2008-07-08 03:21:54 +00:00
Bill Meier
d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API 
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
 2008-07-08 02:43:40 +00:00
Bill Meier
44efa0ed2e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API 
gtk_timeout_add()     ==> g_timeout_add
   gtk_timeout_remove()  ==> g_source_remove()

Also: timer callback should return gboolean (not void or gint)

svn path=/trunk/; revision=25672
 2008-07-08 02:25:30 +00:00
Guy Harris
a04774395f Add Makefile.common files for epan/dfilter and epan/ftypes. 
Add checkapi rules to Makefile.am files.

svn path=/trunk/; revision=25656
 2008-07-02 01:44:30 +00:00
Jeff Morriss
83f9ecf96f Move privileges.c and unicode-utils.c from epan to wsutil (so things like 
capinfos and dumpcap don't need to depend on libwireshark nor directly pull
in those modules).  Because capinfos and editcap were only being linked with
privileges.c if we had plugins, this allows those programs to be linked when
someone is compiling --without-plugins.

svn path=/trunk/; revision=25640
 2008-06-30 17:16:29 +00:00
Gerald Combs
6d4f9c1eda When we open a debug console on Windows, don't grab stdin. We never read 
anything on this particular console, and if we open stdin here we can't
read a capture from an anonymous pipe.

svn path=/trunk/; revision=25638
 2008-06-30 16:36:37 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API 
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
 2008-06-29 15:51:43 +00:00
Sake Blok
cd7405c44d From Kovarththanan Rajaratnam (bug 2657): 
Resolve accelerator ambiguity in filter toolbar


svn path=/trunk/; revision=25633
 2008-06-29 14:59:23 +00:00