osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
27340 commits 23 branches 0 tags 1.3 GiB
Commit graph

3895 commits

Author SHA1 Message Date
Bill Meier
151a1f4361 [Trivial] fix some wording in a comment 
svn path=/trunk/; revision=27743
 2009-03-16 19:02:18 +00:00
Michael Tüxen
8df5f2a33e Fix compilation: Mark unused arg as _U_. 
svn path=/trunk/; revision=27742
 2009-03-16 18:26:37 +00:00
Anders Broman
3c2eddf646 Get rid of Clists, move a comment, move display as hex to gui_utils. 
svn path=/trunk/; revision=27741
 2009-03-16 18:01:25 +00:00
Bill Meier
edc59eb340 Add checkapi for deprecated Gtk APIs for which Wireshark is currently clean. 
checkapi will Error if any of these APIs are seen. 

svn path=/trunk/; revision=27730
 2009-03-15 20:20:54 +00:00
Stig Bjørlykke
62f60df6b4 From Jakub Zawadzki (bug 3331): 
g_free() is NULL safe, so we don't need check against it.

svn path=/trunk/; revision=27718
 2009-03-13 22:06:48 +00:00
Stig Bjørlykke
7ed615f165 From Bahaa Naamneh (bug 3332): 
Disable the Auto-Completion feature in the Find Dialog when
"String" or "Hex value" radio button is selected.

svn path=/trunk/; revision=27717
 2009-03-13 21:25:28 +00:00
Stig Bjørlykke
e8689dde3b From Jakub Zawadzki (bug3330): 
Fix memleaks in expert_comp_dlg.c.

svn path=/trunk/; revision=27712
 2009-03-12 20:38:42 +00:00
Stig Bjørlykke
18c5caa3d4 From Jakub Zawadzki: 
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
 2009-03-12 07:56:42 +00:00
Jaap Keuter
6acffc2357 Get the build going again on non-Windows compilers. 
svn path=/trunk/; revision=27697
 2009-03-11 07:35:43 +00:00
Anders Broman
564846935a From Carlos Mendioroz: 
IAX2 calls statistics window ala RTP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3217

svn path=/trunk/; revision=27696
 2009-03-11 06:43:46 +00:00
Bill Meier
71404bd655 Replace use of perror; Also: define various fcns as static 
svn path=/trunk/; revision=27689
 2009-03-10 17:34:06 +00:00
Bill Meier
cf930e3092 Fix a (very) minor memory leak; include tempfile.h only if _WIN32 
svn path=/trunk/; revision=27686
 2009-03-09 23:38:44 +00:00
Bill Meier
7ce6710735 Replace use of ("prohibited") tmpnam() with code 
adapted from print_dlg.c;
Also: fix some bugs wherein an incorrect filename
 could be printed if an error occurred 
 opening/writing/etc an output file.

svn path=/trunk/; revision=27680
 2009-03-09 20:19:36 +00:00
Bill Meier
e2fe1bdf6f Use "wshprint" (instead of "ethprint") for prefix of temp file name; 
Also: add to comment about non-use of tmpnam

svn path=/trunk/; revision=27679
 2009-03-09 17:08:38 +00:00
Bill Meier
05f4863c16 Add $Id$ 
svn path=/trunk/; revision=27678
 2009-03-09 15:46:43 +00:00
Bill Meier
eb2a2480c5 Fix non-ascii character in file... 
svn path=/trunk/; revision=27677
 2009-03-09 15:42:37 +00:00
Bill Meier
2adef63689 stat() ==> ws_stat() [to keep checkAPIs happy]; 
Also: free() ==> g_free();

svn path=/trunk/; revision=27676
 2009-03-09 15:10:11 +00:00
Bill Meier
292cc21bb0 Use ws_fopen() [not fopen()] so that a path\filename with 
non-ascii charcters will work properly.

svn path=/trunk/; revision=27675
 2009-03-09 14:53:22 +00:00
Bill Meier
8a651ee15c Fix File ! Export ! Selected Bytes [Windows] crash which 
occurred if the file  path\filename contained non-ascii characters.
  1. Use ws_open() [not open()] so UTF8 path\filenames properly
     converted to UTF16 before the open;
  2. If the open/write/close failed, fix crash due to NULL
     filename pointer used when trying to popup an error message box.
     

svn path=/trunk/; revision=27674
 2009-03-09 13:59:41 +00:00
Stig Bjørlykke
cb94226629 Handle BASE_NONE as BASE_DEC until we get a proper handling of integer 
values with BASE_NONE and a value string.

svn path=/trunk/; revision=27669
 2009-03-09 00:30:45 +00:00
Stig Bjørlykke
04dfb4c8b8 Remove a unused g_strdup(). 
svn path=/trunk/; revision=27666
 2009-03-08 22:57:39 +00:00
Stig Bjørlykke
cae81ac405 Don't close the UAT dialog when pressing Apply. 
Default to the ok button in the UAT edit dialog.
Append a ":" to the title labels in the edit and delete dialogs.

svn path=/trunk/; revision=27665
 2009-03-08 22:56:12 +00:00
Bill Meier
b663f6d218 Fix File ! Save As on Windows to properly delete an existing file even if the 
path\filename contains non-ascii characters.

svn path=/trunk/; revision=27662
 2009-03-08 22:19:49 +00:00
Ulf Lamping
bb3b362089 add "PPP/SLIP" to the dialup interfaces 
svn path=/trunk/; revision=27660
 2009-03-08 19:38:24 +00:00
Stig Bjørlykke
f586fd5a93 Implemented edit dialogs for integer, string and range values in 
the submenu containing the preferences for the protocol.

svn path=/trunk/; revision=27653
 2009-03-08 13:19:49 +00:00
Jaap Keuter
01de8873c9 Trying to fix the build on non-Win32 platforms. 
svn path=/trunk/; revision=27649
 2009-03-08 11:00:46 +00:00
Anders Broman
46e3b3218f Get rid of more code related to the Clist removal. 
svn path=/trunk/; revision=27648
 2009-03-08 08:40:20 +00:00
Anders Broman
a9103bb14f Get rid of another Clist. 
svn path=/trunk/; revision=27647
 2009-03-08 01:01:58 +00:00
Anders Broman
646aafff35 Fix "ansi_a_stat.c:314: warning: unused variable ‘default_titles’" 
svn path=/trunk/; revision=27646
 2009-03-07 23:06:38 +00:00
Anders Broman
163e832800 Get rid of another Clist. 
svn path=/trunk/; revision=27645
 2009-03-07 21:14:28 +00:00
Bill Meier
7cf1229160 Fix some usage of deprecated GTK+ functions 
svn path=/trunk/; revision=27630
 2009-03-06 23:02:27 +00:00
Bill Meier
8c685a67e7 Rename a variable ('free') so checkAPIs doesn't incorrectly flag it. 
svn path=/trunk/; revision=27627
 2009-03-06 22:49:27 +00:00
Anders Broman
4175480de6 Get rid of a Clist and move the functon to display floats with two decimals to gui_utils. 
svn path=/trunk/; revision=27621
 2009-03-06 17:16:56 +00:00
Anders Broman
6944dced3d Try to make the solaris buildbot happy. 
svn path=/trunk/; revision=27583
 2009-03-03 05:52:46 +00:00
Stephen Fisher
c71eeeca07 Remove a variable that is no longer used as of svn rev 27580 
svn path=/trunk/; revision=27581
 2009-03-02 21:30:17 +00:00
Anders Broman
4cbe2db1a3 Use gtk_combo_box_new_text (). 
svn path=/trunk/; revision=27580
 2009-03-02 20:20:39 +00:00
Anders Broman
2c1c572d08 Code cleanup. 
svn path=/trunk/; revision=27576
 2009-03-02 07:31:06 +00:00
Martin Mathieson
eeba728afb Fix counting of 'predefined' bytes. 
svn path=/trunk/; revision=27564
 2009-02-27 17:36:06 +00:00
Stig Bjørlykke
570722dab3 Remember the last used profile and restore this on startup. 
svn path=/trunk/; revision=27560
 2009-02-26 22:26:42 +00:00
Stig Bjørlykke
adfda29e38 Don't write the recent file when leaving a deleted profile. 
svn path=/trunk/; revision=27559
 2009-02-26 22:24:18 +00:00
Anders Broman
aa3b687793 gtk_menu_append is deprecated and should not be used in newly-written code. Use gtk_menu_shell_append(). 
svn path=/trunk/; revision=27558
 2009-02-26 21:41:07 +00:00
Anders Broman
04837ca7f2 gtk_label_set -> gtk_label_set_text 
"gtk_label_set is deprecated and should not be used in newly-written code.
Aliases gtk_label_set_text()."

svn path=/trunk/; revision=27556
 2009-02-26 21:11:06 +00:00
Anders Broman
25e8795a06 gtk_list_store_insert_with_values() requires GTK+ 2.6 or later. 
From Jakub Zawadzki further optimisations.

svn path=/trunk/; revision=27555
 2009-02-26 20:55:19 +00:00
Anders Broman
0d0d6c6621 Another small performance boost. 
svn path=/trunk/; revision=27554
 2009-02-26 16:46:00 +00:00
Stig Bjørlykke
56384aaa10 Removed some spaces in BCH Bytes and PCH Bytes. 
svn path=/trunk/; revision=27553
 2009-02-26 14:49:13 +00:00
Martin Mathieson
18b4db2852 More layout improvements (thanks Stig). 
svn path=/trunk/; revision=27552
 2009-02-26 11:47:37 +00:00
Stephen Fisher
a0b1dcb2a1 Fix (private) bug #3278: When first opening the RTP stream analysis window, 
it  hangs for a while before allowing the user to interact with the window.

Fixed by setting columns to fixed height and fixed width.

Also: Don't display columns we were hiding in the CList version of this
window.


svn path=/trunk/; revision=27551
 2009-02-26 07:55:09 +00:00
Martin Mathieson
e39897e30d More updates to LTE MAC stats. Layout working better now. 
svn path=/trunk/; revision=27546
 2009-02-25 18:02:09 +00:00
Martin Mathieson
dec6a82c10 Fix some of the UE issues in this window. 
- don't use table with one row for common channel counts
- the UEs table now grows to fill vertical space as window is resized
- 4 rows UE details still don't all show...

svn path=/trunk/; revision=27534
 2009-02-24 17:57:25 +00:00
Jaap Keuter
d27c92e496 Add posibility to mark protocol as private. This prevents inadvertent Wiki access. 
svn path=/trunk/; revision=27533
 2009-02-24 17:24:03 +00:00
Stig Bjørlykke
b934653277 Use bold labels for headings. 
svn path=/trunk/; revision=27525
 2009-02-23 17:28:31 +00:00
Martin Mathieson
27f81cc8fc Use separate variables for different 'scrolled_window' instances 
svn path=/trunk/; revision=27524
 2009-02-23 16:15:49 +00:00
Stig Bjørlykke
f3d3ecc9de Ah, the line was not supposed to be there. 
svn path=/trunk/; revision=27523
 2009-02-23 16:04:29 +00:00
Stig Bjørlykke
7c2e1623b3 Make it compile. 
svn path=/trunk/; revision=27522
 2009-02-23 15:39:05 +00:00
Martin Mathieson
c29f515169 Add an LTE MAC stats window. 
I'm struggling with the layout - I'll ask the dev list for ideas...

svn path=/trunk/; revision=27521
 2009-02-23 15:33:59 +00:00
Stig Bjørlykke
ad99387305 Show generated hidden protocol items as <[Element: value]> 
svn path=/trunk/; revision=27520
 2009-02-23 15:30:15 +00:00
Stig Bjørlykke
137933aa5b Use gtk_radio_menu_item for enum preferences menu. 
This fixes bug 3206.

svn path=/trunk/; revision=27519
 2009-02-23 14:24:44 +00:00
Stig Bjørlykke
3bf06a7c7a Free string fetched from gtk_editable_get_chars(). 
svn path=/trunk/; revision=27518
 2009-02-22 22:11:38 +00:00
Stig Bjørlykke
0a791948b4 Free path fetched from gtk_tree_model_get_path with gtk_tree_path_free() 
svn path=/trunk/; revision=27516
 2009-02-22 21:28:13 +00:00
Stig Bjørlykke
93f56712bd Free path fetched from gtk_tree_model_get_path with gtk_tree_path_free() 
svn path=/trunk/; revision=27515
 2009-02-22 21:22:30 +00:00
Anders Broman
7c66938e7f Use gtk_file_chooser_dialog_new(). 
svn path=/trunk/; revision=27514
 2009-02-22 20:10:17 +00:00
Anders Broman
2a7af394e2 Remove unused(?) code. 
svn path=/trunk/; revision=27513
 2009-02-22 19:32:15 +00:00
Anders Broman
968c6e06bc Use gtk_file_chooser_dialog_new(). 
svn path=/trunk/; revision=27512
 2009-02-22 19:02:02 +00:00
Anders Broman
52d4a85e21 Use gtk_file_chooser_dialog_new(). 
svn path=/trunk/; revision=27509
 2009-02-22 15:23:06 +00:00
Anders Broman
e88a6e5392 Update CheckApi with: 
#'gtk_clist_new', should we depriceate?
		# GtkCList has been deprecated since GTK+ 2.0 and should not be used
		# in newly written code. Use GtkTreeView instead. 
		'gtk_file_selection_new',

svn path=/trunk/; revision=27508
 2009-02-22 14:47:07 +00:00
Stephen Fisher
01c821cd67 Mark two unused variables 
svn path=/trunk/; revision=27490
 2009-02-20 17:53:39 +00:00
Anders Broman
590bc1122c Replace the clists with gtk_list_store 
Should fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3246

svn path=/trunk/; revision=27489
 2009-02-20 17:13:44 +00:00
Anders Broman
830f6a59a3 Indentation changes. 
svn path=/trunk/; revision=27479
 2009-02-18 06:42:35 +00:00
Guy Harris
5742ede54c Add an additional "title" attribute for UAT fields; that's what's 
displayed to the user.

svn path=/trunk/; revision=27462
 2009-02-16 04:10:06 +00:00
Guy Harris
0bd9f9caa9 Use open_failure_alert_box() for open failures; use 
copy_file_binary_mode() to copy a file, and check for it failing.

svn path=/trunk/; revision=27459
 2009-02-15 22:57:47 +00:00
Guy Harris
ace4af44fc Add a routine to report write errors to the list of failure-reporting 
routines handled by epan/report_err.c.

Move copy_binary_file() in file.c to epan/filesystem.c, and rename it to
copy_file_binary_mode() (to clarify that it *can* copy text files;
arguably, *all* files are "binary" unless you're on, say, an IBM 1401
:-)).  Have it use the report_err.c routines, so it works in
console-mode programs.

Clean up some comments while we're at it.

svn path=/trunk/; revision=27456
 2009-02-15 21:47:57 +00:00
Stig Bjørlykke
84b134a22d Compiling on Ubuntu 8.10 gives a warning when not checking the return value 
from fwrite, so added a check.  Also use size_t for nbytes.

svn path=/trunk/; revision=27451
 2009-02-15 15:02:29 +00:00
Guy Harris
5c5f14fe49 Use the Bluetooth icon for Linux raw Bluetooth devices. Note some issues 
with using it in OS X.

svn path=/trunk/; revision=27450
 2009-02-14 03:03:28 +00:00
Ulf Lamping
974a0d94a7 add a (Windows only) bluetooth network interface icon 
svn path=/trunk/; revision=27447
 2009-02-13 21:35:41 +00:00
Ulf Lamping
f0ba6538af add display of IE_ID_COUNTRY, some code cleanup 
svn path=/trunk/; revision=27439
 2009-02-12 09:42:47 +00:00
Ulf Lamping
c70e7b0d3b try to fix the buildbot 
svn path=/trunk/; revision=27438
 2009-02-12 02:33:19 +00:00
Guy Harris
63b93ee09f Use network_virtual_16.xpm for VMware interfaces on OS X (well, use them 
if VMware Fusion ever lets you capture on them, which it currently
doesn't appear to do), on the assumption that this icon is appropriate
for VMware interfaces on the host machine.

svn path=/trunk/; revision=27437
 2009-02-12 01:48:47 +00:00
Guy Harris
d78ea7720a Make the column information signed, so that -1 is a valid out-of-band 
value.

Use \t, rather than literal tabs, in character strings, so it's more
obvious that they're tabs, and so that if a tool changes tabs to spaces
it won't mess things up.

Use spaces for indentation, for the benefit of editors that have
hardwired tab stops.

svn path=/trunk/; revision=27436
 2009-02-12 01:44:17 +00:00
Ulf Lamping
b75dc4f8c8 network_virtual_16.xpm currently only used on Win32 
svn path=/trunk/; revision=27434
 2009-02-11 21:12:55 +00:00
Ulf Lamping
f8e5b17dbd add support for a simple GeoIP based IP Location Map, more details will follow on the dev-list 
svn path=/trunk/; revision=27433
 2009-02-11 20:25:17 +00:00
Ulf Lamping
a75c684a91 use a special icon for "VMware" virtual networks (yes, I know the icon is *not* very good - but I have no better idea how to display that) 
svn path=/trunk/; revision=27431
 2009-02-11 20:20:10 +00:00
Ulf Lamping
bfce5dac33 <control>1-6 is already used by colorizing, <shift><control>1-6 doesn't work for whatever reason, so use <alt><control>1-6 
svn path=/trunk/; revision=27418
 2009-02-11 01:14:21 +00:00
Ulf Lamping
2106faabe3 add a stock icon "WIRESHARK_STOCK_MAP" to display a map 
svn path=/trunk/; revision=27413
 2009-02-10 21:26:16 +00:00
Ulf Lamping
94ee3dd51a make filename2uri() "public" 
svn path=/trunk/; revision=27412
 2009-02-10 21:23:32 +00:00
Ulf Lamping
3769308172 try improve the "Time Display Format" submenu by sorting the items by "display length" 
add/change accelerator keys:
"Time Display Format" <control>1 - <control>6
"Resize All Columns" <shift><control>R
"First Packet" Home
"Last Packet" End
"Interfaces" <control>I
"Start" <control>E
"Restart" <control>R
"Enabled Protocols" <shift><control>R -> <shift><control>E

svn path=/trunk/; revision=27411
 2009-02-10 21:22:24 +00:00
Ulf Lamping
7e7a3d9bb4 the current tab display "Error 3/24" is missleading IMHO. I would read this 3 out of 24, but in fact it means 3 items appearing in sum 24 times. 
I've changed it to "Error 3 (24)", but this still is not perfect.

Is there an even better idea to display this?

svn path=/trunk/; revision=27410
 2009-02-10 21:16:45 +00:00
Ulf Lamping
f904f42f9d Remove an ugly hack: 
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created.

Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group.

svn path=/trunk/; revision=27407
 2009-02-10 03:54:55 +00:00
Jaap Keuter
acdf91e263 Make "Copy as Filter" on the packet list actually work. 
Up till now every packet in the packet list got a copy of the pointer to the filter expressions for
the last packets' columns. Hence any 'Copy as Filter" on a column got the expression of the last
packet in the packet list. Instead every packet needs to get a pointer to the filter expressions 
for its own columns. This requires making a copy of the filter expressions themselves.

Since this is a bug in 1.0 as well the GLIB1 code is provided for backporting, which can later be dropped from the development tree.

svn path=/trunk/; revision=27396
 2009-02-09 07:10:46 +00:00
Bill Meier
ee908a7abd #include <epan/conversation.h> not req'd ... 
svn path=/trunk/; revision=27392
 2009-02-07 16:01:26 +00:00
Ulf Lamping
d5d3e1fa92 add display of GeoIP latitude/longitude 
This is a crude hack, as the current Wireshark interface to GeoIP is not really suitable for reading several values of a single GeoIP database :-(

svn path=/trunk/; revision=27365
 2009-02-04 01:02:59 +00:00
Anders Broman
3a4903b71a Calculate average max and min setup time. 
svn path=/trunk/; revision=27353
 2009-02-02 18:27:17 +00:00
Guy Harris
10e417e82e Add Linux support for determining the interface icon; this depends on a 
2.6 kernel feature, but it will just pick the default icon if that
feature doesn't work.

svn path=/trunk/; revision=27350
 2009-02-02 04:15:17 +00:00
Guy Harris
11281d8085 Don't include ../image/toolbar/network_wireless_16.xpm on platforms 
where we don't (yet) use it.

svn path=/trunk/; revision=27348
 2009-02-01 23:15:55 +00:00
Guy Harris
82b8d25678 Move declarations of routines in gtk/capture_if_dlg.c into 
gtk/capture_if_dlg.h.  Include that header when appropriate.

Get rid of include of <sys/wait.h> in gtk/capture_if_dlg.c; there's no
forking or waiting in there.

Make update_if() in gtk/capture_if_dlg.c static - it's not used outside
that file.

svn path=/trunk/; revision=27347
 2009-02-01 23:14:07 +00:00
Guy Harris
b4940aca41 No such luck with the AF_LINK address on FreeBSD or OpenBSD. 
svn path=/trunk/; revision=27346
 2009-02-01 22:57:17 +00:00
Guy Harris
ef07402aa5 Add (preliminary, and a bit hacky) support for interface-type icons on 
OS X.

Add some comments to the interface-type icon code, and, when looking for
certain text in the description on Windows, look in the interface
description supplied by WinPcap rather than the user-supplied
description (if we want to look in the latter, we presumably want to
look in both, so the user giving a wireless interface a name they like
won't break the code that checks for wireless interfaces).  There's
probably *some* NDIS OID that can give you the information you want -
hopefully, not an NDIS 6-only OID).

svn path=/trunk/; revision=27345
 2009-02-01 22:20:42 +00:00
Anders Broman
f9bb905d13 Calculate the avrage setuptime. 
svn path=/trunk/; revision=27342
 2009-02-01 20:52:38 +00:00
Guy Harris
faa534529c To avoid adding icons to menu items, leave item_type along, not just 
entry_data; otherwise, you get a bunch of run-time warnings from GTK+. 
Remove the line that sets extra_data, rather than commenting it out with
a C++ comment.

svn path=/trunk/; revision=27339
 2009-02-01 02:59:28 +00:00
Jaap Keuter
03a31436a1 Exclude the new icons from the *NIX build. 
svn path=/trunk/; revision=27338
 2009-01-31 07:00:05 +00:00
Ulf Lamping
e1cce91312 mark unused parameter (under unix) 
svn path=/trunk/; revision=27336
 2009-01-31 00:33:02 +00:00