Commit graph

32776 commits

Author SHA1 Message Date
Stig Bjørlykke
ca5fd0c797 Make it compile.
svn path=/trunk/; revision=34175
2010-09-21 09:59:45 +00:00
Guy Harris
7ee31c94d7 Move a bunch of definitions before the code that uses at least one of
the variables in question.

svn path=/trunk/; revision=34174
2010-09-21 09:53:44 +00:00
Anders Broman
8c964f34cf Try to fix:
"In menus_init() you seem to use ui_manager_packet_list_heading before it's initialized."

svn path=/trunk/; revision=34173
2010-09-21 09:30:16 +00:00
Guy Harris
81f824fbb8 Add an SVN ID.
svn path=/trunk/; revision=34172
2010-09-21 07:18:31 +00:00
Guy Harris
ef4a2e73b0 Get rid of C++ comment.
svn path=/trunk/; revision=34171
2010-09-21 07:17:20 +00:00
Stig Bjørlykke
c2e11e06be Make "Displayed Columns" work yet again, as done in revision 34160.
Bring back 'Resize Column' and 'Rename Column Title'.

svn path=/trunk/; revision=34170
2010-09-21 07:08:35 +00:00
Guy Harris
4eaaf279d0 Fix comments.
svn path=/trunk/; revision=34169
2010-09-21 05:58:14 +00:00
Anders Broman
838aa2db49 Update GUIManager menubar code(#IF 0 ).
svn path=/trunk/; revision=34168
2010-09-21 05:32:32 +00:00
Anders Broman
f62d9d36cc Wrong signature used for a GtkToggleActionEntry callback.
svn path=/trunk/; revision=34167
2010-09-21 05:24:02 +00:00
Anders Broman
c237a52cca Remove leftover debug code/comment
svn path=/trunk/; revision=34166
2010-09-21 05:10:38 +00:00
Jeff Morriss
381664535b As suggested by Kovarththanan Rajaratnam in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 :
Clean up hf fields some more: mostly removing leading and trailing spaces from names and blurbs.

svn path=/trunk/; revision=34165
2010-09-21 03:14:49 +00:00
Jeff Morriss
46ef82837f Add a cast
svn path=/trunk/; revision=34164
2010-09-21 03:06:54 +00:00
Jeff Morriss
79e39c7ecb Use size_t to keep the Windows compiler happy
svn path=/trunk/; revision=34163
2010-09-21 02:41:29 +00:00
Jeff Morriss
f2d070f19e From Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3336 :
We parse host & request page from headers, so we easily can construct full http
uri.

I was thinking about making it as field, so we could filter, print in column
info, or do other fancy stuff, but for now this is imho enough.


From me: add it as a (filterable) item.  Clean up spacing and indentation in a
few places.

svn path=/trunk/; revision=34162
2010-09-21 02:12:21 +00:00
Martin Mathieson
5d84e780d9 Fix sequence numbers reported when duplicate SN detected.
svn path=/trunk/; revision=34161
2010-09-20 17:01:22 +00:00
Stig Bjørlykke
1bc7a24d9b Make "Displayed Columns" work again.
svn path=/trunk/; revision=34160
2010-09-20 13:11:48 +00:00
Stig Bjørlykke
e6dac92931 Put Abort reason in info column.
svn path=/trunk/; revision=34159
2010-09-20 12:49:52 +00:00
Gerald Combs
b08297d7ef [Automatic manuf and enterprise-numbers update for 2010-09-19]
svn path=/trunk/; revision=34155
2010-09-19 15:03:36 +00:00
Jaap Keuter
12b574e628 Fix for bug 5220:
- Don't list codecs which are deleted by using port 0.
- Use real concatenation i.s.o. reprint, which seems to fail in some circumstances.

svn path=/trunk/; revision=34154
2010-09-18 13:12:03 +00:00
Jeff Morriss
a44a2a89ce Update Cal Turney's entry for the tshark SCSI tap
svn path=/trunk/; revision=34153
2010-09-18 01:07:00 +00:00
Jeff Morriss
9d3d2922ea From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5223 :
I would like to contribute iSCSI SRT tap, 'tap-scsistat.c' for tshark. 

The output exactly matches that of the Wireshark's iSCSI(disk) SRT dialog.

From me: a couple of small changes to make it compile without warnings.

svn path=/trunk/; revision=34152
2010-09-18 01:03:45 +00:00
Jeff Morriss
9ac49c557d Copy the rev 34143 changes to packet-snmp.c over to the asn1 source.
hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING.  This fixes
the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233 

svn path=/trunk/; revision=34151
2010-09-17 14:03:05 +00:00
Jeff Morriss
20cc0d7ce9 Don't include stock icons that we no longer use.
svn path=/trunk/; revision=34150
2010-09-17 13:38:09 +00:00
Anders Broman
0519ad45f3 Use GTK dialog stock icons rather than our own.
svn path=/trunk/; revision=34149
2010-09-17 12:54:07 +00:00
Guy Harris
ae13a7ce0c Fix some bugs that show up when you build with the old packet list.
svn path=/trunk/; revision=34148
2010-09-17 08:48:19 +00:00
Guy Harris
c66f97ddad Put the definition of NEW_PACKET_LIST into config.h rather than the
Makefile; that will force a rebuild if you configure it on or off
(that'll rebuild stuff that doesn't need to be rebuilt, but it'll also
rebuild stuff that *does* need to be rebuilt and that wouldn't be
rebuilt otherwise).

svn path=/trunk/; revision=34145
2010-09-17 07:24:35 +00:00
Guy Harris
5f7787d9ec Use the same control sequences for the old packet list that are used for
the new packet list.

svn path=/trunk/; revision=34144
2010-09-17 04:58:30 +00:00
Bill Meier
7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Jeff Morriss
d643e0366a Remove check_col(). Clean up some spacing/indentation too.
svn path=/trunk/; revision=34142
2010-09-17 02:22:37 +00:00
Jeff Morriss
f2cfa4e453 From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5197 :
The NFS dissector (all versions) show access types that have not been requested
to be checked as "not allowed" in the call and reply.  This is incorrect and
misleading.  At present one must manually compare what was requested in order
to assess if access was actually denied for that type.  When there are hundreds
or thousands of these ACCESS requests in a capture, it is not possible or
practical to manually check each one.  

The submitted patch does the following:

* Passes the access mask in the call to the reply for comparison
* Adds filterable fields for each supported (v4) and access type
* Adds a pseudo field, nfs.access_denied
* Lists the access types to be checked in the summary and tree
* Separately lists the supported, denied, and allowed access types in the 
  summary and tree

The changes are applied to all NFS versions.


From me: a couple of small changes to make it compile without warnings.

svn path=/trunk/; revision=34141
2010-09-17 02:03:09 +00:00
Bill Meier
252df40cc2 Extensive V9/V10 code clean up, bug fixing & dissection display improvements:
Bugs fixed:
 - Invalid time display for various time fields;
     Millisecs for types 152, 153 are actually stored as 64 bit integers;
     Microsecs, nanosecs are actually stored  in "NTP format";
     Times for fields 158, 159 are relative to "export time";
     SystemInitTime displayed incorrectly;
     ...
 - Options template not cached when only scope fields in template.
 - Templates not processed on first pass thru capture file:
    (In some cases data flows might not be handled until options template later displayed).
 - V9: number of options template entries limited to about 8 instead of intended 42;
 - Multiple options temlate flows in an Options Template flowset not handled;
 - "NotSentOctets" dislayed as "NotSentPackets";
   ...

Cleanups:
 - Options and data template processing code more or less rewritten;
 - options template displayed with format similar to that used for data templates;
 - Handling and display of PEN field (including use to indicate REVERSE) improved;
 - Don't use same filter name for two similar fields which only differ in size;
 - Handling & dislay of "variable length" fields improved;
 - sminmec lookup (PEN) done only during template processing & cached for later use;
   ...
 - Whitespace/Formatting

svn path=/trunk/; revision=34140
2010-09-17 01:45:29 +00:00
Gerald Combs
8b1205bac4 More typos.
svn path=/trunk/; revision=34139
2010-09-16 19:56:34 +00:00
Gerald Combs
15e9e06448 Fix a typo.
svn path=/trunk/; revision=34138
2010-09-16 19:55:25 +00:00
Gerald Combs
a87bdf9660 Turn on ASLR via /DYNAMICBASE and DEP via SetProcessDEPPolicy().
svn path=/trunk/; revision=34137
2010-09-16 19:20:06 +00:00
Stephen Fisher
034f2739d2 Add "(BE)" to the big endian representations of the ICMP identifier and
sequence number fields to match the "(LE)" ones.


svn path=/trunk/; revision=34136
2010-09-16 18:22:45 +00:00
Jeff Morriss
b6e984c095 #if out ui_desc_conv_filter_popup to get the builds going (it looks like it should be used but it isn't currently).
svn path=/trunk/; revision=34135
2010-09-16 13:12:02 +00:00
Stig Bjørlykke
2d93bc5e9a Make "4 NOP in a row" work again after changing the NOP name for TCP and IP
in revisions 34095 and 34097.

svn path=/trunk/; revision=34134
2010-09-16 12:29:22 +00:00
Anders Broman
0b44725f9f Fix a typo.
svn path=/trunk/; revision=34133
2010-09-16 10:40:33 +00:00
Guy Harris
8c5d32aa8f Remove C++ comments.
svn path=/trunk/; revision=34132
2010-09-16 08:58:46 +00:00
Anders Broman
57f8d0373d menus.c:1508: warning: unused parameter 'current'
menus.c:1508: warning: unused parameter 'user_data'
Mark parameters as unused.

svn path=/trunk/; revision=34131
2010-09-16 08:15:45 +00:00
Anders Broman
55580a9662 Use GUIManager for the pop-up:s.
Can be dissabled by commenting out 
#define MENUS_USE_UIMANAGER 1

svn path=/trunk/; revision=34130
2010-09-16 07:48:18 +00:00
Jeff Morriss
e8bee3d12e Also rename inet_ntop() on Windows
svn path=/trunk/; revision=34129
2010-09-15 21:41:27 +00:00
Sake Blok
84c08f1472 From Juha Siltanen :
When sorting a capture by protocol, some RTP packets are shown only as FLIP,
even though the dissection windows shows the RTP tree.

(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5215)


svn path=/trunk/; revision=34128
2010-09-15 21:17:35 +00:00
Anders Broman
8421bbd8a3 Add more GUIManager code #ifdef:ed out.
The popups should be working now exept for protocol help.
Help with testing and cleaning up apreciated.
GTK 2.6 requred, I'll look into that too later if no one beats me to it.

svn path=/trunk/; revision=34127
2010-09-15 20:51:44 +00:00
Stephen Fisher
c3beba4fd1 Bug #5127 from Guenter Strubreiter:
for avoiding doubled definition of a table needed also by a tcap subdissector
plugin a definition in libwirshark.def is needed:

isup_calling_partys_category_value

Me: Change extern to WS_VAR_IMPORT in header file


svn path=/trunk/; revision=34126
2010-09-15 20:29:31 +00:00
Martin Mathieson
dcf1ce54da Missed this one (check_col() removal)
svn path=/trunk/; revision=34125
2010-09-15 16:17:16 +00:00
Martin Mathieson
a5532739d6 Remove a few more calls to check_col()
svn path=/trunk/; revision=34124
2010-09-15 16:16:23 +00:00
Martin Mathieson
fbf198ae9b Add expert info for timing adjustment control message, and tweak a label.
svn path=/trunk/; revision=34123
2010-09-15 15:52:30 +00:00
Jeff Morriss
71fca3c87f Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5160 differently:
On Windows, rename inet_pton() to ws_inet_pton() so that builds on Vista or
later systems (that have inet_pton() natively) will still work on pre-Vista
systems.

svn path=/trunk/; revision=34122
2010-09-15 15:13:40 +00:00
Jeff Morriss
4584a81149 Revert 34081 and 34093 in preparation for a cleaner fix.
svn path=/trunk/; revision=34121
2010-09-15 15:13:17 +00:00