Commit Graph

15102 Commits

Author SHA1 Message Date
Guy Harris c898ddde94 Include <string.h> to declare "strrchr()".
Clean up indentation.

svn path=/trunk/; revision=15417
2005-08-19 01:57:44 +00:00
Guy Harris 8fe4435694 Set "hoffset" before using it.
svn path=/trunk/; revision=15416
2005-08-19 01:56:14 +00:00
Guy Harris e67b202e2c Have "f_datalen" keep track of the number of bytes of uncompressed file
data, so that "f_len" still keeps the size of the underlying file (which
is necessary in order to make the progress bar when files are being read
work correctly).

svn path=/trunk/; revision=15415
2005-08-19 01:17:24 +00:00
Anders Broman 1e1df99990 From Tim Endean:
Small patch to ber.c

The tcap dissector has been updated to use this length. I have not tested other asn.1 dissectors to ensure that they correctly use the indefinite encoding flag instead of the length value returning zero. 

There may also be some problems when re-assembly is needed, but the ability to deal with indefinite length is much more useful.

For developers the get_ber_length now returns the length of the pdu including the EOC, where you have dissectors that use packet-ber.c the eoc may need to be dealt with separately.

The tcap dissector has had numerous changes to make it less cluttered, and the useful feature of the previous version where a dialogue could be filtered out by selecting either the source or destination transaction ID has been incorporated into this version.

svn path=/trunk/; revision=15414
2005-08-18 21:36:59 +00:00
Ulf Lamping eadeaedc34 fix #305: don't get file creation date/time of the file but just use the filename
svn path=/trunk/; revision=15413
2005-08-18 19:36:19 +00:00
Ulf Lamping 994496a184 several times replacing:
sprintf -> g_snprintf
snprintf -> g_snprintf
vsnprintf -> g_vsnprintf
strdup -> g_strdup

svn path=/trunk/; revision=15412
2005-08-18 19:31:15 +00:00
Ulf Lamping e5af0106ac while sorting the entries, don't use the file creation date but the filename for comparison
svn path=/trunk/; revision=15411
2005-08-18 19:19:59 +00:00
Ulf Lamping 53a3d316da init the file set submenu items, so that the next and previous file items are disabled by default
svn path=/trunk/; revision=15410
2005-08-18 19:09:01 +00:00
Gerald Combs f2b29423aa Fix value_tvb pointers.
svn path=/trunk/; revision=15409
2005-08-18 18:12:55 +00:00
Tomas Kukosa ec979a97fb - dissect_per_restricted_character_string() returns value in tvbbuff_t instead of char
- asn2eth:
  fixed CHOICE tag handling
  #.FN_PARS support for BIT STRING and all string types
  intersection of SIZE and FROM constraints for string is handled
- new asn2eth features used in h225 and h245
- PER dissectors regeneration

svn path=/trunk/; revision=15408
2005-08-18 14:32:49 +00:00
Anders Broman 6fdb974570 From Richard van der Hoff
negative relative time fixes.

svn path=/trunk/; revision=15407
2005-08-18 12:55:01 +00:00
Anders Broman 913b6b22ec Decode some more of MultiRate configuration.
svn path=/trunk/; revision=15406
2005-08-18 11:09:50 +00:00
Ronnie Sahlberg 2edce4224d when kerberos claims a conversation, it only claims it for the source port
since a KDC MIGTH send the reply back from a different port.

Then comes X.L's capture (ethereal-dev) 816fc4.cap from 16Aug2005 where
the client is reusing the same source port to talk to DNS after finishing
doing the port 88 KDC stuff.


==>

Make kerberos/udp able to test the packet for sanity and reject packets that
do not look like kerberos (even if there was a conversation that said it was kerberos)
and thus let other dissectors have a go at it.


in doubt,   try 816fc4.cap  before and after this patch :-)



svn path=/trunk/; revision=15405
2005-08-18 10:37:41 +00:00
Guy Harris d5891d9623 Try yet another scheme for handling time stamps; realtick isn't always
correct.

svn path=/trunk/; revision=15404
2005-08-18 09:47:00 +00:00
Ronnie Sahlberg fc433879e8 replace sprintf with ememified g_snprintf
svn path=/trunk/; revision=15403
2005-08-18 08:55:22 +00:00
Ronnie Sahlberg dc2f29288a Tim's patches for packet-ber for extra testing (works ok with my and with Anders captures)
Anders'  beginnings of a new dissect_ber_set() function

 

svn path=/trunk/; revision=15402
2005-08-18 08:37:31 +00:00
Guy Harris 2831a51832 The length returned for continuation data should be the length remaining
in the tvbuff starting at the specified offset, not the entire length of
the tvbuff.

svn path=/trunk/; revision=15401
2005-08-18 07:09:43 +00:00
Guy Harris 880ef5343a Get rid of a no-longer-used variable.
svn path=/trunk/; revision=15400
2005-08-18 06:40:10 +00:00
Guy Harris 27a04a5255 Show BitTorrent stuff that doesn't look right as continuation data.
svn path=/trunk/; revision=15399
2005-08-18 01:17:46 +00:00
Ulf Lamping 495eb1b788 snprintf -> g_snprintf
svn path=/trunk/; revision=15398
2005-08-17 23:10:28 +00:00
Ulf Lamping 00b682c185 put the intermediate files of the release_notes chm build into it's own dir release_notes_chm/ instead of .
svn path=/trunk/; revision=15397
2005-08-17 22:49:07 +00:00
Ulf Lamping c6c57e7008 0.10.12 -> 0.10.13 (preliminary)
add a section about "new and updated features"

svn path=/trunk/; revision=15396
2005-08-17 22:32:40 +00:00
Gerald Combs 4d9c7cfa0d Flip the separators in the MIBS environment variable between ":" and
";" depending on our platform.  This is a modified version of a patch
that Jaap Keuter sent in.  Leave the preferences tooltip as-is in case
we want to be more strict about separators in the future.

Add a link to an email from Wes explaining that we shouldn't use a
default MIB list.

svn path=/trunk/; revision=15395
2005-08-17 22:27:15 +00:00
Ulf Lamping 2b35007cbd fix a typo
svn path=/trunk/; revision=15394
2005-08-17 22:08:06 +00:00
Ulf Lamping 33b08bdd52 snprintf -> g_snprintf
svn path=/trunk/; revision=15393
2005-08-17 22:03:21 +00:00
Ulf Lamping 75970c09e2 strdup -> g_strdup and alike
svn path=/trunk/; revision=15392
2005-08-17 21:52:16 +00:00
Ronnie Sahlberg 31fc2979b1 update some comments pointing out these buffers need not be freed
svn path=/trunk/; revision=15391
2005-08-17 20:45:18 +00:00
Gerald Combs 27728e30e5 If we receive junk data from the network it means we have a
malformed packet.  It doesn't necessarily mean that we have a problem
with our dissector.  If we see something we didn't expect, throw a
ReportedBoundsError instead of calling DISSECTOR_ASSERT() (which makes
BuildBot open a ticket).

Fixes bugs 362 - 366.


svn path=/trunk/; revision=15390
2005-08-17 15:04:44 +00:00
Jörg Mayer 3150ecb747 As reported by Jim Young:
- The port number was incorrectly displayed
- Be a bit more verbose in the "Info" summary line.
- Display the version including the internal number.


svn path=/trunk/; revision=15389
2005-08-17 12:27:05 +00:00
Jörg Mayer 7f6c6811a1 Comment fixes
svn path=/trunk/; revision=15388
2005-08-17 09:59:47 +00:00
Anders Broman 206c6edb22 from Tomas Kukosa, remove a redundant g_strdup()
svn path=/trunk/; revision=15387
2005-08-17 09:43:16 +00:00
Ronnie Sahlberg d4267d1272 replace some more silly rotating buffers with ep_alloc() calls
svn path=/trunk/; revision=15386
2005-08-17 09:36:20 +00:00
Ronnie Sahlberg 19e3bae487 fix some more silly rotating buffers
svn path=/trunk/; revision=15385
2005-08-17 09:28:24 +00:00
Ronnie Sahlberg 4c1b32d94d replace a whole bunch of silly rotating stating buffers with ep_alloc() calls
this should fix a whole number of display bugs when there are too many such pdus in a single frame for the silly buffers to handle before they wrap.



svn path=/trunk/; revision=15384
2005-08-17 09:25:04 +00:00
Ronnie Sahlberg 1df55c8071 remove g_malloc from manolito
svn path=/trunk/; revision=15383
2005-08-17 09:11:37 +00:00
Ronnie Sahlberg d7cf8bfc97 remove g_malloc()s from rtcp
svn path=/trunk/; revision=15382
2005-08-17 08:54:25 +00:00
Ronnie Sahlberg 68bfa7736e replace g_malloc() with ep_alloc() for ftp and sdp
sdp never free the allocated memory so it were leaking memory for every packet containng sdp.
fix memleak for sdp


svn path=/trunk/; revision=15381
2005-08-17 08:50:04 +00:00
Ronnie Sahlberg db4cbf9537 remove g_malloc() from rip remove one g_malloc() from tacacs
svn path=/trunk/; revision=15380
2005-08-17 08:43:40 +00:00
Ronnie Sahlberg 2046fd75b8 from Tomas Kukosa, remove a redundant g_strdup()
svn path=/trunk/; revision=15379
2005-08-17 08:31:54 +00:00
Jörg Mayer 05856f3519 - Small comment updates.
- Add some info about the element to the top level.

svn path=/trunk/; revision=15378
2005-08-16 21:38:18 +00:00
Gerald Combs 877d75d1a2 For "-G decodes", print the selector values as unsigned ints.
svn path=/trunk/; revision=15377
2005-08-16 16:11:02 +00:00
Gerald Combs e66c31ddd0 Add a note about sFlow. Remove the CSM_ENCAPS bug; I inadvertently
reintroduced it after the 0.10.12 release.

svn path=/trunk/; revision=15376
2005-08-16 16:09:49 +00:00
Gerald Combs 2f2a3fedd3 In packet-sflow.c, don't pass a NULL value pointer to
proto_tree_add_ipv6().  Add tree items for the extended router source
and dest mask, and fix offsets.  These changes appear to be correct,
but I don't have a valid capture with extended router data.

In proto.c, throw a dissector error if we try to pass a NULL value to
various proto_tree_set_*() routines.

Fixes bug 356.


svn path=/trunk/; revision=15375
2005-08-16 16:04:30 +00:00
Ronnie Sahlberg 75f38fa0a5 add SetFileInfo level 1013 SetDispositionInfo decoding
svn path=/trunk/; revision=15374
2005-08-16 08:40:06 +00:00
Ronnie Sahlberg e7d5fbaeff prettify MNT (and friends) by placing the path in COL_INFO
svn path=/trunk/; revision=15373
2005-08-16 07:49:03 +00:00
Jörg Mayer 0b845c626f Change the default font size on Unix (etc) to 10 pt, just as it was
already on Windows.
Changed the default font to Monospace, as some Linux distributions did
that already. In case this isn't available on all platforms we will
need to change it back to "fixed medium".

svn path=/trunk/; revision=15372
2005-08-16 06:48:06 +00:00
Jörg Mayer 0f9ffd6923 Move SVNVERSION handling into version_info. That way, we won't have
to recompile tethereal.o etc each time the svn version has changed,
relinking is sufficient.

I'm not sure what to do about mergecap, as it currently doesn't link
against version_info, so it's "overhead" either way.

svn path=/trunk/; revision=15371
2005-08-16 06:45:17 +00:00
Guy Harris bc35e184c7 Change to match more closely the way I read 802.11h, at least; I'm just
guessing about the "17" indicator for "management notification" frames -
I'm not sure whether, after paying USD 60 to get the current 802.11e
draft, Preview on my Mac could even decrypt it.

802.11h seems to say in 7.2.3.12 and 7.3.1.11 that the body of an Action
frame has a 1-byte Category field, with a value of 0 meaning "Spectrum
management", followed by, for Spectrum management, a 1-byte Action
field, with 0=Measurement Request, 1=Measurement Report, 2=TPC Request,
3=TPC Report, and 4=Channel Switch Announcement, followed by:

	for all but Channel Switch Announcement, a 1-byte Dialog Token
	followed by some tagged parameters;

	for the Channel Switch announcement, some tagged parameters.

Show some fields given in decimal in various 802.11 specs in decimal,
not hex.

svn path=/trunk/; revision=15370
2005-08-16 06:09:39 +00:00
Guy Harris 3b6b4817e1 From Peter Johansson: add an option to decode the client information,
and check the validity of messages a bit more carefully.

Reformat a bit so not as much code is missed by those of us who like
narrow editor windows.

svn path=/trunk/; revision=15369
2005-08-16 05:58:50 +00:00
Guy Harris 79588aa6e9 The real problem is that iTunes requests gzipped data and responds with
it, so unless you're reassembling headers and bodies the DAAP dissector
will see the gzipped crap.  The HTTP dissector should perhaps not bother
handing gzipped or otherwise unusually-encoded bodies to subdissectors
if it's not undoing the encoding.

svn path=/trunk/; revision=15368
2005-08-16 02:04:02 +00:00