osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
35,102 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

5179 Commits

Author SHA1 Message Date
etxrab 2f94b3d532 Revert the previous commit, I was confused :-) 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36750 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-21 12:04:02 +00:00
etxrab bf80a1d2d0 Add a cast as there seems to be a problem on some sytems 
conversations_table.c: In function `ct_create_popup_menu':

conversations_table.c:1938: warning: passing arg 2 of `gtk_action_group_add_actions' discards qualifiers from pointer target type

make: *** [libui_a-conversations_table.o] Error 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36747 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-21 08:12:55 +00:00
etxrab 3986c60cdf Replace the capture interface deprecated gtk_combo_new() with gtk_combo_box_entry_new_text. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36741 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-20 20:17:20 +00:00
sfisher 7df463a3ca From Cecco via bug #5605: bug on gtk wireshark telephony->mtp3->msus 
[doesn't show contents of window]



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36723 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-19 19:52:50 +00:00
etxrab 08ac0e5c8b Replace the capture filter deprecated gtk_combo_new() with gtk_combo_box_entry_new_text, 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36718 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-19 16:02:07 +00:00
etxrab bf8ef0cdc1 Coverity UNUSED_VALUE 
CID 1141

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36684 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-17 18:10:08 +00:00
etxrab bab182c872 Coverity UNUSED_VALUE 
CID 1142,1143,1147

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36683 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-17 18:00:14 +00:00
martinm 3fbb99074a Show max UEs/TTI in MAC stats window (UL/DL separately). 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36658 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-16 10:56:18 +00:00
sfisher 6f76a36dab Change ws_strdup_escape_underscore() function to be more general, by 
accepting any character as the escaped character.  Change existing
uses to use '_' for the underscore escaping.



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36627 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-13 16:56:24 +00:00
guy c6de809d9c Rename ws_stat to ws_stat64, and make it take a pointer to a ws_statb64 
as an argument, along the lines of ws_fstat64, and, on Windows, make it
use _wstati64, to handle 64-bit file sizes.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36547 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-10 20:59:10 +00:00
stig 674c2468b3 From Jakub Zawadzki via bug 5809: 
Compare frame number when columns are equal.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36532 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-09 19:03:04 +00:00
guy 4aa836fe2d In packet_list_dissect_and_cache_record(), set the columns to 
*something* if we get an error reading the packet from the capture file,
rather than leaving them as null (which will cause a crash).


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36527 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-09 04:33:26 +00:00
morriss 975ec9c723 From Gisle Vanem: text_import_scanner_lex.h is no longer used. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36507 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-07 20:04:01 +00:00
cmaynard f39dd8f1a5 More console tweaks. But how to prevent prompt from being displayed before 
command finishes without requiring, "start /wait <command>"?


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36463 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-04 19:15:31 +00:00
gerald a922b86b86 More console tweaks. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36458 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-04 18:03:24 +00:00
gerald a58a0929de Only call destroy_console() when we create a console (pointed out by 
Chris Maynard).


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36455 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-04 17:48:07 +00:00
gerald b5b1f2dfba On Windows, try to use an existing console for our messages. Create one if 
it doesn't exist.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36452 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-04 17:11:56 +00:00
cmaynard d9eb469ea5 Remove const type qualifier from cast. Resolves CID's 582-585. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36430 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-04-01 16:30:59 +00:00
cmaynard f066b02da5 Use a common function, higher_priority_status_level() to determine whether or 
not messages should be pushed onto the statusbar.  Should fix CID 270.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36421 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-31 16:23:07 +00:00
cmaynard ccd8cd1847 Wrap all text lines of help at column 80. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36408 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-30 14:44:18 +00:00
cmaynard 798d4365db Grab URL from frame info value instead of from tvb. Fixes bug 5780. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36398 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-29 20:05:33 +00:00
cmaynard f8edf53f23 Move -D option into "pre-scan" group as there's no need to start gtk+ for it. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36388 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-28 22:12:53 +00:00
stig e41a702f4e Added sanity checks for preferences. 
Coverity 551 & 553.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36352 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-26 15:53:55 +00:00
stig 3b097ad8e6 Added a missing break in graph_select_segment. 
Coverity 482.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36349 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-26 15:20:37 +00:00
stig 5c29a616d6 Added a missing break in hostlist_get_filter_name. 
Coverity 481.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36348 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-26 15:16:40 +00:00
sfisher d44ae73cb5 Fix Coverity 331, 332, 333: Wrap the three remaining 
gtk_tree_selection_get_selected() calls with if(!..) return;
like the rest of them.  These functions shouldn't be called
unless a packet was selected, so this call should always return
TRUE for success.



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36339 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-25 22:35:29 +00:00
wmeier ee296b0e47 Recode a loop slightly .... 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36294 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-23 18:10:34 +00:00
stig 00a0ec838d Removed "comparing an array to null", with no effect. 
Coverity 534.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36281 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-23 07:31:17 +00:00
stig 40950c6323 Removed "comparing an array to null", with no effect. 
Coverity 533.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36280 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-23 07:29:19 +00:00
sahlberg 20d3b85463 Print the time units in the CSV output for io_stat using correct extension, i.e. always in seconds. 
coverity 419


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36275 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-23 05:11:06 +00:00
morriss e043ab59b8 Don't compile expert_dlg.c (that dialog is being removed) 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36271 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 21:15:36 +00:00
stig 63df01cd53 Added a sanity check for finfo->hfinfo. 
Coverity 425.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36268 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 19:48:55 +00:00
stig 24319a5283 Allocate correct size of int, not size of a pointer to int. 
Coverity 717.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36261 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 18:53:37 +00:00
stig 7e4bc274c4 Initialize geom in window_get_geometry. 
Coverity 804.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36259 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 18:28:08 +00:00
morriss ae57eec867 Copy expert_tapdata_t here so that expert_dlg.h is no longer needed. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36251 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 16:05:12 +00:00
guy bfb631e688 Make expert_tapdata_t opaque to its clients; define the structure only 
in gtk/expert_comp_dlg.c.

Don't declare now-static functions in gtk/expert_dlg.h.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36236 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 07:24:14 +00:00
etxrab 0b0c13ad4f Remove the Exper info dialogue. 
(Leave the fies for a while).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36235 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-22 06:17:20 +00:00
wmeier 391a8645fa Re-arrange code slightly to remove a false positive Coverity Prevent "Forward Null" defect report. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36229 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-21 18:54:10 +00:00
morriss 1c84c94d90 #if out another unused routine. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36224 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-21 14:52:54 +00:00
guy 49f30ddcbc #if 0-out an unused routine. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36222 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-21 08:21:51 +00:00
etxrab f1edd9506f expert_dlg.c:603: warning: 'expert_dlg_cb' defined but not used 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36220 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-20 22:36:57 +00:00
etxrab 460ec8c4ac Don't register the Exper info dialogue as a first step of removal. 
Should the common routines be moved into expet_comp_dlg.[ch]?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36219 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-20 19:33:07 +00:00
stig e8d332dbc2 From James Deucker via bug 5766: 
Mark some unused arguments.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36212 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-19 11:09:03 +00:00
wmeier 3d60f63401 Fix bug #5189: Wireshark crashes when cancelling a large sort operation. 
Essentially: Don't try to sort if the pre-requisite "columnization" step is stopped
             via the progressbar dialog window before the step completes.
Also: Fix a (very) minor bug wherein the sort-indicator not always cleared on the
      "previous column" when "No Sorting" was selected from a column context menu.
Also: Do minor code, comments & whitespace cleanup.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36180 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-12 19:02:24 +00:00
cmaynard cc99e4f389 Allow <variance> to be successfully sscanf'd no matter the locale for the 
decimal symbol.  Same change and reason as for revision 36160.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36166 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-08 14:57:38 +00:00
sake f8b32c3385 Removal of the old packet-list in favor of the new packet list. 
It compiles with "./configure without options" on my Mac. Let's see what the buildbots have to say about it :-)



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36161 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-03-08 01:52:25 +00:00
stig 9d76427e1b Added functionality for handling global profiles. 
Global profiles can be installed in a "profiles" directory in the
Global configuration directory, and a global profile will be copied
to the users profiles on first time usage.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36077 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-02-26 17:23:24 +00:00
stig 5dc0bc6f54 Ensure we write the current recent file before copying. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36067 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-02-25 15:06:37 +00:00
gerald c52b571620 Fix some dead code and zero division issues found by Clang scan-build. 
In convert_string_case() use g_utf8_strup() instead of converting each
character by hand. Hopefully this won't cause any unexpected changes in
behavior.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36006 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-02-18 22:43:48 +00:00
gerald 5b1a6c2428 Fix a few errors found by Clang scan-build. 
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36002 f5534014-38df-0310-8fa8-9805f1628bb7
 2011-02-18 19:46:05 +00:00