osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Added sanity checks for preferences. 

Coverity 551 & 553.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36352 f5534014-38df-0310-8fa8-9805f1628bb7
This commit is contained in:
stig 2011-03-26 15:53:55 +00:00
parent 0141fb2dcd
commit e41a702f4e
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gtk/megaco_stat.c
View File

@ -156,6 +156,11 @@ gtk_megacostat_init(const char *optarg, void *userdata _U_)
megaco_ctx_track = prefs_find_preference(prefs_find_module("megaco"),"ctx_info");
h248_ctx_track = prefs_find_preference(prefs_find_module("h248"),"ctx_info");
if (!megaco_ctx_track || !h248_ctx_track) {
/* No such preferences */
return;
}
if (!*megaco_ctx_track->varp.boolp || !*h248_ctx_track->varp.boolp) {
simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", "Track Context option at Protocols -> MEGACO and Protocols -> H248 preferences has to be set to true to enable measurement of service reponse times.");
return;

6
tap-megacostat.c
View File

@ -87,6 +87,12 @@ megacostat_init(const char *optarg, void* userdata _U_)
megaco_ctx_track = prefs_find_preference(prefs_find_module("megaco"),"ctx_info");
h248_ctx_track = prefs_find_preference(prefs_find_module("h248"),"ctx_info");
if (!megaco_ctx_track || !h248_ctx_track) {
/* No such preferences */
return;
}
if (!*megaco_ctx_track->varp.boolp || !*h248_ctx_track->varp.boolp) {
printf("Track Context option at Protocols -> MEGACO and Protocols -> H248 preferences\n");
printf("has to be set to true to enable measurement of service response times.\n");