- Fix potential array overflow;
- Calls to expert...() should not be under 'if (tree)';
- Don't use DISSECTOR_ASSERT for bad data; use expert...();
- Add some XXX comments about enum item values different than
specified in the comments associated with the enum items;
- Init global 'mfgCommandFlag' as appropriate before use;
- Add missing hf[] entries;
- #if 0 various unused #defines and enums;
- Reduce (somewhat) repeated fetches of the same tvb data;
- Remove unneeded initializers;
- Don't use 'l' as a variable name;
- Reformat long lines, hf[] array entries and other;;
- Fix some indentation;
svn path=/trunk/; revision=43663
interface for which we have information.
Fixes bug 7467.
Should also cause an error message, rather than an unreadable capture
file, to be produced for the cases in bug 7381. (This isn't a fix for
bug 7381; it's arguably an improvement, in the sense that a circuit
breaker tripping or a fuse blowing for a short circuit is an improvement
over a fire starting, but it's not a *fix*, any more than a circuit
break or fuse *fixes* the short circuit.)
#BACKPORT
svn path=/trunk/; revision=43657
interface information when opening an output file, one of which I fixed
in my previous checkin and the other of which I didn't notice. Shuffle
code around a little bit so that the lumps are identical and then put
them into a common routine (*with* the fix in question).
#BACKPORT
svn path=/trunk/; revision=43655
object for each line - rather create one and use it for the entire list,
then destroy it.
Simplify the allocation of segments, by no longer messing around with a
static that may or may not be used. Also, there was a good chance the
last one would be leaked (if it was not part of the stream we are
interested in).
Note that both of these improvements would also apply to tcp_graph.c -
will wait a couple of days to be sure the changes are good.
svn path=/trunk/; revision=43654
we're making a fake interface description (it should match the time
stamp resolution). The dump code for pcap-NG now requires the time
units per second value, as it needs to correctly compute the time stamp
value to write out in an EPB.
svn path=/trunk/; revision=43652
for the interface, not based on the default resolution of 1 microsecond.
Fixes bug 7457.
Fix a comment.
Clean up indentation.
#BACKPORT
svn path=/trunk/; revision=43649
resolution is NOT enabled (it's always been like this and I'm not sure why
and I was hesitant to change that). So: don't use the external name resolver
unless both network-name resolution AND use-external-resolvers are enabled.
svn path=/trunk/; revision=43645
There have been some updates to the dictionary.erx since it was last synced
from FreeRADIUS. Please find attached an updated dictionary for Juniper
Networks ERX.
svn path=/trunk/; revision=43643
When showing the TCP (and UDP and other protocols) port numbers in the
framelist columns, they are left aligned. This is sub-optimal if you are
scanning the list for a certain port.
This patch, very small, will properly right justify these numbers:
UNRESOLVED DST PORT
UNRESOLVED SRC PORT
DST PORT
SRC PORT
svn path=/trunk/; revision=43642
Fix an uninitialized-variable error that was breaking compile with gcc.
Also remove some cruft that looks like it was copy-pasted from
ui/gtk/tcp_graph.c
Fixes bug 7460.
svn path=/trunk/; revision=43635
"etherpeek.c" file format is used by AiroPeek and the "airopeek9.c" file
format is used by EtherPeek.
Instead, use the names that WildPackets apparently uses for those
formats - "classic" and "tagged".
svn path=/trunk/; revision=43630
Cleanup and simplify structures and arrays in packet-assa_r3.c as described in
my email to the -dev list [1].
[1] http://www.wireshark.org/lists/wireshark-dev/201207/msg00050.html
From me:
Do the same as above for the commandDissectorParser_t struct mentioned in the EMail
(but not fixed in the patch).
svn path=/trunk/; revision=43623
