Say it builds "as needed".
Change-Id: I85ce2062da7f168785d0d22160b8f19b85d554e3
Reviewed-on: https://code.wireshark.org/review/22909
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Change-Id: I459208eed4a76b104bc28aa44ab05374e57043de
Reviewed-on: https://code.wireshark.org/review/22873
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
from under the security blob since they're physically placed before the blob.
Also renamed them to clarify their link to the blob
Change-Id: I896ce8eea3f5f41c1887a685247e7fa168cc9061
Reviewed-on: https://code.wireshark.org/review/22823
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Instrumentation code increases the stack usage. Let's deactivate the
check when compiling with ASan or UBSan as the objective here is not
to check the stack consumption and its usage is out of our control.
Change-Id: I9d6e269a0d404dc1833183a070fdbbb7fb0446e0
Reviewed-on: https://code.wireshark.org/review/22888
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Flows records can span multiple PDUs (e.g when using TCP).
This commit adds the preference to reassemble flows.
Bug: 13915
Change-Id: I10eb0d9ee5ff5cc06ff52d0d0c8c468140e0273b
Reviewed-on: https://code.wireshark.org/review/22792
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
As explained by 3GPP TS 44.064 Section 6.4.2.2 there are Dummy UI
Commands which are never generated by a LLC entity, but nevertheless
received by a LLC entity. They are generated by the underlying
network-side RLC/MAC entity a as a means to artificially delay the
release of a downlink TBF.
We introduce a new "llcgprs.dummy_ui" boolean field on which the user
can match to filter our such messages, if needed.
Change-Id: Ie8fcb42cbd66a7e5b77849f0bc5a3630d0d54a9c
Reviewed-on: https://code.wireshark.org/review/22862
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Also, process the packet to the end, even if there are fewer than 3
bytes left; we'll throw an exception if we can't fetch the type and
length, which will report the packet as malformed (which it is).
Change-Id: Iddd5be4be635553ac77bdb7fe232c2edb0e4404c
Reviewed-on: https://code.wireshark.org/review/22882
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The RLC/MAC dissector decodes both signalling (PACCH) and data (PDTCH)
RLC/MAC blocks, so let's make sure we dispatch both logical channels
into that dissector.
Change-Id: Ia26a1ba74468a49da071185cc5ee876ade907207
Reviewed-on: https://code.wireshark.org/review/22861
Reviewed-by: Michael Mann <mmann78@netscape.net>
PDCH is the physical channel name, while PDTCH is one of the logical
channels (goether with PTCCH and PACCH) on the PDTCH. Let's call it
by its proper name, rather than keeping the misnomer.
Change-Id: I724fcfba595c9c861b64a30d5510468ec007424c
Reviewed-on: https://code.wireshark.org/review/22860
Reviewed-by: Michael Mann <mmann78@netscape.net>
The original code made all columns read-only; making only the info
column read-only makes the packet summary look weird, with the contained
protocol shown but the info from MSDP shown.
Change-Id: Iaa8afcb98a26a94230d5f344261f202ea658d077
Reviewed-on: https://code.wireshark.org/review/22878
Reviewed-by: Guy Harris <guy@alum.mit.edu>
It's now an RFC; mention the RFC number.
There are no message types in MSDP; the message consists solely of a
sequence of TLVs. Don't speak of TLV types as message types.
When dissecting a TLV, don't go past the end of the TLV. (We should add
a bunch of expert infos for length errors.)
Note that the Notification TLV was in an I-D but isn't in the RFC.
Don't use tvb_new_subset_length_caplen() - tvb_new_subset_length()
suffices; let *it* check for the captured length.
Clean up dissection of the Notification TLV.
Bug: 13933
Change-Id: Ia39b98f061957085c9f15fe6b31cd9c18058df35
Reviewed-on: https://code.wireshark.org/review/22868
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add support for draft-bellis-dnsop-xpf to the DNS dissector:
- Parse the XPF additional RR (currently using a temp value of 65422)
Bug: 13928
Change-Id: I2d4fa23a8d3828db483bc41fafe6cbd8885514dc
Reviewed-on: https://code.wireshark.org/review/22803
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
it is not supported with Qt 4.x
Change-Id: Ie98d5e03d471869e08f5354a509c3317c7c780d7
Reviewed-on: https://code.wireshark.org/review/22831
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Resize so all options can be seen
Bug: 13924
Change-Id: I1e347e83432305cc30f54f61efdb6e4c92e98d5a
Reviewed-on: https://code.wireshark.org/review/22850
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 10579
Change-Id: I18cac02f81465598451e0cf8f6729a26faf8c176
Reviewed-on: https://code.wireshark.org/review/22849
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
"offset" no longer needed (since using dissector table for options),
and since it should always be 0, just remove it.
Change-Id: Icc2802b76bc99a17d60d1deff75e1dc65761e8ed
Reviewed-on: https://code.wireshark.org/review/22848
Reviewed-by: Michael Mann <mmann78@netscape.net>
The LOC records LATITUDE and LONGITUDE angle values may become too
large. Find these and stop conversion into invalid values.
Bug: 13914
Change-Id: Ia01ac1ecf5080350454f06536c9be1cf758d6f3c
Reviewed-on: https://code.wireshark.org/review/22847
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
When getting the (partial) IPv4 address make sure to pass the full
32 bits of the address when adding the proto tree item.
Bug: 13923
Change-Id: I5b849705e723efd1269a64ee28b8d93724ab769a
Reviewed-on: https://code.wireshark.org/review/22838
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Otherwise on second pass pkt_info is null, leading to a segmentation fault
Bug: 13925
Change-Id: I61cfbee894506fb6c4205c9a2ad19e6973821f23
Reviewed-on: https://code.wireshark.org/review/22833
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
When handling a Distributed SAK parameter set with long SAK tracking
the offset was done incorrectly. Fix proposed by Rich Dubrawski.
Also remove the mask from XPN suspension time, it has none.
Bug: 13927
Change-Id: Iba1018632c719a86eaa24a304e1743210b3b3a1c
Reviewed-on: https://code.wireshark.org/review/22836
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This will leave more room for messages on smaller screens. Set the
default OFF because this is probably only useful for developers.
Group Status Bar settings in the Layout frame.
Change-Id: Iea9a55b6c088aac10ee7680b1e8a882ed00c73be
Reviewed-on: https://code.wireshark.org/review/22824
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Set Qt::AA_EnableHighDpiScaling before creating wsApp so that various UI
elements are scaled properly on Windows.
Change-Id: Iee4ff2d97b0834756c805fb3812d556ad3480436
Ping-Bug: 13877
Reviewed-on: https://code.wireshark.org/review/22826
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
(item and tree is the same but avoid mistake)
Ping-Bug: 13917
Change-Id: Ica5cc1b62aa8d359aea19a8292bfcd2cc5c4ae9b
Reviewed-on: https://code.wireshark.org/review/22819
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Guy Harris
Harald Welte