Commit graph

14194 commits

Author SHA1 Message Date
Gerald Combs
bcd1c5b9fa From Steve Grubb: Fix buffer and array length checks. Fixes part of bug 217.
svn path=/trunk/; revision=14498
2005-05-30 21:01:52 +00:00
Gerald Combs
923446f1f5 From Steve Grubb: Initialize some variables. Fixes part of bug 217.
svn path=/trunk/; revision=14497
2005-05-30 21:00:05 +00:00
Gerald Combs
861dc4e340 More bug fixes from Steve Grubb. See bug 217 for details.
svn path=/trunk/; revision=14496
2005-05-30 20:58:20 +00:00
Gerald Combs
12b7466381 From Steve Grubb: Fix a memory leak.
Don't pass a null to atoi().

Fixes part of bug 217.

svn path=/trunk/; revision=14495
2005-05-30 20:55:16 +00:00
Gerald Combs
1d3ba8764b From Steve Grubb: Fix off by one errors. Fixes part of bug 217.
svn path=/trunk/; revision=14494
2005-05-30 20:53:08 +00:00
Gerald Combs
651ee9a2fe From Steve Grubb: Initialize a variable. Fixes part of bug 217.
svn path=/trunk/; revision=14493
2005-05-30 20:51:36 +00:00
Gerald Combs
cebf5bc459 Fix an off-by-one error found by Steve Grubb. Steve gets the award
for longest standing bug found so far.  This has been present since
version 0.5.0.

Fixes part of bug 217.

svn path=/trunk/; revision=14492
2005-05-30 20:48:12 +00:00
Anders Broman
05376bd969 Add dissection of MSRP
http://www.ietf.org/internet-drafts/draft-ietf-simple-message-sessions-10.txt

svn path=/trunk/; revision=14491
2005-05-30 18:39:39 +00:00
Ulf Lamping
cb51c2662a fix highlighting length, if more than one RPC call is in a TCP PDU
set "n*DCERPC" in the proto column if more than one RPC call in a TCP PDU, overwriting the interface name, as there's probably more than one interface involved

add some more RPC info to the toplevel RPC proto_item

add a comment, if some bytes are not dissected but might be in the next TCP PDU

svn path=/trunk/; revision=14490
2005-05-30 18:37:19 +00:00
Gerald Combs
ccffd9b143 Add random bit errors to the fuzz tests.
svn path=/trunk/; revision=14489
2005-05-30 16:49:47 +00:00
Gerald Combs
81a381effd Throw an exception if we're handed a null pointer when we weren't
expecting one.  Fixes bug 200.

svn path=/trunk/; revision=14488
2005-05-30 16:03:24 +00:00
Gerald Combs
b133b98f15 Break out of an infinite loop. Fixes bugs 213 & 214.
svn path=/trunk/; revision=14487
2005-05-30 15:51:03 +00:00
Ronnie Sahlberg
2edd8a7a00 add MMC READ DISC INFORMATION cdb
svn path=/trunk/; revision=14486
2005-05-30 12:09:39 +00:00
Ronnie Sahlberg
3b4e688073 add MMC READ TRACK INFORMATION cdb
svn path=/trunk/; revision=14485
2005-05-30 11:16:08 +00:00
Ulf Lamping
ec246cae54 fix #148: (win32 only) use command line parameter -B to set capture buffer size
svn path=/trunk/; revision=14484
2005-05-30 04:46:25 +00:00
Ulf Lamping
047cdd0f2a First part to fix #148: use command line parameter -o not only for preferences but also for recent settings.
This way we can simply remove the GUI related command line parameters -B, -P and -T, which are useless now.

svn path=/trunk/; revision=14483
2005-05-30 04:06:22 +00:00
Ulf Lamping
feb55854c7 fix #215: the field hf_smb_print_spool_file_name used the wrong type, use FT_STRINGZ to add a string
svn path=/trunk/; revision=14482
2005-05-30 03:10:37 +00:00
Ulf Lamping
f3037e2f53 add two more tvb_ensure_bytes_exist() calls to fix #216
When I look at the remaining code, I fear this will become a never ending story :-(

svn path=/trunk/; revision=14481
2005-05-30 02:58:13 +00:00
Ulf Lamping
c997fbfae9 clarify some recent file entry descriptions
svn path=/trunk/; revision=14480
2005-05-29 14:09:58 +00:00
Ulf Lamping
c173da9fec fix #201: add format_text before output of the DNS name, in case it contains invalid chars
svn path=/trunk/; revision=14479
2005-05-29 13:02:57 +00:00
Ulf Lamping
2b30b539ee fix #86: use format_text before adding version string to the info column
svn path=/trunk/; revision=14478
2005-05-29 12:27:31 +00:00
Ulf Lamping
7c07e00f1d fix #11: add a [truncated] to the label, if the message to display is too long
svn path=/trunk/; revision=14477
2005-05-29 11:23:42 +00:00
Ronnie Sahlberg
acaf8730be add MMC RESERVE TRACK cdb
svn path=/trunk/; revision=14476
2005-05-29 08:45:09 +00:00
Ronnie Sahlberg
bbf29dd862 MMC SET STREAMING command
svn path=/trunk/; revision=14475
2005-05-29 08:29:55 +00:00
Jörg Mayer
0fc3001d6a Add minimal 802.11j decoding. There's not fun in doing more unless
someone provides a capture file.


svn path=/trunk/; revision=14474
2005-05-29 08:19:11 +00:00
Ronnie Sahlberg
aa7157462c remove offset and len from the signature of dissect_scsi_payload()
svn path=/trunk/; revision=14473
2005-05-29 03:18:53 +00:00
Ronnie Sahlberg
e66ff913ff make all callers of dissect_scsi_cdb() first create a new subset tvb
change the signature for dissect_scsi_cdb since we no longer need to pass offset over.



svn path=/trunk/; revision=14472
2005-05-29 02:55:12 +00:00
Ronnie Sahlberg
fc9688991f create a subset tvb before calling off to the SCSI dissector
so that the right part of the hexpane is highlighted when one clicks on an nondissected data line

svn path=/trunk/; revision=14471
2005-05-29 02:30:49 +00:00
Ronnie Sahlberg
6eb6d5f9af minor prettification
in the decode pane for the SCSI protocol,
put the name of the CDB on the protocol line


svn path=/trunk/; revision=14470
2005-05-29 01:54:22 +00:00
Ronnie Sahlberg
ae9968883e update iscsi so that when we have ImmediateData we also call SCSI to decode the
payload (DATAOUT)  and not just the scsi CDB.



svn path=/trunk/; revision=14469
2005-05-29 01:49:09 +00:00
Ronnie Sahlberg
aaaeb78d58 from Alejandro Vaquero
fox to packet-mgcp.c to make the viop analysis working again.


svn path=/trunk/; revision=14468
2005-05-28 23:05:41 +00:00
Ronnie Sahlberg
3007142732 add MMC READ BUFFER CAPACITY command
svn path=/trunk/; revision=14467
2005-05-28 13:29:45 +00:00
Ronnie Sahlberg
5d7e4750d2 add the SynchronizeCache command for MMC
svn path=/trunk/; revision=14466
2005-05-28 13:01:14 +00:00
Ulf Lamping
f8b3fe7668 add some tvb_ensure_bytes_exist() calls, fixes #197, #202 and #208
svn path=/trunk/; revision=14465
2005-05-28 12:49:19 +00:00
Ronnie Sahlberg
fb65ef09eb updates to mmc, add more dissection of GET_CONFIGURATION and READ_TOC
svn path=/trunk/; revision=14464
2005-05-28 12:45:38 +00:00
Ulf Lamping
af9bcf3bf8 prevent unused function warning
svn path=/trunk/; revision=14463
2005-05-28 11:04:11 +00:00
Ronnie Sahlberg
5c1e7a37de some more MMC4 updates
svn path=/trunk/; revision=14462
2005-05-28 08:27:44 +00:00
Ronnie Sahlberg
3df89a9d25 more scsi refactoring
starting to implement MMC codeset : CDROM/DVD



svn path=/trunk/; revision=14461
2005-05-28 05:42:39 +00:00
Ronnie Sahlberg
fd6d7dd38e refactor scsi dissector toi be table driven so it will be easier to add new
commandsets.



svn path=/trunk/; revision=14460
2005-05-28 03:37:16 +00:00
Olivier Biot
97babfb98d From Gilbert Ramirez - Fix a FT_NONE with a bitmask (shouldn't have one).
svn path=/trunk/; revision=14459
2005-05-28 00:51:56 +00:00
Ronnie Sahlberg
0890269d05 from Gilbert,
make kink compile again on non-kerberos builds.

encapsulate a call to decrypt kerberos to only be compiled in when compiling with kerberos.


svn path=/trunk/; revision=14458
2005-05-27 21:39:38 +00:00
Ronnie Sahlberg
6879e6da67 from didier fix for the regression for bug 62
svn path=/trunk/; revision=14457
2005-05-27 21:33:27 +00:00
Anders Broman
d328993c0d From Martin Mathieson
packet-rdt.c:
- register a configurable UDP port (off by default, but needed where setup traffic isn't captured)
- dissect extra 'buffer info' fields
- move bit fields into 'flags' subtrees
- misc. minor fixes and improvements (mainly formatting)
Missed eralier...

svn path=/trunk/; revision=14456
2005-05-27 18:35:19 +00:00
Luis Ontanon
4cd25ccc5e don't use a static buffer for preference values, allocate it, and, if necessary reallocate so that
the string always fits.


svn path=/trunk/; revision=14455
2005-05-27 18:33:09 +00:00
Gilbert Ramirez
c2454f0260 Add a "-G fields3" report which prints the bitmask of the field, and avoids
printing the blurb twice, like fields2 does.
Add a script, fsanity.py, to check sanity of FT definitions. Right now the
only check is for bitmasks for integer-like fields.

svn path=/trunk/; revision=14454
2005-05-27 15:13:09 +00:00
Ronnie Sahlberg
94d8512749 From T.Nakashima
updates to KINK


svn path=/trunk/; revision=14453
2005-05-27 08:53:07 +00:00
Ronnie Sahlberg
864245ef6e cket wsp is creating string items and later appending to them and their value at runtime which breaks when the TRY_TO_FAKE_THIS_ITEM() is used.
Add a comment to proto_item_append_string() explaining the "danger" and what needs to be done if one decides to use proto_item_append_string()

Add a small change to WSP so that it will disable this speed optimization so not to trigger a DISSECTOR_BUG in proto_item_append_string()




svn path=/trunk/; revision=14452
2005-05-27 06:00:08 +00:00
Ronnie Sahlberg
0938d01e38 GdKEventScroll is not available in GTK-1.2
svn path=/trunk/; revision=14451
2005-05-27 05:04:03 +00:00
Guy Harris
cb3bc515e2 The DESIRE_ and OS_ values are bit indices, not numerical values that
appear by themselves; get rid of the value_string tables for them.

svn path=/trunk/; revision=14450
2005-05-27 02:30:10 +00:00
Ulf Lamping
abab83d6e4 fix #203: the scroll event handler used an inappropriate implementation to get event values, fixed this. On win32 this was working before and after the changes, so the bug *might* remain ...
svn path=/trunk/; revision=14448
2005-05-26 23:18:10 +00:00