osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
28850 commits 23 branches 0 tags 1.3 GiB
Commit graph

28850 commits

This branch
This branch
All branches
Author SHA1 Message Date
Martin Mathieson
f0a98e5fe8 Update my entry 
svn path=/trunk/; revision=29485
 2009-08-20 13:25:41 +00:00
Martin Mathieson
70284d6cc4 Trivial formatting changes 
svn path=/trunk/; revision=29484
 2009-08-20 13:16:34 +00:00
Anders Broman
0819c36d3a Prepare to store column text in frame data directly. 
svn path=/trunk/; revision=29483
 2009-08-20 09:49:32 +00:00
Anders Broman
7945bf1bc9 From Harald Welte : 
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
 2009-08-20 07:26:16 +00:00
Anders Broman
a599db08d8 Destroy window with parent, update label when showing window. 
svn path=/trunk/; revision=29481
 2009-08-19 19:20:45 +00:00
Kovarththanan Rajaratnam
0f6b75b7ea Move TRY_TO_FAKE_THIS_ITEM to all public proto_xxx methods. Currently we rely on our internal (static) helper functions to do the faking. However, when they fake a protocol tree, they usually return a valid tree (although a dummy tree it is still a valid one). This means that we end up calling proto_tree_set_representation + friends on it for no reason. By moving TRY_TO_FAKE_THIS_ITEM to the public proto_xxx methods we're able to bail immediately (when we're allowed to do so). 
svn path=/trunk/; revision=29480
 2009-08-19 19:08:34 +00:00
Anders Broman
31132240f9 Make it possible to run checkapi with "deprecated-gtk-todo". 
svn path=/trunk/; revision=29479
 2009-08-19 18:39:30 +00:00
Anders Broman
7ec476b88a From Didier Gautheron: 
Part 2
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.

svn path=/trunk/; revision=29478
 2009-08-19 18:37:13 +00:00
Anders Broman
2c87da6c66 From Didier Gautheron: 
Part 1
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.

svn path=/trunk/; revision=29477
 2009-08-19 18:36:36 +00:00
Jörg Mayer
283dbb4414 As pointed out by Alexis La Goutte via PM, r29474 didn't 
support the different MAC formats (eui48 and eui64) properly.
Now, eui48 is printed as mac, the rest is still handled as
blob.

svn path=/trunk/; revision=29476
 2009-08-19 15:42:24 +00:00
Kovarththanan Rajaratnam
82adb33a48 We shouldn't conditionalise on _filtering_ tap listerners to determine whether tapping should be performed or not. We also need to handle _normal_ tap listerners. This change backs out the regression introduced in r29435. 
Thanks to Didier: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3916

svn path=/trunk/; revision=29475
 2009-08-19 13:52:15 +00:00
Jörg Mayer
69069395df Add support for Radio Mac/Wireless Specific Information optional 
header fields. This patch lacks handling of padding since a) I don't
have a trace containing padding and b) I don't understand the
wording in the rfc (it's to ambigous for my liking).

svn path=/trunk/; revision=29474
 2009-08-19 12:25:40 +00:00
Anders Broman
8e00a20710 From Jochen Bartl: 
EIGRP dissector enhancements (IPv6, Stub routing, Authentication TLVs)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3907

svn path=/trunk/; revision=29473
 2009-08-19 11:34:40 +00:00
Anders Broman
87da96be52 From Jan Lübbe: 
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915

svn path=/trunk/; revision=29472
 2009-08-19 09:32:56 +00:00
Anders Broman
100aeddafe From Didier Gautheron: 
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Make col_expr const gchar.

svn path=/trunk/; revision=29471
 2009-08-19 07:55:11 +00:00
Anders Broman
bbaf419559 Fix a memmory leak. 
svn path=/trunk/; revision=29470
 2009-08-19 06:04:30 +00:00
Anders Broman
a47a4a5242 Add new_packet_list_recent_write_all(). 
svn path=/trunk/; revision=29469
 2009-08-18 23:00:42 +00:00
Jaap Keuter
e2c8640c8d Properly handle closing/destruction of RTP player window. 
svn path=/trunk/; revision=29468
 2009-08-18 17:36:30 +00:00
Anders Broman
3208870317 Make copy summary work for new_packet_list. 
XXX The enum in .h file does not seem to work???

svn path=/trunk/; revision=29467
 2009-08-18 14:40:51 +00:00
Anders Broman
43cbf13ad4 Minor clean up. 
svn path=/trunk/; revision=29466
 2009-08-18 14:39:32 +00:00
Stig Bjørlykke
7ef25b683b Search for includes and libs in /opt/local/ (MacPorts). 
svn path=/trunk/; revision=29465
 2009-08-18 14:37:25 +00:00
Jeff Morriss
b62e6545b9 Add an expert info noting that an ANSI message with the national indicator set to 0 (international) is unusual. 
svn path=/trunk/; revision=29464
 2009-08-18 13:25:49 +00:00
Anders Broman
c8ec27c000 Make build bot happy? 
svn path=/trunk/; revision=29463
 2009-08-18 12:15:36 +00:00
Anders Broman
a4109274e2 Typo: parameter_tvb to be used. 
svn path=/trunk/; revision=29462
 2009-08-18 11:39:55 +00:00
Anders Broman
7dae972f12 From Mathias de Paulis Nilsson: 
Updates to  V8.5.0.

svn path=/trunk/; revision=29461
 2009-08-18 08:00:05 +00:00
Jaap Keuter
a4e174b7f8 From Swapnil Barai: 
Minor Bug in Bearer Context in Packet-gtpv2.c fixed.

svn path=/trunk/; revision=29460
 2009-08-18 06:41:12 +00:00
Stephen Fisher
d777d1dfed Display Microsoft's Remote Desktop Protocol (RDP) extension to the X.224 
connection request that shows the session load balancing information.  There
appears to be more dissecting that can be done for this field, but I don't
have any sample captures to test this.
 

svn path=/trunk/; revision=29459
 2009-08-18 00:32:11 +00:00
Kovarththanan Rajaratnam
5417a21bac As pointed out by Guy, we should probably explain why the gulong -> size_t cast is 'safe' 
svn path=/trunk/; revision=29458
 2009-08-17 20:14:59 +00:00
Jaap Keuter
201746a1a1 Change window_new() to dlg_window_new() and destroy the window with the top level window. 
svn path=/trunk/; revision=29457
 2009-08-17 19:10:19 +00:00
Kovarththanan Rajaratnam
8de8a1cb6e setbit() is (AFAIK) defined in <sys/param.h> (OpenBSD) so rename to dect_setbit() to avoid clash. getbit() is also renamed for consistency. 
Fixes the issue reported by Stan: http://www.wireshark.org/lists/wireshark-users/200908/msg00128.html

svn path=/trunk/; revision=29456
 2009-08-17 17:19:31 +00:00
Anders Broman
a1772b0197 Remove #if 0 
svn path=/trunk/; revision=29455
 2009-08-17 15:13:58 +00:00
Anders Broman
a1a129abb5 Prepare to store column data from pinfo. 
svn path=/trunk/; revision=29454
 2009-08-17 15:05:43 +00:00
Kovarththanan Rajaratnam
460eacaae1 Move the NULL pointer 'tree' check under TRY_TO_FAKE_THIS_ITEMs umbrella 
svn path=/trunk/; revision=29453
 2009-08-17 11:21:33 +00:00
Kovarththanan Rajaratnam
69babcb4a6 Don't do PROTO_REGISTRAR_GET_NTH twice. 
svn path=/trunk/; revision=29452
 2009-08-17 11:13:36 +00:00
Kovarththanan Rajaratnam
e4e9b91275 Add proper type cast. 
Thanks to Martin for reporting this.

svn path=/trunk/; revision=29451
 2009-08-17 04:23:47 +00:00
Kovarththanan Rajaratnam
5b88477401 Add missing call to packets_bar_update() after thaw'ing 
svn path=/trunk/; revision=29450
 2009-08-16 15:33:05 +00:00
Gerald Combs
79c49bfe54 [Automatic manuf and enterprise-numbers update for 2009-08-16] 
svn path=/trunk/; revision=29447
 2009-08-16 15:03:26 +00:00
Kovarththanan Rajaratnam
8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining() 
svn path=/trunk/; revision=29446
 2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
fe6f8b92c7 Add a new function, tvb_new_subset_remaining(), which is a sligtly optimized version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1. 
The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking.

svn path=/trunk/; revision=29445
 2009-08-16 10:53:47 +00:00
Kovarththanan Rajaratnam
c795851beb Remove unused parameters 
svn path=/trunk/; revision=29444
 2009-08-16 09:48:25 +00:00
Kovarththanan Rajaratnam
6cd59f3799 Remove the non-thread safe usage of 'last_tvb' variable in tvb_new_subset() 
svn path=/trunk/; revision=29443
 2009-08-16 09:18:17 +00:00
Kovarththanan Rajaratnam
998ee3a2e0 Make some of the check_XXX functions accept the length/reported length of the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset() 
svn path=/trunk/; revision=29442
 2009-08-16 08:18:17 +00:00
Kovarththanan Rajaratnam
01abc372e6 Remove a non thread-safe usage (useful when/if we ever support threading) of a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff. 
svn path=/trunk/; revision=29441
 2009-08-16 07:29:11 +00:00
Kovarththanan Rajaratnam
7cb17ecec0 Use the slice allocator if GLIB >= 2,10,0 
svn path=/trunk/; revision=29440
 2009-08-16 04:54:33 +00:00
Kovarththanan Rajaratnam
c28b654f20 Switch over to using GPtrArray instead of manually g_renew'ing. This switch has some benefits: 
1) We don't have to manually resize
2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array

svn path=/trunk/; revision=29439
 2009-08-16 04:08:00 +00:00
Stephen Fisher
8b00ed7674 Mark function paramter as unused with _U_ to please gcc. 
svn path=/trunk/; revision=29438
 2009-08-16 02:35:44 +00:00
Anders Broman
408b658647 Try to please build bot 
svn path=/trunk/; revision=29437
 2009-08-15 21:59:03 +00:00
Anders Broman
23dc20f6bf Prepare for storing column data in packet list store. 
svn path=/trunk/; revision=29436
 2009-08-15 21:12:56 +00:00
Kovarththanan Rajaratnam
d4ba2208ec Inline a few checks in the add_packet_to_packet_list() function since it's called in tight loop. This will help us to avoid calling functions that simply returns. This is especially the case when we're dealing with the new packet list due to its dissect-on-demand nature where colour/column construction is delayed until the row becomes visible. 
svn path=/trunk/; revision=29435
 2009-08-15 14:13:36 +00:00
Kovarththanan Rajaratnam
aed905a6c9 Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Broman 
svn path=/trunk/; revision=29434
 2009-08-15 13:24:59 +00:00