Commit graph

28850 commits

Author SHA1 Message Date
Bill Meier
a8e3b5d758 Rework code slightly to prevent a GCC 'breaking strict-aliasing rules' warning
svn path=/trunk/; revision=29537
2009-08-24 14:30:55 +00:00
Anders Broman
ce829a0f94 packet-tcp.c:1551: warning: 'cleared_writable' may be used uninitialized in this function
svn path=/trunk/; revision=29536
2009-08-24 09:29:05 +00:00
Anders Broman
553ef57224 From: : " Michael"
packet-tcp marks a row as unwritable if there is more
than 1 PDU in a packet to prevent overwriting of the
protocol column.

However this breaks the proto,colinfo tap which checks
rows are writable or dies EVEN if it doesn't alter anything.

Suggested patch attached to restore the initial value
after all PDUs have been processed.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3675

svn path=/trunk/; revision=29535
2009-08-24 09:05:23 +00:00
Tomas Kukosa
60022bc5f2 Expert info for undecoded Q.932 and H.450 operations
svn path=/trunk/; revision=29534
2009-08-24 09:05:15 +00:00
Stig Bjørlykke
ca5995f532 From Ivan Sy via bug 3931:
Added ND Proxy Flag for IPv6 RA flag.

svn path=/trunk/; revision=29533
2009-08-24 08:00:39 +00:00
Bill Meier
c66f265dda Rework code slightly to prevent a GCC 'strict-aliasing' warning.
svn path=/trunk/; revision=29532
2009-08-23 23:52:40 +00:00
Jaap Keuter
58dedc3872 From kahou:
Add Fibre Channel Delimiter Dissector for Fibre Channel FC2.

svn path=/trunk/; revision=29531
2009-08-23 19:16:35 +00:00
Kovarththanan Rajaratnam
60a30e223e From Didier gautheron via bug 3929:
* Expert Info / Expert Info Composite requires a full protocol tree.
* Delay tree NULL pointer check in bootp dissector

svn path=/trunk/; revision=29530
2009-08-23 18:32:29 +00:00
Kovarththanan Rajaratnam
7c1d96d831 From Didier gautheron via bug 3929:
* Don't use g_string_chunk_clear(). It is only defined if GLib >= 2.14

From me:

* Whitespace fixes

svn path=/trunk/; revision=29529
2009-08-23 18:13:03 +00:00
Jaap Keuter
1711f5899b From Ivan Sy:
Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6,
Add Number of Sources. Also to show Record Type's numeric value and not 
just its equivalent.

Cleaned up presentation and included record number as well.

svn path=/trunk/; revision=29528
2009-08-23 17:18:29 +00:00
Gerald Combs
db09d3f88c [Automatic manuf and enterprise-numbers update for 2009-08-23]
svn path=/trunk/; revision=29525
2009-08-23 15:03:28 +00:00
Kovarththanan Rajaratnam
23d4eba3b1 Custom columnfication:
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta

svn path=/trunk/; revision=29524
2009-08-23 12:30:48 +00:00
Kovarththanan Rajaratnam
b9cbd15469 Custom columnfication:
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative

svn path=/trunk/; revision=29523
2009-08-23 12:24:14 +00:00
Kovarththanan Rajaratnam
55cf35e3a0 Custom columnfication:
* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci

svn path=/trunk/; revision=29522
2009-08-23 12:16:10 +00:00
Kovarththanan Rajaratnam
ea8296ab26 Avoid signed/unsigned comparison
svn path=/trunk/; revision=29521
2009-08-23 11:35:53 +00:00
Michael Tüxen
375f355046 Update list of PPIDs.
This fixes bug 3928.

svn path=/trunk/; revision=29520
2009-08-23 11:30:54 +00:00
Kovarththanan Rajaratnam
1a7b6733cd #if 0 col_set_circuit_id(). It isn't being used
svn path=/trunk/; revision=29519
2009-08-23 11:13:53 +00:00
Kovarththanan Rajaratnam
51ca1739ae Custom columfication:
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield

svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00
Kovarththanan Rajaratnam
00670c55c6 Custom columfication:
* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid

svn path=/trunk/; revision=29517
2009-08-23 10:25:51 +00:00
Kovarththanan Rajaratnam
205129d25c Custom columfication:
* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys

svn path=/trunk/; revision=29516
2009-08-23 10:20:42 +00:00
Kovarththanan Rajaratnam
56369978ae Custom columfication:
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call

svn path=/trunk/; revision=29515
2009-08-23 09:52:57 +00:00
Kovarththanan Rajaratnam
53586615aa Add initial code to handle the migration to custom columns by mapping the deprecated columns into their custom column counterparts when we read the preference file.
There are still many todos in this area:

1) We need to either warn the user that he/she needs to click "Save" in the preference dialog so we can "flush" the old predefined column or apply this change ourself silently.
2) The predefined columns need to be removed from the "Columns" UI.
3) ....

svn path=/trunk/; revision=29514
2009-08-23 09:16:58 +00:00
Kovarththanan Rajaratnam
6b89de8393 Custom columfication:
* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority

svn path=/trunk/; revision=29513
2009-08-23 09:07:54 +00:00
Jörg Mayer
dfac9e4091 Get rid of a bunch of "warning: redundant redeclaration of" messages.
In that process, include the contents of packet-fmp_notify.h directly
in packet-fmp_notify.c - it wasn't used anywhere else.

svn path=/trunk/; revision=29512
2009-08-23 06:57:16 +00:00
Kovarththanan Rajaratnam
6444abbf7e Avoid 'cast to pointer from integer of different size'
svn path=/trunk/; revision=29511
2009-08-23 05:20:30 +00:00
Balint Reczey
98d79569e0 From Rob Leslie <rob@mars.org>:
[PATCH] Fix dumpcap believing error on ^C i.e. pcap_breakloop()
When ^C was pressed during a packet capture, dumpcap believed a pcap
error had occurred.  We check the return value more closely to avoid
this problem.

svn path=/trunk/; revision=29510
2009-08-22 22:49:59 +00:00
Balint Reczey
035231b534 From Frederic Peters (made endian-aware by me):
fixed segfault with some GIOP packets

svn path=/trunk/; revision=29509
2009-08-22 22:46:41 +00:00
Kovarththanan Rajaratnam
602e3a09e0 Remove col_check() guard wrt. COL_REL_CONV_TIME/COL_DELTA_CONV_TIME
svn path=/trunk/; revision=29508
2009-08-22 19:53:54 +00:00
Kovarththanan Rajaratnam
3d740a490f We initialize col_expr and col_expr_val in col_init() so there's no need to initialize them again in col_set_xxx()
svn path=/trunk/; revision=29507
2009-08-22 19:29:44 +00:00
Jaap Keuter
fdf21357fc From Ivan Sy:
NSEC3PARAM RR (RFC 5155),  APL RR (RFC 3123), PX RR (RFC 2163), GPOS RR (RFC 1712), 
NSAP RR (RFC 1706), NSAP-PTR RR (RFC 1348), AFSDB, RP, X25, ISDN, RT, RR (RFC 1183).
Also cleanup of protocol tree dependancies.

svn path=/trunk/; revision=29506
2009-08-22 17:28:54 +00:00
Bill Meier
2d91ad03f9 Additional validation of 'len' for crc32_ccitt_tvb... fcns;
(-1 is not a valid length);
First of 2 fixes for crash reported in Bug #3925.

svn path=/trunk/; revision=29505
2009-08-22 17:12:33 +00:00
Anders Broman
3c86b750e5 expert_comp_table.c: Minor cleanup
expert_dlg.c change GtkOptionMenu to GtkComboBox.

svn path=/trunk/; revision=29504
2009-08-22 16:17:42 +00:00
Kovarththanan Rajaratnam
da1e555499 Don't dereference pointer before checking for NULL
svn path=/trunk/; revision=29503
2009-08-21 23:02:59 +00:00
Kovarththanan Rajaratnam
2046b144d9 Sanitize epan includes
svn path=/trunk/; revision=29502
2009-08-21 20:51:13 +00:00
Kovarththanan Rajaratnam
66afe84075 Use <gcrypt.h> instead of 'gcrypt.h'
svn path=/trunk/; revision=29501
2009-08-21 20:40:49 +00:00
Kovarththanan Rajaratnam
c19f7978db Sanitize epan includes
svn path=/trunk/; revision=29500
2009-08-21 20:32:50 +00:00
Kovarththanan Rajaratnam
17c9803cac Sanitize epan includes
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Michael Tüxen
cc11620041 From Irene Ruengeler: Fix two bugs regarding plotted TSNs reported by
Christian Constantin.

svn path=/trunk/; revision=29498
2009-08-21 20:10:51 +00:00
Kovarththanan Rajaratnam
9661baf237 Remove unneeded #includes
svn path=/trunk/; revision=29497
2009-08-21 19:48:11 +00:00
Jaap Keuter
ee9ef9f5cb Remove unneeded #includes.
svn path=/trunk/; revision=29496
2009-08-21 18:56:15 +00:00
Jaap Keuter
bf580bfa14 Remove unneeded #includes.
svn path=/trunk/; revision=29495
2009-08-21 18:54:28 +00:00
Kovarththanan Rajaratnam
8a3f4f53eb Delay TRY_TO_FAKE_THIS_ITEM() in proto_tree_add_bits_ret_val() until we know it is safe.
Thanks to Martin for pointing this out in r29493.

svn path=/trunk/; revision=29494
2009-08-21 17:11:02 +00:00
Martin Mathieson
044aabb9ea Don't try TRY_TO_FAKE_THIS_ITEM in proto_tree_add_bits_ret_val(), as otherwise
the side effect 'return_value' getting set doesn't happen.

svn path=/trunk/; revision=29493
2009-08-21 15:16:27 +00:00
Bill Meier
6f87844d0a (Minor) Remove unneeded #includes.
svn path=/trunk/; revision=29492
2009-08-21 14:36:27 +00:00
Kovarththanan Rajaratnam
2afdee256c Handle a text NULL pointer more gracefully
svn path=/trunk/; revision=29491
2009-08-21 11:31:21 +00:00
Kovarththanan Rajaratnam
27f7d88c84 Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
Anders Broman
1108352f00 Use col_text in frame data.
- colum-utils needs more work, based on
 Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=29489
2009-08-21 10:12:47 +00:00
Jaap Keuter
55597ea161 List the new DOCSIS dissector file here as well.
svn path=/trunk/; revision=29488
2009-08-21 05:37:33 +00:00
Jaap Keuter
929a92a454 From Geoffrey Kimball:
DOCSIS 3.0 includes a new Bonded Initial Ranging Request (B-INIT-RNG-REQ) MAC
Management type (34).  A simple dissector is needed to decode this message.

svn path=/trunk/; revision=29487
2009-08-20 19:41:53 +00:00
Kovarththanan Rajaratnam
c48602900a Add error probability command line parameter
svn path=/trunk/; revision=29486
2009-08-20 17:43:56 +00:00